klibc.bbclass: Add spaces around assignment
PATCH 1/1 klibc.bbclass: Add spaces around assignment
--- meta-initramfs/classes/klibc.bbclass | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
meta-initramfs/classes/klibc.bbclass +8 -3
@@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" # klcc uses own optimizations by default. See klcc(1) man file. -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" -export CPPFLAGS="${TUNE_CCARGS}" -export LDFLAGS="${TUNE_CCARGS}" +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" +CFLAGS[export] = "1" + +CPPFLAGS = "${TUNE_CCARGS}" +CPPFLAGS[export] = "1" + +LDFLAGS=" ${TUNE_CCARGS}" +LDFLAGS[export] = "1" OVERRIDES =. "libc-klibc:"
meta-initramfs/classes/klibc.bbclass CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE · line 19
Quoted 2 lines · Khem Raj via lists.openembedded.org
meta-initramfs/classes/klibc.bbclass +2
-0+LDFLAGS=" ${TUNE_CCARGS}" +LDFLAGS[export] = "1"
That space is still off by one in the upper line.
Quoted 15 lines · Khem Raj via lists.openembedded.org
Signed-off-by Khem Raj <[email protected]>--- meta-initramfs/classes/klibc.bbclass | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)meta-initramfs/classes/klibc.bbclass +0
-1@@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}" # klcc uses own optimizations by default. See klcc(1) man file. -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}"
meta-initramfs/classes/klibc.bbclass CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE · line 19
Quoted 10 lines
meta-initramfs/classes/klibc.bbclass +8
-2-export CPPFLAGS="${TUNE_CCARGS}" -export LDFLAGS="${TUNE_CCARGS}" +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" +CFLAGS[export] = "1" + +CPPFLAGS = "${TUNE_CCARGS}" +CPPFLAGS[export] = "1" + +LDFLAGS=" ${TUNE_CCARGS}" +LDFLAGS[export] = "1"
Why the change in export syntax, is the varflag preferred now?
Quoted 14 lines · Martin Jansa via lists.openembedded.org
Quoted 12 lines · Khem Raj via lists.openembedded.org
Signed-off-by Khem Raj <[email protected]>--- meta-initramfs/classes/klibc.bbclass | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)meta-initramfs/classes/klibc.bbclass +0
-0@@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE_CCARGS_MFLOAT') != '') else ''}"
Quoted 13 lines
meta-initramfs/classes/klibc.bbclass CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE · line 19
Quoted 12 lines
meta-initramfs/classes/klibc.bbclass +8
-3# klcc uses own optimizations by default. See klcc(1) man file. -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" -export CPPFLAGS="${TUNE_CCARGS}" -export LDFLAGS="${TUNE_CCARGS}" +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" +CFLAGS[export] = "1" + +CPPFLAGS = "${TUNE_CCARGS}" +CPPFLAGS[export] = "1" + +LDFLAGS=" ${TUNE_CCARGS}" +LDFLAGS[export] = "1"Why the change in export syntax, is the varflag preferred now?
Meta comment: maybe it should be preferred... It is at least a bit confusing that bitbake's and shell's "export" look and work very very similarly, but one of them complains about not having spaces, and the other complains about having spaces.
Quoted 11 lines · Gyorgy Sarvari
Quoted 8 lines · Martin Jansa via lists.openembedded.org
Review
Quoted 6 lines · Khem Raj via lists.openembedded.org
Signed-off-by Khem Raj <[email protected]>--- meta-initramfs/classes/klibc.bbclass | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)(quoted diff) +0
-0b/meta-initramfs/classes/klibc.bbclass
Quoted 21 lines
Quoted 4 lines
meta-initramfs/classes/klibc.bbclass CC:append:armv7ve = " ${@'
Quoted 4 lines
index
ca50a3d431..935ee10c40100644meta-initramfs/classes/klibc.bbclass +0
-0@@ -9,8 +9,13 @@ CC:append:armv7ve = " ${@'-mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE
Quoted 1 line
meta-initramfs/classes/klibc.bbclass CC:append:armv7ve = " ${@' · line 9
Quoted 1 line
meta-initramfs/classes/klibc.bbclass +0
-0CC:append:armv7a = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if(
d.getVar('TUNE_CCARGS_MFLOAT')!= '') else ''}"Quoted 14 lines
meta-initramfs/classes/klibc.bbclass CC:append:armv7ve = " ${@' -mfloat-abi=${TUNE_CCARGS_MFLOAT}' if (d.getVar('TUNE · line 19
Quoted 13 lines
meta-initramfs/classes/klibc.bbclass +8
-3# klcc uses own optimizations by default. See klcc(1) man file. -export CFLAGS="${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" -export CPPFLAGS="${TUNE_CCARGS}" -export LDFLAGS="${TUNE_CCARGS}" +CFLAGS = "${TUNE_CCARGS} ${DEBUG_PREFIX_MAP}" +CFLAGS[export] = "1" + +CPPFLAGS = "${TUNE_CCARGS}" +CPPFLAGS[export] = "1" + +LDFLAGS=" ${TUNE_CCARGS}" +LDFLAGS[export] = "1"Why the change in export syntax, is the varflag preferred now?
It’s fine either way. I preferred bitbakes way of doing it here for not mixing shell syntax ourside of functions
Quoted 6 lines
Meta comment: maybe it should be preferred... It is at least a bit confusing that bitbake's and shell's "export" look and work very very similarly, but one of them complains about not having spaces, and the other complains about having spaces.