net/ixgbe: fix port mask default value in flow director
PATCH 1/1 net/ixgbe: fix port mask default value in flow director
The fdir filter should mask L4 protocol in order to process raw IP packets. However, the initial value of port mask is 0xFF and the filter will not process raw IP packets if the flow rule does not change it.
Fixed by setting the default value to 0.
--- drivers/net/intel/ixgbe/ixgbe_flow.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/intel/ixgbe/ixgbe_flow.c +2 -0
@@ -1644,6 +1644,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,memset (&rule->mask,0xFF ,sizeof (struct ixgbe_hw_fdir_mask )); rule->mask.vlan_tci_mask =0 ; rule->mask.flex_bytes_mask =0 ; + rule->mask.dst_port_mask =0 ; + rule->mask.src_port_mask =0 ;/** * The first not void item should be
Signature · 1 line
2.47.1
Quoted 12 lines
-----Original Message-----
From: Yuan Wang <[email protected]>
Sent: Friday, April 18, 2025 3:43 PM
To: Burakov, Anatoly <[email protected]>; Medvedkin, Vladimir <[email protected]>; [email protected]
Cc: Wang, YuanX <[email protected]>; [email protected]
Subject: [PATCH] net/ixgbe: fix port mask default value in flow directorThe fdir filter should mask L4 protocol in order to process raw IP packets. However, the initial value of port mask is
0xFFand the filter will not process raw IP packets if the flow rule does not change it.
Quoted 7 lines
Fixed by setting the default value to 0.
Fixes 444505f933f1 (net/ixgbe: fix IPv6 mask in flow director)Signed-off-by Yuan Wang <[email protected]>---
Bruce Richardson
AppliedQuoted 12 lines · HailinX
Quoted 12 lines
-----Original Message-----
From: Yuan Wang <[email protected]>
Sent: Friday, April 18, 2025 3:43 PM
To: Burakov, Anatoly <[email protected]>; Medvedkin, Vladimir <[email protected]>; [email protected]
Cc: Wang, YuanX <[email protected]>; [email protected]
Subject: [PATCH] net/ixgbe: fix port mask default value in flow directorThe fdir filter should mask L4 protocol in order to process raw IP packets. However, the initial value of port mask is
0xFFand the filter will not process raw IP packets if the flow rule does not change it.
Quoted 8 lines
Quoted 7 lines
Fixed by setting the default value to 0.
Fixes 444505f933f1 (net/ixgbe: fix IPv6 mask in flow director)Signed-off-by Yuan Wang <[email protected]>---
Tested-by Xu, HailinX <[email protected]>
Applied to dpdk-next-net-intel
Thanks,
/Bruce
Quoted 10 lines · On Fri, 18 Apr 2025 15:43:09 +0800 Yuan Wang <[email protected]> wrote:
The fdir filter should mask L4 protocol in order to process raw IP packets. However, the initial value of port mask is
0xFFand the filter will not process raw IP packets if the flow rule does not change it.Fixed by setting the default value to 0.
Fixes 444505f933f1 (net/ixgbe: fix IPv6 mask in flow director)Signed-off-by Yuan Wang <[email protected]>
Ok, but Intel needs to remove flow director by 25.11. It has been on the deprecation list for years.