Skip to contentSkip to conversation

arm-bsp/external-system: correct whitespace warning

PATCH Applied Jon Mason 2 participants 4 messages Apr 18, 2025 – Apr 19, 2025

lore
Share & tools
lore

Jon Mason

author
#0 lore raw

PATCH 1/3 arm-bsp/external-system: correct whitespace warning

Seeing the following warning:
WARNING: /builds/jonmason00/meta-arm/work/build/../../meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb: /builds/jonmason00/meta-arm/work/build/../../meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb:6 has a lack of whitespace around the assignment: 'INHIBIT_DEFAULT_DEPS="1"'

Adding spaces addresses the issue.

---
 .../recipes-bsp/external-system/external-system_0.1.0.bb        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb +1 -1
index 8bd116163851..1f2d02dfcf8d 100644
@@ -3,7 +3,7 @@ DESCRIPTION = "Firmware to be loaded and run in External System Harness in\
                support to the main application CPU."
 HOMEPAGE = "https://git.linaro.org/landing-teams/working/arm/external-system.git"
 DEPENDS = "gcc-arm-none-eabi-native"
-INHIBIT_DEFAULT_DEPS="1"
+INHIBIT_DEFAULT_DEPS = "1"
 LICENSE = "BSD-3-Clause & Apache-2.0"
 LIC_FILES_CHKSUM = "file://license.md;md5=e44b2531cd6ffe9dece394dbe988d9a0 \
                     file://cmsis/LICENSE.txt;md5=e3fc50a88d0a364313df4b21ef20c29e"
Signature · 1 line
2.39.5 (Apple Git-154)
author
#1 lore raw

PATCH 2/3 arm/tclibc: add spaces after TCLIBC

Seeing the warning:
lack of whitespace around the assignment: 'TCLIBC="musl"'

Add spaces to address the issue

---
 kas/corstone1000-firmware-only.yml      | 2 +-
 meta-arm/conf/multiconfig/firmware.conf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
kas/corstone1000-firmware-only.yml +1 -1
index 6192a4087234..bc47940b316b 100644
@@ -10,7 +10,7 @@ local_conf_header:
     OVERRIDES .= ":firmware"
 
     # Need to ensure we build with a small libc
-    TCLIBC="musl"
+    TCLIBC = "musl"
 
   mass-storage: |
     # Ensure the Mass Storage device is absent
meta-arm/conf/multiconfig/firmware.conf +1 -1
index 95de4d246792..018c0deb81e5 100644
@@ -4,7 +4,7 @@
 DISTROOVERRIDES = "firmware"
 
 TMPDIR:append = "_${MACHINE}"
-TCLIBC="musl"
+TCLIBC = "musl"
 
 # Ignore the testimage flags to include ssh-server-dropbear
 IMAGE_CLASSES:remove = "testimage"
Signature · 1 line
2.39.5 (Apple Git-154)
author
#2 lore raw

PATCH 3/3 CI: add spaces to TS_ENV

In reply to Jon Mason

Seeing the warning:
lack of whitespace around the assignment: 'TS_ENV="sp"'

Add the spaces to address the issue

---
 ci/fvp-base-ts.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
ci/fvp-base-ts.yml +1 -1
index ae74334edfe3..9f13bac7f045 100644
@@ -21,7 +21,7 @@ local_conf_header:
     IMAGE_INSTALL:append = " packagegroup-ts-tests-psa"
     CORE_IMAGE_EXTRA_INSTALL += "optee-test"
     # Set the TS environment
-    TS_ENV="sp"
+    TS_ENV = "sp"
     # Enable and configure semihosting
     FVP_CONFIG[cluster0.cpu0.semihosting-cwd] = "${DEPLOY_DIR_IMAGE}"
     FVP_CONFIG[cluster0.cpu1.semihosting-cwd] = "${DEPLOY_DIR_IMAGE}"
Signature · 1 line
2.39.5 (Apple Git-154)
Applied
#3 lore raw
In reply to Jon Mason
Quoted 6 lines · Jon Mason

Seeing the following warning:
WARNING: /builds/jonmason00/meta-arm/work/build/../../meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb: /builds/jonmason00/meta-arm/work/build/../../meta-arm-bsp/recipes-bsp/external-system/external-system_0.1.0.bb:6 has a lack of whitespace around the assignment: 'INHIBIT_DEFAULT_DEPS="1"'

Adding spaces addresses the issue.

Applied, thanks!

[1/3] arm-bsp/external-system: correct whitespace warning

      commit: ece994e08bac150e22011762ac1036d6efabe937
[2/3] arm/tclibc: add spaces after TCLIBC
      commit: 3124feab662b4a015402e92f0ed3315426e8666b
[3/3] CI: add spaces to TS_ENV
      commit: 62cb568a652fb13a4f46bbcdd0b2fb1e62475e45

Best regards,

Signature · 1 line
Jon Mason <[email protected]>