spi: offload: check for match callback when a trigger is being registered
Subsystems (2)
PATCH 1/1 spi: offload: check for match callback when a trigger is being registered
Make match a required callback when a new trigger is being registered, this allows that other functions like spi_offload_trigger_get() could safelly invoke the callback when it is required
--- drivers/spi/spi-offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-offload.c +1 -1
@@ -434,7 +434,7 @@ int devm_spi_offload_trigger_register(struct device *dev, {struct spi_offload_trigger *trigger; -if (!info->fwnode || !info->ops) +if (!info->fwnode || !(info->ops && info->ops->match))return -EINVAL ; trigger =kzalloc (sizeof (*trigger),GFP_KERNEL );
Signature · 1 line
2.43.0
David Lechner
reviewerQuoted 3 lines · Andres Urian Florez
Make match a required callback when a new trigger is being registered, this allows that other functions like
spi_offload_trigger_get()could safelly invoke the callback when it is required
s/safelly/safely/
Quoted 11 lines
Signed-off-by Andres Urian Florez <[email protected]>--- drivers/spi/spi-offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/spi/spi-offload.c +0
-0
drivers/spi/spi-offload.c int devm_spi_offload_trigger_register(struct device *dev, · line 437
Quoted 5 lines
drivers/spi/spi-offload.c +1
-1@@ -434,7 +434,7 @@ int devm_spi_offload_trigger_register(struct device *dev, {struct spi_offload_trigger *trigger; -if (!info->fwnode || !info->ops) +if (!info->fwnode || !(info->ops && info->ops->match))
IMHO, this would be easier to read and understand as:
if (!info->fwnode || !info->ops || !info->ops->match)
Quoted 3 lines
drivers/spi/spi-offload.c +0
-0return -EINVAL ; trigger =kzalloc (sizeof (*trigger),GFP_KERNEL );
Quoted 22 lines · David Lechner
Quoted 3 lines · Andres Urian Florez
Make match a required callback when a new trigger is being registered, this allows that other functions like
spi_offload_trigger_get()could safelly invoke the callback when it is requireds/safelly/safely/
Quoted 14 lines
Signed-off-by Andres Urian Florez <[email protected]>--- drivers/spi/spi-offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/spi/spi-offload.c +0
-0@@ -434,7 +434,7 @@ int devm_spi_offload_trigger_register(struct device *dev, {struct spi_offload_trigger *trigger;
Quoted 12 lines
drivers/spi/spi-offload.c int devm_spi_offload_trigger_register(struct device *dev, · line 437
Quoted 2 lines
drivers/spi/spi-offload.c +1
-1-if (!info->fwnode || !info->ops) +if (!info->fwnode || !(info->ops && info->ops->match))IMHO, this would be easier to read and understand as:
if (!info->fwnode || !info->ops || !info->ops->match)Quoted 4 lines
drivers/spi/spi-offload.c +0
-0return -EINVAL ;trigger = kzalloc(sizeof(*trigger), GFP_KERNEL);
Right, I will apply your recommendation.
Thanks!