Skip to contentSkip to conversation

spi: offload: check for match callback when a trigger is being registered

PATCH In review Andres Urian Florez 2 participants 3 messages Apr 18, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: offload: check for match callback when a trigger is being registered

Make match a required callback when a new trigger is being registered, this allows that other functions like spi_offload_trigger_get() could safelly invoke the callback when it is required

---
 drivers/spi/spi-offload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-offload.c +1 -1
index 6bad042fe437..6f4c5188e6ad 100644
@@ -434,7 +434,7 @@ int devm_spi_offload_trigger_register(struct device *dev,
 {
 	struct spi_offload_trigger *trigger;
 
-	if (!info->fwnode || !info->ops)
+	if (!info->fwnode || !(info->ops && info->ops->match))
 		return -EINVAL;
 
 	trigger = kzalloc(sizeof(*trigger), GFP_KERNEL);
Signature · 1 line
2.43.0
reviewer
#1 lore raw
Quoted 3 lines · Andres Urian Florez

Make match a required callback when a new trigger is being registered, this allows that other functions like spi_offload_trigger_get() could safelly invoke the callback when it is required

s/safelly/safely/

Quoted 11 lines
---
 drivers/spi/spi-offload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-offload.c +0 -0
index 6bad042fe437..6f4c5188e6ad 100644

drivers/spi/spi-offload.c int devm_spi_offload_trigger_register(struct device *dev, · line 437

Quoted 5 lines
drivers/spi/spi-offload.c +1 -1
@@ -434,7 +434,7 @@ int devm_spi_offload_trigger_register(struct device *dev,
 {
 	struct spi_offload_trigger *trigger;
 
-	if (!info->fwnode || !info->ops)
+	if (!info->fwnode || !(info->ops && info->ops->match))

IMHO, this would be easier to read and understand as:

	if (!info->fwnode || !info->ops || !info->ops->match)
Quoted 3 lines
drivers/spi/spi-offload.c +0 -0
 		return -EINVAL;
 
 	trigger = kzalloc(sizeof(*trigger), GFP_KERNEL);
#2 lore raw
Quoted 22 lines · David Lechner
Quoted 3 lines · Andres Urian Florez

Make match a required callback when a new trigger is being registered, this allows that other functions like spi_offload_trigger_get() could safelly invoke the callback when it is required

s/safelly/safely/

Quoted 14 lines
---
 drivers/spi/spi-offload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-offload.c +0 -0
index 6bad042fe437..6f4c5188e6ad 100644
@@ -434,7 +434,7 @@ int devm_spi_offload_trigger_register(struct device *dev,
 {
      struct spi_offload_trigger *trigger;
 
Quoted 12 lines

drivers/spi/spi-offload.c int devm_spi_offload_trigger_register(struct device *dev, · line 437

Quoted 2 lines
drivers/spi/spi-offload.c +1 -1
-     if (!info->fwnode || !info->ops)
+     if (!info->fwnode || !(info->ops && info->ops->match))

IMHO, this would be easier to read and understand as:

        if (!info->fwnode || !info->ops || !info->ops->match)
Quoted 4 lines
drivers/spi/spi-offload.c +0 -0
              return -EINVAL;
 
 
      trigger = kzalloc(sizeof(*trigger), GFP_KERNEL);

Right, I will apply your recommendation.
Thanks!