Skip to contentSkip to conversation

package/syslog-ng: disable cloud auth if libressl is used

PATCH In review Thomas Devoogdt 2 participants 2 messages Apr 20, 2025 – May 18, 2025

lore
Share & tools
lore

Thomas Devoogdt

author
#0 lore raw

PATCH 1/1 package/syslog-ng: disable cloud auth if libressl is used

From: Thomas Devoogdt <[email protected]>

./modules/cloud-auth/jwt-cpp/include/jwt-cpp/jwt.h:1158:33: error: invalid use of incomplete type 'struct ECDSA_SIG_st'

     auto rr = helper::bn2raw(sig->r);

./modules/cloud-auth/jwt-cpp/include/jwt-cpp/jwt.h:1159:33: error: invalid use of incomplete type 'struct ECDSA_SIG_st'

     auto rs = helper::bn2raw(sig->s);

./modules/cloud-auth/jwt-cpp/include/jwt-cpp/jwt.h:1181:15: error: aggregate 'ECDSA_SIG sig' has incomplete type and cannot be defined

     ECDSA_SIG sig;

Fixes:
- https://autobuild.buildroot.org/results/d76/d76883e0870b4c788058fee1ac2c1c47a17f6bf2/build-end.log

Signed-off-by Thomas Devoogdt <[email protected]>
---
 package/syslog-ng/syslog-ng.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/syslog-ng/syslog-ng.mk +1 -1
index 57ee46ce05..91d2dd5269 100644
@@ -63,7 +63,7 @@ ifeq ($(BR2_PACKAGE_LIBCURL),y)
 SYSLOG_NG_DEPENDENCIES += libcurl
 SYSLOG_NG_CONF_OPTS += --enable-http
 SYSLOG_NG_CONF_OPTS += --with-libcurl="$(STAGING_DIR)/usr"
-ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
+ifeq ($(BR2_INSTALL_LIBSTDCPP):$(BR2_PACKAGE_LIBRESSL),y:)
 SYSLOG_NG_CONF_OPTS += --enable-cloud-auth
 else
 SYSLOG_NG_CONF_OPTS += --disable-cloud-auth
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Thomas,

Quoted 8 lines · On Sun, 20 Apr 2025 09:09:34 +0200 Thomas Devoogdt <[email protected]> wrote:

From: Thomas Devoogdt <[email protected]>

./modules/cloud-auth/jwt-cpp/include/jwt-cpp/jwt.h:1158:33: error: invalid use of incomplete type 'struct ECDSA_SIG_st'

     auto rr = helper::bn2raw(sig->r);

./modules/cloud-auth/jwt-cpp/include/jwt-cpp/jwt.h:1159:33: error: invalid use of incomplete type 'struct ECDSA_SIG_st'

     auto rs = helper::bn2raw(sig->s);
Quoted 7 lines

./modules/cloud-auth/jwt-cpp/include/jwt-cpp/jwt.h:1181:15: error: aggregate 'ECDSA_SIG sig' has incomplete type and cannot be defined

     ECDSA_SIG sig;

Fixes:
- https://autobuild.buildroot.org/results/d76/d76883e0870b4c788058fee1ac2c1c47a17f6bf2/build-end.log

Signed-off-by Thomas Devoogdt <[email protected]>

Thanks for the patch. However instead of this, can we fix the issue? Looking at upstream jwt-cpp (which is bundled in syslog-ng cloud-auth module), this snippet fixes it:

https://github.com/Thalhammer/jwt-cpp/commit/c9a511f436eaa13857336ebeb44dbc5b7860fe01#diff-be2369ece29c0945fc04ffe13a39767b7841fc2fabd3df209a26b3bb381a2fb2

So could you make a syslog-ng patch that adjusts this, and report to upstream syslog-ng the issue so that they update to a newer jwt-cpp version?

Thanks a lot!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot