Skip to contentSkip to conversation

kvm: Improve help message clarity in dirty_log_test

PATCH New Tinu K Cheriya 1 participant 1 message Apr 20, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm: Improve help message clarity in dirty_log_test

From: tinukcheriya <[email protected]>

---
 tools/testing/selftests/kvm/dirty_log_test.c | 30 +++++++++++---------
 1 file changed, 16 insertions(+), 14 deletions(-)
tools/testing/selftests/kvm/dirty_log_test.c +16 -14
index 54da9cc20db4..ac01cf198469 100644
@@ -503,22 +503,24 @@ static void help(char *name)
 	int i;
 
 	puts("");
-	printf("usage: %s [-h] [-i iterations] [-I interval] "
-	       "[-p offset] [-m mode]\n", name);
+	printf("Usage: %s [-h] [-i iterations] [-I interval] [-p offset] [-m mode]\n", name);
 	puts("");
-	printf(" -i: specify iteration counts (default: %"PRIu64")\n",
-	       TEST_HOST_LOOP_N);
-	printf(" -I: specify interval in ms (default: %"PRIu64" ms)\n",
-	       TEST_HOST_LOOP_INTERVAL);
-	printf(" -p: specify guest physical test memory offset\n"
-	       "     Warning: a low offset can conflict with the loaded test code.\n");
-	printf(" -M: specify the host logging mode "
-	       "(default: run all log modes).  Supported modes: \n\t");
+	printf(" -i: Specify the number of test iterations (default: %"PRIu64")\n", 			TEST_HOST_LOOP_N);
+
+	printf(" -p: Specify the guest physical memory offset for the test.\n"
+       "     Warning: Low offsets may conflict with test code loaded in memory.\n");
+	printf(" -p: Specify the guest physical memory offset for the test.\n"
+       "     Warning: Low offsets may conflict with test code loaded in memory.\n");
+
+	printf(" -M: Specify the host logging mode (default: run all log modes).\n"
+       "     Supported modes:\n\t");
+
 	log_modes_dump();
-	printf(" -m: specify the guest mode ID to test "
-	       "(default: test all supported modes)\n"
-	       "     This option may be used multiple times.\n"
-	       "     Guest mode IDs:\n");
+	printf(" -m: Specify the guest mode ID to test "
+       "(default: test all supported modes).\n"
+       "     You may use this option multiple times.\n"
+       "     Guest mode IDs:\n");
+
 	for (i = 0; i < NUM_VM_MODES; ++i) {
 		printf("         %d:    %s%s\n", i, vm_guest_mode_string(i),
 		       guest_modes[i].supported ? " (supported)" : "");
Signature · 1 line
2.25.1