Skip to contentSkip to conversation

drm/display: dp: remove duplicated check of ret < 0

PATCH New Colin Ian King 1 participant 1 message Apr 22, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/display: dp: remove duplicated check of ret < 0

There is a redundant duplicated check for the condition of ret < 0 inside an if block that also checks for ret < 0. The ternary check is always true, so remove it and replace it with just return err.

---
 drivers/gpu/drm/display/drm_dp_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/display/drm_dp_helper.c +1 -1
index 57828f2b7b5a..af62d99a0d94 100644
@@ -4044,7 +4044,7 @@ int drm_edp_backlight_enable(struct drm_dp_aux *aux, const struct drm_edp_backli
 	if (ret < 0) {
 		drm_dbg_kms(aux->drm_dev, "%s: Failed to write aux backlight mode: %d\n",
 			    aux->name, ret);
-		return ret < 0 ? ret : -EIO;
+		return ret;
 	}
 
 	ret = drm_edp_backlight_set_level(aux, bl, level);
Signature · 1 line
2.49.0