Skip to contentSkip to conversation

syscalls/unshare: New test: CLONE_NEWNS unshares fs info

PATCH Superseded lufei 2 participants 6 messages Apr 23, 2025 – Apr 25, 2025

lore
Share & tools
lore

lufei

author
#0 lore raw

PATCH 1/1 syscalls/unshare: New test: CLONE_NEWNS unshares fs info

Add test case unshare04, to verify unshare(CLONE_NEWNS) also unshares filesystem information.

---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/unshare/.gitignore  |  1 +
 testcases/kernel/syscalls/unshare/unshare04.c | 69 +++++++++++++++++++
 3 files changed, 71 insertions(+)
 create mode 100644 testcases/kernel/syscalls/unshare/unshare04.c
runtest/syscalls +1 -0
index 844ae7a13..57338297a 100644
@@ -1725,6 +1725,7 @@ unlinkat01 unlinkat01
 unshare01 unshare01
 unshare02 unshare02
 unshare03 unshare03
+unshare04 unshare04
 
 #
 # These tests require an unmounted block device
testcases/kernel/syscalls/unshare/.gitignore +1 -0
index e5b5c261d..b1206e452 100644
@@ -1,3 +1,4 @@
 /unshare01
 /unshare02
 /unshare03
+/unshare04
testcases/kernel/syscalls/unshare/unshare04.c new file +69 -0

69 lines not on this page · raw message

Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi!

Quoted 34 lines
runtest/syscalls +1 -0
index 844ae7a13..57338297a 100644
@@ -1725,6 +1725,7 @@ unlinkat01 unlinkat01
 unshare01 unshare01
 unshare02 unshare02
 unshare03 unshare03
+unshare04 unshare04
 
 #
 # These tests require an unmounted block device
testcases/kernel/syscalls/unshare/.gitignore +1 -0
index e5b5c261d..b1206e452 100644
@@ -1,3 +1,4 @@
 /unshare01
 /unshare02
 /unshare03
+/unshare04
testcases/kernel/syscalls/unshare/unshare04.c new file +7 -0
new file mode 100644
index 000000000..0bbb9d19d
@@ -0,0 +1,69 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2025 lufei <[email protected]>
+ */
+
+/*\
+ * This test case is to verify unshare(CLONE_NEWNS) also unshares filesystem

testcases/kernel/syscalls/unshare/unshare04.c line 17

Quoted 10 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +10 -0
+ * information.
+ *
+ */
+
+#define _GNU_SOURCE
+
+#include "tst_test.h"
+#include "lapi/sched.h"
+
+#ifdef HAVE_UNSHARE

This shouldn't be needed anymore, the minimal glibc we support at the moment is 2.22, unshare() if I'm looking right is included in glibc 2.4 and newer. I suppose that removing the configure check for unshare() is long overdue.

testcases/kernel/syscalls/unshare/unshare04.c line 19

Quoted 1 line
testcases/kernel/syscalls/unshare/unshare04.c new file +1 -0
+#define TMP "/tmp"

The test shouldn't expect or touch directories outside the test temporary directory. If you need a diretory to chdir() into create one in the test setup() instead.

testcases/kernel/syscalls/unshare/unshare04.c line 31

Quoted 11 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +11 -0
+static void run(void)
+{
+	char *c_cwd;
+	char *p_cwd;
+	size_t size = 1024;
+
+	c_cwd = SAFE_MMAP(NULL, size, PROT_READ | PROT_WRITE,
+			MAP_SHARED | MAP_ANONYMOUS,
+			-1, 0);
+
+	p_cwd = SAFE_MALLOC(size);

These allocations should be made in test setup and freed in the test cleanup.

Quoted 14 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +14 -0
+	struct tst_clone_args args = {
+		.flags = CLONE_FS,
+		.exit_signal = SIGCHLD,
+	};
+
+	if (!SAFE_CLONE(&args)) {
+
+		TST_EXP_PASS(unshare(CLONE_NEWNS));
+
+		SAFE_CHDIR(TMP);
+		SAFE_GETCWD(c_cwd, size);
+	} else {
+		SAFE_WAIT(NULL);
+

testcases/kernel/syscalls/unshare/unshare04.c line 56

Quoted 10 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +10 -0
+		SAFE_GETCWD(p_cwd, size);
+
+		tst_res(TDEBUG, "parent cwd: %s", p_cwd);
+		tst_res(TDEBUG, "child cwd: %s", c_cwd);
+
+		//in parent, cwd stays in tst_tmpdir_path than TMP.
+		if (strcmp(p_cwd, c_cwd) == 0)
+			tst_res(TFAIL, "cwd not unshared as expected");
+		else
+			tst_res(TPASS, "cwd unshared");

We are validating that the CWD wasn't changed in parent after we have done unshare() and chdir() in the child. Why do we even compare the parent CWD againts the child? Rather than that we have to compare the CWD in the parent againts the CWD at the start of the test.

What we should do is:

- do chdir() in child
- check in child that CWD was changed

- wait child in parent
- check in parent that CWD wasn't changed

For that all we have to do is to do getcwd() in the test setup and then use it for a comparsion both in the child and parent.

Quoted 19 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +13 -0
+	}
+}
+
+static struct tst_test test = {
+	.forks_child = 1,
+	.needs_root = 1,
+	.needs_tmpdir = 1,
+	.test_all = run,
+};
+
+#else
+TST_TEST_TCONF("unshare syscall is undefined.");
+#endif
Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#2 lore raw

PATCH v2 1/1 syscalls/unshare: New test: CLONE_NEWNS unshares fs info

In reply to lufei

Add test case unshare04, to verify unshare(CLONE_NEWNS) also unshares filesystem information.

---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/unshare/.gitignore  |  1 +
 testcases/kernel/syscalls/unshare/unshare04.c | 82 +++++++++++++++++++
 3 files changed, 84 insertions(+)
 create mode 100644 testcases/kernel/syscalls/unshare/unshare04.c
runtest/syscalls +1 -0
index 844ae7a13..57338297a 100644
@@ -1725,6 +1725,7 @@ unlinkat01 unlinkat01
 unshare01 unshare01
 unshare02 unshare02
 unshare03 unshare03
+unshare04 unshare04
 
 #
 # These tests require an unmounted block device
testcases/kernel/syscalls/unshare/.gitignore +1 -0
index e5b5c261d..b1206e452 100644
@@ -1,3 +1,4 @@
 /unshare01
 /unshare02
 /unshare03
+/unshare04
testcases/kernel/syscalls/unshare/unshare04.c new file +82 -0

82 lines not on this page · raw message

Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Hi!

Quoted 21 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +21 -0
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2025 lufei <[email protected]>
+ */
+
+/*\
+ * This test case is to verify unshare(CLONE_NEWNS) also unshares filesystem
+ * information.
+ *
+ */
+
+#define _GNU_SOURCE
+
+#include "tst_test.h"
+#include "lapi/sched.h"
+
+#define TMP "/tmp1"
+
+static char *cwd;
+static char *tmpdir;
+static char *c_cwd;

testcases/kernel/syscalls/unshare/unshare04.c line 31

Quoted 10 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +10 -0
+static char *p_cwd;
+static size_t size = 1024;
+
+static void setup(void)
+{
+	cwd = SAFE_MALLOC(size);
+	SAFE_GETCWD(cwd, size);
+
+	tmpdir = tst_tmpdir_genpath(TMP);
+	SAFE_MKDIR(tmpdir, 0700);

There no need for absolute paths, the test starts with CWD pointing to the newly created temporary directory. So all that we need to do is to use relative paths with:

#define TESTDIR "test_dir"

	SAFE_MKDIR(TESTDIR, 0700);

And then later do SAFE_CHDIR(TESTDIR) in the child.

testcases/kernel/syscalls/unshare/unshare04.c line 34

Quoted 2 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +2 -0
+	c_cwd = SAFE_MALLOC(size);
+	p_cwd = SAFE_MALLOC(size);

We do not need two of these, we can use the same buffer both in child and parent.

Quoted 27 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +27 -0
+}
+
+static void cleanup(void)
+{
+	free(c_cwd);
+	free(p_cwd);
+	free(cwd);
+}
+
+
+static void run(void)
+{
+	struct tst_clone_args args = {
+		.flags = CLONE_FS,
+		.exit_signal = SIGCHLD,
+	};
+
+	if (!SAFE_CLONE(&args)) {
+
+		TST_EXP_PASS(unshare(CLONE_NEWNS));
+
+		SAFE_CHDIR(tmpdir);
+		SAFE_GETCWD(c_cwd, size);
+
+		if (strcmp(cwd, c_cwd) == 0)
+			tst_res(TFAIL, "current dir not changed");
+		else

testcases/kernel/syscalls/unshare/unshare04.c line 71

Quoted 10 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +10 -0
+			tst_res(TPASS, "current dir changed to %s", c_cwd);
+	} else {
+		SAFE_WAIT(NULL);
+
+		SAFE_GETCWD(p_cwd, size);
+
+		if (strcmp(cwd, p_cwd) == 0)
+			tst_res(TPASS, "cwd unshared");
+		else
+			tst_res(TFAIL, "cwd not unshare as expected");
                                                  ^
						unshared
Quoted 14 lines
testcases/kernel/syscalls/unshare/unshare04.c new file +11 -0
+	}
+}
+
+static struct tst_test test = {
+	.forks_child = 1,
+	.needs_root = 1,
+	.needs_tmpdir = 1,
+	.test_all = run,
+	.setup = setup,
+	.cleanup = cleanup,
+};
Signature · 1 line
2.39.3
Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
author
#4 lore raw

PATCH v3 1/1 syscalls/unshare: New test: CLONE_NEWNS unshares fs info

In reply to lufei

Add test case unshare04, to verify unshare(CLONE_NEWNS) also unshares filesystem information.

---
 runtest/syscalls                              |  1 +
 testcases/kernel/syscalls/unshare/.gitignore  |  1 +
 testcases/kernel/syscalls/unshare/unshare04.c | 77 +++++++++++++++++++
 3 files changed, 79 insertions(+)
 create mode 100644 testcases/kernel/syscalls/unshare/unshare04.c
runtest/syscalls +1 -0
index 844ae7a13..57338297a 100644
@@ -1725,6 +1725,7 @@ unlinkat01 unlinkat01
 unshare01 unshare01
 unshare02 unshare02
 unshare03 unshare03
+unshare04 unshare04
 
 #
 # These tests require an unmounted block device
testcases/kernel/syscalls/unshare/.gitignore +1 -0
index e5b5c261d..b1206e452 100644
@@ -1,3 +1,4 @@
 /unshare01
 /unshare02
 /unshare03
+/unshare04
testcases/kernel/syscalls/unshare/unshare04.c new file +77 -0

77 lines not on this page · raw message

Signature · 5 lines
2.39.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#5 lore raw

Hi!
I've adjusted the test description a bit and pushed, thanks!

I've clarified what we are testing that CWD is being unshared with:

testcases/kernel/syscalls/unshare/unshare04.c +2 -4
index 5b3e5d98f..4305c5cb1 100644
@@ -4,9 +4,8 @@
  */
 
 /*\
- * This test case is to verify unshare(CLONE_NEWNS) also unshares filesystem
- * information.
- *
+ * This test case is to verify unshare(CLONE_NEWNS) also unshares process
+ * working directory.
  */
 
-- 

Cyril Hrubis
[email protected]

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp