Skip to contentSkip to conversation

serdev: Improve messages printed by dev_err() and dev_dbg()

PATCH Superseded Zijun Hu 3 participants 7 messages Apr 24, 2025 – Apr 25, 2025

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Zijun Hu

author
#0 lore raw

v2 cover serdev: Improve messages printed by dev_err() and dev_dbg()

For messages printed by dev_err() and dev_dbg(), this patch series is to remove hardcoded or repeated device name.

---
Changes in v2:
- Add one more patch to remove repeated device name pointed out by Greg
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Zijun Hu (2):
serdev: Get serdev controller's name by dev_name()
serdev: Remove repeated device name in dev_(err|dbg) messages

 drivers/tty/serdev/core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

---
base-commit: 9d7a0577c9db35c4cc52db90bc415ea248446472
change-id: 20250422-fix_serdev-9da04229081b

Best regards,

Signature · 1 line
Zijun Hu <[email protected]>
author
#1 lore raw

PATCH v2 1/2 serdev: Get serdev controller's name by dev_name()

From: Zijun Hu <[email protected]>

serdev_controller_add() uses hardcoded serdev controller's name, and that may be wrong once user changes the name after serdev_controller_alloc().

Fix by using dev_name() instead of hardcoded name.

---
 drivers/tty/serdev/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serdev/core.c +2 -2
index eb2a2e58fe78fbbdb5839232936a994bda86d0b4..971651b8e18dcbb5b7983cdfa19e7d60d4cd292b 100644
@@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
 		goto err_rpm_disable;
 	}
 
-	dev_dbg(&ctrl->dev, "serdev%d registered: dev:%p\n",
-		ctrl->nr, &ctrl->dev);
+	dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
+		dev_name(&ctrl->dev), &ctrl->dev);
 	return 0;
 
 err_rpm_disable:
Signature · 1 line
2.34.1
author
#2 lore raw

PATCH v2 2/2 serdev: Remove repeated device name in dev_(err|dbg) messages

In reply to Zijun Hu

From: Zijun Hu <[email protected]>

There are serval dev_err() and dev_dbg() usages shown below:

dev_dbg(dev, "...%s...", dev_name(dev))

The device name is repeated since dev_dbg() also prints device name as prefix.

Fix by optimizing the messages printed.

---
 drivers/tty/serdev/core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/tty/serdev/core.c +5 -5
index 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644
@@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)
 
 	err = device_add(&serdev->dev);
 	if (err < 0) {
-		dev_err(&serdev->dev, "Can't add %s, status %pe\n",
-			dev_name(&serdev->dev), ERR_PTR(err));
+		dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
+			ERR_PTR(err));
 		goto err_clear_serdev;
 	}
 
-	dev_dbg(&serdev->dev, "device %s registered\n", dev_name(&serdev->dev));
+	dev_dbg(&serdev->dev, "serdev registered successfully\n");
 
 	return 0;
 
@@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
 		goto err_rpm_disable;
 	}
 
-	dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
-		dev_name(&ctrl->dev), &ctrl->dev);
+	dev_dbg(&ctrl->dev, "serdev controller registered: dev:%p\n",
+		&ctrl->dev);
 	return 0;
 
 err_rpm_disable:
Signature · 1 line
2.34.1
#3 lore raw

Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

Quoted 38 lines · Zijun Hu

From: Zijun Hu <[email protected]>

There are serval dev_err() and dev_dbg() usages shown below:

dev_dbg(dev, "...%s...", dev_name(dev))

The device name is repeated since dev_dbg() also prints device name as prefix.

Fix by optimizing the messages printed.

---
 drivers/tty/serdev/core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/tty/serdev/core.c +3 -3
index 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644
@@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)
 
        err = device_add(&serdev->dev);
        if (err < 0) {
-               dev_err(&serdev->dev, "Can't add %s, status %pe\n",
-                       dev_name(&serdev->dev), ERR_PTR(err));
+               dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
+                       ERR_PTR(err));
                goto err_clear_serdev;
        }
 
-       dev_dbg(&serdev->dev, "device %s registered\n", dev_name(&serdev->dev));
+       dev_dbg(&serdev->dev, "serdev registered successfully\n");
 
        return 0;
 

drivers/tty/serdev/core.c int serdev_controller_add(struct serdev_controller *ctrl) · line 787

Quoted 5 lines
drivers/tty/serdev/core.c +0 -2
@@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
                goto err_rpm_disable;
        }
 
-       dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
-               dev_name(&ctrl->dev), &ctrl->dev);

I don't understand why you add dev_name() and then turn around and remove it in the next patch. Just squash the patches.

Quoted 9 lines
drivers/tty/serdev/core.c +2 -1
+       dev_dbg(&ctrl->dev, "serdev controller registered: dev:%p\n",
+               &ctrl->dev);
        return 0;
 
 err_rpm_disable:
 
--

2.34.1

author
#4 lore raw

Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

Quoted 8 lines · Rob Herring

drivers/tty/serdev/core.c int serdev_controller_add(struct serdev_controller *ctrl) · line 787

Quoted 6 lines
drivers/tty/serdev/core.c +0 -2
@@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
                goto err_rpm_disable;
        }
 
-       dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
-               dev_name(&ctrl->dev), &ctrl->dev);

I don't understand why you add dev_name() and then turn around and remove it in the next patch. Just squash the patches.

okay, will do it in next revision.

maintainer
#5 lore raw

Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

In reply to Zijun Hu
Quoted 21 lines · Zijun Hu

From: Zijun Hu <[email protected]>

There are serval dev_err() and dev_dbg() usages shown below:

dev_dbg(dev, "...%s...", dev_name(dev))

The device name is repeated since dev_dbg() also prints device name as prefix.

Fix by optimizing the messages printed.

---
  drivers/tty/serdev/core.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
drivers/tty/serdev/core.c +0 -0
index 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644

drivers/tty/serdev/core.c int serdev_device_add(struct serdev_device *serdev) · line 122

Quoted 7 lines
drivers/tty/serdev/core.c +2 -2
@@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)
 
  	err = device_add(&serdev->dev);
  	if (err < 0) {
-		dev_err(&serdev->dev, "Can't add %s, status %pe\n",
-			dev_name(&serdev->dev), ERR_PTR(err));
+		dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
+			ERR_PTR(err));

You don't need to wrap now.

Could you also get rid of ERR_PTR() and print err directly using %d?

Quoted 9 lines
drivers/tty/serdev/core.c +1 -1
  		goto err_clear_serdev;
  	}
 
-	dev_dbg(&serdev->dev, "device %s registered\n", dev_name(&serdev->dev));
+	dev_dbg(&serdev->dev, "serdev registered successfully\n");
 
  	return 0;
 

drivers/tty/serdev/core.c int serdev_controller_add(struct serdev_controller *ctrl) · line 787

Quoted 7 lines
drivers/tty/serdev/core.c +2 -2
@@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
  		goto err_rpm_disable;
  	}
 
-	dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
-		dev_name(&ctrl->dev), &ctrl->dev);
+	dev_dbg(&ctrl->dev, "serdev controller registered: dev:%p\n",
+		&ctrl->dev);

No need to wrap.

Signature · 2 lines
js
suse labs
author
#6 lore raw

Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

Quoted 16 lines · Jiri Slaby

drivers/tty/serdev/core.c int serdev_device_add(struct serdev_device *serdev) · line 121

Quoted 13 lines
drivers/tty/serdev/core.c +0 -0

index 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644

drivers/tty/serdev/core.c +2 -2
@@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)
         err = device_add(&serdev->dev);
       if (err < 0) {
-        dev_err(&serdev->dev, "Can't add %s, status %pe\n",
-            dev_name(&serdev->dev), ERR_PTR(err));
+        dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
+            ERR_PTR(err));

You don't need to wrap now.

Quoted 3 lines

Could you also get rid of ERR_PTR() and print err directly using %d?

Quoted 1 line
drivers/tty/serdev/core.c +0 -0
           goto err_clear_serdev; 

sure, will do it in next revision.