Skip to contentSkip to conversation

x86/pmu_pebs: Initalize and enable PMU interrupt (PMI_VECTOR)

PATCH Applied Dapeng Mi 2 participants 2 messages Apr 24, 2025 – Jun 10, 2025 KVM

lore
Share & tools
lore

Dapeng Mi

author
#0 lore raw

PATCH 1/1 x86/pmu_pebs: Initalize and enable PMU interrupt (PMI_VECTOR)

PMU interrupt is not correctly initialized and enabled in pmu_pebs test. It leads to the APIC_LVTPC mask bit is never cleared after first PMI and all subsequential PEBS PMIs are suppressed.

Although it doesn't impact pmu_pebs test results since current pmu_pebs test checks PEBS records by polling instead of PMI driving, it's still an incorrect behavior and could cause some unexpected false positives.

Thus initialize and enable PMU interrupt and ensure PEBS PMI can be generated and correctly processed.

---
 x86/pmu_pebs.c | 3 +++
 1 file changed, 3 insertions(+)
x86/pmu_pebs.c +3 -0
index 6396d51c..6e73fc34 100644
@@ -417,9 +417,11 @@ int main(int ac, char **av)
 	printf("PEBS Fixed counters: %d\n", pmu.nr_fixed_counters);
 	printf("PEBS baseline (Adaptive PEBS): %d\n", has_baseline);
 
+	apic_write(APIC_LVTPC, PMI_VECTOR);
 	handle_irq(PMI_VECTOR, cnt_overflow);
 	alloc_buffers();
 
+	sti();
 	for (i = 0; i < ARRAY_SIZE(counter_start_values); i++) {
 		ctr_start_val = counter_start_values[i];
 		check_pebs_counters(0, false);
@@ -441,6 +443,7 @@ int main(int ac, char **av)
 			report_prefix_pop();
 		}
 	}
+	cli();
 
 	free_buffers();
 

base-commit: abdc5d02a7796a55802509ac9bb704c721f2a5f6

Signature · 1 line
2.40.1
reviewer Applied
#1 lore raw
Quoted 9 lines · Dapeng Mi

PMU interrupt is not correctly initialized and enabled in pmu_pebs test. It leads to the APIC_LVTPC mask bit is never cleared after first PMI and all subsequential PEBS PMIs are suppressed.

Although it doesn't impact pmu_pebs test results since current pmu_pebs test checks PEBS records by polling instead of PMI driving, it's still an incorrect behavior and could cause some unexpected false positives.

[...]

Applied to kvm-x86 next, thanks!

[1/1] x86/pmu_pebs: Initalize and enable PMU interrupt (PMI_VECTOR)

      https://github.com/kvm-x86/kvm-unit-tests/commit/389dfda487f9

--
https://github.com/kvm-x86/kvm-unit-tests/tree/next