USB: serial: ti_usb_3410_5052: drop bogus read urb check

PATCH New Johan Hovold 1 participant 1 message Apr 24, 2025

Subsystems (2)

USB USB serial

lore

Share & tools

lore

Johan Hovold

author maintainer

2025-04-24 07:45 UTC #0 lore raw

PATCH 1/1 USB: serial: ti_usb_3410_5052: drop bogus read urb check

The read urb pointer is dereferenced before checking that it is non-NULL during open(), but no check is needed as the existence of a bulk in endpoint is verified during attach() since commit ef079936d3cd ("USB:
serial: ti_usb_3410_5052: fix NULL-deref at open").

Drop the bogus read urb sanity check.

Signed-off-by Johan Hovold <[email protected]>

---
 drivers/usb/serial/ti_usb_3410_5052.c | 5 -----
 1 file changed, 5 deletions(-)

drivers/usb/serial/ti_usb_3410_5052.c +0 -5

index a0c244bc77c0..d671189ecee2 100644
@@ -729,11 +729,6 @@ static int ti_open(struct tty_struct *tty, struct usb_serial_port *port)
 
 	/* start read urb */
 	urb = port->read_urb;
-	if (!urb) {
-		dev_err(&port->dev, "%s - no read urb\n", __func__);
-		status = -EINVAL;
-		goto unlink_int_urb;
-	}
 	tport->tp_read_urb_state = TI_READ_URB_RUNNING;
 	urb->context = tport;
 	status = usb_submit_urb(urb, GFP_KERNEL);

Signature · 1 line

2.49.0