tools: selftests: prepare for non-default IP_TABLES_LEGACY
Subsystems (3)
Florian Westphal
maintainerPATCH 1/1 tools: selftests: prepare for non-default IP_TABLES_LEGACY
Enable relevant iptables config options explicitly, this is needed to avoid breakage when symbols related to iptables-legacy will depend on NETFILTER_LEGACY resp. IP_TABLES_LEGACY.
This also means that the classic tables (Kernel modules) will not be enabled by default, so enable them too.
---
Hi Pablo
with this nf tests pass with iptables-legacy.
The problematic net tests pass for me as well with either iptables-nft or -legacy.
Problem with iptables-nft was that TARGET_TTL is ignored by Makefile, the symbol picks up TARGET_HL behind the scenes but not after the mentioned commit.
This could be squashed with
netfilter: Exclude LEGACY TABLES on PREEMPT_RT. Or it could be added before. In that case the commit message needs to be updated (CONFIG_NETFILTER_LEGACY knob doesn't exist yet in this case).
tools/testing/selftests/net/config | 11 +++++++++++ tools/testing/selftests/net/netfilter/config | 5 +++++ 2 files changed, 16 insertions(+)
tools/testing/selftests/net/config +11 -0
@@ -29,17 +29,26 @@ CONFIG_INET_ESP_OFFLOAD=y CONFIG_NET_FOU=y CONFIG_NET_FOU_IP_TUNNELS=y CONFIG_NETFILTER=y +CONFIG_NETFILTER_LEGACY=y CONFIG_NETFILTER_ADVANCED=y CONFIG_NF_CONNTRACK=m CONFIG_IPV6_MROUTE=y CONFIG_IPV6_SIT=y CONFIG_NF_NAT=m CONFIG_IP6_NF_IPTABLES=m +CONFIG_IP6_NF_IPTABLES_LEGACY=m CONFIG_IP_NF_IPTABLES=m +CONFIG_IP_NF_IPTABLES_LEGACY=m +CONFIG_IP6_NF_MANGLE=m +CONFIG_IP6_NF_FILTER=m CONFIG_IP6_NF_NAT=m CONFIG_IP6_NF_RAW=m +CONFIG_IP_NF_MANGLE=m +CONFIG_IP_NF_FILTER=m CONFIG_IP_NF_NAT=m CONFIG_IP_NF_RAW=m +CONFIG_IP_NF_TARGET_REJECT=m +CONFIG_IP6_NF_TARGET_REJECT=m CONFIG_IP_NF_TARGET_TTL=m CONFIG_IPV6_GRE=m CONFIG_IPV6_SEG6_LWTUNNEL=y
@@ -57,6 +66,8 @@ CONFIG_NF_TABLES_IPV6=y CONFIG_NF_TABLES_IPV4=y CONFIG_NFT_NAT=m CONFIG_NETFILTER_XT_MATCH_LENGTH=m +CONFIG_NETFILTER_XT_TARGET_HL=m +CONFIG_NETFILTER_XT_NAT=m CONFIG_NET_ACT_CSUM=m CONFIG_NET_ACT_CT=m CONFIG_NET_ACT_GACT=m
tools/testing/selftests/net/netfilter/config +5 -0
@@ -1,6 +1,8 @@ CONFIG_AUDIT=y CONFIG_BPF_SYSCALL=y CONFIG_BRIDGE=m +CONFIG_NETFILTER_LEGACY=y +CONFIG_BRIDGE_NF_EBTABLES_LEGACY=m CONFIG_BRIDGE_EBT_BROUTE=m CONFIG_BRIDGE_EBT_IP=m CONFIG_BRIDGE_EBT_REDIRECT=m
@@ -14,7 +16,10 @@ CONFIG_INET_ESP=m CONFIG_IP_NF_MATCH_RPFILTER=m CONFIG_IP6_NF_MATCH_RPFILTER=m CONFIG_IP_NF_IPTABLES=m +CONFIG_IP_NF_IPTABLES_LEGACY=m CONFIG_IP6_NF_IPTABLES=m +CONFIG_IP6_NF_IPTABLES_LEGACY=m +CONFIG_IP_NF_NAT=m CONFIG_IP_NF_FILTER=m CONFIG_IP6_NF_FILTER=m CONFIG_IP_NF_RAW=m
Signature · 1 line
2.49.0
Pablo Neira Ayuso
maintainerOn Thu, Apr 24, 2025 at 03:49:27PM +0200, Florian Westphal wrote:
[...]
Quoted 5 lines
This could be squashed with
netfilter: Exclude LEGACY TABLES onPREEMPT_RT. Or it could be added before. In that case the commit message needs to be updated (CONFIG_NETFILTER_LEGACYknob doesn't exist yet in this case).
Thanks Florian, I am going to collapse this, make a few more tests then prepare for another pull request.