media: ov5675/ov8856: suppress probe deferral errors
Subsystems (4)
cover media: ov5675/ov8856: suppress probe deferral errors
Probe of the camera sensor on the Lenovo ThinkPad X13s is sometimes deferred when its supplies are not yet ready and this is incorrectly logged as an error:
ov5675 24-0010: failed to get HW configuration: -517
This series suppress the bogus error in the ov5675 and ov8856 drivers.
Johan
Johan Hovold (2):
media: ov5675: suppress probe deferral errors
media: ov8856: suppress probe deferral errors
drivers/media/i2c/ov5675.c | 5 +---- drivers/media/i2c/ov8856.c | 9 +++------ 2 files changed, 4 insertions(+), 10 deletions(-)
Signature · 1 line
2.49.0
PATCH 1/2 media: ov5675: suppress probe deferral errors
Probe deferral should not be logged as an error:
ov5675 24-0010: failed to get HW configuration: -517
Drop the (mostly) redundant dev_err() from sensor probe() to suppress it.
Note that errors during clock and regulator lookup are already correctly logged using dev_err_probe().
--- drivers/media/i2c/ov5675.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/media/i2c/ov5675.c +1 -4
@@ -1295,11 +1295,8 @@ static int ov5675_probe(struct i2c_client *client)return -ENOMEM ; ret =ov5675_get_hwcfg (ov5675, &client->dev); -if (ret) { -dev_err (&client->dev,"failed to get HW configuration: %d" , - ret); +if (ret)return ret; - }v4l2_i2c_subdev_init (&ov5675->sd, client, &ov5675_subdev_ops);
Signature · 1 line
2.49.0
PATCH 2/2 media: ov8856: suppress probe deferral errors
In reply to Johan HovoldProbe deferral should not be logged as an error:
ov8856 24-0010: failed to get HW configuration: -517
Use dev_err_probe() for the clock lookup and drop the (mostly) redundant dev_err() from sensor probe() to suppress it.
Note that errors during regulator lookup is already correctly logged using dev_err_probe().
--- drivers/media/i2c/ov8856.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/media/i2c/ov8856.c +3 -6
@@ -2276,8 +2276,8 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, struct device *dev)if (!is_acpi_node (fwnode)) { ov8856->xvclk =devm_clk_get (dev,"xvclk" );if (IS_ERR (ov8856->xvclk)) { -dev_err (dev,"could not get xvclk clock (%pe)\n" , - ov8856->xvclk); +dev_err_probe (dev,PTR_ERR (ov8856->xvclk), +"could not get xvclk clock\n" );return PTR_ERR (ov8856->xvclk); }
@@ -2382,11 +2382,8 @@ static int ov8856_probe(struct i2c_client *client)return -ENOMEM ; ret =ov8856_get_hwcfg (ov8856, &client->dev); -if (ret) { -dev_err (&client->dev,"failed to get HW configuration: %d" , - ret); +if (ret)return ret; - }v4l2_i2c_subdev_init (&ov8856->sd, client, &ov8856_subdev_ops);
Signature · 1 line
2.49.0