Skip to contentSkip to conversation

multipath-tools: replace dead url

PATCH In review Xose Vazquez Perez 2 participants 2 messages Apr 27, 2025 – Apr 30, 2025 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 multipath-tools: replace dead url

Original url at Wayback Machine:
https://web.archive.org/web/20230820174630/https://listman.redhat.com/archives/dm-devel/2017-September/msg00326.html

Cc Martin Wilck <[email protected]>
Cc Benjamin Marzinski <[email protected]>
Cc Christophe Varoqui <[email protected]>
Cc DM-DEVEL ML <[email protected]>

---
Should this code be replaced with DETECT_CHECKER_OFF in hwtable ???

---
 libmultipath/propsel.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
libmultipath/propsel.c +4 -5
index ad771d35..52a10765 100644
@@ -642,13 +642,12 @@ out:
 }
 
 /*
- * Current RDAC (NetApp E/EF Series) firmware relies
- * on periodic REPORT TARGET PORT GROUPS for
- * internal load balancing.
+ * Current RDAC (NetApp E/EF Series) firmware relies on periodic
+ * REPORT TARGET PORT GROUPS for internal load balancing.
  * Using the sysfs priority checker defeats this purpose.
  *
- * Moreover, NetApp would also prefer the RDAC checker over ALUA.
- * (https://listman.redhat.com/archives/dm-devel/2017-September/msg00326.html)
+ * Moreover, NetApp would also prefer the RDAC checker over ALUA:
+ * (https://lore.kernel.org/dm-devel/[email protected]/)
  */
 static int
 check_rdac(struct path * pp)
Signature · 1 line
2.49.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Xose Vazquez Perez

Original url at Wayback Machine:
https://web.archive.org/web/20230820174630/https://listman.redhat.com/archives/dm-devel/2017-September/msg00326.html

Cc Martin Wilck <[email protected]>
Cc Benjamin Marzinski <[email protected]>
Cc Christophe Varoqui <[email protected]>
Cc DM-DEVEL ML <[email protected]>
Quoted 2 lines

---
Should this code be replaced with DETECT_CHECKER_OFF in hwtable ???

No, let's just keep it as is. The check_rdac() code uses a vendor- specific VPD page to check for RDAC features, which is not the same as hard-coded values in the hwtable based on vendor and product.

I'd rather not risk regressions for a minor code simplification.

Regards
Martin