Skip to contentSkip to conversation

hw/arm/npcm8xx_boards: Correct valid_cpu_types setting of NPCM8XX SoC

PATCH Applied Tim Lee 3 participants 4 messages Apr 28, 2025 – May 5, 2025

lore
Share & tools
lore

Tim Lee

author
#0 lore raw

PATCH 1/1 hw/arm/npcm8xx_boards: Correct valid_cpu_types setting of NPCM8XX SoC

NPCM8XX SoC is the successor of the NPCM7XX. It features quad-core Cortex-A35 (Armv8, 64-bit) CPUs and some additional peripherals. Correct the valid_cpu_types setting to match the NPCM8XX SoC.

---
 hw/arm/npcm8xx_boards.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/arm/npcm8xx_boards.c +1 -1
index 3fb8478e72..6d3e59f6b9 100644
@@ -213,7 +213,7 @@ static void npcm8xx_machine_class_init(ObjectClass *oc, void *data)
 {
     MachineClass *mc = MACHINE_CLASS(oc);
     static const char * const valid_cpu_types[] = {
-        ARM_CPU_TYPE_NAME("cortex-a9"),
+        ARM_CPU_TYPE_NAME("cortex-a35"),
         NULL
     };
 
Signature · 1 line
2.34.1
#1 lore raw
Quoted 15 lines · Tim Lee

NPCM8XX SoC is the successor of the NPCM7XX. It features quad-core Cortex-A35 (Armv8, 64-bit) CPUs and some additional peripherals. Correct the valid_cpu_types setting to match the NPCM8XX SoC.

---
 hw/arm/npcm8xx_boards.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/arm/npcm8xx_boards.c +0 -0
index 3fb8478e72..6d3e59f6b9 100644

hw/arm/npcm8xx_boards.c static void npcm8xx_machine_class_init(ObjectClass *oc, void *data) · line 218

Quoted 7 lines
hw/arm/npcm8xx_boards.c +1 -1
@@ -213,7 +213,7 @@ static void npcm8xx_machine_class_init(ObjectClass *oc, void *data)
 {
     MachineClass *mc = MACHINE_CLASS(oc);
     static const char * const valid_cpu_types[] = {
-        ARM_CPU_TYPE_NAME("cortex-a9"),
+        ARM_CPU_TYPE_NAME("cortex-a35"),
         NULL
     };

Is this worth backporting to stable branches?

Applied to target-arm.next, thanks.

-- PMM

author
#2 lore raw
Quoted 5 lines

Is this worth backporting to stable branches?

Applied to target-arm.next, thanks.

-- PMM

Hi Peter,
Thank you for taking the time to review this. I believe it is worth backporting to stable branches.
The string "cortex-a9" and "cortex-a35" will point to different ARMCPUInfo which could cause some features to not be applied correctly in specific initial functions: "cortex_a9_initfn" and "aarch64_a35_initfn".

Sincerely,
Tim Lee

Reviewed-by on v1 1/1
#3 lore raw
In reply to Tim Lee

From: Tim Lee <[email protected]>
Sent: Monday, April 28, 2025 10:30 AM
To: [email protected]; [email protected]; CS20 KFTing <[email protected]>; CS20 CHLi30 <[email protected]>
Cc: [email protected]; [email protected]; Tim Lee <[email protected]>
Subject: [PATCH] hw/arm/npcm8xx_boards: Correct valid_cpu_types setting of NPCM8XX SoC

NPCM8XX SoC is the successor of the NPCM7XX. It features quad-core Cortex-A35 (Armv8, 64-bit) CPUs and some additional peripherals. Correct the valid_cpu_types setting to match the NPCM8XX SoC.

---
 hw/arm/npcm8xx_boards.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/arm/npcm8xx_boards.c +1 -2
@@ -213,7 +213,7 @@ static void npcm8xx_machine_class_init(ObjectClass *oc, void *data)  {
     MachineClass *mc = MACHINE_CLASS(oc);
     static const char * const valid_cpu_types[] = {
-        ARM_CPU_TYPE_NAME("cortex-a9"),
+        ARM_CPU_TYPE_NAME("cortex-a35"),
         NULL
     };
 
--

2.34.1

________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.