ASoC: wm_adsp: Don't use no_free_ptr() when passing to PTR_ERR()
Subsystems (3)
PATCH 1/1 ASoC: wm_adsp: Don't use no_free_ptr() when passing to PTR_ERR()
It's no longer necessary to no_free_ptr() an auto-freed pointer before passing it to PTR_ERR(). This was fixed by commit cd7eb8f83fcf ("mm/slab: make __free(kfree) accept error pointers").
Removing the no_free_ptr() avoids the spurious warning "inconsistent IS_ERR and PTR_ERR".
--- sound/soc/codecs/wm_adsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/wm_adsp.c +1 -1
@@ -419,7 +419,7 @@ static int wm_coeff_tlv_put(struct snd_kcontrol *kctl, void *scratch __free(kvfree) = vmemdup_user(bytes, size);if (IS_ERR (scratch)) -return PTR_ERR (no_free_ptr (scratch)); +return PTR_ERR (scratch);return cs_dsp_coeff_lock_and_write_ctrl (cs_ctl,0 , scratch, size); }
Signature · 1 line
2.43.0
Mark Brown
maintainerQuoted 8 lines · Richard Fitzgerald
It's no longer necessary to
no_free_ptr()an auto-freed pointer before passing it toPTR_ERR(). This was fixed by commitcd7eb8f83fcf("mm/slab: make__free(kfree)accept error pointers").Removing the
no_free_ptr()avoids the spurious warning "inconsistentIS_ERRandPTR_ERR".[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: wm_adsp: Don't use no_free_ptr() when passing to PTR_ERR()
commit: 94602d84163c127ec2374fba0fcb6587a07785ce
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark