scsi: mpi3mr: Introduce smp_affinity_enable module parameter
Subsystems (2)
cover scsi: mpi3mr: Introduce smp_affinity_enable module parameter
I noticed that the Linux MegaRAID driver for SAS based RAID controllers has the same aforementioned module parameter. Despite the potential performance drawbacks, I suspect it would be useful with the Broadcom MPI3 Storage Controller Driver too, to respect the default IRQ affinity. Please let me know your thoughts.
Aaron Tomlin (1):
scsi: mpi3mr: Introduce smp_affinity_enable module parameter
drivers/scsi/mpi3mr/mpi3mr_fw.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
2.47.1
RFC PATCH 1/1 scsi: mpi3mr: Introduce smp_affinity_enable module parameter
This patch introduces a new module parameter namely "smp_affinity_enable", to govern the application of system-wide IRQ affinity (with kernel boot-time parameter "irqaffinity") for MSI-X interrupts. By default, the default IRQ affinity mask will not be respected. Set smp_affinity_enable to 0 disables this behaviour. Consequently, preventing the auto-assignment of MSI-X IRQs.
--- drivers/scsi/mpi3mr/mpi3mr_fw.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/scsi/mpi3mr/mpi3mr_fw.c +6 -1
@@ -22,6 +22,10 @@ static int poll_queues;module_param (poll_queues, int,0444 );MODULE_PARM_DESC (poll_queues,"Number of queues for io_uring poll mode. (Range 1 - 126)" ); +static int smp_affinity_enable =1 ; +module_param (smp_affinity_enable, int,0444 ); +MODULE_PARM_DESC (smp_affinity_enable,"SMP affinity feature enable/disable Default: enable(1)" ); +#if defined(writeq) && defined(CONFIG_64BIT )static inline void mpi3mr_writeq (__u64 b,volatile void __iomem *addr) {
@@ -846,7 +850,8 @@ static int mpi3mr_setup_isr(struct mpi3mr_ioc *mrioc, u8 setup_one) desc.post_vectors = mrioc->requested_poll_qcount; min_vec = desc.pre_vectors + desc.post_vectors; - irq_flags |=PCI_IRQ_AFFINITY |PCI_IRQ_ALL_TYPES ; +if (smp_affinity_enable) + irq_flags |=PCI_IRQ_AFFINITY |PCI_IRQ_ALL_TYPES ; retval =pci_alloc_irq_vectors_affinity (mrioc->pdev, min_vec, max_vectors, irq_flags, &desc);
Signature · 1 line
2.47.1