Skip to contentSkip to conversation

drm/st7571-i2c: select CONFIG_DRM_CLIENT_SELECTION

PATCH In review Arnd Bergmann 3 participants 3 messages Apr 28, 2025 – Apr 29, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/st7571-i2c: select CONFIG_DRM_CLIENT_SELECTION

From: Arnd Bergmann <[email protected]>

The newly added driver calls drm_client_setup(), but that is not always built in:

x86_64-linux-ld: vmlinux.o: in function `st7571_probe':
st7571-i2c.c:(.text+0x7b7119): undefined reference to `drm_client_setup'

Select the appropriate Kconfig symbol.

Fixes 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller")
---
 drivers/gpu/drm/tiny/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/tiny/Kconfig +1 -0
index 1dfe6291d9c0..654cd6f25faa 100644
@@ -215,6 +215,7 @@ config TINYDRM_ST7586
 config DRM_ST7571_I2C
 	tristate "DRM support for Sitronix ST7571 display panels (I2C)"
 	depends on DRM && I2C && MMU
+	select DRM_CLIENT_SELECTION
 	select DRM_GEM_SHMEM_HELPER
 	select DRM_KMS_HELPER
 	select REGMAP_I2C
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The newly added driver calls drm_client_setup(), but that is not always built in:

Quoted 7 lines

x86_64-linux-ld: vmlinux.o: in function `st7571_probe':
st7571-i2c.c:(.text+0x7b7119): undefined reference to `drm_client_setup'

Select the appropriate Kconfig symbol.

Fixes 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller")
Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann

Hello Arnd,

Quoted 5 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The newly added driver calls drm_client_setup(), but that is not always built in:

Quoted 8 lines

x86_64-linux-ld: vmlinux.o: in function `st7571_probe':
st7571-i2c.c:(.text+0x7b7119): undefined reference to `drm_client_setup'

Select the appropriate Kconfig symbol.

Fixes 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller")

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat