Skip to contentSkip to conversation

firmware: ti_sci: Add Initialization of dev_info head node

PATCH Superseded Udit Kumar 3 participants 3 messages Apr 29, 2025 Texas instruments' system control interface (TISCI) protocol driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Udit Kumar

author
#0 lore raw

PATCH 1/1 firmware: ti_sci: Add Initialization of dev_info head node

On K3 devices two drivers ti_sci and ti_sci_dm are supporting firmware functions. At run time one of driver is used.

Driver ti_sci already initializing head for dev_list in its probe function, but it was missed in ti_sci_dm driver.

So add head list init support for ti_sci_dm driver.

Fixes 5d5a699855a7("firmware: ti_sci: Add support for Resoure Management at R5 SPL stage")
---
 drivers/firmware/ti_sci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/firmware/ti_sci.c +2 -0
index 54d6689ce78..a599de9e013 100644
@@ -2891,6 +2891,8 @@ static __maybe_unused int ti_sci_dm_probe(struct udevice *dev)
 
 	list_add_tail(&info->list, &ti_sci_list);
 
+	INIT_LIST_HEAD(&info->dev_list);
+
 	ops = &info->handle.ops;
 
 	rm_core_ops = &ops->rm_core_ops;
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Udit

Quoted 20 lines · Udit Kumar

On K3 devices two drivers ti_sci and ti_sci_dm are supporting firmware functions. At run time one of driver is used.

Driver ti_sci already initializing head for dev_list in its probe function, but it was missed in ti_sci_dm driver.

So add head list init support for ti_sci_dm driver.

Fixes 5d5a699855a7("firmware: ti_sci: Add support for Resoure Management at R5 SPL stage")
---
 drivers/firmware/ti_sci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/firmware/ti_sci.c +0 -0
index 54d6689ce78..a599de9e013 100644

drivers/firmware/ti_sci.c static __maybe_unused int ti_sci_dm_probe(struct udevice *dev) · line 2898

Quoted 8 lines
drivers/firmware/ti_sci.c +2 -0
@@ -2891,6 +2891,8 @@ static __maybe_unused int ti_sci_dm_probe(struct udevice *dev)
 
 	list_add_tail(&info->list, &ti_sci_list);
 
+	INIT_LIST_HEAD(&info->dev_list);
+
 	ops = &info->handle.ops;
 
 	rm_core_ops = &ops->rm_core_ops;
Signature · 2 lines
Thanking You
Neha Malcom Francis
maintainer
#2 lore raw
In reply to Udit Kumar
Quoted 9 lines · Udit Kumar

On K3 devices two drivers ti_sci and ti_sci_dm are supporting firmware functions. At run time one of driver is used.

Driver ti_sci already initializing head for dev_list in its probe function, but it was missed in ti_sci_dm driver.

So add head list init support for ti_sci_dm driver.

Fixes 5d5a699855a7("firmware: ti_sci: Add support for Resoure Management at R5 SPL stage")

Nice catch.

Quoted 11 lines
---
 drivers/firmware/ti_sci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/firmware/ti_sci.c +0 -0
index 54d6689ce78..a599de9e013 100644

drivers/firmware/ti_sci.c static __maybe_unused int ti_sci_dm_probe(struct udevice *dev) · line 2895

Quoted 5 lines
drivers/firmware/ti_sci.c +2 -0
@@ -2891,6 +2891,8 @@ static __maybe_unused int ti_sci_dm_probe(struct udevice *dev)
 
 	list_add_tail(&info->list, &ti_sci_list);
 
+	INIT_LIST_HEAD(&info->dev_list);
+

I don't think this impacts a lot, but for sanity reasons, you might want to do this before we add it to ti_sci_list.

Similarly, ti_sci_probe() does INIT_LIST_HEAD after adding to the &ti_sci_list, might want to do the INIT before adding to list.

Quoted 6 lines
drivers/firmware/ti_sci.c +0 -0
 	ops = &info->handle.ops;
 
 	rm_core_ops = &ops->rm_core_ops;
Signature · 1 line
2.34.1
Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D