6.1.136-rc1 review
Subsystems (7)
Greg Kroah-Hartman
maintainerPATCH 148/167 md/raid1: Add check for missing source disk in process_checks()
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Meir Elisha <[email protected]>
[ Upstream commit b7c178d9e57c8fd4238ff77263b877f6f16182ba ]
During recovery/check operations, the process_checks function loops through available disks to find a 'primary' source with successfully read data.
If no suitable source disk is found after checking all possibilities, the 'primary' index will reach conf->raid_disks * 2. Add an explicit check for this condition after the loop. If no source disk was found, print an error message and return early to prevent further processing without a valid primary source.
--- drivers/md/raid1.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-)
drivers/md/raid1.c +16 -10
@@ -2068,14 +2068,9 @@ static int fix_sync_read_error(struct r1bio *r1_bio)if (!rdev_set_badblocks (rdev, sect, s,0 )) abort =1 ; } -if (abort) { - conf->recovery_disabled = - mddev->recovery_disabled; -set_bit (MD_RECOVERY_INTR , &mddev->recovery); -md_done_sync (mddev, r1_bio->sectors,0 ); -put_buf (r1_bio); +if (abort)return 0 ; - } +/* Try next page */ sectors -= s; sect += s;
@@ -2214,10 +2209,21 @@ static void sync_request_write(struct mddev *mddev, struct r1bio *r1_bio)int disks = conf->raid_disks *2 ;struct bio *wbio; -if (!test_bit (R1BIO_Uptodate, &r1_bio->state)) -/* ouch - failed to read all of that. */ -if (!fix_sync_read_error (r1_bio)) +if (!test_bit (R1BIO_Uptodate, &r1_bio->state)) { +/* +* ouch - failed to read all of that. +* No need to fix read error for check/repair +* because all member disks are read. +*/ +if (test_bit (MD_RECOVERY_REQUESTED , &mddev->recovery) || + !fix_sync_read_error (r1_bio)) { + conf->recovery_disabled = mddev->recovery_disabled; +set_bit (MD_RECOVERY_INTR , &mddev->recovery); +md_done_sync (mddev, r1_bio->sectors,0 ); +put_buf (r1_bio);return ; + } + }if (test_bit (MD_RECOVERY_REQUESTED , &mddev->recovery))process_checks (r1_bio);
Signature · 1 line
2.39.5
Greg Kroah-Hartman
maintainerPATCH 149/167 spi: spi-imx: Add check for spi_imx_setupxfer()
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tamura Dai <[email protected]>
[ Upstream commit 951a04ab3a2db4029debfa48d380ef834b93207e ]
Add check for the return value of spi_imx_setupxfer(). spi_imx->rx and spi_imx->tx function pointer can be NULL when spi_imx_setupxfer() return error, and make NULL pointer dereference.
Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 Call trace: 0x0 spi_imx_pio_transfer+0x50/0xd8 spi_imx_transfer_one+0x18c/0x858 spi_transfer_one_message+0x43c/0x790 __spi_pump_transfer_message+0x238/0x5d4 __spi_sync+0x2b0/0x454 spi_write_then_read+0x11c/0x200
--- drivers/spi/spi-imx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/spi/spi-imx.c +4 -1
@@ -1605,10 +1605,13 @@ static int spi_imx_transfer_one(struct spi_controller *controller,struct spi_device *spi, struct spi_transfer *transfer) { + int ret;struct spi_imx_data *spi_imx =spi_controller_get_devdata (spi->controller);unsigned long hz_per_byte, byte_limit; -spi_imx_setupxfer (spi, transfer); + ret =spi_imx_setupxfer (spi, transfer); +if (ret <0 ) +return ret; transfer->effective_speed_hz = spi_imx->spi_bus_clk;/* flush rxfifo before transfer */
Signature · 1 line
2.39.5
Greg Kroah-Hartman
maintainerPATCH 150/167 of: module: add buffer overflow check in of_modalias()
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sergey Shtylyov <[email protected]>
commit cf7385cb26ac4f0ee6c7385960525ad534323252 upstream.
In of_modalias(), if the buffer happens to be too small even for the 1st snprintf() call, the len parameter will become negative and str parameter (if not NULL initially) will point beyond the buffer's end. Add the buffer overflow check after the 1st snprintf() call and fix such check after the strlen() call (accounting for the terminating NUL char).
--- drivers/of/device.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/of/device.c +4 -3
@@ -264,14 +264,15 @@ static ssize_t of_device_get_modalias(st csize =snprintf (str, len,"of:N%pOFn%c%s" , dev->of_node,'T' ,of_node_get_device_type (dev->of_node)); tsize = csize; +if (csize >= len) + csize = len >0 ? len -1 :0 ; len -= csize; -if (str) - str += csize; + str += csize;of_property_for_each_string (dev->of_node,"compatible" , p, compat) { csize =strlen (compat) +1 ; tsize += csize; -if (csize > len) +if (csize >= len)continue ; csize =snprintf (str, len,"C%s" , compat);
Re: [PATCH 6.1 150/167] of: module: add buffer overflow check in of_modalias()
Hi,
Quoted 6 lines · On Tue, 29 Apr 2025 18:44:18 +0200 Greg Kroah-Hartman…
6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sergey Shtylyov <[email protected]>
Quoted 7 lines
commit
cf7385cb26ac4f0ee6c7385960525ad534323252upstream.In
of_modalias(), if the buffer happens to be too small even for the 1stsnprintf()call, the len parameter will become negative and str parameter (if not NULL initially) will point beyond the buffer's end. Add the buffer overflow check after the 1stsnprintf()call and fix such check after thestrlen()call (accounting for the terminating NUL char).
Thank you for catching this and push it to 6.1.y branch.
And it seems that other older stable branches - linux-5.4.y, linux-5.10.y and linux-5.15.y can be updated with cherry-picking 5d59fd637a8af42b211a92b2edb2474325b4d488
Could you also review and apply it if it is okay, please?
Signature · 1 line
Hideki Yamane <[email protected] / debian.org | [email protected] >
Greg Kroah-Hartman
maintainerRe: [PATCH 6.1 150/167] of: module: add buffer overflow check in of_modalias()
Quoted 18 lines · Hideki Yamane
Hi,
Quoted 6 lines · On Tue, 29 Apr 2025 18:44:18 +0200 Greg Kroah-Hartman…
6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sergey Shtylyov <[email protected]>
Quoted 7 lines
commit
cf7385cb26ac4f0ee6c7385960525ad534323252upstream.In
of_modalias(), if the buffer happens to be too small even for the 1stsnprintf()call, the len parameter will become negative and str parameter (if not NULL initially) will point beyond the buffer's end. Add the buffer overflow check after the 1stsnprintf()call and fix such check after thestrlen()call (accounting for the terminating NUL char).
Quoted 7 lines
Thank you for catching this and push it to 6.1.y branch.
And it seems that other older stable branches - linux-5.4.y, linux-5.10.y and linux-5.15.y can be updated with cherry-picking
5d59fd637a8af42b211a92b2edb2474325b4d488Could you also review and apply it if it is okay, please?
It does not apply there cleanly, please submit tested patches against those branches if you wish to have it applied there.
thanks,
greg k-h
Re: [PATCH 6.1 150/167] of: module: add buffer overflow check in of_modalias()
Hello Greg,
Quoted 21 lines · Greg Kroah-Hartman
Quoted 20 lines · Hideki Yamane
Hi,
Quoted 6 lines · On Tue, 29 Apr 2025 18:44:18 +0200 Greg Kroah-Hartman…
6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sergey Shtylyov <[email protected]>
Quoted 7 lines
commit
cf7385cb26ac4f0ee6c7385960525ad534323252upstream.In
of_modalias(), if the buffer happens to be too small even for the 1stsnprintf()call, the len parameter will become negative and str parameter (if not NULL initially) will point beyond the buffer's end. Add the buffer overflow check after the 1stsnprintf()call and fix such check after thestrlen()call (accounting for the terminating NUL char).Thank you for catching this and push it to 6.1.y branch.
Quoted 8 lines
Quoted 5 lines
And it seems that other older stable branches - linux-5.4.y, linux-5.10.y and linux-5.15.y can be updated with cherry-picking
5d59fd637a8af42b211a92b2edb2474325b4d488Could you also review and apply it if it is okay, please?
It does not apply there cleanly, please submit tested patches against those branches if you wish to have it applied there.
git cherry-pick 5d59fd637a8af42b211a92b2edb2474325b4d488 applies and compiles fine (amd64) here on top of v5.15.181, 5.10.237 and 5.4.293.
*some time later*
Ah, the hunk offsets are different, which git gets right but patch fails.
Sent out three patches for the three stable trees.
Best regards
Uwe
Re: [PATCH 6.1 150/167] of: module: add buffer overflow check in of_modalias()
In reply to Greg Kroah-HartmanQuoted 2 lines · On Wed, 7 May 2025 13:12:02 +0200 Greg Kroah-Hartman…
It does not apply there cleanly, please submit tested patches against those branches if you wish to have it applied there.
Diff attached, and built fine with those patches and corresponded branches on my laptop. Those changes just adds checks for length, so I guess no harm with that.
I'm not familiar with Linux kernel development (my previous 1-liner patch was merged 20 years ago ;) so maybe I did something wrong again, please point out, then. Thank you.
Signature · 1 line
Hideki Yamane <[email protected] / debian.org | [email protected]>
From 0c6f88bd0ec71dccb358d9b969abee22d9d9f6cd Mon Sep 17 00:00:00 2001
From: Sergey Shtylyov <[email protected]>
Date: Sun, 14 Apr 2024 11:51:39 +0300
Subject: [PATCH] of: module: add buffer overflow check in of_modalias()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
commit cf7385cb26ac4f0ee6c7385960525ad534323252 upstream.
In of_modalias(), if the buffer happens to be too small even for the 1st snprintf() call, the len parameter will become negative and str parameter (if not NULL initially) will point beyond the buffer's end. Add the buffer overflow check after the 1st snprintf() call and fix such check after the strlen() call (accounting for the terminating NUL char).
--- drivers/of/device.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/of/device.c +4 -3
@@ -213,14 +213,15 @@ static ssize_t of_device_get_modalias(struct device *dev, char *str, ssize_t len csize =snprintf (str, len,"of:N%pOFn%c%s" , dev->of_node,'T' ,of_node_get_device_type (dev->of_node)); tsize = csize; +if (csize >= len) + csize = len >0 ? len -1 :0 ; len -= csize; -if (str) - str += csize; + str += csize;of_property_for_each_string (dev->of_node,"compatible" , p, compat) { csize =strlen (compat) +1 ; tsize += csize; -if (csize > len) +if (csize >= len)continue ; csize =snprintf (str, len,"C%s" , compat);
Signature · 1 line
2.47.2
From ecc1a605db01948a72effe99f4e866c640e28211 Mon Sep 17 00:00:00 2001
From: Sergey Shtylyov <[email protected]>
Date: Sun, 14 Apr 2024 11:51:39 +0300
Subject: [PATCH] of: module: add buffer overflow check in of_modalias()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
commit cf7385cb26ac4f0ee6c7385960525ad534323252 upstream.
In of_modalias(), if the buffer happens to be too small even for the 1st snprintf() call, the len parameter will become negative and str parameter (if not NULL initially) will point beyond the buffer's end. Add the buffer overflow check after the 1st snprintf() call and fix such check after the strlen() call (accounting for the terminating NUL char).
--- drivers/of/device.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/of/device.c +4 -3
@@ -231,14 +231,15 @@ static ssize_t of_device_get_modalias(struct device *dev, char *str, ssize_t len csize =snprintf (str, len,"of:N%pOFn%c%s" , dev->of_node,'T' ,of_node_get_device_type (dev->of_node)); tsize = csize; +if (csize >= len) + csize = len >0 ? len -1 :0 ; len -= csize; -if (str) - str += csize; + str += csize;of_property_for_each_string (dev->of_node,"compatible" , p, compat) { csize =strlen (compat) +1 ; tsize += csize; -if (csize > len) +if (csize >= len)continue ; csize =snprintf (str, len,"C%s" , compat);
Signature · 1 line
2.47.2
From f28ebf105a327a1d6e476e250a3904ca33eb47fb Mon Sep 17 00:00:00 2001
From: Sergey Shtylyov <[email protected]>
Date: Sun, 14 Apr 2024 11:51:39 +0300
Subject: [PATCH] of: module: add buffer overflow check in of_modalias()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
commit cf7385cb26ac4f0ee6c7385960525ad534323252 upstream.
In of_modalias(), if the buffer happens to be too small even for the 1st snprintf() call, the len parameter will become negative and str parameter (if not NULL initially) will point beyond the buffer's end. Add the buffer overflow check after the 1st snprintf() call and fix such check after the strlen() call (accounting for the terminating NUL char).
--- drivers/of/device.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/of/device.c +4 -3
@@ -257,14 +257,15 @@ static ssize_t of_device_get_modalias(struct device *dev, char *str, ssize_t len csize =snprintf (str, len,"of:N%pOFn%c%s" , dev->of_node,'T' ,of_node_get_device_type (dev->of_node)); tsize = csize; +if (csize >= len) + csize = len >0 ? len -1 :0 ; len -= csize; -if (str) - str += csize; + str += csize;of_property_for_each_string (dev->of_node,"compatible" , p, compat) { csize =strlen (compat) +1 ; tsize += csize; -if (csize > len) +if (csize >= len)continue ; csize =snprintf (str, len,"C%s" , compat);
Signature · 1 line
2.47.2
Greg Kroah-Hartman
maintainerRe: [PATCH 6.1 150/167] of: module: add buffer overflow check in of_modalias()
Quoted 5 lines · Hideki Yamane
Quoted 2 lines · On Wed, 7 May 2025 13:12:02 +0200 Greg Kroah-Hartman…
It does not apply there cleanly, please submit tested patches against those branches if you wish to have it applied there.
Quoted 8 lines
Diff attached, and built fine with those patches and corresponded branches on my laptop. Those changes just adds checks for length, so I guess no harm with that.
I'm not familiar with Linux kernel development (my previous 1-liner patch was merged 20 years ago ;) so maybe I did something wrong again, please point out, then. Thank you.
I'll take Uwe's backports, but in the future, when you send a patch on like this, you also need to sign-off on it, especially as you had to modify it from the original change.
thanks,
greg k-h
Re: [PATCH 6.1 150/167] of: module: add buffer overflow check in of_modalias()
Hi,
Quoted 3 lines · On Wed, 7 May 2025 15:28:25 +0200 Greg Kroah-Hartman…
I'll take Uwe's backports, but in the future, when you send a patch on like this, you also need to sign-off on it, especially as you had to modify it from the original change.
Thanks Greg and Uwe, I'll do it as you suggest if I can have a chance to contribute something to Linux again :)
Signature · 1 line
Hideki Yamane <[email protected] / debian.org | [email protected]>
Greg Kroah-Hartman
maintainerPATCH 151/167 jfs: define xtree root and page independently
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dave Kleikamp <[email protected]>
commit a779ed754e52d582b8c0e17959df063108bd0656 upstream.
In order to make array bounds checking sane, provide a separate definition of the in-inode xtree root and the external xtree page.
--- fs/jfs/jfs_dinode.h | 2 +- fs/jfs/jfs_imap.c | 6 +++--- fs/jfs/jfs_incore.h | 2 +- fs/jfs/jfs_txnmgr.c | 4 ++-- fs/jfs/jfs_xtree.c | 4 ++-- fs/jfs/jfs_xtree.h | 37 +++++++++++++++++++++++-------------- 6 files changed, 32 insertions(+), 23 deletions(-)
fs/jfs/jfs_dinode.h +1 -1
@@ -96,7 +96,7 @@ struct dinode {#define di_gengen u._file._u1._imap._gengenunion { -xtpage_t _xtroot; +xtroot_t _xtroot;struct {u8 unused[16 ];/* 16: */ dxd_t _dxd;/* 16: */
fs/jfs/jfs_imap.c +3 -3
@@ -673,7 +673,7 @@ int diWrite(tid_t tid, struct inode *ip)* This is the special xtree inside the directory for storing * the directory table */ -xtpage_t *p, *xp; +xtroot_t *p, *xp;xad_t *xad; jfs_ip->xtlid =0 ;
@@ -687,7 +687,7 @@ int diWrite(tid_t tid, struct inode *ip)* copy xtree root from inode to dinode: */ p = &jfs_ip->i_xtroot; - xp = (xtpage_t *) &dp->di_dirtable; + xp = (xtroot_t *) &dp->di_dirtable; lv = ilinelock->lv;for (n =0 ; n < ilinelock->index; n++, lv++) { memcpy(&xp->xad[lv->offset], &p->xad[lv->offset],
@@ -716,7 +716,7 @@ int diWrite(tid_t tid, struct inode *ip)* regular file: 16 byte (XAD slot) granularity */ if (type & tlckXTREE) { -xtpage_t *p, *xp; +xtroot_t *p, *xp;xad_t *xad;/*
fs/jfs/jfs_incore.h +1 -1
@@ -66,7 +66,7 @@ struct jfs_inode_info {lid_t xtlid;/* lid of xtree lock on directory */ union {struct { -xtpage_t _xtroot;/* 288: xtree root */ +xtroot_t _xtroot;/* 288: xtree root */ struct inomap *_imap;/* 4: inode map header */ } file;struct {
fs/jfs/jfs_txnmgr.c +2 -2
@@ -783,7 +783,7 @@ struct tlock *txLock(tid_t tid, struct iif (mp->xflag &COMMIT_PAGE ) p = (xtpage_t *) mp->data;else - p = &jfs_ip->i_xtroot; + p = (xtpage_t *) &jfs_ip->i_xtroot; xtlck->lwm.offset =le16_to_cpu (p->header.nextindex); }
@@ -1676,7 +1676,7 @@ static void xtLog(struct jfs_log * log,if (tlck->type & tlckBTROOT) { lrd->log.redopage.type |=cpu_to_le16 (LOG_BTROOT ); - p = &JFS_IP (ip)->i_xtroot; + p = (xtpage_t *) &JFS_IP (ip)->i_xtroot;if (S_ISDIR (ip->i_mode)) lrd->log.redopage.type |=cpu_to_le16 (LOG_DIR_XTREE );
fs/jfs/jfs_xtree.c +2 -2
@@ -1213,7 +1213,7 @@ xtSplitRoot(tid_t tid,struct xtlock *xtlck;int rc; - sp = &JFS_IP (ip)->i_xtroot; + sp = (xtpage_t *) &JFS_IP (ip)->i_xtroot;INCREMENT (xtStat.split);
@@ -2098,7 +2098,7 @@ int xtAppend(tid_t tid, /* transaction*/ void xtInitRoot (tid_t tid,struct inode *ip) { -xtpage_t *p; +xtroot_t *p;/* * acquire a transaction lock on the root
fs/jfs/jfs_xtree.h +23 -14
@@ -65,24 +65,33 @@ struct xadlist {#define XTPAGEMAXSLOT 256#define XTENTRYSTART 2 +struct xtheader { +__le64 next;/* 8: */ +__le64 prev;/* 8: */ + +u8 flag;/* 1: */ +u8 rsrvd1;/* 1: */ +__le16 nextindex;/* 2: next index = number of entries */ +__le16 maxentry;/* 2: max number of entries */ +__le16 rsrvd2;/* 2: */ + +pxd_t self;/* 8: self */ +}; +/* -* xtree page: +* xtree root (in inode): */ typedef union { -struct xtheader { -__le64 next;/* 8: */ -__le64 prev;/* 8: */ - -u8 flag;/* 1: */ -u8 rsrvd1;/* 1: */ -__le16 nextindex;/* 2: next index = number of entries */ -__le16 maxentry;/* 2: max number of entries */ -__le16 rsrvd2;/* 2: */ - -pxd_t self;/* 8: self */ - } header;/* (32) */ - +struct xtheader header;xad_t xad[XTROOTMAXSLOT ];/* 16 * maxentry: xad array */ +}xtroot_t ; + +/* +* xtree page: +*/ +typedef union { +struct xtheader header; +xad_t xad[XTPAGEMAXSLOT ];/* 16 * maxentry: xad array */ }xtpage_t ;/*
Greg Kroah-Hartman
maintainerPATCH 152/167 comedi: jr3_pci: Fix synchronous deletion of timer
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ian Abbott <[email protected]>
commit 44d9b3f584c59a606b521e7274e658d5b866c699 upstream.
When jr3_pci_detach() is called during device removal, it calls timer_delete_sync() to stop the timer, but the timer expiry function always reschedules the timer, so the synchronization is ineffective.
Call timer_shutdown_sync() instead. It does not matter that the timer expiry function pointer is cleared, because the device is being removed.
--- drivers/comedi/drivers/jr3_pci.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
drivers/comedi/drivers/jr3_pci.c +12 -5
@@ -87,6 +87,7 @@ struct jr3_pci_poll_delay {struct jr3_pci_dev_private {struct timer_list timer;struct comedi_device *dev; +bool timer_enable; };union jr3_pci_single_range {
@@ -596,10 +597,11 @@ static void jr3_pci_poll_dev(struct time delay = sub_delay.max; } } +if (devpriv->timer_enable) { + devpriv->timer.expires = jiffies +msecs_to_jiffies (delay); +add_timer (&devpriv->timer); + }spin_unlock_irqrestore (&dev->spinlock, flags); - - devpriv->timer.expires = jiffies +msecs_to_jiffies (delay); -add_timer (&devpriv->timer); } static struct jr3_pci_subdev_private *
@@ -748,6 +750,7 @@ static int jr3_pci_auto_attach(struct co devpriv->dev = dev;timer_setup (&devpriv->timer, jr3_pci_poll_dev,0 ); devpriv->timer.expires = jiffies +msecs_to_jiffies (1000 ); + devpriv->timer_enable = true;add_timer (&devpriv->timer);return 0 ;
@@ -757,8 +760,12 @@ static void jr3_pci_detach(struct comedi {struct jr3_pci_dev_private *devpriv = dev->private; -if (devpriv) -del_timer_sync (&devpriv->timer); +if (devpriv) { +spin_lock_bh (&dev->spinlock); + devpriv->timer_enable = false; +spin_unlock_bh (&dev->spinlock); +timer_delete_sync (&devpriv->timer); + }comedi_pci_detach (dev); }
Greg Kroah-Hartman
maintainerPATCH 153/167 crypto: atmel-sha204a - Set hwrng quality to lowest possible
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Marek Behún <[email protected]>
commit 8006aff15516a170640239c5a8e6696c0ba18d8e upstream.
According to the review by Bill Cox [1], the Atmel SHA204A random number generator produces random numbers with very low entropy.
Set the lowest possible entropy for this chip just to be safe.
[1] https://www.metzdowd.com/pipermail/cryptography/2014-December/023858.html
--- drivers/crypto/atmel-sha204a.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/crypto/atmel-sha204a.c +6 -1
@@ -107,7 +107,12 @@ static int atmel_sha204a_probe(struct i2 i2c_priv->hwrng.name =dev_name (&client->dev); i2c_priv->hwrng.read = atmel_sha204a_rng_read; - i2c_priv->hwrng.quality =1024 ; + +/* +* According to review by Bill Cox [1], this HWRNG has very low entropy. +* [1] https://www.metzdowd.com/pipermail/cryptography/2014-December/023858.html +*/ + i2c_priv->hwrng.quality =1 ; ret =devm_hwrng_register (&client->dev, &i2c_priv->hwrng);if (ret)
Greg Kroah-Hartman
maintainerPATCH 154/167 net/sched: act_mirred: dont override retval if we already lost the skb
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jakub Kicinski <[email protected]>
commit 166c2c8a6a4dc2e4ceba9e10cfe81c3e469e3210 upstream.
If we're redirecting the skb, and haven't called tcf_mirred_forward(), yet, we need to tell the core to drop the skb by setting the retcode to SHOT. If we have called tcf_mirred_forward(), however, the skb is out of our hands and returning SHOT will lead to UaF.
Move the retval override to the error path which actually need it.
--- net/sched/act_mirred.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-)
net/sched/act_mirred.c +13 -9
@@ -255,31 +255,31 @@ static int tcf_mirred_act(struct sk_buff m_mac_header_xmit =READ_ONCE (m->tcfm_mac_header_xmit); m_eaction =READ_ONCE (m->tcfm_eaction); + is_redirect =tcf_mirred_is_act_redirect (m_eaction); retval =READ_ONCE (m->tcf_action); dev =rcu_dereference_bh (m->tcfm_dev);if (unlikely (!dev)) {pr_notice_once ("tc mirred: target device is gone\n" ); - goto out; + goto err_cant_do; }if (unlikely (!(dev->flags &IFF_UP )) || !netif_carrier_ok (dev)) {net_notice_ratelimited ("tc mirred to Houston: device %s is down\n" , dev->name); - goto out; + goto err_cant_do; }/* we could easily avoid the clone only if called by ingress and clsact; * since we can't easily detect the clsact caller, skip clone only for * ingress - that covers the TC S/W datapath. */ - is_redirect =tcf_mirred_is_act_redirect (m_eaction); at_ingress =skb_at_tc_ingress (skb); use_reinsert = at_ingress && is_redirect &&tcf_mirred_can_reinsert (retval);if (!use_reinsert) { skb2 =skb_clone (skb,GFP_ATOMIC );if (!skb2) - goto out; + goto err_cant_do; } want_ingress =tcf_mirred_act_wants_ingress (m_eaction);
@@ -321,12 +321,16 @@ static int tcf_mirred_act(struct sk_buff } err =tcf_mirred_forward (want_ingress, skb2); -if (err) { -out: +if (err)tcf_action_inc_overlimit_qstats (&m->common); -if (tcf_mirred_is_act_redirect (m_eaction)) - retval =TC_ACT_SHOT ; - } +__this_cpu_dec (mirred_nest_level); + +return retval; + +err_cant_do: +if (is_redirect) + retval =TC_ACT_SHOT ; +tcf_action_inc_overlimit_qstats (&m->common);__this_cpu_dec (mirred_nest_level);return retval;
Greg Kroah-Hartman
maintainerPATCH 155/167 net: dsa: mv88e6xxx: fix atu_move_port_mask for 6341 family
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Marek Beh�n" <[email protected]>
commit 4ae01ec007716986e1a20f1285eb013cbf188830 upstream.
The atu_move_port_mask for 6341 family (Topaz) is 0xf, not 0x1f. The PortVec field is 8 bits wide, not 11 as in 6390 family. Fix this.
--- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/dsa/mv88e6xxx/chip.c +2 -2
@@ -5813,7 +5813,7 @@ static const struct mv88e6xxx_info mv88e .global1_addr = 0x1b, .global2_addr = 0x1c, .age_time_coeff = 3750, - .atu_move_port_mask = 0x1f, + .atu_move_port_mask = 0xf, .g1_irqs = 9, .g2_irqs = 10, .pvt = true,
@@ -6272,7 +6272,7 @@ static const struct mv88e6xxx_info mv88e .global1_addr = 0x1b, .global2_addr = 0x1c, .age_time_coeff = 3750, - .atu_move_port_mask = 0x1f, + .atu_move_port_mask = 0xf, .g1_irqs = 9, .g2_irqs = 10, .pvt = true,
Greg Kroah-Hartman
maintainerPATCH 156/167 net: dsa: mv88e6xxx: enable PVT for 6321 switch
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Marek Beh�n" <[email protected]>
commit f85c69369854a43af2c5d3b3896da0908d713133 upstream.
Commit f36456522168 ("net: dsa: mv88e6xxx: move PVT description in info") did not enable PVT for 6321 switch. Fix it.
--- drivers/net/dsa/mv88e6xxx/chip.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/dsa/mv88e6xxx/chip.c +1 -0
@@ -6250,6 +6250,7 @@ static const struct mv88e6xxx_info mv88e .g1_irqs = 8, .g2_irqs = 10, .atu_move_port_mask = 0xf, + .pvt = true, .multi_chip = true, .edsa_support = MV88E6XXX_EDSA_SUPPORTED, .ptp_support = true,
Greg Kroah-Hartman
maintainerPATCH 157/167 net: dsa: mv88e6xxx: enable .port_set_policy() for 6320 family
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Marek Beh�n" <[email protected]>
commit a2ef58e2c4aea4de166fc9832eb2b621e88c98d5 upstream.
Commit f3a2cd326e44 ("net: dsa: mv88e6xxx: introduce .port_set_policy") did not add the .port_set_policy() method for the 6320 family. Fix it.
--- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/dsa/mv88e6xxx/chip.c +2 -0
@@ -5173,6 +5173,7 @@ static const struct mv88e6xxx_ops mv88e6 .port_set_rgmii_delay = mv88e6320_port_set_rgmii_delay, .port_set_speed_duplex = mv88e6185_port_set_speed_duplex, .port_tag_remap = mv88e6095_port_tag_remap, + .port_set_policy = mv88e6352_port_set_policy, .port_set_frame_mode = mv88e6351_port_set_frame_mode, .port_set_ucast_flood = mv88e6352_port_set_ucast_flood, .port_set_mcast_flood = mv88e6352_port_set_mcast_flood,
@@ -5221,6 +5222,7 @@ static const struct mv88e6xxx_ops mv88e6 .port_set_rgmii_delay = mv88e6320_port_set_rgmii_delay, .port_set_speed_duplex = mv88e6185_port_set_speed_duplex, .port_tag_remap = mv88e6095_port_tag_remap, + .port_set_policy = mv88e6352_port_set_policy, .port_set_frame_mode = mv88e6351_port_set_frame_mode, .port_set_ucast_flood = mv88e6352_port_set_ucast_flood, .port_set_mcast_flood = mv88e6352_port_set_mcast_flood,
Greg Kroah-Hartman
maintainerPATCH 158/167 net: dsa: mv88e6xxx: enable STU methods for 6320 family
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Marek Beh�n" <[email protected]>
commit 1428a6109b20e356188c3fb027bdb7998cc2fb98 upstream.
Commit c050f5e91b47 ("net: dsa: mv88e6xxx: Fill in STU support for all supported chips") introduced STU methods, but did not add them to the 6320 family. Fix it.
--- drivers/net/dsa/mv88e6xxx/chip.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/dsa/mv88e6xxx/chip.c +6 -0
@@ -5200,6 +5200,8 @@ static const struct mv88e6xxx_ops mv88e6 .reset = mv88e6352_g1_reset, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, + .stu_getnext = mv88e6352_g1_stu_getnext, + .stu_loadpurge = mv88e6352_g1_stu_loadpurge, .gpio_ops = &mv88e6352_gpio_ops, .avb_ops = &mv88e6352_avb_ops, .ptp_ops = &mv88e6352_ptp_ops,
@@ -5248,6 +5250,8 @@ static const struct mv88e6xxx_ops mv88e6 .reset = mv88e6352_g1_reset, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, + .stu_getnext = mv88e6352_g1_stu_getnext, + .stu_loadpurge = mv88e6352_g1_stu_loadpurge, .gpio_ops = &mv88e6352_gpio_ops, .avb_ops = &mv88e6352_avb_ops, .ptp_ops = &mv88e6352_ptp_ops,
@@ -6218,6 +6222,7 @@ static const struct mv88e6xxx_info mv88e .internal_phys_offset = 3, .num_gpio = 15, .max_vid = 4095, + .max_sid = 63, .port_base_addr = 0x10, .phy_base_addr = 0x0, .global1_addr = 0x1b,
@@ -6244,6 +6249,7 @@ static const struct mv88e6xxx_info mv88e .internal_phys_offset = 3, .num_gpio = 15, .max_vid = 4095, + .max_sid = 63, .port_base_addr = 0x10, .phy_base_addr = 0x0, .global1_addr = 0x1b,
Greg Kroah-Hartman
maintainerPATCH 159/167 xdp: Reset bpf_redirect_info before running a xdps BPF prog.
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sebastian Andrzej Siewior <[email protected]>
Ricardo reported a KASAN discovered use after free in v6.6-stable.
The syzbot starts a BPF program via xdp_test_run_batch() which assigns ri->tgt_value via dev_hash_map_redirect() and the return code isn't XDP_REDIRECT it looks like nonsense. So the output in bpf_warn_invalid_xdp_action() appears once.
Then the TUN driver runs another BPF program (on the same CPU) which returns XDP_REDIRECT without setting ri->tgt_value first. It invokes bpf_trace_printk() to print four characters and obtain the required return value. This is enough to get xdp_do_redirect() invoked which then accesses the pointer in tgt_value which might have been already deallocated.
This problem does not affect upstream because since commit
401cb7dae8130 ("net: Reference bpf_redirect_info via task_struct on PREEMPT_RT.")
the per-CPU variable is referenced via task's task_struct and exists on the stack during NAPI callback. Therefore it is cleared once before the first invocation and remains valid within the RCU section of the NAPI callback.
Instead of performing the huge backport of the commit (plus its fix ups) here is an alternative version which only resets the variable in question prior invoking the BPF program.
--- include/linux/filter.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
include/linux/filter.h +8 -1
@@ -775,7 +775,14 @@ static __always_inline u32 bpf_prog_run_* under local_bh_disable(), which provides the needed RCU protection * for accessing map entries. */ -u32 act =__bpf_prog_run (prog, xdp,BPF_DISPATCHER_FUNC (xdp)); +struct bpf_redirect_info *ri =this_cpu_ptr (&bpf_redirect_info); +u32 act; + +if (ri->map_id || ri->map_type) { + ri->map_id =0 ; + ri->map_type =BPF_MAP_TYPE_UNSPEC ; + } + act =__bpf_prog_run (prog, xdp,BPF_DISPATCHER_FUNC (xdp));if (static_branch_unlikely (&bpf_master_redirect_enabled_key)) {if (act ==XDP_TX &&netif_is_bond_slave (xdp->rxq->dev))
Greg Kroah-Hartman
maintainerPATCH 160/167 MIPS: cm: Fix warning if MIPS_CM is disabled
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Thomas Bogendoerfer <[email protected]>
commit b73c3ccdca95c237750c981054997c71d33e09d7 upstream.
Commit e27fbe16af5c ("MIPS: cm: Detect CM quirks from device tree") introduced
arch/mips/include/asm/mips-cm.h:119:13: error: ‘mips_cm_update_property’
defined but not used [-Werror=unused-function]
Fix this by making empty function implementation inline
--- arch/mips/include/asm/mips-cm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/include/asm/mips-cm.h +1 -1
@@ -104,7 +104,7 @@ static inline bool mips_cm_present(void)#ifdef CONFIG_MIPS_CM extern void mips_cm_update_property (void );#else -static void mips_cm_update_property (void ) {} +static inline void mips_cm_update_property (void ) {}#endif /**
Greg Kroah-Hartman
maintainerPATCH 161/167 nvme: fixup scan failure for non-ANA multipath controllers
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hannes Reinecke <[email protected]>
commit 26d7fb4fd4ca1180e2fa96587dea544563b4962a upstream.
Commit 62baf70c3274 caused the ANA log page to be re-read, even on controllers that do not support ANA. While this should generally harmless, some controllers hang on the unsupported log page and never finish probing.
--- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
@@ -4709,7 +4709,7 @@ static void nvme_scan_work(struct work_sif (test_bit (NVME_AER_NOTICE_NS_CHANGED , &ctrl->events))nvme_queue_scan (ctrl);#ifdef CONFIG_NVME_MULTIPATH - else + else if (ctrl->ana_log_buf) /* Re-read the ANA log page to not miss updates */ queue_work(nvme_wq, &ctrl->ana_work);#endif
Greg Kroah-Hartman
maintainerPATCH 162/167 phy: freescale: imx8m-pcie: Do CMN_RST just before PHY PLL lock check
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Richard Zhu <[email protected]>
commit f89263b69731e0144d275fff777ee0dd92069200 upstream.
When enable initcall_debug together with higher debug level below. CONFIG_CONSOLE_LOGLEVEL_DEFAULT=9 CONFIG_CONSOLE_LOGLEVEL_QUIET=9 CONFIG_MESSAGE_LOGLEVEL_DEFAULT=7
The initialization of i.MX8MP PCIe PHY might be timeout failed randomly. To fix this issue, adjust the sequence of the resets refer to the power up sequence listed below.
i.MX8MP PCIe PHY power up sequence:
/---------------------------------------------
1.8v supply ---------/
/---------------------------------------------------0.8v supply ---/
---\ /--------------------------------------------------
X REFCLK Valid
Reference Clock ---/ \--------------------------------------------------
-------------------------------------------
|
i_init_restn --------------
------------------------------------
|
i_cmn_rstn ---------------------
-------------------------------
|o_pll_lock_done --------------------------
Logs:
imx6q-pcie 33800000.pcie: host bridge /soc@0/pcie@33800000 ranges: imx6q-pcie 33800000.pcie: IO 0x001ff80000..0x001ff8ffff -> 0x0000000000 imx6q-pcie 33800000.pcie: MEM 0x0018000000..0x001fefffff -> 0x0018000000
probe of clk_imx8mp_audiomix.reset.0 returned 0 after 1052 usecs
probe of 30e20000.clock-controller returned 0 after 32971 usecs
phy phy-32f00000.pcie-phy.4: phy poweron failed --> -110
probe of 30e10000.dma-controller returned 0 after 10235 usecs
imx6q-pcie 33800000.pcie: waiting for PHY ready timeout!
dwhdmi-imx 32fd8000.hdmi: Detected HDMI TX controller v2.13a with HDCP (samsung_dw_hdmi_phy2) imx6q-pcie 33800000.pcie: probe with driver imx6q-pcie failed with error -110
v2 changes:
- Rebase to latest fixes branch of linux-phy git repo.
- Richard's environment have problem and can't sent out patch. So I help post this fix patch.
--- drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/phy/freescale/phy-fsl-imx8m-pcie.c +5 -5
@@ -143,11 +143,6 @@ static int imx8_pcie_phy_power_on(struct IMX8MM_GPR_PCIE_REF_CLK_PLL);usleep_range (100 ,200 ); -/* Do the PHY common block reset */ -regmap_update_bits (imx8_phy->iomuxc_gpr,IOMUXC_GPR14 , -IMX8MM_GPR_PCIE_CMN_RST , -IMX8MM_GPR_PCIE_CMN_RST ); -switch (imx8_phy->drvdata->variant) {case IMX8MP :reset_control_deassert (imx8_phy->perst);
@@ -158,6 +153,11 @@ static int imx8_pcie_phy_power_on(structbreak ; } +/* Do the PHY common block reset */ +regmap_update_bits (imx8_phy->iomuxc_gpr,IOMUXC_GPR14 , +IMX8MM_GPR_PCIE_CMN_RST , +IMX8MM_GPR_PCIE_CMN_RST ); +/* Polling to check the phy is ready or not. */ ret = readl_poll_timeout(imx8_phy->base + IMX8MM_PCIE_PHY_CMN_REG75, val, val == PCIE_PHY_CMN_REG75_PLL_DONE,
Greg Kroah-Hartman
maintainerPATCH 163/167 phy: freescale: imx8m-pcie: Add one missing error return
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Richard Zhu <[email protected]>
commit b574baa64cf84e7793fe79f4491ae36c16e65a0b upstream.
There should be one error return when fail to fetch the perst reset. Add the missing error return.
--- drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/freescale/phy-fsl-imx8m-pcie.c +1 -1
@@ -271,7 +271,7 @@ static int imx8_pcie_phy_probe(struct pl imx8_phy->perst =devm_reset_control_get_exclusive (dev,"perst" );if (IS_ERR (imx8_phy->perst)) -dev_err_probe (dev,PTR_ERR (imx8_phy->perst), +return dev_err_probe (dev,PTR_ERR (imx8_phy->perst),"Failed to get PCIE PHY PERST control\n" ); }
Greg Kroah-Hartman
maintainerPATCH 164/167 tracing: Remove pointer (asterisk) and brackets from cpumask_t field
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Steven Rostedt (Google) <[email protected]>
commit fab89a09c86f948adfc7e20a7d608bd9f323bbe1 upstream.
To differentiate between long arrays and cpumasks, the __cpumask() field was created. Part of the TRACE_EVENT() macros test if the type is signed or not by using the is_signed_type() macro. The __cpumask() field used the __dynamic_array() helper but because cpumask_t is a structure, it could not be used in the is_signed_type() macro as that would fail to build, so instead it passed in the pointer to cpumask_t.
Unfortunately, that creates in the format file:
field:__data_loc cpumask_t *[] mask; offset:36; size:4; signed:0;
Which looks like an array of pointers to cpumask_t and not a cpumask_t type, which is misleading to user space parsers.
Douglas Raillard pointed out that the "[]" are also misleading, as cpumask_t is not an array.
Since cpumask() hasn't been created yet, and the parsers currently fail on it (but will still produce the raw output), make it be:
field:__data_loc cpumask_t mask; offset:36; size:4; signed:0;
Which is the correct type of the field.
Then the parsers can be updated to handle this.
--- include/trace/stages/stage4_event_fields.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
include/trace/stages/stage4_event_fields.h +8 -2
@@ -48,7 +48,10 @@#define __bitmask (item, nr_bits) __dynamic_array(unsigned long, item, -1)#undef __cpumask -#define __cpumask (item) __dynamic_array(cpumask_t *, item, -1) +#define __cpumask (item) { \ + .type = "__data_loc cpumask_t", .name = #item, \ + .size = 4, .align = 4, \ + .is_signed = 0, .filter_type = FILTER_OTHER },#undef __sockaddr#define __sockaddr (field, len) __dynamic_array(u8, field, len)
@@ -69,7 +72,10 @@#define __rel_bitmask (item, nr_bits) __rel_dynamic_array(unsigned long, item, -1)#undef __rel_cpumask -#define __rel_cpumask (item) __rel_dynamic_array(cpumask_t *, item, -1) +#define __rel_cpumask (item) { \ + .type = "__rel_loc cpumask_t", .name = #item, \ + .size = 4, .align = 4, \ + .is_signed = 0, .filter_type = FILTER_OTHER },#undef __rel_sockaddr#define __rel_sockaddr (field, len) __rel_dynamic_array(u8, field, len)
Greg Kroah-Hartman
maintainerPATCH 165/167 PCI: Fix use-after-free in pci_bus_release_domain_nr()
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Rob Herring <[email protected]>
commit 30ba2d09edb5ea857a1473ae3d820911347ada62 upstream.
Commit c14f7ccc9f5d ("PCI: Assign PCI domain IDs by ida_alloc()") introduced a use-after-free bug in the bus removal cleanup. The issue was found with kfence:
[ 19.293351] BUG: KFENCE: use-after-free read in pci_bus_release_domain_nr+0x10/0x70
[ 19.302817] Use-after-free read at 0x000000007f3b80eb (in kfence-#115): [ 19.309677] pci_bus_release_domain_nr+0x10/0x70 [ 19.309691] dw_pcie_host_deinit+0x28/0x78 [ 19.309702] tegra_pcie_deinit_controller+0x1c/0x38 [pcie_tegra194] [ 19.309734] tegra_pcie_dw_probe+0x648/0xb28 [pcie_tegra194] [ 19.309752] platform_probe+0x90/0xd8 ...
[ 19.311457] kfence-#115: 0x00000000063a155a-0x00000000ba698da8, size=1072, cache=kmalloc-2k
[ 19.311469] allocated by task 96 on cpu 10 at 19.279323s: [ 19.311562] __kmem_cache_alloc_node+0x260/0x278 [ 19.311571] kmalloc_trace+0x24/0x30 [ 19.311580] pci_alloc_bus+0x24/0xa0 [ 19.311590] pci_register_host_bridge+0x48/0x4b8 [ 19.311601] pci_scan_root_bus_bridge+0xc0/0xe8 [ 19.311613] pci_host_probe+0x18/0xc0 [ 19.311623] dw_pcie_host_init+0x2c0/0x568 [ 19.311630] tegra_pcie_dw_probe+0x610/0xb28 [pcie_tegra194] [ 19.311647] platform_probe+0x90/0xd8 ...
[ 19.311782] freed by task 96 on cpu 10 at 19.285833s: [ 19.311799] release_pcibus_dev+0x30/0x40 [ 19.311808] device_release+0x30/0x90 [ 19.311814] kobject_put+0xa8/0x120 [ 19.311832] device_unregister+0x20/0x30 [ 19.311839] pci_remove_bus+0x78/0x88 [ 19.311850] pci_remove_root_bus+0x5c/0x98 [ 19.311860] dw_pcie_host_deinit+0x28/0x78 [ 19.311866] tegra_pcie_deinit_controller+0x1c/0x38 [pcie_tegra194] [ 19.311883] tegra_pcie_dw_probe+0x648/0xb28 [pcie_tegra194] [ 19.311900] platform_probe+0x90/0xd8 ...
[ 19.313579] CPU: 10 PID: 96 Comm: kworker/u24:2 Not tainted 6.2.0 #4 [ 19.320171] Hardware name: /, BIOS 1.0-d7fb19b 08/10/2022 [ 19.325852] Workqueue: events_unbound deferred_probe_work_func
The stack trace is a bit misleading as dw_pcie_host_deinit() doesn't directly call pci_bus_release_domain_nr(). The issue turns out to be in pci_remove_root_bus() which first calls pci_remove_bus() which frees the struct pci_bus when its struct device is released. Then pci_bus_release_domain_nr() is called and accesses the freed struct pci_bus. Reordering these fixes the issue.
--- drivers/pci/remove.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pci/remove.c +3 -2
@@ -157,8 +157,6 @@ void pci_remove_root_bus(struct pci_buslist_for_each_entry_safe (child, tmp, &bus->devices, bus_list)pci_remove_bus_device (child); -pci_remove_bus (bus); - host_bridge->bus =NULL ;#ifdef CONFIG_PCI_DOMAINS_GENERIC /* Release domain_nr if it was dynamically allocated */
@@ -166,6 +164,9 @@ void pci_remove_root_bus(struct pci_buspci_bus_release_domain_nr (bus, host_bridge->dev.parent);#endif +pci_remove_bus (bus); + host_bridge->bus =NULL ; +/* remove the host bridge */ device_del (&host_bridge->dev); }
Greg Kroah-Hartman
maintainerPATCH 166/167 ASoC: qcom: q6afe-dai: fix Display Port Playback stream name
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Srinivas Kandagatla <[email protected]>
commit 4f3fcf5f6dc8ab561e152c8747fd7e502b32266c upstream.
With recent changes to add more display ports did not change the Stream name in q6afe-dai. This results in below error
"ASoC: Failed to add route DISPLAY_PORT_RX -> Display Port Playback(*)" and sound card fails to probe.
Fix this by adding correct stream name.
--- sound/soc/qcom/qdsp6/q6afe-dai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/qcom/qdsp6/q6afe-dai.c +1 -1
@@ -496,7 +496,7 @@ static int q6afe_mi2s_set_sysclk(structstatic const struct snd_soc_dapm_route q6afe_dapm_routes[] = { {"HDMI Playback" ,NULL ,"HDMI_RX" }, - {"Display Port Playback" ,NULL ,"DISPLAY_PORT_RX" }, + {"DISPLAY_PORT_RX_0 Playback" ,NULL ,"DISPLAY_PORT_RX" }, {"Slimbus Playback" ,NULL ,"SLIMBUS_0_RX" }, {"Slimbus1 Playback" ,NULL ,"SLIMBUS_1_RX" }, {"Slimbus2 Playback" ,NULL ,"SLIMBUS_2_RX" },
Greg Kroah-Hartman
maintainerPATCH 167/167 objtool: Silence more KCOV warnings, part 2
In reply to Greg Kroah-Hartman6.1-stable review patch. If anyone has any objections, please let me know.
------------------
From: Josh Poimboeuf <[email protected]>
commit 55c78035a1a8dfb05f1472018ce2a651701adb7d upstream.
Similar to GCOV, KCOV can leave behind dead code and undefined behavior. Warnings related to those should be ignored.
The previous commit:
6b023c784204 ("objtool: Silence more KCOV warnings")
... only did so for CONFIG_CGOV_KERNEL. Also do it for CONFIG_KCOV, but for real this time.
Fixes the following warning:
vmlinux.o: warning: objtool: synaptics_report_mt_data: unexpected end of section .text.synaptics_report_mt_data
--- scripts/Makefile.lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/Makefile.lib +1 -1
@@ -263,7 +263,7 @@ objtool-args-$(CONFIG_SLS) += --sls objtool-args-$(CONFIG_STACK_VALIDATION) += --stackval objtool-args-$(CONFIG_HAVE_STATIC_CALL_INLINE) += --static-call objtool-args-$(CONFIG_HAVE_UACCESS_VALIDATION) += --uaccess -objtool-args-$(CONFIG_GCOV_KERNEL) += --no-unreachable +objtool-args-$(or $(CONFIG_GCOV_KERNEL),$(CONFIG_KCOV)) += --no-unreachable objtool-args = $(objtool-args-y) \ $(if $(delay-objtool), --link) \
Hi!
Quoted 4 lines
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-6.1.y
Best regards,
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Am 29.04.2025 um 18:41 schrieb Greg Kroah-Hartman:
Quoted 4 lines
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Builds, boots and works on my 2-socket Ivy Bridge Xeon E5-2697 v2 server. No dmesg oddities or regressions found.
Beste Grüße,
Peter Schneider
Signature · 8 lines
Climb the mountain not to plant your flag, but to embrace the challenge, enjoy the air and behold the view. Climb it so you can see the world, not so the world can see you. -- David McCullough Jr. OpenPGP: 0xA3828BD796CCE11A8CADE8866E3A92C92C3FF244 Download: https://www.peters-netzplatz.de/download/pschneider1968_pub.asc https://keys.mailvelope.com/pks/lookup?op=get&[email protected] https://keys.mailvelope.com/pks/lookup?op=get&[email protected]
The kernel, bpf tool and perf tool builds fine for v6.1.136-rc1 on x86 and arm64 Azure VM.
Thanks,
Hardik
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 01 May 2025 16:10:15 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.136-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.1.y
and the diffstat can be found below.thanks,
greg k-h
There are three build regressions and two build warnings.
1)
Regressions on x86_64 with defconfig builds with clang-nightly toolchain on the stable-rc 6.1.136-rc1.
* x86_64, build
- clang-nightly-lkftconfig
- clang-nightly-x86_64_defconfig
Regression Analysis:
- New regression? Yes
- Reproducibility? Yes
Build regression: x86_64 clang-nightly net ip.h error default initialization of an object of type 'typeof (rt->dst.expires)'
## Build error x86_64include/net/ip.h:462:14: error: default initialization of an object of type 'typeof (rt->dst.expires)' (aka 'const unsigned long') leaves the object uninitialized and is incompatible with C++ [-Werror,-Wdefault-const-init-unsafe]
462 | if (mtu && time_before(jiffies, rt->dst.expires))
| ^
## Build x86_64
* Build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268204/suite/build/test/clang-nightly-x86_64_defconfig/log
* Build history:
https://qa-reports.linaro.org/lkft/linux-stale-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268204/suite/build/test/clang-nightly-x86_64_defconfig/history/
* Build details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268204/suite/build/test/clang-nightly-x86_64_defconfig/details/
* Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfmTxuT4qMCUSSj4ZwJQJrqY/
* Kernel config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfmTxuT4qMCUSSj4ZwJQJrqY/config
* Toolchain: Debian clang version 21.0.0
(++20250428112741+e086d7b1464a-1~exp1~20250428112923.1416)
2)
Regressions on s390 with defconfig builds with gcc-13, gcc-8 and clang-20 and clang-nightly toolchains on the stable-rc 6.1.136-rc1.
* s390, build
- clang-20-defconfig
- clang-nightly-defconfig
- gcc-13-allmodconfig
- gcc-13-defconfig
- gcc-8-defconfig-fe40093d
Regression Analysis:
- New regression? Yes
- Reproducibility? Yes
Build regression: s390 pci_report.c fatal error linux sprintf.h No such file or directory
## Build error S390arch/s390/pci/pci_report.c:14:10: fatal error: linux/sprintf.h: No such file or directory
14 | #include <linux/sprintf.h>
| ^~~~~~~~~~~~~~~~~
compilation terminated.arch/s390/pci/pci_fixup.c: In function 'zpci_ism_bar_no_mmap':arch/s390/pci/pci_fixup.c:19:13: error: 'struct pci_dev' has no member named 'non_mappable_bars'
19 | pdev->non_mappable_bars = 1;
| ^~drivers/s390/virtio/virtio_ccw.c:88:9: error: unknown type name 'dma64_t'
88 | dma64_t queue;
| ^~~~~~~
drivers/s390/virtio/virtio_ccw.c:95:9: error: unknown type name 'dma64_t'
95 | dma64_t desc;
| ^~~~~~~
drivers/s390/virtio/virtio_ccw.c:99:9: error: unknown type name 'dma64_t'
99 | dma64_t avail;
| ^~~~~~~
drivers/s390/virtio/virtio_ccw.c:100:9: error: unknown type name 'dma64_t'
100 | dma64_t used;
| ^~~~~~~
drivers/s390/virtio/virtio_ccw.c:109:9: error: unknown type name 'dma64_t'
109 | dma64_t summary_indicator;
| ^~~~~~~
drivers/s390/virtio/virtio_ccw.c:110:9: error: unknown type name 'dma64_t'
110 | dma64_t indicator;
| ^~~~~~~drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_drop_indicator':drivers/s390/virtio/virtio_ccw.c:370:25: error: implicit declaration of function 'virt_to_dma64'; did you mean 'virt_to_page'? [-Werror=implicit-function-declaration]
370 | virt_to_dma64(get_summary_indicator(airq_info));
| ^~~~~~~~~~~~~
| virt_to_page
drivers/s390/virtio/virtio_ccw.c:374:28: error: implicit declaration
of function 'virt_to_dma32'; did you mean 'virt_to_page'?
[-Werror=implicit-function-declaration]
374 | ccw->cda = virt_to_dma32(thinint_area);
| ^~~~~~~~~~~~~
| virt_to_pagedrivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_setup_vq':drivers/s390/virtio/virtio_ccw.c:552:45: error: implicit declaration of function 'u64_to_dma64' [-Werror=implicit-function-declaration]
552 | info->info_block->l.queue = u64_to_dma64(queue);
| ^~~~~~~~~~~~drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_find_vqs':drivers/s390/virtio/virtio_ccw.c:654:9: error: unknown type name 'dma64_t'
654 | dma64_t *indicatorp = NULL;
| ^~~~~~~cc1: some warnings being treated as errors
## Build s390
* Build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268210/suite/build/test/gcc-13-defconfig/log
* Build history:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268210/suite/build/test/gcc-13-defconfig/history/
* Build details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268210/suite/build/test/gcc-13-defconfig/details/
* Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfcqRiiDhTc38knEJ0xbygtF/
* Kernel config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfcqRiiDhTc38knEJ0xbygtF/config
* Toolchain: Debian clang version 21.0.0
(++20250428112741+e086d7b1464a-1~exp1~20250428112923.1416)
3)
Regressions on mips with defconfig builds with clang-nightly toolchains on the stable-rc 6.1.136-rc1.
* mips, build
- clang-nightly-allnoconfig
- clang-nightly-defconfig
- clang-nightly-tinyconfig
Regression Analysis:
- New regression? Yes
- Reproducibility? Yes
Build regression: mips kernel branch.c error default initialization of an object of type union
## Build error mipsarch/mips/kernel/branch.c:35:6: error: default initialization of an object of type 'union (unnamed union at arch/mips/kernel/branch.c:35:6)' with const member leaves the object uninitialized and is incompatible with C++ [-Werror,-Wdefault-const-init-unsafe]
35 | if (__get_user(inst, (u16 __user *) msk_isa16_mode(epc))) {
| ^
## Build mips
* Build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28266863/suite/build/test/clang-nightly-tinyconfig/log
* Build history:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28266863/suite/build/test/clang-nightly-tinyconfig/history/
* Build details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28266863/suite/build/test/clang-nightly-tinyconfig/details/
* Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfMHLLGL9OjZrjKvW9u8uy4b/
* Kernel config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfMHLLGL9OjZrjKvW9u8uy4b/config
## Build warnings
a)
Build warnings on x86_64 builds. io_uring/timeout.c:410:31: warning: default initialization of an object of type 'typeof ((sqe->addr2))' (aka 'const unsigned long long') leaves the object uninitialized and is incompatible with C++ [-Wdefault-const-init-unsafe]
410 | if (get_timespec64(&tr->ts,u64_to_user_ptr(sqe->addr2)))
| ^
Links:
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjeiV7BNYgKZ2oXuK3BNEYYBa/
b)
Build warnings on arm with clang-nightly with tinyconfig.
clang: warning: argument unused during compilation: '-march=armv7-m' [-Wunused-command-line-argument]kernel/params.c:367:22: warning: default initialization of an object of type 'struct kernel_param' with const member leaves the object uninitialized and is incompatible with C++ [-Wdefault-const-init-unsafe]
367 | struct kernel_param dummy;
| ^include/linux/moduleparam.h:73:12: note: member 'perm' declared 'const' here
73 | const u16 perm;
| ^kernel/params.c:423:22: warning: default initialization of an object of type 'struct kernel_param' with const member leaves the object uninitialized and is incompatible with C++ [-Wdefault-const-init-unsafe]
423 | struct kernel_param kp;
| ^include/linux/moduleparam.h:73:12: note: member 'perm' declared 'const' here
73 | const u16 perm;
| ^
2 warnings generated.
Links:
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjeaX1oyIaa7F0nsdW1BymEGQ/
## Build
* kernel: 6.1.136-rc1
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit: 961a5173f29d2aa1f2c87ff9612b029c46086972
* git describe: v6.1.134-461-g961a5173f29d
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d
## Test Regressions (compared to v6.1.134-292-gb8b5da130779)
* i386, build
- clang-nightly-defconfig
- clang-nightly-lkftconfig
* mips, build
- clang-nightly-allnoconfig
- clang-nightly-defconfig
- clang-nightly-tinyconfig
* s390, build
- clang-20-defconfig
- clang-nightly-defconfig
- gcc-13-allmodconfig
- gcc-13-defconfig
- gcc-8-defconfig-fe40093d
* x86_64, build
- clang-nightly-lkftconfig
- clang-nightly-x86_64_defconfig
## Metric Regressions (compared to v6.1.134-292-gb8b5da130779)
## Test Fixes (compared to v6.1.134-292-gb8b5da130779)
## Metric Fixes (compared to v6.1.134-292-gb8b5da130779)
## Test result summary
total: 96862, pass: 76665, fail: 4435, skip: 15439, xfail: 323
## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 135 total, 135 passed, 0 failed
* arm64: 43 total, 43 passed, 0 failed
* i386: 27 total, 20 passed, 7 failed
* mips: 26 total, 22 passed, 4 failed
* parisc: 4 total, 4 passed, 0 failed
* powerpc: 32 total, 31 passed, 1 failed
* riscv: 11 total, 9 passed, 2 failed
* s390: 14 total, 8 passed, 6 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 7 total, 7 passed, 0 failed
* x86_64: 35 total, 32 passed, 3 failed
## Test suites summary
* boot
* commands
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-efivarfs
* kselftest-exec
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-kcmp
* kselftest-kvm
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-mincore
* kselftest-mqueue
* kselftest-net
* kselftest-net-mptcp
* kselftest-openat2
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user_events
* kselftest-vDSO
* kselftest-x86
* kunit
* kvm-unit-tests
* lava
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-build-clang
* log-parser-build-gcc
* log-parser-test
* ltp-capability
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture
--
Linaro LKFT
https://lkft.linaro.org
All the clang-nightly issues seem like bugs in clang. I would say only the build error on S390 is a kernel issue.
regards,
dan carpenter
Quoted 358 lines · Naresh Kamboju
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 01 May 2025 16:10:15 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.136-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.1.y
and the diffstat can be found below.thanks,
greg k-h
There are three build regressions and two build warnings.
1)
Regressions onx86_64with defconfig builds with clang-nightly toolchain on the stable-rc 6.1.136-rc1.*
x86_64, build
- clang-nightly-lkftconfig
- clang-nightly-x86_64_defconfigRegression Analysis:
- New regression? Yes
- Reproducibility? YesBuild regression:
x86_64clang-nightly netip.herror default initialization of an object of type 'typeof (rt->dst.expires)'## Build error
x86_64include/net/ip.h:462:14: error: default initialization of an object of type 'typeof (rt->dst.expires)' (aka 'const unsigned long') leaves the object uninitialized and is incompatible with C++ [-Werror,-Wdefault-const-init-unsafe]
462 | if (mtu &&time_before(jiffies, rt->dst.expires))
| ^## Build
x86_64
* Build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268204/suite/build/test/clang-nightly-x86_64_defconfig/log
* Build history:
https://qa-reports.linaro.org/lkft/linux-stale-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268204/suite/build/test/clang-nightly-x86_64_defconfig/history/
* Build details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268204/suite/build/test/clang-nightly-x86_64_defconfig/details/
* Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfmTxuT4qMCUSSj4ZwJQJrqY/
* Kernel config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfmTxuT4qMCUSSj4ZwJQJrqY/config
* Toolchain: Debian clang version 21.0.0
(++20250428112741+e086d7b1464a-1~exp1~20250428112923.1416)2)
Regressions on s390 with defconfig builds with gcc-13, gcc-8 and clang-20 and clang-nightly toolchains on the stable-rc 6.1.136-rc1.* s390, build
- clang-20-defconfig
- clang-nightly-defconfig
- gcc-13-allmodconfig
- gcc-13-defconfig
- gcc-8-defconfig-fe40093dRegression Analysis:
- New regression? Yes
- Reproducibility? YesBuild regression: s390
pci_report.cfatal error linuxsprintf.hNo such file or directory## Build error S390
arch/s390/pci/pci_report.c:14:10: fatal error:linux/sprintf.h: No such file or directory
14 | #include <linux/sprintf.h>| ^~~~~~~~~~~~~~~~~compilation terminated.
arch/s390/pci/pci_fixup.c: In function 'zpci_ism_bar_no_mmap':arch/s390/pci/pci_fixup.c:19:13: error: 'structpci_dev' has no member named 'non_mappable_bars'
19 |pdev->non_mappable_bars= 1;
| ^~drivers/s390/virtio/virtio_ccw.c:88:9: error: unknown type name 'dma64_t'88 | dma64_t queue; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:95:9: error: unknown type name 'dma64_t' 95 | dma64_t desc; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:99:9: error: unknown type name 'dma64_t' 99 | dma64_t avail; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:100:9: error: unknown type name 'dma64_t' 100 | dma64_t used; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:109:9: error: unknown type name 'dma64_t' 109 | dma64_t summary_indicator; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:110:9: error: unknown type name 'dma64_t' 110 | dma64_t indicator; | ^~~~~~~
drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_drop_indicator':drivers/s390/virtio/virtio_ccw.c:370:25: error: implicit declaration of function 'virt_to_dma64'; did you mean 'virt_to_page'? [-Werror=implicit-function-declaration]370 | virt_to_dma64(get_summary_indicator(airq_info)); | ^~~~~~~~~~~~~ | virt_to_page drivers/s390/virtio/virtio_ccw.c:374:28: error: implicit declaration of function 'virt_to_dma32'; did you mean 'virt_to_page'? [-Werror=implicit-function-declaration] 374 | ccw->cda = virt_to_dma32(thinint_area); | ^~~~~~~~~~~~~ | virt_to_page
drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_setup_vq':drivers/s390/virtio/virtio_ccw.c:552:45: error: implicit declaration of function 'u64_to_dma64' [-Werror=implicit-function-declaration]
552 |info->info_block->l.queue=u64_to_dma64(queue);
| ^~~~~~~~~~~~drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_find_vqs':drivers/s390/virtio/virtio_ccw.c:654:9: error: unknown type name 'dma64_t'654 | dma64_t *indicatorp = NULL; | ^~~~~~~cc1: some warnings being treated as errors
## Build s390
* Build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268210/suite/build/test/gcc-13-defconfig/log
* Build history:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268210/suite/build/test/gcc-13-defconfig/history/
* Build details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28268210/suite/build/test/gcc-13-defconfig/details/
* Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfcqRiiDhTc38knEJ0xbygtF/
* Kernel config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfcqRiiDhTc38knEJ0xbygtF/config
* Toolchain: Debian clang version 21.0.0
(++20250428112741+e086d7b1464a-1~exp1~20250428112923.1416)3)
Regressions on mips with defconfig builds with clang-nightly toolchains on the stable-rc 6.1.136-rc1.* mips, build
- clang-nightly-allnoconfig
- clang-nightly-defconfig
- clang-nightly-tinyconfigRegression Analysis:
- New regression? Yes
- Reproducibility? YesBuild regression: mips kernel
branch.cerror default initialization of an object of type union## Build error mips
arch/mips/kernel/branch.c:35:6: error: default initialization of an object of type 'union (unnamed union atarch/mips/kernel/branch.c:35:6)' with const member leaves the object uninitialized and is incompatible with C++ [-Werror,-Wdefault-const-init-unsafe]
35 | if (__get_user(inst, (u16 __user *) msk_isa16_mode(epc))) {
| ^## Build mips
* Build log: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28266863/suite/build/test/clang-nightly-tinyconfig/log
* Build history:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28266863/suite/build/test/clang-nightly-tinyconfig/history/
* Build details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d/testrun/28266863/suite/build/test/clang-nightly-tinyconfig/details/
* Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfMHLLGL9OjZrjKvW9u8uy4b/
* Kernel config:
https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjfMHLLGL9OjZrjKvW9u8uy4b/config## Build warnings
a)
Build warnings onx86_64builds.io_uring/timeout.c:410:31: warning: default initialization of an object of type 'typeof ((sqe->addr2))' (aka 'const unsigned long long') leaves the object uninitialized and is incompatible with C++ [-Wdefault-const-init-unsafe]
410 | if (get_timespec64(&tr->ts,u64_to_user_ptr(sqe->addr2)))
| ^Links:
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjeiV7BNYgKZ2oXuK3BNEYYBa/b)
Build warnings on arm with clang-nightly with tinyconfig.clang: warning: argument unused during compilation: '-march=armv7-m' [-Wunused-command-line-argument]
kernel/params.c:367:22: warning: default initialization of an object of type 'structkernel_param' with const member leaves the object uninitialized and is incompatible with C++ [-Wdefault-const-init-unsafe]
367 | structkernel_paramdummy;
| ^include/linux/moduleparam.h:73:12: note: member 'perm' declared 'const' here
73 | const u16 perm;
| ^kernel/params.c:423:22: warning: default initialization of an object of type 'structkernel_param' with const member leaves the object uninitialized and is incompatible with C++ [-Wdefault-const-init-unsafe]
423 | structkernel_paramkp;
| ^include/linux/moduleparam.h:73:12: note: member 'perm' declared 'const' here
73 | const u16 perm;
| ^
2 warnings generated.Links:
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2wPjeaX1oyIaa7F0nsdW1BymEGQ/## Build
* kernel: 6.1.136-rc1
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit:961a5173f29d2aa1f2c87ff9612b029c46086972
* git describe: v6.1.134-461-g961a5173f29d
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.134-461-g961a5173f29d## Test Regressions (compared to v6.1.134-292-gb8b5da130779)
* i386, build
- clang-nightly-defconfig
- clang-nightly-lkftconfig* mips, build
- clang-nightly-allnoconfig
- clang-nightly-defconfig
- clang-nightly-tinyconfig* s390, build
- clang-20-defconfig
- clang-nightly-defconfig
- gcc-13-allmodconfig
- gcc-13-defconfig
- gcc-8-defconfig-fe40093d*
x86_64, build
- clang-nightly-lkftconfig
- clang-nightly-x86_64_defconfig## Metric Regressions (compared to v6.1.134-292-gb8b5da130779)
## Test Fixes (compared to v6.1.134-292-gb8b5da130779)
## Metric Fixes (compared to v6.1.134-292-gb8b5da130779)
## Test result summary
total: 96862, pass: 76665, fail: 4435, skip: 15439, xfail: 323## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 135 total, 135 passed, 0 failed
* arm64: 43 total, 43 passed, 0 failed
* i386: 27 total, 20 passed, 7 failed
* mips: 26 total, 22 passed, 4 failed
* parisc: 4 total, 4 passed, 0 failed
* powerpc: 32 total, 31 passed, 1 failed
* riscv: 11 total, 9 passed, 2 failed
* s390: 14 total, 8 passed, 6 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 7 total, 7 passed, 0 failed
*x86_64: 35 total, 32 passed, 3 failed## Test suites summary
* boot
* commands
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-efivarfs
* kselftest-exec
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-kcmp
* kselftest-kvm
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-mincore
* kselftest-mqueue
* kselftest-net
* kselftest-net-mptcp
* kselftest-openat2
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user_events
* kselftest-vDSO
* kselftest-x86
* kunit
* kvm-unit-tests
* lava
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-build-clang
* log-parser-build-gcc
* log-parser-test
* ltp-capability
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture--
Linaro LKFT
https://lkft.linaro.org
Greg Kroah-Hartman
maintainerQuoted 40 lines · Naresh Kamboju
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 01 May 2025 16:10:15 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.136-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.1.y
and the diffstat can be found below.thanks,
greg k-h
There are three build regressions and two build warnings.
1)
Regressions onx86_64with defconfig builds with clang-nightly toolchain on the stable-rc 6.1.136-rc1.*
x86_64, build
- clang-nightly-lkftconfig
- clang-nightly-x86_64_defconfigRegression Analysis:
- New regression? Yes
- Reproducibility? YesBuild regression:
x86_64clang-nightly netip.herror default initialization of an object of type 'typeof (rt->dst.expires)'
Quoted 7 lines
## Build error
x86_64include/net/ip.h:462:14: error: default initialization of an object of type 'typeof (rt->dst.expires)' (aka 'const unsigned long') leaves the object uninitialized and is incompatible with C++ [-Werror,-Wdefault-const-init-unsafe]
462 | if (mtu &&time_before(jiffies, rt->dst.expires))
| ^
This isn't c++, so are you sure this isn't just a clang bug?
thanks,
greg k-h
Quoted 3 lines · Greg Kroah-Hartman
Quoted 2 lines · Naresh Kamboju
Regressions on
x86_64with defconfig builds with clang-nightly toolchain on the stable-rc 6.1.136-rc1.
clang-nightly is always a moving target so for the sake of the stable -rc reports, I would only focus on issues that appear with just those patches, as you should see this issue on 6.1.136.
Quoted 21 lines
Quoted 13 lines
*
x86_64, build
- clang-nightly-lkftconfig
- clang-nightly-x86_64_defconfigRegression Analysis:
- New regression? Yes
- Reproducibility? YesBuild regression:
x86_64clang-nightly netip.herror default initialization of an object of type 'typeof (rt->dst.expires)'Quoted 7 lines
## Build error
x86_64include/net/ip.h:462:14: error: default initialization of an object of type 'typeof (rt->dst.expires)' (aka 'const unsigned long') leaves the object uninitialized and is incompatible with C++ [-Werror,-Wdefault-const-init-unsafe]
462 | if (mtu &&time_before(jiffies, rt->dst.expires))
| ^
Quoted 1 line
This isn't c++, so are you sure this isn't just a clang bug?
Yes, it is intentional that this warns for C code, the clang maintainer felt that the default initialization behavior of const variables not marked as static or thread local was worth warning about by default.
https://github.com/llvm/llvm-project/pull/137166
But it is going to be adjusted to allow the kernel to opt-out of the warning for aggregate members, as that triggers often in the kernel:
https://github.com/llvm/llvm-project/pull/137961
The only instance of -Wdefault-const-init-var-unsafe that I have found so far is in typecheck(), which should be easy enough to clean up.
Cheers,
Nathan
include/linux/typecheck.h +2 -2
@@ -7,8 +7,8 @@* Always evaluates to 1 so you may use it easily in comparisons. */ #define typecheck (type,x) \ -({ type __dummy; \ - typeof(x) __dummy2; \ +({ type __dummy = {}; \ + typeof(x) __dummy2 = {}; \ (void)(&__dummy == &__dummy2); \ 1; \ })
Quoted 16 lines
2)
Regressions on s390 with defconfig builds with gcc-13, gcc-8 and clang-20 and clang-nightly toolchains on the stable-rc 6.1.136-rc1.* s390, build
- clang-20-defconfig
- clang-nightly-defconfig
- gcc-13-allmodconfig
- gcc-13-defconfig
- gcc-8-defconfig-fe40093dRegression Analysis:
- New regression? Yes
- Reproducibility? Yes
...
Quoted 38 lines
drivers/s390/virtio/virtio_ccw.c:88:9: error: unknown type name 'dma64_t'88 | dma64_t queue; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:95:9: error: unknown type name 'dma64_t' 95 | dma64_t desc; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:99:9: error: unknown type name 'dma64_t' 99 | dma64_t avail; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:100:9: error: unknown type name 'dma64_t' 100 | dma64_t used; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:109:9: error: unknown type name 'dma64_t' 109 | dma64_t summary_indicator; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:110:9: error: unknown type name 'dma64_t' 110 | dma64_t indicator; | ^~~~~~~
drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_drop_indicator':drivers/s390/virtio/virtio_ccw.c:370:25: error: implicit declaration of function 'virt_to_dma64'; did you mean 'virt_to_page'? [-Werror=implicit-function-declaration]370 | virt_to_dma64(get_summary_indicator(airq_info)); | ^~~~~~~~~~~~~ | virt_to_page drivers/s390/virtio/virtio_ccw.c:374:28: error: implicit declaration of function 'virt_to_dma32'; did you mean 'virt_to_page'? [-Werror=implicit-function-declaration] 374 | ccw->cda = virt_to_dma32(thinint_area); | ^~~~~~~~~~~~~ | virt_to_page
drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_setup_vq':drivers/s390/virtio/virtio_ccw.c:552:45: error: implicit declaration of function 'u64_to_dma64' [-Werror=implicit-function-declaration]
552 |info->info_block->l.queue=u64_to_dma64(queue);
| ^~~~~~~~~~~~drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_find_vqs':drivers/s390/virtio/virtio_ccw.c:654:9: error: unknown type name 'dma64_t'
Quoted 3 lines
654 | dma64_t *indicatorp = NULL; | ^~~~~~~cc1: some warnings being treated as errors
The virtio_ccw errors are caused by '[PATCH 6.1 033/167] s390/virtio_ccw: fix virtual vs physical address confusion'
Picking the following 2 dependencies would resolve the build error:
1bcf7f48b7d4 s390/cio: use bitwise types to allow for type checking 8b19e145e82f s390/cio: introduce bitwise dma types and helper functions
Greg Kroah-Hartman
maintainerQuoted 59 lines · Matthew Rosato
Quoted 16 lines
2)
Regressions on s390 with defconfig builds with gcc-13, gcc-8 and clang-20 and clang-nightly toolchains on the stable-rc 6.1.136-rc1.* s390, build
- clang-20-defconfig
- clang-nightly-defconfig
- gcc-13-allmodconfig
- gcc-13-defconfig
- gcc-8-defconfig-fe40093dRegression Analysis:
- New regression? Yes
- Reproducibility? Yes...
Quoted 38 lines
drivers/s390/virtio/virtio_ccw.c:88:9: error: unknown type name 'dma64_t'88 | dma64_t queue; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:95:9: error: unknown type name 'dma64_t' 95 | dma64_t desc; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:99:9: error: unknown type name 'dma64_t' 99 | dma64_t avail; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:100:9: error: unknown type name 'dma64_t' 100 | dma64_t used; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:109:9: error: unknown type name 'dma64_t' 109 | dma64_t summary_indicator; | ^~~~~~~ drivers/s390/virtio/virtio_ccw.c:110:9: error: unknown type name 'dma64_t' 110 | dma64_t indicator; | ^~~~~~~
drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_drop_indicator':drivers/s390/virtio/virtio_ccw.c:370:25: error: implicit declaration of function 'virt_to_dma64'; did you mean 'virt_to_page'? [-Werror=implicit-function-declaration]370 | virt_to_dma64(get_summary_indicator(airq_info)); | ^~~~~~~~~~~~~ | virt_to_page drivers/s390/virtio/virtio_ccw.c:374:28: error: implicit declaration of function 'virt_to_dma32'; did you mean 'virt_to_page'? [-Werror=implicit-function-declaration] 374 | ccw->cda = virt_to_dma32(thinint_area); | ^~~~~~~~~~~~~ | virt_to_page
drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_setup_vq':drivers/s390/virtio/virtio_ccw.c:552:45: error: implicit declaration of function 'u64_to_dma64' [-Werror=implicit-function-declaration]
552 |info->info_block->l.queue=u64_to_dma64(queue);
| ^~~~~~~~~~~~drivers/s390/virtio/virtio_ccw.c: In function 'virtio_ccw_find_vqs':drivers/s390/virtio/virtio_ccw.c:654:9: error: unknown type name 'dma64_t'Quoted 3 lines
654 | dma64_t *indicatorp = NULL; | ^~~~~~~cc1: some warnings being treated as errors
Quoted 6 lines
The
virtio_ccwerrors are caused by '[PATCH 6.1 033/167] s390/virtio_ccw: fix virtual vs physical address confusion'Picking the following 2 dependencies would resolve the build error:
1bcf7f48b7d4s390/cio: use bitwise types to allow for type checking8b19e145e82fs390/cio: introduce bitwise dma types and helper functions
I'm just going to drop all of these now and wait for a tested series to be sent.
thanks,
greg k-h
Jon Hunter
maintainerQuoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 01 May 2025 16:10:15 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.136-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.1.y
and the diffstat can be found below.thanks,
greg k-h
Failures detected for Tegra ...
Test results for stable-v6.1:
10 builds: 10 pass, 0 fail
28 boots: 28 pass, 0 fail
105 tests: 100 pass, 5 failLinux version: 6.1.136-rc1-g961a5173f29d
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra186-p3509-0000+p3636-0001, tegra194-p2972-0000,
tegra194-p3509-0000+p3668-0000, tegra20-ventana,
tegra210-p2371-2180, tegra210-p3450-0000,
tegra30-cardhu-a04Test failures: tegra186-p2771-0000: cpu-hotplug
tegra194-p2972-0000: pm-system-suspend.sh
tegra210-p2371-2180: cpu-hotplug
tegra210-p3450-0000: cpu-hotplugJon
Jon Hunter
maintainerHi Greg,
Quoted 33 lines · Jon Hunter
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 01 May 2025 16:10:15 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.136-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.1.y
and the diffstat can be found below.thanks,
greg k-h
Failures detected for Tegra ...
Test results for stable-v6.1:
10 builds: 10 pass, 0 fail 28 boots: 28 pass, 0 fail 105 tests: 100 pass, 5 failLinux version: 6.1.136-rc1-g961a5173f29d
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,tegra186-p3509-0000+p3636-0001, tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000, tegra20-ventana, tegra210-p2371-2180, tegra210-p3450-0000, tegra30-cardhu-a04
Quoted 4 lines
Test failures: tegra186-p2771-0000: cpu-hotplug
tegra194-p2972-0000: pm-system-suspend.sh tegra210-p2371-2180: cpu-hotplug tegra210-p3450-0000: cpu-hotplug
Bisect is pointing to the following commit and reverting this does fix the issue ...
# first bad commit: [d908866131a314dbbdd34a205d2514f92e42bb80] memcg: drain obj stock on cpu hotplug teardown
Jon
Signature · 1 line
nvpublic
Greg Kroah-Hartman
maintainerQuoted 42 lines · Jon Hunter
Hi Greg,
Quoted 33 lines · Jon Hunter
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 01 May 2025 16:10:15 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.136-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.1.y
and the diffstat can be found below.thanks,
greg k-h
Failures detected for Tegra ...
Test results for stable-v6.1:
10 builds: 10 pass, 0 fail 28 boots: 28 pass, 0 fail 105 tests: 100 pass, 5 failLinux version: 6.1.136-rc1-g961a5173f29d
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,tegra186-p3509-0000+p3636-0001, tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000, tegra20-ventana, tegra210-p2371-2180, tegra210-p3450-0000, tegra30-cardhu-a04Quoted 4 lines
Test failures: tegra186-p2771-0000: cpu-hotplug
tegra194-p2972-0000: pm-system-suspend.sh tegra210-p2371-2180: cpu-hotplug tegra210-p3450-0000: cpu-hotplug
Quoted 4 lines
Bisect is pointing to the following commit and reverting this does fix the issue ...
# first bad commit: [d908866131a314dbbdd34a205d2514f92e42bb80] memcg: drain obj stock on cpu hotplug teardown
I'll drop this from both 6.1 and 6.6 queues, thanks!
greg k-h
Quoted 8 lines · On Tue, 29 Apr 2025 18:41:48 +0200 Greg Kroah-Hartman…
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 01 May 2025 16:10:15 +0000. Anything received after that time might be too late.
Boot-tested under QEMU for Rust x86_64:
Thanks!
Cheers,
Miguel
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 01 May 2025 16:10:15 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.136-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.1.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu, 01 May 2025 16:10:15 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.136-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-6.1.y
and the diffstat can be found below.thanks,
greg k-h
Built and booted successfully on RISC-V RV64 (HiFive Unmatched).
Quoted 4 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
This breaks NFS boot on the Raspberry Pi 3+, the same issue appears in 5.15. We don't appear to get any incoming traffic:
Begin: Waiting up to 180 secs for any network device to become available ... done.
IP-Config: enxb827eb57f534 hardware address b8:27:eb:57:f5:34 mt[ 16.127316] lan78xx 1-1.1.1:1.0 enxb827eb57f534: Link is Down
u 1500 DHCP
[ 16.840932] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000): clkctl 0x50 IP-Config: no response after 2 secs - giving up IP-Config: enxb827eb57f534 hardware address b8:27:eb:57:f5:34 mtu 1500 DHCP
There was a similar issue in mainline last release, I can't remember the exact fix though.
A bisect identifies "net: phy: microchip: force IRQ polling mode for lan88xx" as the problematic commit.
# bad: [c77e7bf5aa741c165e37394b3adb82bcb3cd9918] Linux 5.15.181-rc1
# good: [f7347f4005727f3155551c0550f4deb9c40b56c2] Linux 5.15.180
git bisect start 'c77e7bf5aa741c165e37394b3adb82bcb3cd9918' 'f7347f4005727f3155551c0550f4deb9c40b56c2'
# test job: [c77e7bf5aa741c165e37394b3adb82bcb3cd9918] https://lava.sirena.org.uk/scheduler/job/1340356 # bad: [c77e7bf5aa741c165e37394b3adb82bcb3cd9918] Linux 5.15.181-rc1 git bisect bad c77e7bf5aa741c165e37394b3adb82bcb3cd9918 # test job: [9599afaa6d1a303c39918a477f76fe8cc9534115] https://lava.sirena.org.uk/scheduler/job/1340569 # good: [9599afaa6d1a303c39918a477f76fe8cc9534115] KVM: arm64: Always start with clearing SVE flag on load git bisect good 9599afaa6d1a303c39918a477f76fe8cc9534115 # test job: [714307f60a32bfc44a0767e9b0fc66a841d2b8f6] https://lava.sirena.org.uk/scheduler/job/1340691 # good: [714307f60a32bfc44a0767e9b0fc66a841d2b8f6] kmsan: disable strscpy() optimization under KMSAN git bisect good 714307f60a32bfc44a0767e9b0fc66a841d2b8f6 # test job: [db8fb490436bd100da815da4e775b51b01e42df2] https://lava.sirena.org.uk/scheduler/job/1341008 # bad: [db8fb490436bd100da815da4e775b51b01e42df2] s390/sclp: Add check for get_zeroed_page() git bisect bad db8fb490436bd100da815da4e775b51b01e42df2 # test job: [4757e8122001124752d7854bec726a61c60ae36a] https://lava.sirena.org.uk/scheduler/job/1341258 # bad: [4757e8122001124752d7854bec726a61c60ae36a] USB: storage: quirk for ADATA Portable HDD CH94 git bisect bad 4757e8122001124752d7854bec726a61c60ae36a # test job: [1f079f1c5fcf13295fc1b583268cc53c80492cfb] https://lava.sirena.org.uk/scheduler/job/1341360 # good: [1f079f1c5fcf13295fc1b583268cc53c80492cfb] tipc: fix NULL pointer dereference in tipc_mon_reinit_self() git bisect good 1f079f1c5fcf13295fc1b583268cc53c80492cfb # test job: [cee5176a98accc550585680213f71d1d307a2e9a] https://lava.sirena.org.uk/scheduler/job/1341449 # good: [cee5176a98accc550585680213f71d1d307a2e9a] virtio_console: fix missing byte order handling for cols and rows git bisect good cee5176a98accc550585680213f71d1d307a2e9a # test job: [5e9fff164f2e60ade9282ee30ad3293eb6312f0e] https://lava.sirena.org.uk/scheduler/job/1341692 # bad: [5e9fff164f2e60ade9282ee30ad3293eb6312f0e] drm/amd/display: Fix gpu reset in multidisplay config git bisect bad 5e9fff164f2e60ade9282ee30ad3293eb6312f0e # test job: [ecc30d7f041daf7de7d0d554ebeeaec1a0870e53] https://lava.sirena.org.uk/scheduler/job/1341795 # bad: [ecc30d7f041daf7de7d0d554ebeeaec1a0870e53] net: phy: microchip: force IRQ polling mode for lan88xx git bisect bad ecc30d7f041daf7de7d0d554ebeeaec1a0870e53 # test job: [40dc7515d0b13057d576610a8dd23ccb42d4259f] https://lava.sirena.org.uk/scheduler/job/1341924 # good: [40dc7515d0b13057d576610a8dd23ccb42d4259f] net: selftests: initialize TCP header and skb payload with zero git bisect good 40dc7515d0b13057d576610a8dd23ccb42d4259f # first bad commit: [ecc30d7f041daf7de7d0d554ebeeaec1a0870e53] net: phy: microchip: force IRQ polling mode for lan88xx
Greg Kroah-Hartman
maintainerQuoted 48 lines · Mark Brown
Quoted 4 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 6.1.136 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
This breaks NFS boot on the Raspberry Pi 3+, the same issue appears in 5.15. We don't appear to get any incoming traffic:
Begin: Waiting up to 180 secs for any network device to become available ... done.
IP-Config: enxb827eb57f534 hardware address b8:27:eb:57:f5:34 mt[ 16.127316] lan78xx 1-1.1.1:1.0 enxb827eb57f534: Link is Down
u 1500 DHCP[ 16.840932] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000): clkctl 0x50 IP-Config: no response after 2 secs - giving up IP-Config: enxb827eb57f534 hardware address b8:27:eb:57:f5:34 mtu 1500 DHCPThere was a similar issue in mainline last release, I can't remember the exact fix though.
A bisect identifies "net: phy: microchip: force IRQ polling mode for lan88xx" as the problematic commit.
# bad: [
c77e7bf5aa741c165e37394b3adb82bcb3cd9918] Linux 5.15.181-rc1
# good: [f7347f4005727f3155551c0550f4deb9c40b56c2] Linux 5.15.180
git bisect start 'c77e7bf5aa741c165e37394b3adb82bcb3cd9918' 'f7347f4005727f3155551c0550f4deb9c40b56c2'# test job: [c77e7bf5aa741c165e37394b3adb82bcb3cd9918] https://lava.sirena.org.uk/scheduler/job/1340356 # bad: [c77e7bf5aa741c165e37394b3adb82bcb3cd9918] Linux 5.15.181-rc1 git bisect bad c77e7bf5aa741c165e37394b3adb82bcb3cd9918 # test job: [9599afaa6d1a303c39918a477f76fe8cc9534115] https://lava.sirena.org.uk/scheduler/job/1340569 # good: [9599afaa6d1a303c39918a477f76fe8cc9534115] KVM: arm64: Always start with clearing SVE flag on load git bisect good 9599afaa6d1a303c39918a477f76fe8cc9534115 # test job: [714307f60a32bfc44a0767e9b0fc66a841d2b8f6] https://lava.sirena.org.uk/scheduler/job/1340691 # good: [714307f60a32bfc44a0767e9b0fc66a841d2b8f6] kmsan: disable strscpy() optimization under KMSAN git bisect good 714307f60a32bfc44a0767e9b0fc66a841d2b8f6 # test job: [db8fb490436bd100da815da4e775b51b01e42df2] https://lava.sirena.org.uk/scheduler/job/1341008 # bad: [db8fb490436bd100da815da4e775b51b01e42df2] s390/sclp: Add check for get_zeroed_page() git bisect bad db8fb490436bd100da815da4e775b51b01e42df2 # test job: [4757e8122001124752d7854bec726a61c60ae36a] https://lava.sirena.org.uk/scheduler/job/1341258 # bad: [4757e8122001124752d7854bec726a61c60ae36a] USB: storage: quirk for ADATA Portable HDD CH94 git bisect bad 4757e8122001124752d7854bec726a61c60ae36a # test job: [1f079f1c5fcf13295fc1b583268cc53c80492cfb] https://lava.sirena.org.uk/scheduler/job/1341360 # good: [1f079f1c5fcf13295fc1b583268cc53c80492cfb] tipc: fix NULL pointer dereference in tipc_mon_reinit_self() git bisect good 1f079f1c5fcf13295fc1b583268cc53c80492cfb # test job: [cee5176a98accc550585680213f71d1d307a2e9a] https://lava.sirena.org.uk/scheduler/job/1341449 # good: [cee5176a98accc550585680213f71d1d307a2e9a] virtio_console: fix missing byte order handling for cols and rows git bisect good cee5176a98accc550585680213f71d1d307a2e9a # test job: [5e9fff164f2e60ade9282ee30ad3293eb6312f0e] https://lava.sirena.org.uk/scheduler/job/1341692 # bad: [5e9fff164f2e60ade9282ee30ad3293eb6312f0e] drm/amd/display: Fix gpu reset in multidisplay config
Quoted 8 lines
git bisect bad 5e9fff164f2e60ade9282ee30ad3293eb6312f0e # test job: [ecc30d7f041daf7de7d0d554ebeeaec1a0870e53] https://lava.sirena.org.uk/scheduler/job/1341795 # bad: [ecc30d7f041daf7de7d0d554ebeeaec1a0870e53] net: phy: microchip: force IRQ polling mode for lan88xx git bisect bad ecc30d7f041daf7de7d0d554ebeeaec1a0870e53 # test job: [40dc7515d0b13057d576610a8dd23ccb42d4259f] https://lava.sirena.org.uk/scheduler/job/1341924 # good: [40dc7515d0b13057d576610a8dd23ccb42d4259f] net: selftests: initialize TCP header and skb payload with zero git bisect good 40dc7515d0b13057d576610a8dd23ccb42d4259f # first bad commit: [ecc30d7f041daf7de7d0d554ebeeaec1a0870e53] net: phy: microchip: force IRQ polling mode for lan88xx
Thanks for the bisection, I'll go drop this from 5.15.y and 6.1.y now.
greg k-h