powerpc/pseries: Include linux/types.h in papr-platform-dump.h
Subsystems (2)
PATCH 1/1 powerpc/pseries: Include linux/types.h in papr-platform-dump.h
Fix the following build warning:usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type without #include <linux/types.h>
--- arch/powerpc/include/uapi/asm/papr-platform-dump.h | 1 + 1 file changed, 1 insertion(+)
arch/powerpc/include/uapi/asm/papr-platform-dump.h +1 -0
@@ -2,6 +2,7 @@#ifndef _UAPI_PAPR_PLATFORM_DUMP_H_#define _UAPI_PAPR_PLATFORM_DUMP_H_ +#include <linux/types.h> #include <asm/ioctl.h> #include <asm/papr-miscdev.h>
Signature · 1 line
2.43.5
Hi Haren,
Thanks for this. I have a small nitpick below.
Quoted 9 lines · On Tue, 29 Apr 2025 14:14:18 -0700 Haren Myneni <[email protected]> wrote:
Fix the following build warning:
usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type without #include <linux/types.h>Fixes 8aa9efc0be66 ("powerpc/pseries: Add papr-platform-dump character driver for dump retrieval")Reported-by Stephen Rothwell <[email protected]>Signed-off-by Haren Myneni <[email protected]>
Please keep all the commit message tags together at the end of the commit message.
Signature · 2 lines
Cheers, Stephen Rothwell
Madhavan Srinivasan
maintainerQuoted 15 lines · Stephen Rothwell
Hi Haren,
Thanks for this. I have a small nitpick below.
Quoted 9 lines · On Tue, 29 Apr 2025 14:14:18 -0700 Haren Myneni <[email protected]> wrote:
Fix the following build warning:
usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type without #include <linux/types.h>Fixes 8aa9efc0be66 ("powerpc/pseries: Add papr-platform-dump character driver for dump retrieval")Reported-by Stephen Rothwell <[email protected]>Signed-off-by Haren Myneni <[email protected]>
For now, when pulling this in , i will fix it,
but in future kindly have all tags together at
the end as suggested.
Maddy
Quoted 3 lines
Please keep all the commit message tags together at the end of the commit message.
Quoted 17 lines · Haren Myneni
Fix the following build warning:
usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type without #include <linux/types.h>Fixes 8aa9efc0be66 ("powerpc/pseries: Add papr-platform-dump character driver for dump retrieval")Reported-by Stephen Rothwell <[email protected]>Signed-off-by Haren Myneni <[email protected]>--- arch/powerpc/include/uapi/asm/papr-platform-dump.h | 1 + 1 file changed, 1 insertion(+)arch/powerpc/include/uapi/asm/papr-platform-dump.h +0
-0
arch/powerpc/include/uapi/asm/papr-platform-dump.h line 8
Quoted 7 lines
arch/powerpc/include/uapi/asm/papr-platform-dump.h +1
-0@@ -2,6 +2,7 @@#ifndef _UAPI_PAPR_PLATFORM_DUMP_H_#define _UAPI_PAPR_PLATFORM_DUMP_H_ +#include <linux/types.h> #include <asm/ioctl.h> #include <asm/papr-miscdev.h>
Tested this patch by applying on top of 6.15.0-rc4-next-20250429 and it fixes the reported warning. Hence,
Before Patch:
make -j 17 -s && make modules_install && make install usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type without #include <linux/types.h> SYMLINK /lib/modules/6.15.0-rc4-next-20250429-auto/build
INSTALL /lib/modules/6.15.0-rc4-next-20250429-auto/modules.order
After Patch:
make -j 17 -s && make modules_install && make install
SYMLINK /lib/modules/6.15.0-rc4-next-20250429-auto-00001-g5f4677f96288/build INSTALL /lib/modules/6.15.0-rc4-next-20250429-auto-00001-g5f4677f96288/modules.order INSTALL /lib/modules/6.15.0-rc4-next-20250429-auto-00001-g5f4677f96288/modules.builti
Regards,
Venkat.
Quoted 8 lines · Haren Myneni
Fix the following build warning:
usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type without #include <linux/types.h>Fixes 8aa9efc0be66 ("powerpc/pseries: Add papr-platform-dump character driver for dump retrieval")[...]
Applied to powerpc/next.
[1/1] powerpc/pseries: Include linux/types.h in papr-platform-dump.h
https://git.kernel.org/powerpc/c/925e8620db51ca6bd5c87256dc71c38770b8f6e1
Thanks