Skip to contentSkip to conversation

cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test

PATCH Applied Dave Jiang 3 participants 4 messages Apr 29, 2025 – May 9, 2025 CXL

lore
Share & tools
lore

Dave Jiang

author maintainer
#0 lore raw

PATCH 1/1 cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test

Add MODULE_DESCRIPTION() to address the following warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_test.o
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock.o
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock_mem.o

---
 tools/testing/cxl/test/cxl.c  | 1 +
 tools/testing/cxl/test/mem.c  | 1 +
 tools/testing/cxl/test/mock.c | 1 +
 3 files changed, 3 insertions(+)
tools/testing/cxl/test/cxl.c +1 -0
index 1c3336095923..eb36408d287a 100644
@@ -1527,5 +1527,6 @@ MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
 module_init(cxl_test_init);
 module_exit(cxl_test_exit);
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("CXL test setup module");
 MODULE_IMPORT_NS("ACPI");
 MODULE_IMPORT_NS("CXL");
tools/testing/cxl/test/mem.c +1 -0
index bf9caa908f89..32d47e3df22a 100644
@@ -1909,4 +1909,5 @@ static struct platform_driver cxl_mock_mem_driver = {
 
 module_platform_driver(cxl_mock_mem_driver);
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("CXL test mem device mock module");
 MODULE_IMPORT_NS("CXL");
tools/testing/cxl/test/mock.c +1 -0
index af2594e4f35d..6147f0966ffd 100644
@@ -312,5 +312,6 @@ void __wrap_cxl_dport_init_ras_reporting(struct cxl_dport *dport, struct device
 EXPORT_SYMBOL_NS_GPL(__wrap_cxl_dport_init_ras_reporting, "CXL");
 
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("CXL test emulation module");
 MODULE_IMPORT_NS("ACPI");
 MODULE_IMPORT_NS("CXL");
Signature · 1 line
2.49.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Dave Jiang

Add MODULE_DESCRIPTION() to address the following warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_test.o
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock.o
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock_mem.o

snip

Reviewed-by on v1 1/1
#2 lore raw
In reply to Dave Jiang
Quoted 17 lines · Dave Jiang

Add MODULE_DESCRIPTION() to address the following warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_test.o
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock.o
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock_mem.o

---
 tools/testing/cxl/test/cxl.c  | 1 +
 tools/testing/cxl/test/mem.c  | 1 +
 tools/testing/cxl/test/mock.c | 1 +
 3 files changed, 3 insertions(+)
tools/testing/cxl/test/cxl.c +0 -0
index 1c3336095923..eb36408d287a 100644

tools/testing/cxl/test/cxl.c MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1"); · line 1530

Quoted 4 lines
tools/testing/cxl/test/cxl.c +1 -0
@@ -1527,5 +1527,6 @@ MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
 module_init(cxl_test_init);
 module_exit(cxl_test_exit);
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("CXL test setup module");

In all of these I would s/CXL test/cxl_test:/ to clarify the relationship. Other than that:

author maintainer Applied
#3 lore raw
In reply to Dave Jiang
Quoted 6 lines · Dave Jiang

Add MODULE_DESCRIPTION() to address the following warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_test.o
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock.o
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock_mem.o

Applied to cxl/next

Quoted 38 lines
---
 tools/testing/cxl/test/cxl.c  | 1 +
 tools/testing/cxl/test/mem.c  | 1 +
 tools/testing/cxl/test/mock.c | 1 +
 3 files changed, 3 insertions(+)
tools/testing/cxl/test/cxl.c +1 -0
index 1c3336095923..eb36408d287a 100644
@@ -1527,5 +1527,6 @@ MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
 module_init(cxl_test_init);
 module_exit(cxl_test_exit);
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("CXL test setup module");
 MODULE_IMPORT_NS("ACPI");
 MODULE_IMPORT_NS("CXL");
tools/testing/cxl/test/mem.c +1 -0
index bf9caa908f89..32d47e3df22a 100644
@@ -1909,4 +1909,5 @@ static struct platform_driver cxl_mock_mem_driver = {
 
 module_platform_driver(cxl_mock_mem_driver);
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("CXL test mem device mock module");
 MODULE_IMPORT_NS("CXL");
tools/testing/cxl/test/mock.c +1 -0
index af2594e4f35d..6147f0966ffd 100644
@@ -312,5 +312,6 @@ void __wrap_cxl_dport_init_ras_reporting(struct cxl_dport *dport, struct device
 EXPORT_SYMBOL_NS_GPL(__wrap_cxl_dport_init_ras_reporting, "CXL");
 
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("CXL test emulation module");
 MODULE_IMPORT_NS("ACPI");
 MODULE_IMPORT_NS("CXL");