Skip to contentSkip to conversation

iommu: Cleanup comments for dev_enable/disable_feat

PATCH Applied Lu Baolu 4 participants 4 messages Apr 30, 2025 – May 2, 2025 IOMMU

lore
Share & tools
lore

Lu Baolu

author
#0 lore raw

PATCH 1/1 iommu: Cleanup comments for dev_enable/disable_feat

The dev_enable/disable_feat ops have been removed by commit <f984fb09e60e> ("iommu: Remove iommu_dev_enable/disable_feature()"). Cleanup the comments to make the code clean.

---
 include/linux/iommu.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/iommu.h +0 -2
index 1785caee5977..36df38c2d3a9 100644
@@ -590,8 +590,6 @@ iommu_copy_struct_from_full_user_array(void *kdst, size_t kdst_entry_size,
  * @of_xlate: add OF master IDs to iommu grouping
  * @is_attach_deferred: Check if domain attach should be deferred from iommu
  *                      driver init to device driver init (default no)
- * @dev_enable/disable_feat: per device entries to enable/disable
- *                               iommu specific features.
  * @page_response: handle page request response
  * @def_domain_type: device default domain type, return value:
  *		- IOMMU_DOMAIN_IDENTITY: must use an identity domain
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Lu Baolu
Quoted 5 lines · Lu Baolu

The dev_enable/disable_feat ops have been removed by commit <f984fb09e60e> ("iommu: Remove iommu_dev_enable/disable_feature()"). Cleanup the comments to make the code clean.

-Vasant

Quoted 17 lines
---
 include/linux/iommu.h | 2 --
 1 file changed, 2 deletions(-)
include/linux/iommu.h +0 -2
index 1785caee5977..36df38c2d3a9 100644
@@ -590,8 +590,6 @@ iommu_copy_struct_from_full_user_array(void *kdst, size_t kdst_entry_size,
  * @of_xlate: add OF master IDs to iommu grouping
  * @is_attach_deferred: Check if domain attach should be deferred from iommu
  *                      driver init to device driver init (default no)
- * @dev_enable/disable_feat: per device entries to enable/disable
- *                               iommu specific features.
  * @page_response: handle page request response
  * @def_domain_type: device default domain type, return value:
  *		- IOMMU_DOMAIN_IDENTITY: must use an identity domain
maintainer Applied
#3 lore raw
In reply to Lu Baolu
Quoted 8 lines · Lu Baolu

The dev_enable/disable_feat ops have been removed by commit <f984fb09e60e> ("iommu: Remove iommu_dev_enable/disable_feature()"). Cleanup the comments to make the code clean.

---
 include/linux/iommu.h | 2 --
 1 file changed, 2 deletions(-)

Applied, thanks.