Define Ansible inventory in the Ansible Configuration file
v2 cover Define Ansible inventory in the Ansible Configuration file
This promotes the Ansible inventory file (typically 'hosts' in kdevops) to the Ansible Configuration file (ansible.cfg). By doing this, we allow to control the hosts globally rather than in all the ansible-playbook commands, as well as clean up the ansible-playbook command.
So, we don't need to define anymore the inventory file in the command. However, playbooks may still be controlled on which targets the playbook is run. This is done through the playbook itself and/or through the ansible-playbook argument --limit.
As part of the series, the term 'all' to refer to all hosts is redefined to include the localhost. This removes the need to be explicit with localhost playbooks runs, as it's now just another target in the inventory file. This term redefinition requires to change playbooks that use the term all, either through ansible-playbook command or through the
host: field in the YAML playbook file. For this reason, the term has been replaced in most cases with 'all:!localhost', which means all targets in the inventory file except the localhost. Except the bootlinux.yml playbook, all playbooks run either on localhost or remote targets (the previous all definition). Therefore, all playbooks have been converted to use 'hosts: all!localhost'. For the bootlinux.yml playbook, all is kept and the control of host execution is done via the --limit argument. It was found that only the linux-clone-9p target runs the bootlinux playbook in the localhost while the rest of linux-* targets run the playbook in all the remotes (all:!localhosts).
In addition, in order to help me debug this change, I found it convenient to print the Makefile target name being run before the command. This allows to be more explicit in verbose mode (V=1) when a playbook is run (or any subsequent command in the target). And makes it easier to discover which target the ansible-playbook command belongs to when debugging playbook execution. To clarify, V=1 already prints the command but not the Makefile target. The command output behaviour will be a bit different as it is today as the command itself will be printed in one line, instead of multiple.
Series has been tested here:
https://github.com/linux-kdevops/kdevops/actions/runs/14773869477
---
Changes in v2:
- Update ANSIBLE_CFG_INVENTORY help description as per Chuck suggestion
- Add docs/kdevops-ansible-configuration.md for extensive module
documentation
- Include fix to avoid generating always the ansible.cfg and hosts
files. Reported by Chuck
The same commit change also includes support to change the ansible.cfg
path.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Daniel Gomez (10):
playbooks: fix playbook name for all hosts plays
playbooks: fix playbook name for localhost plays
Makefile: use long form of limit argument for clarity
Makefile: print target when debug .github/workflows/fstests.yml: enable make verbosity
ansible_cfg: add inventory support
gen_hosts: templates: add localhost to all hosts
Makefile: use inventory from ansible.cfg
ansible_cfg: add support to change ansible.cfg file location
docs: ansible_cfg: add documentation
.github/workflows/fstests.yml | 16 ++-- MAINTAINERS | 2 +- Makefile | 42 ++++----- Makefile.btrfs_progs | 4 +- Makefile.build_qemu | 12 +-- Makefile.hypervisor-tunings | 3 +- Makefile.kdevops | 19 ++-- Makefile.linux-mirror | 6 +- Makefile.postfix | 3 +- docs/kdevops-ansible-configuration.md | 102 +++++++++++++++++++++ kconfigs/Kconfig.ansible_cfg | 33 +++++++ kconfigs/Kconfig.ansible_provisioning | 6 -- playbooks/blktests.yml | 3 +- playbooks/bootlinux-local.yml | 3 +- playbooks/bootlinux.yml | 3 +- playbooks/bringup_guestfs.yml | 3 +- playbooks/build_qemu.yml | 3 +- playbooks/common.yml | 3 +- playbooks/create_data_partition.yml | 3 +- playbooks/cxl.yml | 3 +- playbooks/devconfig.yml | 3 +- playbooks/fstests.yml | 5 +- playbooks/gen-pci-kconfig.yml | 3 +- playbooks/gen_hosts.yml | 3 +- playbooks/gen_nodes.yml | 3 +- playbooks/gen_tfvars.yml | 3 +- playbooks/gitr.yml | 3 +- playbooks/hypervisor-tuning.yml | 3 +- playbooks/install-menuconfig-deps.yml | 3 +- playbooks/install_systemd_journal_remote.yml | 3 +- playbooks/install_systemd_timesyncd.yml | 3 +- playbooks/install_terraform.yml | 3 +- playbooks/install_vagrant_boxes.yml | 3 +- playbooks/iscsi.yml | 3 +- playbooks/kdc.yml | 3 +- playbooks/kdevops_archive.yml | 3 +- playbooks/krb5.yml | 3 +- playbooks/ktls.yml | 3 +- playbooks/libvirt_pcie_passthrough.yml | 3 +- playbooks/libvirt_storage_pool_create.yml | 3 +- playbooks/libvirt_user.yml | 3 +- playbooks/linux-mirror.yml | 3 +- playbooks/ltp.yml | 3 +- playbooks/nfsd.yml | 3 +- playbooks/nfstest.yml | 3 +- playbooks/pkg.yml | 3 +- playbooks/postfix_relay_host.yml | 3 +- playbooks/pynfs.yml | 3 +- playbooks/reboot-limit.yml | 3 +- playbooks/roles/ansible_cfg/tasks/main.yml | 2 +- .../roles/ansible_cfg/templates/ansible.cfg.j2 | 1 + playbooks/roles/gen_hosts/defaults/main.yml | 1 - playbooks/roles/gen_hosts/tasks/main.yml | 52 +++++------ playbooks/roles/gen_hosts/templates/blktests.j2 | 1 + playbooks/roles/gen_hosts/templates/cxl.j2 | 1 + playbooks/roles/gen_hosts/templates/fstests.j2 | 1 + playbooks/roles/gen_hosts/templates/gitr.j2 | 1 + playbooks/roles/gen_hosts/templates/hosts.j2 | 2 + playbooks/roles/gen_hosts/templates/ltp.j2 | 1 + playbooks/roles/gen_hosts/templates/nfstest.j2 | 1 + playbooks/roles/gen_hosts/templates/pynfs.j2 | 1 + playbooks/roles/gen_hosts/templates/selftests.j2 | 1 + playbooks/roles/gen_hosts/templates/sysbench.j2 | 1 + playbooks/roles/update_etc_hosts/tasks/main.yml | 2 +- playbooks/rxe.yml | 3 +- playbooks/selftests.yml | 3 +- playbooks/siw.yml | 3 +- playbooks/smbd.yml | 3 +- playbooks/sysbench.yml | 3 +- playbooks/terraform.yml | 3 +- playbooks/update_etc_hosts.yml | 3 +- playbooks/update_ssh_config_guestfs.yml | 3 +- playbooks/update_ssh_config_vagrant.yml | 3 +- scripts/archive.Makefile | 3 +- scripts/devconfig.Makefile | 8 +- scripts/dynamic-pci-kconfig.Makefile | 3 +- scripts/firstconfig.Makefile | 5 +- scripts/gen-hosts.Makefile | 1 - scripts/guestfs.Makefile | 17 ++-- scripts/install-menuconfig-deps.Makefile | 3 +- scripts/iscsi.Makefile | 2 +- scripts/journal-server.Makefile | 23 +++-- scripts/kotd.Makefile | 16 ++-- scripts/krb5.Makefile | 4 +- scripts/ktls.Makefile | 1 - scripts/nfsd.Makefile | 2 +- scripts/provision.Makefile | 5 +- scripts/rdma.Makefile | 2 - scripts/smbd.Makefile | 2 +- scripts/systemd-timesync.Makefile | 8 +- scripts/terraform.Makefile | 6 +- scripts/update_etc_hosts.Makefile | 2 +- scripts/vagrant.Makefile | 10 +- scripts/workflows/lib/crash.py | 4 +- workflows/blktests/Makefile | 20 ++-- workflows/common/Makefile | 2 +- workflows/cxl/Makefile | 14 +-- workflows/demos/reboot-limit/Makefile | 32 ++++--- workflows/fstests/Makefile | 40 +++++--- workflows/gitr/Makefile | 8 +- workflows/linux/Makefile | 61 +++++++----- workflows/ltp/Makefile | 8 +- workflows/nfstest/Makefile | 8 +- workflows/pynfs/Makefile | 12 +-- workflows/selftests/Makefile | 11 ++- workflows/sysbench/Makefile | 12 +-- 106 files changed, 510 insertions(+), 302 deletions(-)
---
base-commit: 1e8f65cd4c4385e47c04356b701c101bd519adf2
change-id: 20250430-ansible_cfg_inventory-7955944ce8ff
Best regards,
Signature · 1 line
Daniel Gomez <[email protected]>
PATCH v2 1/10 playbooks: fix playbook name for all hosts plays
From: Daniel Gomez <[email protected]>
Fix name rule by naming all the playbooks that run in all hosts.
https://ansible.readthedocs.io/projects/lint/rules/name/
--- playbooks/blktests.yml | 3 ++- playbooks/bootlinux.yml | 3 ++- playbooks/common.yml | 3 ++- playbooks/create_data_partition.yml | 3 ++- playbooks/cxl.yml | 3 ++- playbooks/devconfig.yml | 3 ++- playbooks/gitr.yml | 3 ++- playbooks/iscsi.yml | 3 ++- playbooks/kdc.yml | 3 ++- playbooks/krb5.yml | 3 ++- playbooks/ktls.yml | 3 ++- playbooks/ltp.yml | 3 ++- playbooks/nfsd.yml | 3 ++- playbooks/nfstest.yml | 3 ++- playbooks/pkg.yml | 3 ++- playbooks/pynfs.yml | 3 ++- playbooks/reboot-limit.yml | 3 ++- playbooks/rxe.yml | 3 ++- playbooks/selftests.yml | 3 ++- playbooks/siw.yml | 3 ++- playbooks/smbd.yml | 3 ++- playbooks/sysbench.yml | 3 ++- playbooks/terraform.yml | 3 ++- playbooks/update_etc_hosts.yml | 3 ++- 24 files changed, 48 insertions(+), 24 deletions(-)
playbooks/blktests.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: blktests + hosts: all roles: - role: blktests
playbooks/bootlinux.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: bootlinux + hosts: all roles: - role: bootlinux
playbooks/common.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: common + hosts: all roles: - role: common
playbooks/create_data_partition.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: create_data_partition + hosts: all roles: - role: create_data_partition
playbooks/cxl.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: cxl + hosts: all roles: - role: cxl
playbooks/devconfig.yml +2 -1
@@ -1,5 +1,6 @@ --- -- hosts: all +- name: devconfig + hosts: all gather_facts: no roles: - role: devconfig
playbooks/gitr.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: gitr + hosts: all roles: - role: gitr
playbooks/iscsi.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: iscsi + hosts: all roles: - role: iscsi
playbooks/kdc.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: kdc + hosts: all roles: - role: kdc
playbooks/krb5.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: krb5 + hosts: all roles: - role: krb5
playbooks/ktls.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: ktls + hosts: all roles: - role: ktls
playbooks/ltp.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: ltp + hosts: all roles: - role: ltp
playbooks/nfsd.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: nfsd + hosts: all roles: - role: nfsd
playbooks/nfstest.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: nfstest + hosts: all roles: - role: nfstest
playbooks/pkg.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: pkg + hosts: all roles: - role: pkg
playbooks/pynfs.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: pynfs + hosts: all roles: - role: pynfs
playbooks/reboot-limit.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: reboot-limit + hosts: all roles: - role: reboot-limit
playbooks/rxe.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: rxe + hosts: all roles: - role: rxe
playbooks/selftests.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: selftests + hosts: all roles: - role: selftests
playbooks/siw.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: siw + hosts: all roles: - role: siw
playbooks/smbd.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: smbd + hosts: all roles: - role: smbd
playbooks/sysbench.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: all +- name: sysbench + hosts: all roles: - role: sysbench
playbooks/terraform.yml +2 -1
@@ -1,5 +1,6 @@ --- -- hosts: all +- name: terraform + hosts: all gather_facts: false roles: - role: terraform
playbooks/update_etc_hosts.yml +2 -1
@@ -1,5 +1,6 @@ --- -- hosts: all +- name: update_etc_hosts + hosts: all gather_facts: no roles: - role: update_etc_hosts
Signature · 1 line
2.49.0
PATCH v2 2/10 playbooks: fix playbook name for localhost plays
In reply to Daniel GomezFrom: Daniel Gomez <[email protected]>
Fix name rule by naming all the playbooks that run in localhost.
https://ansible.readthedocs.io/projects/lint/rules/name/
--- playbooks/bootlinux-local.yml | 3 ++- playbooks/bringup_guestfs.yml | 3 ++- playbooks/build_qemu.yml | 3 ++- playbooks/fstests.yml | 3 ++- playbooks/gen-pci-kconfig.yml | 3 ++- playbooks/gen_hosts.yml | 3 ++- playbooks/gen_nodes.yml | 3 ++- playbooks/gen_tfvars.yml | 3 ++- playbooks/hypervisor-tuning.yml | 3 ++- playbooks/install-menuconfig-deps.yml | 3 ++- playbooks/install_systemd_journal_remote.yml | 3 ++- playbooks/install_systemd_timesyncd.yml | 3 ++- playbooks/install_terraform.yml | 3 ++- playbooks/install_vagrant_boxes.yml | 3 ++- playbooks/kdevops_archive.yml | 3 ++- playbooks/libvirt_pcie_passthrough.yml | 3 ++- playbooks/libvirt_storage_pool_create.yml | 3 ++- playbooks/libvirt_user.yml | 3 ++- playbooks/linux-mirror.yml | 3 ++- playbooks/postfix_relay_host.yml | 3 ++- playbooks/update_ssh_config_guestfs.yml | 3 ++- playbooks/update_ssh_config_vagrant.yml | 3 ++- 22 files changed, 44 insertions(+), 22 deletions(-)
playbooks/bootlinux-local.yml +2 -1
@@ -1,5 +1,6 @@ --- -- hosts: localhost +- name: bootlinux-local + hosts: localhost connection: local roles: - role: bootlinux-local
playbooks/bringup_guestfs.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: bringup_guestfs + hosts: localhost roles: - role: bringup_guestfs
playbooks/build_qemu.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: build_qemu + hosts: localhost roles: - role: build_qemu
playbooks/fstests.yml +2 -1
@@ -1,5 +1,6 @@ --- -- hosts: localhost +- name: fstests + hosts: localhost roles: - role: fstests_prep_localhost
playbooks/gen-pci-kconfig.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: gen-pci-kconfig + hosts: localhost roles: - role: gen_pci_kconfig
playbooks/gen_hosts.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: gen_hosts + hosts: localhost roles: - role: gen_hosts
playbooks/gen_nodes.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: gen_nodes + hosts: localhost roles: - role: gen_nodes
playbooks/gen_tfvars.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: gen_tfvars + hosts: localhost roles: - role: gen_tfvars
playbooks/hypervisor-tuning.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: hypervisor-tuning + hosts: localhost roles: - role: hypervisor-tuning
playbooks/install-menuconfig-deps.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: install-menuconfig-deps + hosts: localhost roles: - role: install-menuconfig-deps
playbooks/install_systemd_journal_remote.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: install_systemd_journal_remote + hosts: localhost roles: - role: install_systemd_journal_remote
playbooks/install_systemd_timesyncd.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: install_systemd_timesyncd + hosts: localhost roles: - role: install_systemd_timesyncd
playbooks/install_terraform.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: install_terraform + hosts: localhost roles: - role: install_terraform
playbooks/install_vagrant_boxes.yml +2 -1
@@ -1,5 +1,6 @@ --- -- hosts: localhost +- name: install_vagrant_boxes + hosts: localhost tasks: - include_role: name: install_vagrant_boxes
playbooks/kdevops_archive.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: kdevops_archive + hosts: localhost roles: - role: kdevops_archive
playbooks/libvirt_pcie_passthrough.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: libvirt_pcie_passthrough + hosts: localhost roles: - role: libvirt_pcie_passthrough
playbooks/libvirt_storage_pool_create.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: libvirt_storage_pool_create + hosts: localhost roles: - role: libvirt_storage_pool_create
playbooks/libvirt_user.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: libvirt_user + hosts: localhost roles: - role: libvirt_user
playbooks/linux-mirror.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: linux-mirror + hosts: localhost roles: - role: linux-mirror
playbooks/postfix_relay_host.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: postfix_relay_host + hosts: localhost roles: - role: postfix_relay_host
playbooks/update_ssh_config_guestfs.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: update_ssh_config_guestfs + hosts: localhost roles: - role: update_ssh_config_guestfs
playbooks/update_ssh_config_vagrant.yml +2 -1
@@ -1,4 +1,5 @@ --- -- hosts: localhost +- name: update_ssh_config_vagrant + hosts: localhost roles: - role: update_ssh_config_vagrant
Signature · 1 line
2.49.0
PATCH v2 3/10 Makefile: use long form of limit argument for clarity
In reply to Daniel GomezFrom: Daniel Gomez <[email protected]>
Replace the short -l argument option with the more explicit --limit in the Makefile for ansible-playbook runs. This improves readability and makes the purpose of the flag clearer.
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
@@ -62,7 +62,7 @@ include scripts/ansible.Makefile LIMIT_HOSTS := ifneq (,$(HOSTS)) -LIMIT_HOSTS := '-l $(subst ${space},$(comma),$(HOSTS))' +LIMIT_HOSTS := '--limit $(subst ${space},$(comma),$(HOSTS))' endif export LIMIT_TESTS :=
Signature · 1 line
2.49.0
PATCH v2 4/10 Makefile: print target when debug
In reply to Daniel GomezFrom: Daniel Gomez <[email protected]>
When debugging with V=1, print also the Makefile target before the command.
This allows to speciy the target as well as keep verbosity of the command being executed. The only limitations is that commands are printed in one line.
Example:
make V=1
==> [ansible.cfg]
+ ansible-playbook playbooks/ansible_cfg.yml --extra-vars=@./.extra_vars_auto.yaml [WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are modifying the Ansible engine, or trying out features under development. This is a rapidly changing source of code and can become unstable at any point.
PLAY 1: ANSIBLE CONFIGURATION ROLE
task 1. [started TASK: Gathering Facts on localhost]
task 2. [started TASK: ansible_cfg : Import optional extra_args file on localhost] task 3. [started TASK: ansible_cfg : Generate kdevops ansible.cfg on localhost]
==> [inventory]
+ ansible-playbook playbooks/gen_hosts.yml --extra-vars=@./extra_vars.yaml {...}
Before:
make V=1
[WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are modifying the Ansible engine, or trying out features under development. This is a rapidly changing source of code and can become unstable at any point.
PLAY 1: ANSIBLE CONFIGURATION ROLE
task 1. [started TASK: Gathering Facts on localhost]
task 2. [started TASK: ansible_cfg : Import optional extra_args file on localhost] task 3. [started TASK: ansible_cfg : Generate kdevops ansible.cfg on localhost]
ansible-playbook \
playbooks/gen_hosts.yml \
--extra-vars=@./extra_vars.yaml[WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are modifying the Ansible engine, or trying out features under development. This is a rapidly changing source of code and can become unstable at any point. PLAY 1: GEN_HOSTS
task 1. [started TASK: Gathering Facts on localhost]
{...}
--- Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Makefile +5 -1
@@ -38,8 +38,12 @@ KDEVOPS_DEPCHECK = .kdevops.depcheck PHONY += kconfig-help-menu +define print_target + echo "==> [$1]" +endef + ifeq ($(V),1) -export Q= +export Q=@$(call print_target,$@) && set -x && export NQ=true else export Q=@
Signature · 1 line
2.49.0
PATCH v2 5/10 .github/workflows/fstests.yml: enable make verbosity
In reply to Daniel GomezFrom: Daniel Gomez <[email protected]>
This prints the commands as well as the Makefile target being run.
--- .github/workflows/fstests.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
.github/workflows/fstests.yml +8 -8
@@ -44,23 +44,23 @@ jobs: - name: Run kdevops make run: | - make -j$(nproc) + make V=1 -j$(nproc) - name: Run kdevops make bringup run: | - make bringup + make V=1 bringup - name: Build linux and boot test nodes on test kernel run: | - make linux + make V=1 linux - name: Build fstests run: | - make fstests + make V=1 fstests - name: Run just one fstest to verify we tests and test collection works run: | - make fstests-baseline TESTS=generic/003 + make V=1 fstests-baseline TESTS=generic/003 echo "ok" > ci.result find workflows/fstests/results/last-run -name xunit_results.txt -type f -exec cat {} \; > ci.commit_extra || true if ! grep -E "failures, [1-9]|errors, [1-9]" ci.commit_extra; then
@@ -70,7 +70,7 @@ jobs: - name: Get systemd journal files if: always() # This ensures the step runs even if previous steps failed run: | - make journal-dump + make V=1 journal-dump - name: Start SSH Agent if: always() # Ensure this step runs even if previous steps failed
@@ -81,7 +81,7 @@ jobs: - name: Build our kdevops archive results if: always() # This ensures the step runs even if previous steps failed run: | - make ci-archive + make V=1 ci-archive - name: Upload our kdevops results archive if: always() # This ensures the step runs even if previous steps failed
@@ -94,4 +94,4 @@ jobs: - name: Run kdevops make destroy if: always() # This ensures the step runs even if previous steps failed run: | - make destroy + make V=1 destroy
Signature · 1 line
2.49.0
PATCH v2 6/10 ansible_cfg: add inventory support
In reply to Daniel GomezFrom: Daniel Gomez <[email protected]>
Allow to configure the inventory file (currently via KDEVOPS_HOSTFILE and KDEVOPS_HOSTS) via ansible.cfg.
The Ansible inventory file [1][2][3] is used in all kdevops/Makefile ansible-playbook calls. Enable this configuration to the global Ansible configuration file (ansible.cfg) and allow to define the inventory via Kconfig. This will simplify the playbook invocation.
[1]
https://docs.ansible.com/ansible/latest/reference_appendices/
config.html#default-host-list
[2]
https://docs.ansible.com/ansible/latest/cli/
ansible-inventory.html#cmdoption-ansible-inventory-i
[3]
https://docs.ansible.com/ansible/latest/reference_appendices/
config.html#envvar-ANSIBLE_INVENTORY
This has no effect yet, as all ansible-playbook calls currently specify the --inventory (-i) argument. The next commits will clean up the code and allow the inventory defined in ansible.cfg to take effect.
Keep the ANSIBLE_CFG_ prefix to refer to the kdevops Ansible configuration module. This isn't part of the Ansible config file, but rather of the kdevops module that configures Ansible.
--- kconfigs/Kconfig.ansible_cfg | 18 ++++++++++++++++++ kconfigs/Kconfig.ansible_provisioning | 6 ------ playbooks/roles/ansible_cfg/templates/ansible.cfg.j2 | 1 + 3 files changed, 19 insertions(+), 6 deletions(-)
kconfigs/Kconfig.ansible_cfg +18 -0
@@ -207,6 +207,24 @@ config ANSIBLE_CFG_FORKS endif # !ANSIBLE_CFG_FORKS_CUSTOM +config ANSIBLE_CFG_INVENTORY + string "Ansible inventory sources" + output yaml + default "$(TOPDIR_PATH)/hosts" + help + Comma-separated list of Ansible inventory source paths. + + This is mapped to the [defaults] section of the Ansible configuration + file (ansible.cfg): + inventory = <value> + + Each entry can be a path to an inventory file or directory, + such as: + /path/to/hosts,/path/to/inventory_dir + + For more details, refer to the Ansible documentation: + https://docs.ansible.com/ansible/latest/reference_appendices/config.html#default-host-list + if DISTRO_OPENSUSE config ANSIBLE_CFG_RECONNECTION_RETRIES
kconfigs/Kconfig.ansible_provisioning +0 -6
@@ -98,12 +98,6 @@ config KDEVOPS_DEVCONFIG_SYSTEMD_WATCHDOG_TIMEOUT_KEXEC endif # KDEVOPS_DEVCONFIG_ENABLE_SYSTEMD_WATCHDOG -config KDEVOPS_ANSIBLE_INVENTORY_FILE - string "The ansible inventory file to use" - default $(shell, scripts/append-makefile-vars.sh $(KDEVOPS_HOSTFILE)) - help - The file to use for the ansible inventory. - config HAVE_DISTRO_PREFERS_ANSIBLE_PYTHON2 bool default n
playbooks/roles/ansible_cfg/templates/ansible.cfg.j2 +1 -0
@@ -10,6 +10,7 @@ show_per_host_start = {{ ansible_cfg_callback_plugin_show_per_host_start }} show_task_path_on_failure = {{ ansible_cfg_callback_plugin_show_task_path_on_failure }} interpreter_python = {{ ansible_cfg_interpreter_python_string }} forks = {{ ansible_cfg_forks }} +inventory = {{ ansible_cfg_inventory }} {% if ansible_facts['distribution'] == 'openSUSE' %} [connection] retries = {{ ansible_cfg_reconnection_retries }}
Signature · 1 line
2.49.0
PATCH v2 7/10 gen_hosts: templates: add localhost to all hosts
In reply to Daniel GomezFrom: Daniel Gomez <[email protected]>
This redefines the concept of all targets but allows to really include 'all' hosts in the Ansible inventory file (hosts).
Change playbooks hosts list to exclude localhost when using all.
--- playbooks/blktests.yml | 2 +- playbooks/common.yml | 2 +- playbooks/create_data_partition.yml | 2 +- playbooks/cxl.yml | 2 +- playbooks/devconfig.yml | 2 +- playbooks/fstests.yml | 2 +- playbooks/gitr.yml | 2 +- playbooks/iscsi.yml | 2 +- playbooks/kdc.yml | 2 +- playbooks/krb5.yml | 2 +- playbooks/ktls.yml | 2 +- playbooks/ltp.yml | 2 +- playbooks/nfsd.yml | 2 +- playbooks/nfstest.yml | 2 +- playbooks/pkg.yml | 2 +- playbooks/pynfs.yml | 2 +- playbooks/reboot-limit.yml | 2 +- playbooks/roles/gen_hosts/templates/blktests.j2 | 1 + playbooks/roles/gen_hosts/templates/cxl.j2 | 1 + playbooks/roles/gen_hosts/templates/fstests.j2 | 1 + playbooks/roles/gen_hosts/templates/gitr.j2 | 1 + playbooks/roles/gen_hosts/templates/hosts.j2 | 2 ++ playbooks/roles/gen_hosts/templates/ltp.j2 | 1 + playbooks/roles/gen_hosts/templates/nfstest.j2 | 1 + playbooks/roles/gen_hosts/templates/pynfs.j2 | 1 + playbooks/roles/gen_hosts/templates/selftests.j2 | 1 + playbooks/roles/gen_hosts/templates/sysbench.j2 | 1 + playbooks/rxe.yml | 2 +- playbooks/selftests.yml | 2 +- playbooks/siw.yml | 2 +- playbooks/smbd.yml | 2 +- playbooks/sysbench.yml | 2 +- playbooks/terraform.yml | 2 +- playbooks/update_etc_hosts.yml | 2 +- scripts/guestfs.Makefile | 2 +- workflows/linux/Makefile | 2 +- 36 files changed, 37 insertions(+), 26 deletions(-)
playbooks/blktests.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: blktests - hosts: all + hosts: all:!localhost roles: - role: blktests
playbooks/common.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: common - hosts: all + hosts: all:!localhost roles: - role: common
playbooks/create_data_partition.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: create_data_partition - hosts: all + hosts: all:!localhost roles: - role: create_data_partition
playbooks/cxl.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: cxl - hosts: all + hosts: all:!localhost roles: - role: cxl
playbooks/devconfig.yml +1 -1
@@ -1,6 +1,6 @@ --- - name: devconfig - hosts: all + hosts: all:!localhost gather_facts: no roles: - role: devconfig
playbooks/fstests.yml +1 -1
@@ -4,6 +4,6 @@ roles: - role: fstests_prep_localhost -- hosts: all +- hosts: all:!localhost roles: - role: fstests
playbooks/gitr.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: gitr - hosts: all + hosts: all:!localhost roles: - role: gitr
playbooks/iscsi.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: iscsi - hosts: all + hosts: all:!localhost roles: - role: iscsi
playbooks/kdc.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: kdc - hosts: all + hosts: all:!localhost roles: - role: kdc
playbooks/krb5.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: krb5 - hosts: all + hosts: all:!localhost roles: - role: krb5
playbooks/ktls.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: ktls - hosts: all + hosts: all:!localhost roles: - role: ktls
playbooks/ltp.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: ltp - hosts: all + hosts: all:!localhost roles: - role: ltp
playbooks/nfsd.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: nfsd - hosts: all + hosts: all:!localhost roles: - role: nfsd
playbooks/nfstest.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: nfstest - hosts: all + hosts: all:!localhost roles: - role: nfstest
playbooks/pkg.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: pkg - hosts: all + hosts: all:!localhost roles: - role: pkg
playbooks/pynfs.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: pynfs - hosts: all + hosts: all:!localhost roles: - role: pynfs
playbooks/reboot-limit.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: reboot-limit - hosts: all + hosts: all:!localhost roles: - role: reboot-limit
playbooks/roles/gen_hosts/templates/blktests.j2 +1 -0
@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for test_type in blktests_enabled_test_types %} {{ kdevops_host_prefix }}-{{ test_type }} {% if kdevops_baseline_and_dev %}
playbooks/roles/gen_hosts/templates/cxl.j2 +1 -0
@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {{ kdevops_hosts_prefix }} {% if kdevops_baseline_and_dev == True %} {{ kdevops_hosts_prefix }}-dev
playbooks/roles/gen_hosts/templates/fstests.j2 +1 -0
@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in fstests_enabled_test_types %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}
playbooks/roles/gen_hosts/templates/gitr.j2 +1 -0
@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in gitr_enabled_hosts %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}
playbooks/roles/gen_hosts/templates/hosts.j2 +2 -0
@@ -7,9 +7,11 @@ its own jinja2 template file and define its own ansible task for its generation. #} {% if kdevops_workflows_dedicated_workflow %} [all] +localhost ansible_connection=local write-your-own-template-for-your-workflow-and-task {% else %} [all] +localhost ansible_connection=local {{ kdevops_hosts_prefix }} {% if kdevops_baseline_and_dev == True %} {{ kdevops_hosts_prefix }}-dev
playbooks/roles/gen_hosts/templates/ltp.j2 +1 -0
@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in ltp_enabled_hosts %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}
playbooks/roles/gen_hosts/templates/nfstest.j2 +1 -0
@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in nfstest_enabled_hosts %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}
playbooks/roles/gen_hosts/templates/pynfs.j2 +1 -0
@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {{ kdevops_hosts_prefix }}-nfsd [all:vars] ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
playbooks/roles/gen_hosts/templates/selftests.j2 +1 -0
@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for test_type in selftests_enabled_test_types %} {{ kdevops_host_prefix }}-{{ test_type }} {% if kdevops_baseline_and_dev %}
playbooks/roles/gen_hosts/templates/sysbench.j2 +1 -0
@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for test_type in enabled_sysbench_tests %} {{ kdevops_host_prefix }}-{{ test_type }} {% if kdevops_baseline_and_dev %}
playbooks/rxe.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: rxe - hosts: all + hosts: all:!localhost roles: - role: rxe
playbooks/selftests.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: selftests - hosts: all + hosts: all:!localhost roles: - role: selftests
playbooks/siw.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: siw - hosts: all + hosts: all:!localhost roles: - role: siw
playbooks/smbd.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: smbd - hosts: all + hosts: all:!localhost roles: - role: smbd
playbooks/sysbench.yml +1 -1
@@ -1,5 +1,5 @@ --- - name: sysbench - hosts: all + hosts: all:!localhost roles: - role: sysbench
playbooks/terraform.yml +1 -1
@@ -1,6 +1,6 @@ --- - name: terraform - hosts: all + hosts: all:!localhost gather_facts: false roles: - role: terraform
playbooks/update_etc_hosts.yml +1 -1
@@ -1,6 +1,6 @@ --- - name: update_etc_hosts - hosts: all + hosts: all:!localhost gather_facts: no roles: - role: update_etc_hosts
scripts/guestfs.Makefile +1 -1
@@ -64,7 +64,7 @@ $(KDEVOPS_PROVISIONED_SSH): LIBVIRT_DEFAULT_URI=$(CONFIG_LIBVIRT_URI) \ $(TOPDIR)/scripts/update_ssh_config_guestfs.py; \ fi - $(Q)ansible $(ANSIBLE_VERBOSE) -i hosts all -m wait_for_connection + $(Q)ansible $(ANSIBLE_VERBOSE) -i hosts 'all:!localhost' -m wait_for_connection $(Q)touch $(KDEVOPS_PROVISIONED_SSH) install_libguestfs:
workflows/linux/Makefile +1 -1
@@ -157,7 +157,7 @@ linux-reboot: PHONY += uname uname: - $(Q)ansible all -i hosts -b -m command -a "uname -r" -o \ + $(Q)ansible 'all:!localhost' -i hosts -b -m command -a "uname -r" -o \ | awk -F '|' '{gsub(/^ +| +$$/, "", $$2); printf "%-30s %s\n", $$1, $$4}' \ | sed -e 's|(stdout)||'
Signature · 1 line
2.49.0
Re: [PATCH v2 07/10] gen_hosts: templates: add localhost to all hosts
Quoted 440 lines · Daniel Gomez
From: Daniel Gomez <[email protected]>
This redefines the concept of all targets but allows to really include 'all' hosts in the Ansible inventory file (hosts).
Change playbooks hosts list to exclude localhost when using all.
Signed-off-by Daniel Gomez <[email protected]>--- playbooks/blktests.yml | 2 +- playbooks/common.yml | 2 +- playbooks/create_data_partition.yml | 2 +- playbooks/cxl.yml | 2 +- playbooks/devconfig.yml | 2 +- playbooks/fstests.yml | 2 +- playbooks/gitr.yml | 2 +- playbooks/iscsi.yml | 2 +- playbooks/kdc.yml | 2 +- playbooks/krb5.yml | 2 +- playbooks/ktls.yml | 2 +- playbooks/ltp.yml | 2 +- playbooks/nfsd.yml | 2 +- playbooks/nfstest.yml | 2 +- playbooks/pkg.yml | 2 +- playbooks/pynfs.yml | 2 +- playbooks/reboot-limit.yml | 2 +- playbooks/roles/gen_hosts/templates/blktests.j2 | 1 + playbooks/roles/gen_hosts/templates/cxl.j2 | 1 + playbooks/roles/gen_hosts/templates/fstests.j2 | 1 + playbooks/roles/gen_hosts/templates/gitr.j2 | 1 + playbooks/roles/gen_hosts/templates/hosts.j2 | 2 ++ playbooks/roles/gen_hosts/templates/ltp.j2 | 1 + playbooks/roles/gen_hosts/templates/nfstest.j2 | 1 + playbooks/roles/gen_hosts/templates/pynfs.j2 | 1 + playbooks/roles/gen_hosts/templates/selftests.j2 | 1 + playbooks/roles/gen_hosts/templates/sysbench.j2 | 1 + playbooks/rxe.yml | 2 +- playbooks/selftests.yml | 2 +- playbooks/siw.yml | 2 +- playbooks/smbd.yml | 2 +- playbooks/sysbench.yml | 2 +- playbooks/terraform.yml | 2 +- playbooks/update_etc_hosts.yml | 2 +- scripts/guestfs.Makefile | 2 +- workflows/linux/Makefile | 2 +- 36 files changed, 37 insertions(+), 26 deletions(-)playbooks/blktests.yml +1
-1@@ -1,5 +1,5 @@ --- - name: blktests - hosts: all + hosts: all:!localhost roles: - role: blktestsplaybooks/common.yml +1
-1@@ -1,5 +1,5 @@ --- - name: common - hosts: all + hosts: all:!localhost roles: - role: commonplaybooks/create_data_partition.yml +1
-1@@ -1,5 +1,5 @@ --- - name: create_data_partition - hosts: all + hosts: all:!localhost roles: - role: create_data_partitionplaybooks/cxl.yml +1
-1@@ -1,5 +1,5 @@ --- - name: cxl - hosts: all + hosts: all:!localhost roles: - role: cxlplaybooks/devconfig.yml +1
-1@@ -1,6 +1,6 @@ --- - name: devconfig - hosts: all + hosts: all:!localhost gather_facts: no roles: - role: devconfigplaybooks/fstests.yml +1
-1@@ -4,6 +4,6 @@ roles: - role: fstests_prep_localhost -- hosts: all +- hosts: all:!localhost roles: - role: fstestsplaybooks/gitr.yml +1
-1@@ -1,5 +1,5 @@ --- - name: gitr - hosts: all + hosts: all:!localhost roles: - role: gitrplaybooks/iscsi.yml +1
-1@@ -1,5 +1,5 @@ --- - name: iscsi - hosts: all + hosts: all:!localhost roles: - role: iscsiplaybooks/kdc.yml +1
-1@@ -1,5 +1,5 @@ --- - name: kdc - hosts: all + hosts: all:!localhost roles: - role: kdcplaybooks/krb5.yml +1
-1@@ -1,5 +1,5 @@ --- - name: krb5 - hosts: all + hosts: all:!localhost roles: - role: krb5playbooks/ktls.yml +1
-1@@ -1,5 +1,5 @@ --- - name: ktls - hosts: all + hosts: all:!localhost roles: - role: ktlsplaybooks/ltp.yml +1
-1@@ -1,5 +1,5 @@ --- - name: ltp - hosts: all + hosts: all:!localhost roles: - role: ltpplaybooks/nfsd.yml +1
-1@@ -1,5 +1,5 @@ --- - name: nfsd - hosts: all + hosts: all:!localhost roles: - role: nfsdplaybooks/nfstest.yml +1
-1@@ -1,5 +1,5 @@ --- - name: nfstest - hosts: all + hosts: all:!localhost roles: - role: nfstestplaybooks/pkg.yml +1
-1@@ -1,5 +1,5 @@ --- - name: pkg - hosts: all + hosts: all:!localhost roles: - role: pkgplaybooks/pynfs.yml +1
-1@@ -1,5 +1,5 @@ --- - name: pynfs - hosts: all + hosts: all:!localhost roles: - role: pynfsplaybooks/reboot-limit.yml +1
-1@@ -1,5 +1,5 @@ --- - name: reboot-limit - hosts: all + hosts: all:!localhost roles: - role: reboot-limitplaybooks/roles/gen_hosts/templates/blktests.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for test_type in blktests_enabled_test_types %} {{ kdevops_host_prefix }}-{{ test_type }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/cxl.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {{ kdevops_hosts_prefix }} {% if kdevops_baseline_and_dev == True %} {{ kdevops_hosts_prefix }}-devplaybooks/roles/gen_hosts/templates/fstests.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in fstests_enabled_test_types %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/gitr.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in gitr_enabled_hosts %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/hosts.j2 +2
-0@@ -7,9 +7,11 @@ its own jinja2 template file and define its own ansible task for its generation. #} {% if kdevops_workflows_dedicated_workflow %} [all] +localhost ansible_connection=local write-your-own-template-for-your-workflow-and-task {% else %} [all] +localhost ansible_connection=local {{ kdevops_hosts_prefix }} {% if kdevops_baseline_and_dev == True %} {{ kdevops_hosts_prefix }}-devplaybooks/roles/gen_hosts/templates/ltp.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in ltp_enabled_hosts %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/nfstest.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in nfstest_enabled_hosts %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/pynfs.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {{ kdevops_hosts_prefix }}-nfsd [all:vars] ansible_python_interpreter = "{{ kdevops_python_interpreter }}"playbooks/roles/gen_hosts/templates/selftests.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for test_type in selftests_enabled_test_types %} {{ kdevops_host_prefix }}-{{ test_type }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/sysbench.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for test_type in enabled_sysbench_tests %} {{ kdevops_host_prefix }}-{{ test_type }} {% if kdevops_baseline_and_dev %}playbooks/rxe.yml +1
-1@@ -1,5 +1,5 @@ --- - name: rxe - hosts: all + hosts: all:!localhost roles: - role: rxeplaybooks/selftests.yml +1
-1@@ -1,5 +1,5 @@ --- - name: selftests - hosts: all + hosts: all:!localhost roles: - role: selftestsplaybooks/siw.yml +1
-1@@ -1,5 +1,5 @@ --- - name: siw - hosts: all + hosts: all:!localhost roles: - role: siwplaybooks/smbd.yml +1
-1@@ -1,5 +1,5 @@ --- - name: smbd - hosts: all + hosts: all:!localhost roles: - role: smbdplaybooks/sysbench.yml +1
-1@@ -1,5 +1,5 @@ --- - name: sysbench - hosts: all + hosts: all:!localhost roles: - role: sysbenchplaybooks/terraform.yml +1
-1@@ -1,6 +1,6 @@ --- - name: terraform - hosts: all + hosts: all:!localhost gather_facts: false roles: - role: terraformplaybooks/update_etc_hosts.yml +1
-1@@ -1,6 +1,6 @@ --- - name: update_etc_hosts - hosts: all + hosts: all:!localhost gather_facts: no roles: - role: update_etc_hostsscripts/guestfs.Makefile +1
-1@@ -64,7 +64,7 @@ $(KDEVOPS_PROVISIONED_SSH): LIBVIRT_DEFAULT_URI=$(CONFIG_LIBVIRT_URI) \ $(TOPDIR)/scripts/update_ssh_config_guestfs.py; \ fi - $(Q)ansible $(ANSIBLE_VERBOSE) -i hosts all -m wait_for_connection + $(Q)ansible $(ANSIBLE_VERBOSE) -i hosts 'all:!localhost' -m wait_for_connection $(Q)touch $(KDEVOPS_PROVISIONED_SSH) install_libguestfs:workflows/linux/Makefile +0
-0
workflows/linux/Makefile linux-reboot: · line 163
Quoted 8 lines
workflows/linux/Makefile +1
-1@@ -157,7 +157,7 @@ linux-reboot: PHONY += uname uname: - $(Q)ansible all -i hosts -b -m command -a "uname -r" -o \ + $(Q)ansible 'all:!localhost' -i hosts -b -m command -a "uname -r" -o \ | awk -F '|' '{gsub(/^ +| +$$/, "", $$2); printf "%-30s %s\n", $$1, $$4}' \ | sed -e 's|(stdout)||'
After this commit is applied, "make bringup" fails with:
task path:/home/cel/src/kdevops/buildbot-configs/playbooks/roles/update_etc_hosts/tasks/main.yml:61
fatal: [cel-nfsd]: FAILED! => {}
MSG:
The task includes an option with an undefined variable. The error was:
'ansible.vars.hostvars.HostVarsVars object' has no attribute 'ansible_all_ipv4_addresses'. 'ansible.vars.hostvars.HostVarsVars object' has no attribute 'ansible_all_ipv4_addresses'
The error appears to be in '/home/cel/src/kdevops/buildbot-configs/playbooks/roles/update_etc_hosts/tasks/main.yml':
line 61, column 3, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
- name: Add IP address of all hosts to all hosts
^ here
Signature · 1 line
Chuck Lever
Re: [PATCH v2 07/10] gen_hosts: templates: add localhost to all hosts
Quoted 468 lines · Chuck Lever
Quoted 440 lines · Daniel Gomez
From: Daniel Gomez <[email protected]>
This redefines the concept of all targets but allows to really include 'all' hosts in the Ansible inventory file (hosts).
Change playbooks hosts list to exclude localhost when using all.
Signed-off-by Daniel Gomez <[email protected]>--- playbooks/blktests.yml | 2 +- playbooks/common.yml | 2 +- playbooks/create_data_partition.yml | 2 +- playbooks/cxl.yml | 2 +- playbooks/devconfig.yml | 2 +- playbooks/fstests.yml | 2 +- playbooks/gitr.yml | 2 +- playbooks/iscsi.yml | 2 +- playbooks/kdc.yml | 2 +- playbooks/krb5.yml | 2 +- playbooks/ktls.yml | 2 +- playbooks/ltp.yml | 2 +- playbooks/nfsd.yml | 2 +- playbooks/nfstest.yml | 2 +- playbooks/pkg.yml | 2 +- playbooks/pynfs.yml | 2 +- playbooks/reboot-limit.yml | 2 +- playbooks/roles/gen_hosts/templates/blktests.j2 | 1 + playbooks/roles/gen_hosts/templates/cxl.j2 | 1 + playbooks/roles/gen_hosts/templates/fstests.j2 | 1 + playbooks/roles/gen_hosts/templates/gitr.j2 | 1 + playbooks/roles/gen_hosts/templates/hosts.j2 | 2 ++ playbooks/roles/gen_hosts/templates/ltp.j2 | 1 + playbooks/roles/gen_hosts/templates/nfstest.j2 | 1 + playbooks/roles/gen_hosts/templates/pynfs.j2 | 1 + playbooks/roles/gen_hosts/templates/selftests.j2 | 1 + playbooks/roles/gen_hosts/templates/sysbench.j2 | 1 + playbooks/rxe.yml | 2 +- playbooks/selftests.yml | 2 +- playbooks/siw.yml | 2 +- playbooks/smbd.yml | 2 +- playbooks/sysbench.yml | 2 +- playbooks/terraform.yml | 2 +- playbooks/update_etc_hosts.yml | 2 +- scripts/guestfs.Makefile | 2 +- workflows/linux/Makefile | 2 +- 36 files changed, 37 insertions(+), 26 deletions(-)playbooks/blktests.yml +1
-1@@ -1,5 +1,5 @@ --- - name: blktests - hosts: all + hosts: all:!localhost roles: - role: blktestsplaybooks/common.yml +1
-1@@ -1,5 +1,5 @@ --- - name: common - hosts: all + hosts: all:!localhost roles: - role: commonplaybooks/create_data_partition.yml +1
-1@@ -1,5 +1,5 @@ --- - name: create_data_partition - hosts: all + hosts: all:!localhost roles: - role: create_data_partitionplaybooks/cxl.yml +1
-1@@ -1,5 +1,5 @@ --- - name: cxl - hosts: all + hosts: all:!localhost roles: - role: cxlplaybooks/devconfig.yml +1
-1@@ -1,6 +1,6 @@ --- - name: devconfig - hosts: all + hosts: all:!localhost gather_facts: no roles: - role: devconfigplaybooks/fstests.yml +1
-1@@ -4,6 +4,6 @@ roles: - role: fstests_prep_localhost -- hosts: all +- hosts: all:!localhost roles: - role: fstestsplaybooks/gitr.yml +1
-1@@ -1,5 +1,5 @@ --- - name: gitr - hosts: all + hosts: all:!localhost roles: - role: gitrplaybooks/iscsi.yml +1
-1@@ -1,5 +1,5 @@ --- - name: iscsi - hosts: all + hosts: all:!localhost roles: - role: iscsiplaybooks/kdc.yml +1
-1@@ -1,5 +1,5 @@ --- - name: kdc - hosts: all + hosts: all:!localhost roles: - role: kdcplaybooks/krb5.yml +1
-1@@ -1,5 +1,5 @@ --- - name: krb5 - hosts: all + hosts: all:!localhost roles: - role: krb5playbooks/ktls.yml +1
-1@@ -1,5 +1,5 @@ --- - name: ktls - hosts: all + hosts: all:!localhost roles: - role: ktlsplaybooks/ltp.yml +1
-1@@ -1,5 +1,5 @@ --- - name: ltp - hosts: all + hosts: all:!localhost roles: - role: ltpplaybooks/nfsd.yml +1
-1@@ -1,5 +1,5 @@ --- - name: nfsd - hosts: all + hosts: all:!localhost roles: - role: nfsdplaybooks/nfstest.yml +1
-1@@ -1,5 +1,5 @@ --- - name: nfstest - hosts: all + hosts: all:!localhost roles: - role: nfstestplaybooks/pkg.yml +1
-1@@ -1,5 +1,5 @@ --- - name: pkg - hosts: all + hosts: all:!localhost roles: - role: pkgplaybooks/pynfs.yml +1
-1@@ -1,5 +1,5 @@ --- - name: pynfs - hosts: all + hosts: all:!localhost roles: - role: pynfsplaybooks/reboot-limit.yml +1
-1@@ -1,5 +1,5 @@ --- - name: reboot-limit - hosts: all + hosts: all:!localhost roles: - role: reboot-limitplaybooks/roles/gen_hosts/templates/blktests.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for test_type in blktests_enabled_test_types %} {{ kdevops_host_prefix }}-{{ test_type }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/cxl.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {{ kdevops_hosts_prefix }} {% if kdevops_baseline_and_dev == True %} {{ kdevops_hosts_prefix }}-devplaybooks/roles/gen_hosts/templates/fstests.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in fstests_enabled_test_types %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/gitr.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in gitr_enabled_hosts %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/hosts.j2 +2
-0@@ -7,9 +7,11 @@ its own jinja2 template file and define its own ansible task for its generation. #} {% if kdevops_workflows_dedicated_workflow %} [all] +localhost ansible_connection=local write-your-own-template-for-your-workflow-and-task {% else %} [all] +localhost ansible_connection=local {{ kdevops_hosts_prefix }} {% if kdevops_baseline_and_dev == True %} {{ kdevops_hosts_prefix }}-devplaybooks/roles/gen_hosts/templates/ltp.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in ltp_enabled_hosts %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/nfstest.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for s in nfstest_enabled_hosts %} {{ kdevops_host_prefix }}-{{ s }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/pynfs.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {{ kdevops_hosts_prefix }}-nfsd [all:vars] ansible_python_interpreter = "{{ kdevops_python_interpreter }}"playbooks/roles/gen_hosts/templates/selftests.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for test_type in selftests_enabled_test_types %} {{ kdevops_host_prefix }}-{{ test_type }} {% if kdevops_baseline_and_dev %}playbooks/roles/gen_hosts/templates/sysbench.j2 +1
-0@@ -1,4 +1,5 @@ [all] +localhost ansible_connection=local {% for test_type in enabled_sysbench_tests %} {{ kdevops_host_prefix }}-{{ test_type }} {% if kdevops_baseline_and_dev %}playbooks/rxe.yml +1
-1@@ -1,5 +1,5 @@ --- - name: rxe - hosts: all + hosts: all:!localhost roles: - role: rxeplaybooks/selftests.yml +1
-1@@ -1,5 +1,5 @@ --- - name: selftests - hosts: all + hosts: all:!localhost roles: - role: selftestsplaybooks/siw.yml +1
-1@@ -1,5 +1,5 @@ --- - name: siw - hosts: all + hosts: all:!localhost roles: - role: siwplaybooks/smbd.yml +1
-1@@ -1,5 +1,5 @@ --- - name: smbd - hosts: all + hosts: all:!localhost roles: - role: smbdplaybooks/sysbench.yml +1
-1@@ -1,5 +1,5 @@ --- - name: sysbench - hosts: all + hosts: all:!localhost roles: - role: sysbenchplaybooks/terraform.yml +1
-1@@ -1,6 +1,6 @@ --- - name: terraform - hosts: all + hosts: all:!localhost gather_facts: false roles: - role: terraformplaybooks/update_etc_hosts.yml +1
-1@@ -1,6 +1,6 @@ --- - name: update_etc_hosts - hosts: all + hosts: all:!localhost gather_facts: no roles: - role: update_etc_hostsscripts/guestfs.Makefile +1
-1@@ -64,7 +64,7 @@ $(KDEVOPS_PROVISIONED_SSH): LIBVIRT_DEFAULT_URI=$(CONFIG_LIBVIRT_URI) \ $(TOPDIR)/scripts/update_ssh_config_guestfs.py; \ fi - $(Q)ansible $(ANSIBLE_VERBOSE) -i hosts all -m wait_for_connection + $(Q)ansible $(ANSIBLE_VERBOSE) -i hosts 'all:!localhost' -m wait_for_connection $(Q)touch $(KDEVOPS_PROVISIONED_SSH) install_libguestfs:workflows/linux/Makefile +0
-0workflows/linux/Makefile linux-reboot: · line 163
Quoted 8 lines
workflows/linux/Makefile +1
-1@@ -157,7 +157,7 @@ linux-reboot: PHONY += uname uname: - $(Q)ansible all -i hosts -b -m command -a "uname -r" -o \ + $(Q)ansible 'all:!localhost' -i hosts -b -m command -a "uname -r" -o \ | awk -F '|' '{gsub(/^ +| +$$/, "", $$2); printf "%-30s %s\n", $$1, $$4}' \ | sed -e 's|(stdout)||'After this commit is applied, "make bringup" fails with:
task path:
/home/cel/src/kdevops/buildbot-configs/playbooks/roles/update_etc_hosts/tasks/main.yml:61
fatal: [cel-nfsd]: FAILED! => {}MSG:
The task includes an option with an undefined variable. The error was:
'ansible.vars.hostvars.HostVarsVars object' has no attribute 'ansible_all_ipv4_addresses'. 'ansible.vars.hostvars.HostVarsVars object' has no attribute 'ansible_all_ipv4_addresses'The error appears to be in '
/home/cel/src/kdevops/buildbot-configs/playbooks/roles/update_etc_hosts/tasks/main.yml':
line 61, column 3, but may
be elsewhere in the file depending on the exact syntax problem.
Quoted 5 lines
The offending line appears to be:
- name: Add IP address of all hosts to all hosts
^ here
IIRC, I fixed that error. So, probably the hunk below it's applied to the wrong commit. I'll double check.
Thanks!
playbooks/roles/update_etc_hosts/tasks/main.yml +1 -1
@@ -26,7 +26,7 @@ - name: Build list of hosts set_fact: - ueh_hosts: "{{ groups.all | flatten(levels=1) | reject('eq', inventory_hostname) }}" + ueh_hosts: "{{ ansible_play_hosts_all | difference([inventory_hostname]) }}" - debug: var: ueh_hosts
Quoted 4 lines
Signature · 2 lines
-- Chuck Lever
PATCH v2 8/10 Makefile: use inventory from ansible.cfg
In reply to Daniel GomezFrom: Daniel Gomez <[email protected]>
We can define the Ansible inventory via ansible.cfg inventory variable. Make use of it and remove all the -i/--inventory arguments in all the ansible-playbook calls.
Target control is now handled in 2 different ways:
- At playbook (hosts: <targets>): E.g. all, all!localhost (all targets except localhost), localhost. An alternative to all!localhost is to define all the groups such as baseline,dev. The former option was chosen for brevity.
So, most of the playbooks have been converted from all -> all!localhosts. Except for bootlinux playbook, where all is kept as the playbook runs limited to localhost in linux-clone-9p and limited to all:!localhosts for the rest of the targets.
- At command line: ansible-playbook --limit 'SUBSET'. In order to control the hosts when the playbook defines something wider (such as the case where we want to run only on baseline targets for example), we use the ansible-playbook argument --limit.
Use --limits argument with the proper syntax [1]: with quotes and colons (for list of targets or group of targets).
Ensure the target string written to the file excludes the double quotes. Their presence caused the Makefile target to be triggered every time.
[1]
https://docs.ansible.com/ansible/latest/inventory_guide/intro_patterns.html
--- Makefile | 21 ++++----- Makefile.btrfs_progs | 4 +- Makefile.build_qemu | 12 ++--- Makefile.hypervisor-tunings | 3 +- Makefile.kdevops | 19 +++----- Makefile.linux-mirror | 6 +-- Makefile.postfix | 3 +- playbooks/roles/gen_hosts/defaults/main.yml | 1 - playbooks/roles/gen_hosts/tasks/main.yml | 52 ++++++++++----------- playbooks/roles/update_etc_hosts/tasks/main.yml | 2 +- scripts/archive.Makefile | 3 +- scripts/devconfig.Makefile | 8 ++-- scripts/dynamic-pci-kconfig.Makefile | 3 +- scripts/firstconfig.Makefile | 5 +- scripts/gen-hosts.Makefile | 1 - scripts/guestfs.Makefile | 17 +++---- scripts/install-menuconfig-deps.Makefile | 3 +- scripts/iscsi.Makefile | 2 +- scripts/journal-server.Makefile | 23 ++++++---- scripts/kotd.Makefile | 16 ++++--- scripts/krb5.Makefile | 4 +- scripts/ktls.Makefile | 1 - scripts/nfsd.Makefile | 2 +- scripts/provision.Makefile | 5 +- scripts/rdma.Makefile | 2 - scripts/smbd.Makefile | 2 +- scripts/systemd-timesync.Makefile | 8 ++-- scripts/terraform.Makefile | 6 +-- scripts/update_etc_hosts.Makefile | 2 +- scripts/vagrant.Makefile | 10 ++-- scripts/workflows/lib/crash.py | 4 +- workflows/blktests/Makefile | 20 +++++--- workflows/common/Makefile | 2 +- workflows/cxl/Makefile | 14 +++--- workflows/demos/reboot-limit/Makefile | 32 ++++++++----- workflows/fstests/Makefile | 40 ++++++++++------ workflows/gitr/Makefile | 8 ++-- workflows/linux/Makefile | 61 ++++++++++++++++--------- workflows/ltp/Makefile | 8 ++-- workflows/nfstest/Makefile | 8 ++-- workflows/pynfs/Makefile | 12 ++--- workflows/selftests/Makefile | 11 +++-- workflows/sysbench/Makefile | 12 ++--- 43 files changed, 248 insertions(+), 230 deletions(-)
Makefile +9 -12
@@ -15,7 +15,6 @@ include Makefile.subtrees export KDEVOPS_EXTRA_VARS ?= extra_vars.yaml export KDEVOPS_PLAYBOOKS_DIR := playbooks -export KDEVOPS_HOSTFILE ?= hosts export KDEVOPS_NODES := export KDEVOPS_VAGRANT := export PYTHONUNBUFFERED=1
@@ -27,6 +26,8 @@ KDEVOPS_NODES_ROLE_TEMPLATE_DIR := $(KDEVOPS_PLAYBOOKS_DIR)/roles/gen_nodes/tem export KDEVOPS_NODES_TEMPLATE := export KDEVOPS_MRPROPER := +ANSIBLE_INVENTORY_FILE := $(shell echo $(CONFIG_ANSIBLE_CFG_INVENTORY) | tr --delete '"') + KDEVOPS_INSTALL_TARGETS := DEFAULT_DEPS :=
@@ -79,8 +80,7 @@ CFLAGS += $(INCLUDES) ANSIBLE_EXTRA_ARGS += kdevops_version='$(PROJECTRELEASE)' -export KDEVOPS_HOSTS_TEMPLATE := $(KDEVOPS_HOSTFILE).j2 -export KDEVOPS_HOSTS := $(KDEVOPS_HOSTFILE) +export KDEVOPS_HOSTS_TEMPLATE := hosts.j2 LOCAL_DEVELOPMENT_ARGS := ifeq (y,$(CONFIG_NEEDS_LOCAL_DEVELOPMENT_PATH))
@@ -198,8 +198,7 @@ include scripts/gen-nodes.Makefile PHONY += ansible.cfg ansible.cfg: - @$(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + @$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/ansible_cfg.yml \ --extra-vars=@./.extra_vars_auto.yaml
@@ -227,17 +226,15 @@ ifneq (,$(KDEVOPS_BRING_UP_DEPS)) include scripts/bringup.Makefile endif -DEFAULT_DEPS += $(KDEVOPS_HOSTS) -$(KDEVOPS_HOSTS): .config ansible.cfg $(KDEVOPS_HOSTS_TEMPLATE) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ +DEFAULT_DEPS += $(ANSIBLE_INVENTORY_FILE) +$(ANSIBLE_INVENTORY_FILE): .config ansible.cfg $(KDEVOPS_HOSTS_TEMPLATE) + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/gen_hosts.yml \ --extra-vars=@./extra_vars.yaml DEFAULT_DEPS += $(KDEVOPS_NODES) $(KDEVOPS_NODES) $(KDEVOPS_VAGRANT): .config ansible.cfg $(KDEVOPS_NODES_TEMPLATE) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/gen_nodes.yml \ --extra-vars=@./extra_vars.yaml
@@ -263,7 +260,7 @@ mrproper: $(Q)rm -f terraform/*/terraform.tfvars $(Q)rm -rf terraform/*/.terraform $(Q)rm -f $(KDEVOPS_NODES) - $(Q)rm -f $(KDEVOPS_HOSTFILE) $(KDEVOPS_MRPROPER) + $(Q)rm -f $(ANSIBLE_CFG_INVENTORY) $(KDEVOPS_MRPROPER) $(Q)rm -f .config .config.old extra_vars.yaml $(KCONFIG_YAMLCFG) $(Q)rm -f ansible.cfg $(Q)rm -f playbooks/secret.yml $(KDEVOPS_EXTRA_ADDON_DEST)
Makefile.btrfs_progs +2 -2
@@ -5,8 +5,8 @@ BTRFS_PROGS_SETUP_ARGS += btrfs_progs_build=True PHONY += btrfs-progs btrfs-progs: $(KDEVOPS_NODES) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \ - $(KDEVOPS_HOSTFILE) $(KDEVOPS_PLAYBOOKS_DIR)/btrfs-progs.yml \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + $(KDEVOPS_PLAYBOOKS_DIR)/btrfs-progs.yml \ --extra-vars=$(BTRFS_PROGS_SETUP_ARGS) $(LIMIT_HOSTS) btrfs-progs-help-menu:
Makefile.build_qemu +4 -8
@@ -20,29 +20,25 @@ QEMU_BUILD_SETUP_ARGS += qemu_target="ppc64-softmmu" endif qemu: $(KDEVOPS_EXTRA_VARS) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/build_qemu.yml \ --extra-vars=@./extra_vars.yaml PHONY += qemu qemu-install: $(KDEVOPS_EXTRA_VARS) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/build_qemu.yml \ --extra-vars=@./extra_vars.yaml --tags vars,install PHONY += qemu-install qemu-configure: $(KDEVOPS_EXTRA_VARS) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/build_qemu.yml \ --extra-vars=@./extra_vars.yaml --tags vars,configure PHONY += qemu-configure qemu-build: $(KDEVOPS_EXTRA_VARS) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/build_qemu.yml \ --extra-vars=@./extra_vars.yaml --tags vars,build PHONY += qemu-build
Makefile.hypervisor-tunings +1 -2
@@ -14,8 +14,7 @@ HYPERVISOR_TUNING_ARGS += hypervisor_tunning_zswap_max_pool_percent=$(ZSWAP_MAX_ endif kdevops_hypervisor_tunning: $(KDEVOPS_EXTRA_VARS) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/hypervisor-tuning.yml \ --extra-vars=@./extra_vars.yaml PHONY += kdevops_hypervisor_tunning
Makefile.kdevops +6 -13
@@ -2,26 +2,22 @@ # allow your project to define these and just include this file. KDEVOPS_TERRAFORM_DIR ?= terraform KDEVOPS_PLAYBOOKS_DIR ?= playbooks -KDEVOPS_HOSTFILE ?= hosts KDEVOPS_LOCAL_WORK := kdevops_all: kdevops_deps PHONY := kdevops_all kdevops_terraform_deps: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/install_terraform.yml PHONY += kdevops_terraform_deps kdevops_install_libvirt: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/libvirt_user.yml -e "skip_configuration=True" kdevops_configure_libvirt: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/libvirt_user.yml -e "skip_install=True" \ -e 'running_user=$(USER)'
@@ -33,23 +29,20 @@ PHONY += kdevops_vagrant_deps KDEVOPS_VAGRANT_WORK := kdevops_vagrant_deps kdevops_vagrant_boxes: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/install_vagrant_boxes.yml PHONY += kdevops_vagrant_boxes KDEVOPS_VAGRANT_WORK += kdevops_vagrant_boxes kdevops_verify_libvirt_user: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/libvirt_user.yml -e "only_verify_user=True" PHONY += kdevops_verify_libvirt_user KDEVOPS_VAGRANT_WORK += kdevops_verify_libvirt_user kdevops_libvirt_storage_pool_create: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/libvirt_storage_pool_create.yml PHONY += kdevops_libvirt_storage_pool_create
Makefile.linux-mirror +2 -4
@@ -25,8 +25,7 @@ endif MIRROR_CODE := $(TOPDIR)/playbooks/roles/linux-mirror/linux-mirror-systemd/ kdevops_linux_mirror: $(KDEVOPS_EXTRA_VARS) - $(Q)ansible-playbook --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook \ --tags vars,mirror \ $(KDEVOPS_PLAYBOOKS_DIR)/linux-mirror.yml \ --extra-vars=@./extra_vars.yaml
@@ -37,8 +36,7 @@ mirror: $(KDEVOPS_EXTRA_VARS) kdevops_linux_mirror PHONY += mirror mirror-status: $(KDEVOPS_EXTRA_VARS) - $(Q)ansible-playbook --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook \ --tags vars,mirror-status \ $(KDEVOPS_PLAYBOOKS_DIR)/linux-mirror.yml \ --extra-vars=@./extra_vars.yaml
Makefile.postfix +1 -2
@@ -7,8 +7,7 @@ POSTFIX_SETUP_ARGS += postfix_relay_host_setup=True POSTFIX_SETUP_ARGS += postfix_relay_host=$(POSTFIX_RELAY_HOST) kdevops_postfix_setup_relay: $(KDEVOPS_EXTRA_VARS) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/postfix_relay_host.yml \ --extra-vars=@./extra_vars.yaml PHONY += kdevos_postfix_setup_relay
playbooks/roles/gen_hosts/defaults/main.yml +0 -1
@@ -6,7 +6,6 @@ hosts_type_generic: True hosts_type_fs: False hosts_type_block: False -kdevops_hosts: "hosts" kdevops_hosts_template: "hosts.in" kdevops_playbooks_dir: "/dev/null" kdevops_genhosts_templates_dir: "/dev/null"
playbooks/roles/gen_hosts/tasks/main.yml +26 -26
175 lines not on this page · raw message
playbooks/roles/update_etc_hosts/tasks/main.yml +1 -1
@@ -26,7 +26,7 @@ - name: Build list of hosts set_fact: - ueh_hosts: "{{ groups.all | flatten(levels=1) | reject('eq', inventory_hostname) }}" + ueh_hosts: "{{ ansible_play_hosts_all | difference([inventory_hostname]) }}" - debug: var: ueh_hosts
scripts/archive.Makefile +1 -2
@@ -13,8 +13,7 @@ ARCHIVE_DYNAMIC_RUNTIME_VARS += \ endif ci-archive: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/kdevops_archive.yml \ --extra-vars '{ $(ARCHIVE_DYNAMIC_RUNTIME_VARS) }' \ --extra-vars=@./extra_vars.yaml
scripts/devconfig.Makefile +4 -4
@@ -56,8 +56,8 @@ extend-extra-args-devconfig: PHONY += devconfig devconfig: $(KDEVOPS_NODES) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i $(KDEVOPS_HOSTFILE) \ - -l all,nfsd \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'all:!localhost' \ $(KDEVOPS_PLAYBOOKS_DIR)/devconfig.yml \ --extra-vars="$(BOOTLINUX_ARGS)" \ --extra-vars '{ kdevops_cli_install: True }' \
@@ -71,8 +71,8 @@ HELP_TARGETS+=devconfig-generic-help-menu ifeq (y,$(CONFIG_SYSCTL_TUNING)) PHONY += sysctl-tunings sysctl-tunings: $(KDEVOPS_NODES) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i $(KDEVOPS_HOSTFILE) \ - -l all,nfsd \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'all:!localhost' \ $(KDEVOPS_PLAYBOOKS_DIR)/devconfig.yml \ --extra-vars="$(BOOTLINUX_ARGS)" $(LIMIT_HOSTS) --tags vars,sysctl
scripts/dynamic-pci-kconfig.Makefile +1 -2
@@ -42,8 +42,7 @@ endif # CONFIG_KDEVOPS_LIBVIRT_PCIE_PASSTHROUGH HELP_TARGETS += dynamic-kconfig-pci-help dynamic_pcipassthrough_kconfig: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/gen-pci-kconfig.yml \ --extra-vars '{ $(PCIE_RUNTIME_VARS) }'
scripts/firstconfig.Makefile +3 -2
@@ -1,8 +1,9 @@ # SPDX-License-Identifier: copyleft-next-0.3.1 firstconfig: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \ - -i hosts --extra-vars '{ kdevops_cli_install: True }' \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'baseline:dev' \ + --extra-vars '{ kdevops_cli_install: True }' \ --tags vars_simple,firstconfig \ $(KDEVOPS_PLAYBOOKS_DIR)/devconfig.yml
scripts/gen-hosts.Makefile +0 -1
@@ -4,7 +4,6 @@ KDEVOPS_PLAYBOOKS_DIR_FULL_PATH=$(TOPDIR_PATH)/$(KDEVOPS_PLAYBOOKS_DIR) KDEVOPS_HOSTS_TEMPLATE_DIR=$(KDEVOPS_PLAYBOOKS_DIR_FULL_PATH)/roles/gen_hosts/templates GENHOSTS_EXTRA_ARGS += kdevops_playbooks_dir='$(KDEVOPS_PLAYBOOKS_DIR)' -GENHOSTS_EXTRA_ARGS += kdevops_hosts='$(KDEVOPS_HOSTFILE)' # Relative path so that ansible can work with it KDEVOPS_HOSTS_TEMPLATE_SHORT:=$(KDEVOPS_HOSTS_TEMPLATE)
scripts/guestfs.Makefile +6 -11
@@ -51,38 +51,33 @@ KDEVOPS_PROVISION_DESTROY_METHOD := destroy_guestfs $(Q)make linux-clone libvirt_pcie_passthrough_permissions: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/libvirt_pcie_passthrough.yml $(KDEVOPS_PROVISIONED_SSH): $(Q)if [[ "$(CONFIG_KDEVOPS_SSH_CONFIG_UPDATE)" == "y" ]]; then \ - ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/update_ssh_config_guestfs.yml \ --extra-vars=@./extra_vars.yaml; \ LIBVIRT_DEFAULT_URI=$(CONFIG_LIBVIRT_URI) \ $(TOPDIR)/scripts/update_ssh_config_guestfs.py; \ fi - $(Q)ansible $(ANSIBLE_VERBOSE) -i hosts 'all:!localhost' -m wait_for_connection + $(Q)ansible $(ANSIBLE_VERBOSE) 'all:!localhost' -m wait_for_connection $(Q)touch $(KDEVOPS_PROVISIONED_SSH) install_libguestfs: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/bringup_guestfs.yml \ --extra-vars=@./extra_vars.yaml \ --tags install-deps bringup_guestfs: $(GUESTFS_BRINGUP_DEPS) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/bringup_guestfs.yml \ --extra-vars=@./extra_vars.yaml \ --tags config-check,network,storage-pool-path $(Q)$(TOPDIR)/scripts/bringup_guestfs.sh - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/bringup_guestfs.yml \ --extra-vars=@./extra_vars.yaml \ --tags console-permissions
scripts/install-menuconfig-deps.Makefile +1 -2
@@ -1,8 +1,7 @@ # SPDX-License-Identifier: copyleft-next-0.3.1 menuconfig-deps: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/install-menuconfig-deps.yml \ -e 'kdevops_first_run=True' PHONY += menuconfig-deps
scripts/iscsi.Makefile +1 -1
@@ -7,7 +7,7 @@ ANSIBLE_EXTRA_ARGS += $(ISCSI_EXTRA_ARGS) iscsi: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l iscsi \ + --limit 'iscsi' \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/iscsi.yml
scripts/journal-server.Makefile +13 -10
@@ -11,24 +11,26 @@ ANSIBLE_EXTRA_ARGS += devconfig_systemd_journal_use_http='True' endif journal-client: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \ - -i hosts --extra-vars '{ kdevops_cli_install: True }' \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'baseline:dev' \ + --extra-vars '{ kdevops_cli_install: True }' \ --tags vars_simple,journal \ $(KDEVOPS_PLAYBOOKS_DIR)/devconfig.yml journal-server: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/install_systemd_journal_remote.yml journal-restart: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \ - -i hosts --tags vars_extra,journal-upload-restart \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'baseline:dev' \ + --tags vars_extra,journal-upload-restart \ $(KDEVOPS_PLAYBOOKS_DIR)/devconfig.yml journal-status: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \ - -i hosts --tags vars_extra,journal-status \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'baseline:dev' \ + --tags vars_extra,journal-status \ $(KDEVOPS_PLAYBOOKS_DIR)/devconfig.yml journal-ls:
@@ -39,8 +41,9 @@ journal-dump: journal-ln: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \ - -i hosts --tags vars_extra,journal_ln \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'baseline:dev' \ + --tags vars_extra,journal_ln \ $(KDEVOPS_PLAYBOOKS_DIR)/devconfig.yml LOCALHOST_SETUP_WORK += journal-server
scripts/kotd.Makefile +10 -6
@@ -9,19 +9,23 @@ endif # HAVE_DISTRO_CUSTOM_KOTD_REPO ANSIBLE_CMD_KOTD_ENABLE := -kotd: $(KDEVOPS_HOSTS) .config +kotd: inventory .config $(Q)$(ANSIBLE_CMD_KOTD_ENABLE)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/devconfig.yml --tags vars,kotd \ + playbooks/devconfig.yml --tags vars,kotd \ --extra-vars=@./extra_vars.yaml -kotd-baseline: $(KDEVOPS_HOSTS) .config +kotd-baseline: inventory .config $(Q)$(ANSIBLE_CMD_KOTD_ENABLE)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/devconfig.yml --tags vars,kotd \ + --limit 'baseline' \ + playbooks/devconfig.yml \ + --tags vars,kotd \ --extra-vars=@./extra_vars.yaml -kotd-dev: $(KDEVOPS_HOSTS) .config +kotd-dev: inventory .config $(Q)$(ANSIBLE_CMD_KOTD_ENABLE)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l dev playbooks/devconfig.yml --tags vars,kotd \ + --limit 'dev' \ + playbooks/devconfig.yml \ + --tags vars,kotd \ --extra-vars=@./extra_vars.yaml kotd-help-menu:
scripts/krb5.Makefile +2 -2
@@ -8,13 +8,13 @@ ANSIBLE_EXTRA_ARGS += $(KRB5_EXTRA_ARGS) kdc: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l kdc \ + --limit 'kdc' \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/kdc.yml krb5: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l krb5 \ + --limit 'krb5' \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/krb5.yml
scripts/ktls.Makefile +0 -1
@@ -2,7 +2,6 @@ ifeq (y,$(CONFIG_KDEVOPS_SETUP_KTLS)) ktls: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/ktls.yml
scripts/nfsd.Makefile +1 -1
@@ -29,7 +29,7 @@ ANSIBLE_EXTRA_ARGS += $(NFSD_EXTRA_ARGS) nfsd: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l nfsd \ + --limit 'nfsd' \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/nfsd.yml
scripts/provision.Makefile +3 -2
@@ -69,8 +69,9 @@ KDEVOPS_MRPROPER += $(KDEVOPS_PROVISIONED_DEVCONFIG) $(KDEVOPS_PROVISIONED_DEVCONFIG): $(Q)if [[ "$(CONFIG_KDEVOPS_ANSIBLE_PROVISION_PLAYBOOK)" != "" ]]; then \ - ansible-playbook $(ANSIBLE_VERBOSE) -i \ - $(KDEVOPS_HOSTFILE) $(KDEVOPS_PLAYBOOKS_DIR)/$(KDEVOPS_ANSIBLE_PROVISION_PLAYBOOK) ;\ + ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit '!localhost' \ + $(KDEVOPS_PLAYBOOKS_DIR)/$(KDEVOPS_ANSIBLE_PROVISION_PLAYBOOK) ;\ fi $(Q)touch $(KDEVOPS_PROVISIONED_DEVCONFIG)
scripts/rdma.Makefile +0 -2
@@ -2,7 +2,6 @@ ifeq (y,$(CONFIG_KDEVOPS_SETUP_RDMA_SIW)) siw: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/siw.yml
@@ -16,7 +15,6 @@ ifeq (y,$(CONFIG_KDEVOPS_SETUP_RDMA_RXE)) rxe: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/rxe.yml
scripts/smbd.Makefile +1 -1
@@ -9,7 +9,7 @@ ANSIBLE_EXTRA_ARGS += $(SMBD_EXTRA_ARGS) smbd: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l smbd \ + --limit 'smbd' \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/smbd.yml
scripts/systemd-timesync.Makefile +4 -4
@@ -20,14 +20,14 @@ ANSIBLE_EXTRA_ARGS += devconfig_enable_systemd_timesyncd_ntp_google_debian='True endif timesyncd-client: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \ - -i hosts --extra-vars '{ kdevops_cli_install: True }' \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'baseline:dev' \ + --extra-vars '{ kdevops_cli_install: True }' \ --tags vars_simple,timesyncd \ $(KDEVOPS_PLAYBOOKS_DIR)/devconfig.yml timesyncd-server: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/install_systemd_timesyncd.yml timesyncd-status:
scripts/terraform.Makefile +1 -5
@@ -102,13 +102,11 @@ ANSIBLE_EXTRA_ARGS += $(TERRAFORM_EXTRA_VARS) bringup_terraform: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - --connection=local --inventory localhost, \ playbooks/terraform.yml --tags bringup \ --extra-vars=@./extra_vars.yaml $(KDEVOPS_PROVISIONED_SSH): $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) \ playbooks/terraform.yml --tags ssh \ --extra-vars=@./extra_vars.yaml $(Q)touch $(KDEVOPS_PROVISIONED_SSH)
@@ -118,13 +116,11 @@ status_terraform: destroy_terraform: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - --connection=local -i $(KDEVOPS_HOSTFILE) \ playbooks/terraform.yml --tags destroy \ --extra-vars=@./extra_vars.yaml $(Q)rm -f $(KDEVOPS_PROVISIONED_SSH) $(KDEVOPS_PROVISIONED_DEVCONFIG) $(KDEVOPS_TFVARS): $(KDEVOPS_TFVARS_TEMPLATE) .config - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/gen_tfvars.yml \ --extra-vars=@./extra_vars.yaml
scripts/update_etc_hosts.Makefile +1 -1
@@ -1,6 +1,6 @@ update_etc_hosts: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/update_etc_hosts.yml + playbooks/update_etc_hosts.yml KDEVOPS_BRING_UP_DEPS_EARLY += update_etc_hosts
scripts/vagrant.Makefile +4 -6
@@ -80,21 +80,19 @@ extend-extra-args-vagrant: fi vagrant_private_box_install: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \ - $(KDEVOPS_HOSTFILE) $(KDEVOPS_PLAYBOOKS_DIR)/install_vagrant_boxes.yml + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + $(KDEVOPS_PLAYBOOKS_DIR)/install_vagrant_boxes.yml vagrant_9p_linux_clone: $(Q)make linux-clone libvirt_pcie_passthrough_permissions: - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/libvirt_pcie_passthrough.yml $(KDEVOPS_PROVISIONED_SSH): $(Q)if [[ "$(CONFIG_KDEVOPS_SSH_CONFIG_UPDATE)" == "y" ]]; then \ - ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/update_ssh_config_vagrant.yml fi $(Q)touch $(KDEVOPS_PROVISIONED_SSH)
scripts/workflows/lib/crash.py +1 -3
@@ -769,9 +769,7 @@ class KernelCrashWatchdog: subprocess.run( [ "ansible", - "-i", - "hosts", - "all", + "'all:!localhost'", "-m", "wait_for_connection", "-l",
workflows/blktests/Makefile +13 -7
@@ -67,12 +67,13 @@ extend-extra-args-blktests: blktests: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/blktests.yml \ + playbooks/blktests.yml \ --skip-tags run_tests,copy_results $(LIMIT_HOSTS) blktests-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/blktests.yml \ + --limit 'baseline' \ + playbooks/blktests.yml \ --tags run_tests,copy_results \ --extra-vars '{ $(BLKTESTS_DYNAMIC_RUNTIME_VARS) }' \ --extra-vars=@./extra_vars.yaml $(LIMIT_HOSTS)
@@ -85,14 +86,16 @@ blktests-baseline-kernelci: blktests-baseline-skip-kdevops-update: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/blktests.yml \ + --limit 'baseline' \ + playbooks/blktests.yml \ --tags run_tests,copy_results --skip-tags git_update \ --extra-vars '{ $(BLKTESTS_DYNAMIC_RUNTIME_VARS) }' \ --extra-vars=@./extra_vars.yaml $(LIMIT_HOSTS) blktests-baseline-run-oscheck-only: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/blktests.yml \ + --limit 'baseline' \ + playbooks/blktests.yml \ --tags run_tests,copy_results \ --skip-tags git_update,reboot,clean_results \ --extra-vars '{ $(BLKTESTS_DYNAMIC_RUNTIME_VARS) }' \
@@ -100,14 +103,16 @@ blktests-baseline-run-oscheck-only: blktests-dev: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l dev playbooks/blktests.yml \ + --limit 'dev' \ + playbooks/blktests.yml \ --tags run_tests,copy_results \ --extra-vars '{ $(BLKTESTS_DYNAMIC_RUNTIME_VARS) }' \ --extra-vars=@./extra_vars.yaml $(LIMIT_HOSTS) blktests-baseline-results: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/blktests.yml \ + --limit 'baseline' \ + playbooks/blktests.yml \ --tags copy_results,print_results \ --extra-vars '{ kdevops_run_blktests: True }' \ --extra-vars=@./extra_vars.yaml $(LIMIT_HOSTS)
@@ -116,7 +121,8 @@ blktests-results: blktests-baseline-results blktests-dev-results: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l dev playbooks/blktests.yml \ + --limit 'dev' \ + playbooks/blktests.yml \ --tags copy_results,print_results \ --extra-vars '{ kdevops_run_blktests: True }' \ --extra-vars=@./extra_vars.yaml $(LIMIT_HOSTS)
workflows/common/Makefile +1 -1
@@ -38,7 +38,7 @@ endif # CONFIG_WORKFLOW_INFER_USER_AND_GROUP == y ifeq (y,$(CONFIG_KDEVOPS_WORKFLOW_GIT_CLONES_KDEVOPS_GIT)) kdevops-git-reset: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/common.yml --tags vars,kdevops_reset \ + playbooks/common.yml --tags vars,kdevops_reset \ --extra-vars '{ kdevops_git_reset: True }' $(LIMIT_HOSTS) kdevops-help-menu:
workflows/cxl/Makefile +7 -7
@@ -20,42 +20,42 @@ include $(TOPDIR)/workflows/cxl/Makefile.kernel cxl: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/cxl.yml \ + playbooks/cxl.yml \ --skip-tags run_tests,copy_results \ $(LIMIT_HOSTS) cxl-test-probe: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/cxl.yml \ + playbooks/cxl.yml \ --tags vars,cxl-test-prep,cxl-test-probe \ --extra-vars '{ $(CXL_DYNAMIC_RUNTIME_VARS) }' \ $(LIMIT_HOSTS) cxl-test-meson: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/cxl.yml \ + playbooks/cxl.yml \ --tags vars,cxl-test-prep,cxl-test-meson \ --extra-vars '{ $(CXL_DYNAMIC_RUNTIME_VARS) }' \ $(LIMIT_HOSTS) cxl-results: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/cxl.yml \ + playbooks/cxl.yml \ --tags vars,copy_results $(LIMIT_HOSTS) cxl-mem-setup: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/cxl.yml \ + playbooks/cxl.yml \ --tags vars,extra-vars,cxl-mem-setup $(LIMIT_HOSTS) cxl-create-dc-region: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/cxl.yml \ + playbooks/cxl.yml \ --tags vars,cxl-create-dc-region $(LIMIT_HOSTS) cxl-dcd-setup: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/cxl.yml \ + playbooks/cxl.yml \ --tags vars,cxl-dcd-setup $(LIMIT_HOSTS) cxl-help-menu:
workflows/demos/reboot-limit/Makefile +21 -11
@@ -25,7 +25,7 @@ REBOOT_LIMIT_TEST_TYPE :=$(subst ",,$(CONFIG_REBOOT_LIMIT_TEST_TYPE)) # into the file extra_vars.yaml. The extra_vars.yaml file is always used as an # argument to ansible so that it reads our manually converted kconfig varibles # in ansible. We typically call a playbook with something like: -# ansible-playbook -i hosts -l baseline playbooks/foo.yml --tags bar --extra-vars=@./extra_vars.yaml +# ansible-playbook -l baseline playbooks/foo.yml --tags bar --extra-vars=@./extra_vars.yaml # # Likewise most playbooks also have something like the following as their first # task in their playbooks, so that they don't have to be specifying the
@@ -104,7 +104,7 @@ endif # CONFIG_KERNEL_CI # with tags "run_tests" or "copy_results". reboot-limit: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/reboot-limit.yml \ + playbooks/reboot-limit.yml \ --skip-tags run_tests,copy_results # kdevops supports generic workflows such as the enabling you to then use the
@@ -134,10 +134,13 @@ reboot-limit: # fly. reboot-limit-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/reboot-limit.yml \ - --tags vars,first_run,reset --extra-vars=@./extra_vars.yaml + --limit 'baseline' \ + playbooks/reboot-limit.yml \ + --tags vars,first_run,reset \ + --extra-vars=@./extra_vars.yaml $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/reboot-limit.yml \ + --limit 'baseline' \ + playbooks/reboot-limit.yml \ --tags vars,run_tests,copy_results \ --extra-vars=@./extra_vars.yaml
@@ -155,16 +158,21 @@ reboot-limit-baseline-kernelci: # Resets the boot counters so we start from scratch reboot-limit-baseline-reset: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/reboot-limit.yml \ - --tags vars,reset --extra-vars=@./extra_vars.yaml + --limit 'baseline' \ + playbooks/reboot-limit.yml \ + --tags vars,reset \ + --extra-vars=@./extra_vars.yaml # Below are the corresponding dev targets reboot-limit-dev-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l dev playbooks/reboot-limit.yml \ - --tags vars,first_run,reset --extra-vars=@./extra_vars.yaml + --limit 'dev' \ + playbooks/reboot-limit.yml \ + --tags vars,first_run,reset \ + --extra-vars=@./extra_vars.yaml $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l dev playbooks/reboot-limit.yml \ + --limit 'dev' \ + playbooks/reboot-limit.yml \ --tags vars,run_tests,copy_results \ --extra-vars=@./extra_vars.yaml
@@ -176,7 +184,9 @@ reboot-limit-dev-kernelci: reboot-limit-dev-reset: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l dev playbooks/reboot-limit.yml --tags vars,reset \ + --limit 'dev' \ + playbooks/reboot-limit.yml \ + --tags vars,reset \ --extra-vars=@./extra_vars.yaml reboot-limit-help-menu:
workflows/fstests/Makefile +25 -15
@@ -138,19 +138,22 @@ endif endif fstests: $(FSTESTS_BASELINE_EXTRA) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l localhost,baseline,dev \ - -i hosts playbooks/fstests.yml \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'localhost:baseline:dev' \ + playbooks/fstests.yml \ --skip-tags run_tests,copy_results $(LIMIT_HOSTS) fstests-kdevops-setup: $(KDEVOPS_EXTRA_VARS) $(FSTESTS_BASELINE_EXTRA) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \ - -i hosts playbooks/fstests.yml \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'baseline:dev' \ + playbooks/fstests.yml \ --tags vars,kdevops_fstests_setup,gendisks \ $(LIMIT_HOSTS) fstests-baseline: $(FSTESTS_BASELINE_EXTRA) $(Q)PYTHONUNBUFFERED=1 ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/fstests.yml \ + --limit 'baseline' \ + playbooks/fstests.yml \ --tags vars,run_tests,copy_results \ --extra-vars '{ $(FSTESTS_DYNAMIC_RUNTIME_VARS) }' \ --extra-vars=@./extra_vars.yaml $(LIMIT_HOSTS)
@@ -163,7 +166,8 @@ fstests-baseline-kernelci: $(KDEVOPS_EXTRA_VARS) fstests-baseline-skip-kdevops-update: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/fstests.yml \ + --limit 'baseline' \ + playbooks/fstests.yml \ --tags run_tests,copy_results \ --skip-tags git_update \ --extra-vars \
@@ -173,7 +177,8 @@ fstests-baseline-skip-kdevops-update: $(KDEVOPS_EXTRA_VARS) fstests-baseline-run-oscheck-only: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/fstests.yml \ + --limit 'baseline' \ + playbooks/fstests.yml \ --tags run_tests,copy_results \ --skip-tags git_update,reboot,clean_results \ --extra-vars \
@@ -183,14 +188,14 @@ fstests-baseline-run-oscheck-only: $(KDEVOPS_EXTRA_VARS) fstests-config: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/fstests.yml \ + --limit 'baseline' \ + playbooks/fstests.yml \ --tags vars,generate-fstests-config \ --extra-vars=@./extra_vars.yaml \ $(LIMIT_HOSTS) fstests-config-debug: $(KDEVOPS_EXTRA_VARS) - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ - --inventory localhost, \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/fstests.yml \ -e 'fstests_debug_localhost=True' \ --tags vars,generate-fstests-config \
@@ -198,7 +203,8 @@ fstests-config-debug: $(KDEVOPS_EXTRA_VARS) fstests-dev: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l dev playbooks/fstests.yml \ + --limit 'dev' \ + playbooks/fstests.yml \ --tags vars,run_tests,copy_results \ --extra-vars \ '{ $(FSTESTS_DYNAMIC_RUNTIME_VARS) }' \
@@ -206,7 +212,8 @@ fstests-dev: $(KDEVOPS_EXTRA_VARS) fstests-baseline-results-tfb-ls: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/fstests.yml \ + --limit 'baseline' \ + playbooks/fstests.yml \ --tags vars,tfb \ --skip-tags copy_final \ --extra-vars \
@@ -215,7 +222,8 @@ fstests-baseline-results-tfb-ls: $(KDEVOPS_EXTRA_VARS) fstests-baseline-results-tfb-trim: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/fstests.yml \ + --limit 'baseline' \ + playbooks/fstests.yml \ --tags vars,tfb \ --skip-tags copy_final \ --extra-vars \
@@ -224,7 +232,8 @@ fstests-baseline-results-tfb-trim: $(KDEVOPS_EXTRA_VARS) fstests-baseline-results: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/fstests.yml \ + --limit 'baseline' \ + playbooks/fstests.yml \ --tags copy_results,print_results,tfb \ --extra-vars '{ kdevops_run_fstests: True }' \ --extra-vars=@./extra_vars.yaml \
@@ -234,7 +243,8 @@ fstests-results: fstests-baseline-results fstests-dev-results: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l dev playbooks/fstests.yml \ + --limit 'dev' \ + playbooks/fstests.yml \ --tags copy_results,print_results \ --extra-vars '{ kdevops_run_fstests: True }' \ --extra-vars=@./extra_vars.yaml \
workflows/gitr/Makefile +4 -4
@@ -90,13 +90,13 @@ endif gitr: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l baseline,dev \ + --limit 'baseline:dev' \ --skip-tags run_tests,run_specific_tests,copy_results \ $(KDEVOPS_PLAYBOOKS_DIR)/gitr.yml gitr-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l baseline \ + --limit 'baseline' \ --tags $(GITR_PLAY_TAGS) \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/gitr.yml
@@ -109,7 +109,7 @@ gitr-baseline-kernelci: gitr-dev-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l dev \ + --limit 'dev' \ --tags $(GITR_PLAY_TAGS) \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/gitr.yml
@@ -122,7 +122,7 @@ gitr-dev-kernelci: gitr-dev-reset: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l dev \ + --limit 'dev' \ --tags vars,reset \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/gitr.yml
workflows/linux/Makefile +40 -21
124 lines not on this page · raw message
workflows/ltp/Makefile +4 -4
@@ -116,13 +116,13 @@ endif ltp: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l baseline,dev \ + --limit 'baseline:dev' \ --skip-tags run_tests,copy_results \ $(KDEVOPS_PLAYBOOKS_DIR)/ltp.yml ltp-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l baseline \ + --limit 'baseline' \ --tags vars,run_tests,copy_results \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/ltp.yml
@@ -135,7 +135,7 @@ ltp-baseline-kernelci: ltp-dev-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l dev \ + --limit 'dev' \ --tags vars,run_tests,copy_results \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/ltp.yml
@@ -148,7 +148,7 @@ ltp-dev-kernelci: ltp-dev-reset: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l dev \ + --limit 'dev' \ --tags vars,reset \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/ltp.yml
workflows/nfstest/Makefile +4 -4
@@ -73,13 +73,13 @@ endif nfstest: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l baseline,dev \ + --limit 'baseline:dev' \ --skip-tags run_tests,copy_results \ $(KDEVOPS_PLAYBOOKS_DIR)/nfstest.yml nfstest-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l baseline \ + --limit 'baseline' \ --tags vars,run_tests,copy_results \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/nfstest.yml
@@ -92,7 +92,7 @@ nfstest-baseline-kernelci: nfstest-dev-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l dev \ + --limit 'dev' \ --tags vars,run_tests,copy_results \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/nfstest.yml
@@ -105,7 +105,7 @@ nfstest-dev-kernelci: nfstest-dev-reset: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l dev \ + --limit 'dev' \ --tags vars,reset \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/nfstest.yml
workflows/pynfs/Makefile +6 -6
@@ -45,18 +45,18 @@ endif # Makefile for pynfs targets pynfs: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l baseline,dev \ + --limit 'baseline:dev' \ --skip-tags run_tests,copy_results,clean_local_results \ $(KDEVOPS_PLAYBOOKS_DIR)/pynfs.yml pynfs-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l baseline \ + --limit 'baseline' \ --tags vars,first_run,reset \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/pynfs.yml $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l baseline \ + --limit 'baseline' \ --tags vars,run_tests,copy_results \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/pynfs.yml
@@ -75,12 +75,12 @@ pynfs-baseline-kernelci: # Below are the corresponding dev targets pynfs-dev-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l dev \ + --limit 'dev' \ --tags vars,first_run,reset \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/pynfs.yml $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l dev \ + --limit 'dev' \ --tags vars,run_tests,copy_results \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/pynfs.yml
@@ -93,7 +93,7 @@ pynfs-dev-kernelci: pynfs-dev-reset: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i $(KDEVOPS_HOSTFILE) -l dev \ + --limit 'dev' \ --tags vars,reset \ --extra-vars=@./extra_vars.yaml \ $(KDEVOPS_PLAYBOOKS_DIR)/pynfs.yml
workflows/selftests/Makefile +7 -4
@@ -33,24 +33,27 @@ include $(TOPDIR)/workflows/selftests/tests/Makefile.xarray selftests: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/selftests.yml \ + playbooks/selftests.yml \ --skip-tags run_tests,copy_results,check_results \ $(LIMIT_HOSTS) selftests-baseline: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/selftests.yml \ + --limit 'baseline' \ + playbooks/selftests.yml \ --extra-vars '{ $(SELFTESTS_DYNAMIC_RUNTIME_VARS) }' \ --tags vars,run_tests,copy_results,check_results $(LIMIT_HOSTS) selftests-results: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/selftests.yml \ + --limit 'baseline' \ + playbooks/selftests.yml \ --tags vars,copy_results,check_results $(LIMIT_HOSTS) selftests-check-results: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts -l baseline playbooks/selftests.yml \ + --limit 'baseline' \ + playbooks/selftests.yml \ --tags vars,check_results $(LIMIT_HOSTS) selftests-help-main:
workflows/sysbench/Makefile +6 -6
@@ -29,36 +29,36 @@ TAGS_SYSBENCH_RESULTS += results # Target to set up sysbench (MySQL or PostgreSQL) sysbench: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/sysbench.yml \ + playbooks/sysbench.yml \ --skip-tags $(subst $(space),$(comma),$(TAGS_SYSBENCH_RUN)) # Target to run sysbench tests (including telemetry) sysbench-test: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/sysbench.yml \ + playbooks/sysbench.yml \ --tags $(subst $(space),$(comma),$(TAGS_SYSBENCH_TEST)) # Optional target to collect telemetry sysbench-telemetry: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/sysbench.yml \ + playbooks/sysbench.yml \ --tags $(subst $(space),$(comma),$(TAGS_SYSBENCH_TELEMETRY)) # Optional target to collect all results sysbench-results: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/sysbench.yml \ + playbooks/sysbench.yml \ --tags $(subst $(space),$(comma),$(TAGS_SYSBENCH_RESULTS)) sysbench-clean: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/sysbench.yml \ + playbooks/sysbench.yml \ --tags vars,clean # Optional in case you want to improve graphing sysbench-plot: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts playbooks/sysbench.yml \ + playbooks/sysbench.yml \ --tags vars,plot # Help target to show available options
Signature · 1 line
2.49.0
Re: [PATCH v2 08/10] Makefile: use inventory from ansible.cfg
Quoted 13 lines · Daniel Gomez
workflows/linux/Makefile +1
-0@@ -75,6 +75,7 @@ linux-help-menu: echo "linux-mount - Mounts 9p path on targets" ;\ fi @echo "linux-deploy - Builds, installs, updates GRUB and reboots - useful for rapid development" + @echo "linux-build - Builds kernel" @echo "linux-install - Only builds and installs Linux" @echo "linux-uninstall - Remove a kernel you can pass arguments for the version such as KVER=6.5.0-rc7-next-20230825" @echo "linux-clone - Only clones Linux"
workflows/linux/Makefile LINUX_HELP_EXTRA := · line 95
Quoted 4 lines
workflows/linux/Makefile +1
-0@@ -91,51 +92,66 @@ LINUX_HELP_EXTRA := PHONY += linux linux: $(KDEVOPS_NODES) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'all:!localhost' \
This is wrong. I just need to remove the inventory here and use playbook hosts:
field.
workflows/linux/Makefile LINUX_HELP_EXTRA := · line 101
Quoted 8 lines
workflows/linux/Makefile +3
-2$(KDEVOPS_PLAYBOOKS_DIR)/bootlinux-local.yml \ --extra-vars="$(BOOTLINUX_ARGS)" - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \ - $(KDEVOPS_HOSTFILE) $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'all:!localhost' \ + $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ --extra-vars="$(BOOTLINUX_ARGS)" $(LIMIT_HOSTS)
This break HOSTS="host1 host2" variable somehow. Not sure where the issue is yet.
==> [linux]
+ ansible-playbook -v -i playbooks/bootlinux.yml '--extra-vars=target_linux_git=/mirror/linux.git target_linux_tree=linux target_linux_ref=v6.15-rc4 target_linux_config=config-v6.15-rc4 target_linux_kernelrelease= target_linux_localversion= target_linux_shallow_depth=1 bootlinux_9p=True bootlinux_9p_host_path='\''/ media/tarkir/dagomez/src/linux-kdevops/kdevops/linux'\'' bootlinux_9p_msize='\''131072'\'' bootlinux_9p_fsdev='\''kdevops_9p_fsdev'\'' bootlinux_9p_security_model='\''none'\'' bootlinux_9p_driver='\''virtio-9p-pci'\'' bootlinux_9p_mount_tag='\''kdevops_9p_bootlinux'\'' bootlinux_cxl_test=' '-l "debian13-block-dev,debian13-nvme-dev"'
[WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are modifying the Ansible engine, or trying out features under development. This is a rapidly changing source of code and can become unstable at any point.
usage: ansible-playbook [-h] [--version] [-v] [--private-key PRIVATE_KEY_FILE] [-u REMOTE_USER] [-c CONNECTION] [-T TIMEOUT] [--ssh-common-args SSH_COMMON_ARGS] [--sftp-extra-args SFTP_EXTRA_ARGS] [--scp-extra-args SCP_EXTRA_ARGS] [--ssh-extra-args SSH_EXTRA_ARGS] [-k |
--connection-password-file CONNECTION_PASSWORD_FILE]
[--force-handlers] [-b] [--become-method BECOME_METHOD] [--become-user BECOME_USER] [-K | --become-password-file BECOME_PASSWORD_FILE] [-t TAGS] [--skip-tags SKIP_TAGS] [-C] [-D] [-i INVENTORY] [--list-hosts] [-l SUBSET]
[--flush-cache] [-e EXTRA_VARS] [--vault-id VAULT_IDS]
[-J | --vault-password-file VAULT_PASSWORD_FILES] [-f FORKS] [-M MODULE_PATH] [--syntax-check] [--list-tasks] [--list-tags] [--step] [--start-at-task START_AT_TASK]
playbook [playbook ...]
ansible-playbook: error: the following arguments are required: playbook
Re: [PATCH v2 08/10] Makefile: use inventory from ansible.cfg
Quoted 58 lines · Daniel Gomez
Quoted 13 lines · Daniel Gomez
workflows/linux/Makefile +1
-0@@ -75,6 +75,7 @@ linux-help-menu: echo "linux-mount - Mounts 9p path on targets" ;\ fi @echo "linux-deploy - Builds, installs, updates GRUB and reboots - useful for rapid development" + @echo "linux-build - Builds kernel" @echo "linux-install - Only builds and installs Linux" @echo "linux-uninstall - Remove a kernel you can pass arguments for the version such as KVER=6.5.0-rc7-next-20230825" @echo "linux-clone - Only clones Linux"workflows/linux/Makefile LINUX_HELP_EXTRA := · line 95
Quoted 4 lines
workflows/linux/Makefile +1
-0@@ -91,51 +92,66 @@ LINUX_HELP_EXTRA := PHONY += linux linux: $(KDEVOPS_NODES) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'all:!localhost' \This is wrong. I just need to remove the inventory here and use playbook hosts:
field.workflows/linux/Makefile LINUX_HELP_EXTRA := · line 101
Quoted 8 lines
workflows/linux/Makefile +3
-2$(KDEVOPS_PLAYBOOKS_DIR)/bootlinux-local.yml \ --extra-vars="$(BOOTLINUX_ARGS)" - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \ - $(KDEVOPS_HOSTFILE) $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'all:!localhost' \ + $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ --extra-vars="$(BOOTLINUX_ARGS)" $(LIMIT_HOSTS)This break HOSTS="host1 host2" variable somehow. Not sure where the issue is yet.
==> [linux]
+ ansible-playbook -v -iplaybooks/bootlinux.yml'--extra-vars=target_linux_git=/mirror/linux.git target_linux_tree=linux target_linux_ref=v6.15-rc4 target_linux_config=config-v6.15-rc4 target_linux_kernelrelease= target_linux_localversion= target_linux_shallow_depth=1 bootlinux_9p=True bootlinux_9p_host_path='\''/ media/tarkir/dagomez/src/linux-kdevops/kdevops/linux'\'' bootlinux_9p_msize='\''131072'\'' bootlinux_9p_fsdev='\''kdevops_9p_fsdev'\'' bootlinux_9p_security_model='\''none'\'' bootlinux_9p_driver='\''virtio-9p-pci'\'' bootlinux_9p_mount_tag='\''kdevops_9p_bootlinux'\'' bootlinux_cxl_test=' '-l "debian13-block-dev,debian13-nvme-dev"'
[WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are modifying the Ansible engine, or trying out features under development. This is a rapidly changing source of code and can become unstable at any point.
usage: ansible-playbook [-h] [--version] [-v] [--private-keyPRIVATE_KEY_FILE] [-uREMOTE_USER] [-c CONNECTION] [-T TIMEOUT] [--ssh-common-argsSSH_COMMON_ARGS] [--sftp-extra-argsSFTP_EXTRA_ARGS] [--scp-extra-argsSCP_EXTRA_ARGS] [--ssh-extra-argsSSH_EXTRA_ARGS] [-k |
--connection-password-fileCONNECTION_PASSWORD_FILE]
[--force-handlers] [-b] [--become-methodBECOME_METHOD] [--become-userBECOME_USER] [-K | --become-password-fileBECOME_PASSWORD_FILE] [-t TAGS] [--skip-tagsSKIP_TAGS] [-C] [-D] [-i INVENTORY] [--list-hosts] [-l SUBSET]
Quoted 8 lines
[--flush-cache] [-e EXTRA_VARS] [--vault-id VAULT_IDS][-J | --vault-password-file
VAULT_PASSWORD_FILES] [-f FORKS] [-MMODULE_PATH] [--syntax-check] [--list-tasks] [--list-tags] [--step] [--start-at-taskSTART_AT_TASK]
playbook [playbook ...]
ansible-playbook: error: the following arguments are required: playbook
I will apply 1/10 through 7/10 at least and exercise them a bit.
Signature · 1 line
Chuck Lever
Re: [PATCH v2 08/10] Makefile: use inventory from ansible.cfg
Quoted 68 lines · Chuck Lever
Quoted 58 lines · Daniel Gomez
Quoted 13 lines · Daniel Gomez
workflows/linux/Makefile +1
-0@@ -75,6 +75,7 @@ linux-help-menu: echo "linux-mount - Mounts 9p path on targets" ;\ fi @echo "linux-deploy - Builds, installs, updates GRUB and reboots - useful for rapid development" + @echo "linux-build - Builds kernel" @echo "linux-install - Only builds and installs Linux" @echo "linux-uninstall - Remove a kernel you can pass arguments for the version such as KVER=6.5.0-rc7-next-20230825" @echo "linux-clone - Only clones Linux"workflows/linux/Makefile LINUX_HELP_EXTRA := · line 95
Quoted 4 lines
workflows/linux/Makefile +1
-0@@ -91,51 +92,66 @@ LINUX_HELP_EXTRA := PHONY += linux linux: $(KDEVOPS_NODES) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'all:!localhost' \This is wrong. I just need to remove the inventory here and use playbook hosts:
field.workflows/linux/Makefile LINUX_HELP_EXTRA := · line 101
Quoted 8 lines
workflows/linux/Makefile +3
-2$(KDEVOPS_PLAYBOOKS_DIR)/bootlinux-local.yml \ --extra-vars="$(BOOTLINUX_ARGS)" - $(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \ - $(KDEVOPS_HOSTFILE) $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ + $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ + --limit 'all:!localhost' \ + $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \ --extra-vars="$(BOOTLINUX_ARGS)" $(LIMIT_HOSTS)This break HOSTS="host1 host2" variable somehow. Not sure where the issue is yet.
==> [linux]
+ ansible-playbook -v -iplaybooks/bootlinux.yml'--extra-vars=target_linux_git=/mirror/linux.git target_linux_tree=linux target_linux_ref=v6.15-rc4 target_linux_config=config-v6.15-rc4 target_linux_kernelrelease= target_linux_localversion= target_linux_shallow_depth=1 bootlinux_9p=True bootlinux_9p_host_path='\''/ media/tarkir/dagomez/src/linux-kdevops/kdevops/linux'\'' bootlinux_9p_msize='\''131072'\'' bootlinux_9p_fsdev='\''kdevops_9p_fsdev'\'' bootlinux_9p_security_model='\''none'\'' bootlinux_9p_driver='\''virtio-9p-pci'\'' bootlinux_9p_mount_tag='\''kdevops_9p_bootlinux'\'' bootlinux_cxl_test=' '-l "debian13-block-dev,debian13-nvme-dev"'
[WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are modifying the Ansible engine, or trying out features under development. This is a rapidly changing source of code and can become unstable at any point.
usage: ansible-playbook [-h] [--version] [-v] [--private-keyPRIVATE_KEY_FILE] [-uREMOTE_USER] [-c CONNECTION] [-T TIMEOUT] [--ssh-common-argsSSH_COMMON_ARGS] [--sftp-extra-argsSFTP_EXTRA_ARGS] [--scp-extra-argsSCP_EXTRA_ARGS] [--ssh-extra-argsSSH_EXTRA_ARGS] [-k |
--connection-password-fileCONNECTION_PASSWORD_FILE]
[--force-handlers] [-b] [--become-methodBECOME_METHOD] [--become-userBECOME_USER] [-K | --become-password-fileBECOME_PASSWORD_FILE] [-t TAGS] [--skip-tagsSKIP_TAGS] [-C] [-D] [-i INVENTORY] [--list-hosts] [-l SUBSET]Quoted 8 lines
[--flush-cache] [-e EXTRA_VARS] [--vault-id VAULT_IDS][-J | --vault-password-file
VAULT_PASSWORD_FILES] [-f FORKS] [-MMODULE_PATH] [--syntax-check] [--list-tasks] [--list-tags] [--step] [--start-at-taskSTART_AT_TASK]
playbook [playbook ...]
ansible-playbook: error: the following arguments are required: playbook
Quoted 1 line
I will apply 1/10 through 7/10 at least and exercise them a bit.
I found the problem in patch 3 with the quotes. Removing them for the long form makes it work again:
@@ -68,7 +71,7 @@ include scripts/ansible.Makefile
LIMIT_HOSTS :=
ifneq (,$(HOSTS))
-LIMIT_HOSTS := '--limit $(subst ${space},$(comma),$(HOSTS))' +LIMIT_HOSTS := --limit $(subst ${space},$(comma),$(HOSTS))
endif
export LIMIT_TESTS :=
I'll send a new revision with this change + the wrong limit fix explained above.
workflows/linux/Makefile +0 -1
@@ -92,7 +92,6 @@ LINUX_HELP_EXTRA := PHONY += linux linux: $(KDEVOPS_NODES) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - --limit 'all:!localhost' \ $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux-local.yml \ --extra-vars="$(BOOTLINUX_ARGS)" $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
This last point got me thinking... What if we want to run a workflow on baremetal (localhost)? In that case, I'd need to change the limits from 'all:! localhost' to 'baseline:dev'. Thoughts?
Is this workflow possible with CONFIG_SKIP_BRINGUP? A quick test enabling that + fstests with tmpfs does not work for me:
make fstests
: Install local dependencies for fstests command and control on localhost]
task 12. [started TASK: fstests_prep_localhost : Install junitparser on localhost]
PLAY 2: ALL
task 1. [started TASK: Gathering Facts on kdevops-tmpfs-default]
task 1: Gathering Facts
unreachable: kdevops-tmpfs-default: Failed to connect to the host via ssh: debug1: OpenSSH_10.0p2 Debian-2, OpenSSL 3.5.0 8 Apr 2025
debug1: Reading configuration data /home/dagomez/.ssh/config
debug1: Reading configuration data /home/dagomez/.ssh/ config_kdevops_c063ec7d89886ab778ae347ed8879313be4efae697274f49f0a1e7b33b8e598b
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: Reading configuration data /etc/ssh/ssh_config.d/20-systemd-ssh-proxy.conf
debug1: /etc/ssh/ssh_config line 21: Applying options for *
debug1: auto-mux: Trying existing master at '/home/dagomez/.ansible/
cp/5b4a0226ee'
debug1: Control socket "/home/dagomez/.ansible/cp/5b4a0226ee" does not exist
ssh: Could not resolve hostname kdevops-tmpfs-default: Name or service not known
SUMMARY
kdevops-tmpfs-default : ok=0 changed=0 unreachable=1 failed=0 rescued=0 ignored=0
localhost : ok=4 changed=0 unreachable=0 failed=0 rescued=0 ignored=0
make: *** [workflows/fstests/Makefile:141: fstests] Error 4
Quoted 4 lines
Signature · 2 lines
-- Chuck Lever
PATCH v2 9/10 ansible_cfg: add support to change ansible.cfg file location
In reply to Daniel GomezFrom: Daniel Gomez <[email protected]>
This adds support to change the Ansible Configuration filename and location via Kconfig.
It also fixes the target to generate the file only if it doesn't exist, instead of regenerating it every time make is invoked. Removing the quotes from the variable used as target fixes the problem.
Remove the file from MAINTAINERS list as it is autogenerated and not in tree.
--- MAINTAINERS | 1 - Makefile | 15 +++++++-------- kconfigs/Kconfig.ansible_cfg | 15 +++++++++++++++ playbooks/roles/ansible_cfg/tasks/main.yml | 2 +- 4 files changed, 23 insertions(+), 10 deletions(-)
MAINTAINERS +0 -1
@@ -72,7 +72,6 @@ M: Daniel Gomez <[email protected]> L: [email protected] S: Maintained T: git https://github.com/linux-kdevops/kdevops.git -F: ansible.cfg F: kconfigs/Kconfig.ansible_cfg F: playbooks/ansible_cfg.yml F: playbooks/roles/ansible_cfg
Makefile +7 -8
@@ -26,6 +26,7 @@ KDEVOPS_NODES_ROLE_TEMPLATE_DIR := $(KDEVOPS_PLAYBOOKS_DIR)/roles/gen_nodes/tem export KDEVOPS_NODES_TEMPLATE := export KDEVOPS_MRPROPER := +ANSIBLE_CFG_FILE := $(shell echo $(CONFIG_ANSIBLE_CFG_FILE) | tr --delete '"') ANSIBLE_INVENTORY_FILE := $(shell echo $(CONFIG_ANSIBLE_CFG_INVENTORY) | tr --delete '"') KDEVOPS_INSTALL_TARGETS :=
@@ -195,16 +196,14 @@ include scripts/gen-nodes.Makefile make -f scripts/build.Makefile help ;\ false) - -PHONY += ansible.cfg -ansible.cfg: +$(ANSIBLE_CFG_FILE): @$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/ansible_cfg.yml \ --extra-vars=@./.extra_vars_auto.yaml PHONY += $(EXTRA_VAR_INPUTS) $(EXTRA_VAR_INPUTS_LAST) -$(KDEVOPS_EXTRA_VARS): .config ansible.cfg $(EXTRA_VAR_INPUTS) $(EXTRA_VAR_INPUTS_LAST) +$(KDEVOPS_EXTRA_VARS): .config $(ANSIBLE_CFG_FILE) $(EXTRA_VAR_INPUTS) $(EXTRA_VAR_INPUTS_LAST) playbooks/secret.yml: @if [[ "$(CONFIG_KDEVOPS_REG_TWOLINE_REGCODE)" == "" ]]; then \
@@ -216,7 +215,7 @@ playbooks/secret.yml: @echo "$(CONFIG_KDEVOPS_REG_TWOLINE_REGCODE_VAR): $(CONFIG_KDEVOPS_REG_TWOLINE_REGCODE)" >> $@ ifeq (y,$(CONFIG_KDEVOPS_ENABLE_DISTRO_EXTRA_ADDONS)) -$(KDEVOPS_EXTRA_ADDON_DEST): .config ansible.cfg $(KDEVOPS_EXTRA_ADDON_SOURCE) +$(KDEVOPS_EXTRA_ADDON_DEST): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_EXTRA_ADDON_SOURCE) $(Q)cp $(KDEVOPS_EXTRA_ADDON_SOURCE) $(KDEVOPS_EXTRA_ADDON_DEST) endif
@@ -227,13 +226,13 @@ include scripts/bringup.Makefile endif DEFAULT_DEPS += $(ANSIBLE_INVENTORY_FILE) -$(ANSIBLE_INVENTORY_FILE): .config ansible.cfg $(KDEVOPS_HOSTS_TEMPLATE) +$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/gen_hosts.yml \ --extra-vars=@./extra_vars.yaml DEFAULT_DEPS += $(KDEVOPS_NODES) -$(KDEVOPS_NODES) $(KDEVOPS_VAGRANT): .config ansible.cfg $(KDEVOPS_NODES_TEMPLATE) +$(KDEVOPS_NODES) $(KDEVOPS_VAGRANT): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_NODES_TEMPLATE) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/gen_nodes.yml \ --extra-vars=@./extra_vars.yaml
@@ -262,7 +261,7 @@ mrproper: $(Q)rm -f $(KDEVOPS_NODES) $(Q)rm -f $(ANSIBLE_CFG_INVENTORY) $(KDEVOPS_MRPROPER) $(Q)rm -f .config .config.old extra_vars.yaml $(KCONFIG_YAMLCFG) - $(Q)rm -f ansible.cfg + $(Q)rm -f $(ANSIBLE_CFG_FILE) $(Q)rm -f playbooks/secret.yml $(KDEVOPS_EXTRA_ADDON_DEST) $(Q)rm -rf include $(Q)rm -rf guestfs
kconfigs/Kconfig.ansible_cfg +15 -0
@@ -1,3 +1,18 @@ +config ANSIBLE_CFG_FILE + string "Ansible configuration file" + output yaml + default "$(TOPDIR_PATH)/ansible.cfg" + help + Path and filename to the Ansible configuration file. + + This option lets you specify the path and filename for the Ansible + configuration file. If the specified file already exists, it will not + be overwritten. Otherwise, kdevops will generate one using the settings + defined in this Kconfig menu. + + For more details, refer to the Ansible documentation: + https://docs.ansible.com/ansible/latest/reference_appendices/config.html#the-configuration-file + config ANSIBLE_CFG_CALLBACK_PLUGIN_SET_BY_CLI bool default $(shell, scripts/check-cli-set-var.sh ANSIBLE_CFG_CALLBACK_PLUGIN)
playbooks/roles/ansible_cfg/tasks/main.yml +1 -1
@@ -14,5 +14,5 @@ - name: Generate kdevops ansible.cfg ansible.builtin.template: src: "ansible.cfg.j2" - dest: "{{ topdir_path }}/ansible.cfg" + dest: "{{ ansible_cfg_file }}" mode: '0755'
Signature · 1 line
2.49.0
PATCH v2 10/10 docs: ansible_cfg: add documentation
In reply to Daniel GomezFrom: Daniel Gomez <[email protected]>
Add documentation file for the Ansible Configuration Module (ansible_cfg).
--- MAINTAINERS | 1 + docs/kdevops-ansible-configuration.md | 102 ++++++++++++++++++++++++++++++++++ 2 files changed, 103 insertions(+)
MAINTAINERS +1 -0
@@ -72,6 +72,7 @@ M: Daniel Gomez <[email protected]> L: [email protected] S: Maintained T: git https://github.com/linux-kdevops/kdevops.git +F: docs/kdevops-ansible-configuration.md F: kconfigs/Kconfig.ansible_cfg F: playbooks/ansible_cfg.yml F: playbooks/roles/ansible_cfg
docs/kdevops-ansible-configuration.md new file +102 -0
102 lines not on this page · raw message
Signature · 1 line
2.49.0