Skip to contentSkip to conversation

Add support for rk3399 industry evaluation board

PATCH Superseded Chaoyi Chen 4 participants 9 messages Apr 30, 2025 – May 2, 2025

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add support for rk3399 industry evaluation board

From: Chaoyi Chen <[email protected]>

General feature for rk3399 industry evaluation board:
- Rockchip RK3399
- 4GB LPDDR4
- emmc5.1
- SDIO3.0 compatible TF card
- 1x HDMI2.0a TX
- 1x HDMI1.4b RX with TC358749XBG HDMI to MIPI CSI2 bridge chip
- 1x type-c DisplayPort
- 3x USB3.0 Host
- 1x USB2.0 Host
- 1x Ethernet / USB3.0 to Ethernet

Tested with HDMI/GPU/USB2.0/USB3.0/TF card/emmc.

Changes in v2:
- Link to V1: https://lore.kernel.org/all/[email protected]/
- Remove gmac
- Add rk809 PMIC
- Add CPU supply
- Fix io-domain for sdmmc
- Enable vopl

Chaoyi Chen (2):
dt-bindings: arm: rockchip: Add rk3399 industry evaluation board
arm64: dts: rockchip: Add rk3399-evb-ind board

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3399-evb-ind.dts      | 466 ++++++++++++++++++
 3 files changed, 472 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts

--
2.49.0

#1 lore raw

PATCH v2 1/2 dt-bindings: arm: rockchip: Add rk3399 industry evaluation board

From: Chaoyi Chen <[email protected]>

Add devicetree binding for the rk3399 industry evaluation board.

---

(no changes since v1)

 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
index 650fb833d96e..684d48ba20fc 100644
@@ -1047,6 +1047,11 @@ properties:
           - const: rockchip,rk3399-evb
           - const: rockchip,rk3399
 
+      - description: Rockchip RK3399 Industry Evaluation board
+        items:
+          - const: rockchip,rk3399-evb-ind
+          - const: rockchip,rk3399
+
       - description: Rockchip RK3399 Sapphire standalone
         items:
           - const: rockchip,rk3399-sapphire

--
2.49.0

maintainer Acked-by Krzysztof Kozlowski on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add rk3399 industry evaluation board

Quoted 4 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

Add devicetree binding for the rk3399 industry evaluation board.

Quoted 8 lines

---

(no changes since v1)

 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

Missing tags:

#3 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add rk3399 industry evaluation board

Hi Rob,

Quoted 20 lines · Rob Herring (Arm)
Quoted 4 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

Add devicetree binding for the rk3399 industry evaluation board.

Quoted 8 lines

---

(no changes since v1)

  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
  1 file changed, 5 insertions(+)

Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

Quoted 6 lines

If a tag was not added on purpose, please state why and what changed.

Missing tags:

To be fair, the Acked-by was given on the v1[1] after the v2[2] was sent, we cannot expect Chaoyi Chen to travel back in time :)

[1] https://lore.kernel.org/linux-rockchip/20250430-light-chital-of-cookies-b8f2ab@kuoka/ 10:22 UTC
[2] https://lore.kernel.org/linux-rockchip/[email protected]/ 7:48 UTC

Cheers,
Quentin

maintainer
#4 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add rk3399 industry evaluation board

Quoted 25 lines · Quentin Schulz

Hi Rob,

Quoted 22 lines · Rob Herring (Arm)
Quoted 4 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

Add devicetree binding for the rk3399 industry evaluation board.

Quoted 8 lines

---

(no changes since v1)

  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
  1 file changed, 5 insertions(+)

Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

Quoted 7 lines
Quoted 4 lines

Missing tags:

To be fair, the Acked-by was given on the v1[1] after the v2[2] was sent, we cannot expect Chaoyi Chen to travel back in time :)

Usually a sign of sending new versions too quickly...

But I just send this semi-automated email so we capture the ack and I can clear it out of my inbox.

Rob

#5 lore raw

PATCH v2 2/2 arm64: dts: rockchip: Add rk3399-evb-ind board

In reply to Chaoyi Chen

From: Chaoyi Chen <[email protected]>

General feature for rk3399 industry evaluation board:
- Rockchip RK3399
- 4GB LPDDR4
- emmc5.1
- SDIO3.0 compatible TF card
- 1x HDMI2.0a TX
- 1x HDMI1.4b RX with TC358749XBG HDMI to MIPI CSI2 bridge chip
- 1x type-c DisplayPort
- 3x USB3.0 Host
- 1x USB2.0 Host
- 1x Ethernet / USB3.0 to Ethernet

Tested with HDMI/GPU/USB2.0/USB3.0/TF card/emmc.

---

Changes in v2:
- Remove gmac
- Add rk809 PMIC
- Add CPU supply
- Fix io-domain for sdmmc
- Enable vopl

 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3399-evb-ind.dts      | 466 ++++++++++++++++++
 2 files changed, 467 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 3e8771ef69ba..8a3adb7482ca 100644
@@ -40,6 +40,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5-evb.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-eaidk-610.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb-ind.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-ficus.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-firefly.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-bob.dtb
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +466 -0

466 lines not on this page · raw message

--
2.49.0

#6 lore raw

Re: [PATCH v2 2/2] arm64: dts: rockchip: Add rk3399-evb-ind board

Hi Chaoyi Chen,

Quoted 4 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

General feature for rk3399 industry evaluation board:
- Rockchip RK3399

Quick question, is this really an RK3399 or rather an RK3399K (the industrial grade)? If it's a K variant, then we need a new rk3399-k.dtsi with the appropriate OPPs and include that instead.

Quoted 45 lines

- 4GB LPDDR4
- emmc5.1
- SDIO3.0 compatible TF card
- 1x HDMI2.0a TX
- 1x HDMI1.4b RX with TC358749XBG HDMI to MIPI CSI2 bridge chip
- 1x type-c DisplayPort
- 3x USB3.0 Host
- 1x USB2.0 Host
- 1x Ethernet / USB3.0 to Ethernet

Tested with HDMI/GPU/USB2.0/USB3.0/TF card/emmc.

---

Changes in v2:
- Remove gmac
- Add rk809 PMIC
- Add CPU supply
- Fix io-domain for sdmmc
- Enable vopl

  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
  .../boot/dts/rockchip/rk3399-evb-ind.dts      | 466 ++++++++++++++++++
  2 files changed, 467 insertions(+)

create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts

arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 3e8771ef69ba..8a3adb7482ca 100644
@@ -40,6 +40,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5-evb.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-eaidk-610.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb-ind.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-ficus.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-firefly.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-bob.dtb
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +0 -0
new file mode 100644
index 000000000000..ebfe7e56b3f5

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 8

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +8 -0
@@ -0,0 +1,466 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2025 Rockchip Electronics Co., Ltd.
+ */
+
+/dts-v1/;
+#include "rk3399-base.dtsi"
+

You're supposed to include one device tree include with OPPs. I see that the rk3399-evb is the only one that does that.

According to 296602b8e5f7 ("arm64: dts: rockchip: Move RK3399 OPPs to dtsi files for SoC variants"), this was done because:

The only exception to the "include only a SoC variant dtsi" is found in rk3399-evb.dts, which includes rk3399-base.dtsi instead of rk3399.dtsi. This is intentional, because this board dts file doesn't enable the
TSADC,
so including rk3399.dtsi would enable the SoC to go into higher
OPPs with
no thermal throttling in place. Let's hope that people interested
in this
board will fix this in the future.

Soooo, maybe you could fix that now? At the very least for the industrial variant (but it would also be most welcomed for the "normal" EVB).

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 14

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +6 -0
+/ {
+	model = "Rockchip RK3399 EVB IND LPDDR4 Board";
+	compatible = "rockchip,rk3399-evb-ind", "rockchip,rk3399";
+
+	aliases {
+		ethernet0 = &gmac;

Considering gmac is gone from the DT, maybe you want to have that one in the patch that will add Ethernet support?

Quoted 34 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +34 -0
+		mmc0 = &sdhci;
+		mmc1 = &sdmmc;
+	};
+
+	chosen {
+		stdout-path = "serial2:1500000n8";
+	};
+
+	vcc5v0_sys: regulator-vcc5v0-sys {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>;
+		regulator-name = "vcc5v0_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-max-microvolt = <5000000>;
+		regulator-min-microvolt = <5000000>;
+	};
+};
+
+&cpu_l0 {
+	cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_l1 {
+	cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_l2 {
+	cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_l3 {
+	cpu-supply = <&vdd_cpu_l>;

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 58

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+};
+
+&cpu_b0 {
+	cpu-supply = <&vdd_cpu_b>;
+};
+
+&cpu_b1 {
+	cpu-supply = <&vdd_cpu_b>;
+};
+

Please order the nodes alphabetically, so cpu_bX before cpu_lX. See https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html

Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +9 -0
+&emmc_phy {
+	status = "okay";
+};
+
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 77

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+&hdmi {
+	pinctrl-names = "default";
+	pinctrl-0 = <&hdmi_i2c_xfer>, <&hdmi_cec>;
+	status = "okay";
+};
+
+&hdmi_sound {
+	status = "okay";
+};
+

hdmi_sound requires i2s2 controller to be enabled too, but I don't see it in this device tree?

Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +9 -0
+&i2c0 {
+	clock-frequency = <400000>;
+	i2c-scl-falling-time-ns = <4>;
+	i2c-scl-rising-time-ns = <168>;
+	status = "okay";
+
+	rk809: pmic@20 {
+		compatible = "rockchip,rk809";
+		reg = <0x20>;

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 96

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+		interrupt-parent = <&gpio1>;
+		interrupts = <RK_PC5 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pmic_int_l>;
+		rockchip,system-power-controller;
+		#clock-cells = <1>;
+		pmic-reset-func = <0>;
+		wakeup-source;
+		clock-output-names = "xin32k", "rk808-clkout2";
+

Please order properties correctly, see https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html

Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +9 -0
+		vcc1-supply = <&vcc5v0_sys>;
+		vcc2-supply = <&vcc5v0_sys>;
+		vcc3-supply = <&vcc5v0_sys>;
+		vcc4-supply = <&vcc5v0_sys>;
+		vcc5-supply = <&vcc_buck5>;
+		vcc6-supply = <&vcc_buck5>;
+		vcc7-supply = <&vcc5v0_sys>;
+		vcc8-supply = <&vcc3v3_sys>;
+		vcc9-supply = <&vcc5v0_sys>;

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 115

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+
+		regulators {
+			vdd_center: DCDC_REG1 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-initial-mode = <0x2>;
+				regulator-max-microvolt = <1350000>;
+				regulator-min-microvolt = <750000>;
+				regulator-ramp-delay = <6001>;
+				regulator-name = "vdd_center";

Missing blank line between last property and first child node, see https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html. Same remark for all other regulators.

Quoted 165 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +165 -0
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vdd_cpu_l: DCDC_REG2 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-initial-mode = <0x2>;
+				regulator-max-microvolt = <1350000>;
+				regulator-min-microvolt = <750000>;
+				regulator-ramp-delay = <6001>;
+				regulator-name = "vdd_cpu_l";
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc_ddr: DCDC_REG3 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-initial-mode = <0x2>;
+				regulator-name = "vcc_ddr";
+				regulator-state-mem {
+					regulator-on-in-suspend;
+				};
+			};
+
+			vcc3v3_sys: DCDC_REG4 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-initial-mode = <0x2>;
+				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <3300000>;
+				regulator-name = "vcc3v3_sys";
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <3300000>;
+				};
+			};
+
+			vcc_buck5: DCDC_REG5 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-max-microvolt = <2200000>;
+				regulator-min-microvolt = <2200000>;
+				regulator-name = "vcc_buck5";
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <2200000>;
+				};
+			};
+
+			vcca_0v9: LDO_REG1 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-max-microvolt = <900000>;
+				regulator-min-microvolt = <900000>;
+				regulator-name = "vcca_0v9";
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc_1v8: LDO_REG2 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-max-microvolt = <1800000>;
+				regulator-min-microvolt = <1800000>;
+				regulator-name = "vcc_1v8";
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <1800000>;
+				};
+			};
+
+			vcc0v9_soc: LDO_REG3 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-max-microvolt = <900000>;
+				regulator-min-microvolt = <900000>;
+				regulator-name = "vcc0v9_soc";
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <900000>;
+				};
+			};
+
+			vcca_1v8: LDO_REG4 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-max-microvolt = <1800000>;
+				regulator-min-microvolt = <1800000>;
+				regulator-name = "vcca_1v8";
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vdd1v5_dvp: LDO_REG5 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-max-microvolt = <1500000>;
+				regulator-min-microvolt = <1500000>;
+				regulator-name = "vdd1v5_dvp";
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc_1v5: LDO_REG6 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-max-microvolt = <1500000>;
+				regulator-min-microvolt = <1500000>;
+				regulator-name = "vcc_1v5";
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc_3v0: LDO_REG7 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-max-microvolt = <3000000>;
+				regulator-min-microvolt = <3000000>;
+				regulator-name = "vcc_3v0";
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vccio_sd: LDO_REG8 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <1800000>;
+				regulator-name = "vccio_sd";
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc_sd: LDO_REG9 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <3300000>;
+				regulator-name = "vcc_sd";
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc5v0_usb: SWITCH_REG1 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-name = "vcc5v0_usb";
+				regulator-state-mem {
+					regulator-on-in-suspend;
+				};
+			};
+
+			vccio_3v3: SWITCH_REG2 {
+				regulator-always-on;

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 290

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+				regulator-boot-on;
+				regulator-name = "vccio_3v3";
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+		};
+	};
+
+	vdd_cpu_b: tcs4525@1c {

Please set the node name to regulator@1c.

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +8 -0
+		compatible = "tcs,tcs4525";
+		reg = <0x1c>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&vsel1_gpio>;
+		fcs,suspend-voltage-selector = <1>;
+		vin-supply = <&vcc5v0_sys>;
+		vsel-gpios = <&gpio1 RK_PC1 GPIO_ACTIVE_HIGH>;
+		regulator-compatible = "fan53555-reg";

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 308

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-initial-state = <3>;
+		regulator-max-microvolt = <1500000>;
+		regulator-min-microvolt = <712500>;
+		regulator-name = "vdd_cpu_b";
+		regulator-ramp-delay = <1000>;
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};

Properties order and blank line before child node, see https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 311

Quoted 3 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +3 -0
+	};
+
+	vdd_gpu: tcs4526@10 {

Please set node name to regulator@10.

Please order child nodes in busses based on their address, i.e.:

vdd_gpu
vdd_cpu_b
rk809

in this case.

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +8 -0
+		compatible = "tcs,tcs4525";
+		reg = <0x10>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&vsel2_gpio>;
+		fcs,suspend-voltage-selector = <1>;
+		vin-supply = <&vcc5v0_sys>;
+		vsel-gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_HIGH>;
+		regulator-compatible = "fan53555-reg";

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 329

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-initial-state = <3>;
+		regulator-max-microvolt = <1500000>;
+		regulator-min-microvolt = <712500>;
+		regulator-name = "vdd_gpu";
+		regulator-ramp-delay = <1000>;
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};

Properties order and blank line before child node, see https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 339

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+	};
+};
+
+&io_domains {
+	audio-supply = <&vcca_1v8>;
+	bt656-supply = <&vcc_3v0>;
+	gpio1830-supply = <&vcc_3v0>;
+	sdmmc-supply = <&vccio_sd>;
+	status = "okay";
+};

What about pmu_io_domains too?

Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +7 -0
+
+&sdmmc {
+	bus-width = <4>;
+	cap-mmc-highspeed;
+	cap-sd-highspeed;
+	disable-wp;
+	no-sdio;

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 356

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+	no-mmc;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
+	sd-uhs-sdr104;
+	vmmc-supply = <&vcc_sd>;
+	vqmmc-supply = <&vccio_sd>;
+	status = "okay";
+};
+
+&sdhci {

This should be before sdmmc

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +8 -0
+	bus-width = <8>;
+	keep-power-in-suspend;
+	mmc-hs400-1_8v;
+	mmc-hs400-enhanced-strobe;
+	no-sdio;
+	no-sd;
+	non-removable;
+	status = "okay";

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 374

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+};
+
+&tcphy0 {
+	status = "okay";
+};
+
+&tcphy1 {
+	status = "okay";
+};
+

What about tsadc?

Quoted 52 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +52 -0
+&u2phy0 {
+	status = "okay";
+};
+
+&u2phy0_host {
+	status = "okay";
+};
+
+&u2phy0_otg {
+	status = "okay";
+};
+
+&u2phy1 {
+	status = "okay";
+};
+
+&u2phy1_host {
+	status = "okay";
+};
+
+&u2phy1_otg {
+	status = "okay";
+};
+
+&uart2 {
+	status = "okay";
+};
+
+&usbdrd_dwc3_0 {
+	status = "okay";
+};
+
+&usbdrd3_0 {
+	status = "okay";
+};
+
+&usbdrd3_1 {
+	status = "okay";
+};
+
+&usbdrd_dwc3_1 {
+	dr_mode = "host";
+	status = "okay";
+};
+
+&usb_host0_ehci {
+	status = "okay";
+};
+
+&usb_host0_ohci {
+	status = "okay";
+};

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 436

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+
+&usb_host1_ehci {
+	status = "okay";
+};
+
+&usb_host1_ohci {
+	status = "okay";
+};
+
+&pinctrl {

This needs to be ordered alphabetically, see https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html (so before sdhci here).

Cheers,
Quentin

#7 lore raw

Re: [PATCH v2 2/2] arm64: dts: rockchip: Add rk3399-evb-ind board

Hi Quentin,

Quoted 9 lines · Quentin Schulz

Hi Chaoyi Chen,

Quoted 4 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

General feature for rk3399 industry evaluation board:
- Rockchip RK3399

Quick question, is this really an RK3399 or rather an RK3399K (the industrial grade)? If it's a K variant, then we need a new rk3399-k.dtsi with the appropriate OPPs and include that instead.

Yes, it is really an RK3399.

Quoted 59 lines
Quoted 46 lines

- 4GB LPDDR4
- emmc5.1
- SDIO3.0 compatible TF card
- 1x HDMI2.0a TX
- 1x HDMI1.4b RX with TC358749XBG HDMI to MIPI CSI2 bridge chip
- 1x type-c DisplayPort
- 3x USB3.0 Host
- 1x USB2.0 Host
- 1x Ethernet / USB3.0 to Ethernet

Tested with HDMI/GPU/USB2.0/USB3.0/TF card/emmc.

---

Changes in v2:
- Remove gmac
- Add rk809 PMIC
- Add CPU supply
- Fix io-domain for sdmmc
- Enable vopl

  arch/arm64/boot/dts/rockchip/Makefile         |   1 + .../boot/dts/rockchip/rk3399-evb-ind.dts      | 466 ++++++++++++++++++

  2 files changed, 467 insertions(+)

  create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts

arch/arm64/boot/dts/rockchip/Makefile +0 -0
index 3e8771ef69ba..8a3adb7482ca 100644
@@ -40,6 +40,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5-evb.dtb

  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-eaidk-610.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb-ind.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-ficus.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-firefly.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-bob.dtb

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +0 -0
new file mode 100644
index 000000000000..ebfe7e56b3f5

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 8

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +8 -0
@@ -0,0 +1,466 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2025 Rockchip Electronics Co., Ltd.
+ */
+
+/dts-v1/;
+#include "rk3399-base.dtsi"
+

You're supposed to include one device tree include with OPPs. I see that the rk3399-evb is the only one that does that.

According to 296602b8e5f7 ("arm64: dts: rockchip: Move RK3399 OPPs to dtsi files for SoC variants"), this was done because:

Quoted 9 lines

    The only exception to the "include only a SoC variant dtsi" is found in rk3399-evb.dts, which includes rk3399-base.dtsi instead of rk3399.dtsi. This is intentional, because this board dts file doesn't enable the TSADC, so including rk3399.dtsi would enable the SoC to go into higher OPPs with no thermal throttling in place.  Let's hope that people interested in this board will fix this in the future.

Soooo, maybe you could fix that now? At the very least for the industrial variant (but it would also be most welcomed for the "normal" EVB).

I think this should include "rk3399.dtsi", since this is just the normal version of RK3399. I will investigate further about rk3399-evb.

Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 14

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +6 -0
+/ {
+    model = "Rockchip RK3399 EVB IND LPDDR4 Board";
+    compatible = "rockchip,rk3399-evb-ind", "rockchip,rk3399";
+
+    aliases {
+        ethernet0 = &gmac;

Considering gmac is gone from the DT, maybe you want to have that one in the patch that will add Ethernet support?

Yes, there will be an additional series. I will remove them in v3 for now.

Quoted 39 lines
Quoted 39 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +38 -0
+        mmc0 = &sdhci;
+        mmc1 = &sdmmc;
+    };
+
+    chosen {
+        stdout-path = "serial2:1500000n8";
+    };
+
+    vcc5v0_sys: regulator-vcc5v0-sys {
+        compatible = "regulator-fixed";
+        enable-active-high;
+        gpio = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>;
+        regulator-name = "vcc5v0_sys";
+        regulator-always-on;
+        regulator-boot-on;
+        regulator-max-microvolt = <5000000>;
+        regulator-min-microvolt = <5000000>;
+    };
+};
+
+&cpu_l0 {
+    cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_l1 {
+    cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_l2 {
+    cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_l3 {
+    cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_b0 {
+    cpu-supply = <&vdd_cpu_b>;
Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 58

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +6 -0
+};
+
+&cpu_b1 {
+    cpu-supply = <&vdd_cpu_b>;
+};
+

Please order the nodes alphabetically, so cpu_bX before cpu_lX. See https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html

Will fix in v3.

Quoted 14 lines
Quoted 14 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +13 -0
+&emmc_phy {
+    status = "okay";
+};
+
+&gpu {
+    mali-supply = <&vdd_gpu>;
+    status = "okay";
+};
+
+&hdmi {
+    pinctrl-names = "default";
+    pinctrl-0 = <&hdmi_i2c_xfer>, <&hdmi_cec>;
+    status = "okay";
Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 77

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +6 -0
+};
+
+&hdmi_sound {
+    status = "okay";
+};
+

hdmi_sound requires i2s2 controller to be enabled too, but I don't see it in this device tree?

Will fix in v3.

Quoted 14 lines
Quoted 14 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +13 -0
+&i2c0 {
+    clock-frequency = <400000>;
+    i2c-scl-falling-time-ns = <4>;
+    i2c-scl-rising-time-ns = <168>;
+    status = "okay";
+
+    rk809: pmic@20 {
+        compatible = "rockchip,rk809";
+        reg = <0x20>;
+        interrupt-parent = <&gpio1>;
+        interrupts = <RK_PC5 IRQ_TYPE_LEVEL_LOW>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&pmic_int_l>;
Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 96

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +6 -0
+        rockchip,system-power-controller;
+        #clock-cells = <1>;
+        pmic-reset-func = <0>;
+        wakeup-source;
+        clock-output-names = "xin32k", "rk808-clkout2";
+

Please order properties correctly, see https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html

Will fix in v3.

Quoted 21 lines
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +9 -0
+        vcc1-supply = <&vcc5v0_sys>;
+        vcc2-supply = <&vcc5v0_sys>;
+        vcc3-supply = <&vcc5v0_sys>;
+        vcc4-supply = <&vcc5v0_sys>;
+        vcc5-supply = <&vcc_buck5>;
+        vcc6-supply = <&vcc_buck5>;
+        vcc7-supply = <&vcc5v0_sys>;
+        vcc8-supply = <&vcc3v3_sys>;
+        vcc9-supply = <&vcc5v0_sys>;

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 115

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+
+        regulators {
+            vdd_center: DCDC_REG1 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-initial-mode = <0x2>;
+                regulator-max-microvolt = <1350000>;
+                regulator-min-microvolt = <750000>;
+                regulator-ramp-delay = <6001>;
+                regulator-name = "vdd_center";
Quoted 1 line

Missing blank line between last property and first child node, see https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html. Same remark for all other regulators.

Will fix them in v3.

Quoted 170 lines
Quoted 170 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +169 -0
+                regulator-state-mem {
+                    regulator-off-in-suspend;
+                };
+            };
+
+            vdd_cpu_l: DCDC_REG2 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-initial-mode = <0x2>;
+                regulator-max-microvolt = <1350000>;
+                regulator-min-microvolt = <750000>;
+                regulator-ramp-delay = <6001>;
+                regulator-name = "vdd_cpu_l";
+                regulator-state-mem {
+                    regulator-off-in-suspend;
+                };
+            };
+
+            vcc_ddr: DCDC_REG3 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-initial-mode = <0x2>;
+                regulator-name = "vcc_ddr";
+                regulator-state-mem {
+                    regulator-on-in-suspend;
+                };
+            };
+
+            vcc3v3_sys: DCDC_REG4 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-initial-mode = <0x2>;
+                regulator-max-microvolt = <3300000>;
+                regulator-min-microvolt = <3300000>;
+                regulator-name = "vcc3v3_sys";
+                regulator-state-mem {
+                    regulator-on-in-suspend;
+                    regulator-suspend-microvolt = <3300000>;
+                };
+            };
+
+            vcc_buck5: DCDC_REG5 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-max-microvolt = <2200000>;
+                regulator-min-microvolt = <2200000>;
+                regulator-name = "vcc_buck5";
+                regulator-state-mem {
+                    regulator-on-in-suspend;
+                    regulator-suspend-microvolt = <2200000>;
+                };
+            };
+
+            vcca_0v9: LDO_REG1 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-max-microvolt = <900000>;
+                regulator-min-microvolt = <900000>;
+                regulator-name = "vcca_0v9";
+                regulator-state-mem {
+                    regulator-off-in-suspend;
+                };
+            };
+
+            vcc_1v8: LDO_REG2 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-max-microvolt = <1800000>;
+                regulator-min-microvolt = <1800000>;
+                regulator-name = "vcc_1v8";
+                regulator-state-mem {
+                    regulator-on-in-suspend;
+                    regulator-suspend-microvolt = <1800000>;
+                };
+            };
+
+            vcc0v9_soc: LDO_REG3 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-max-microvolt = <900000>;
+                regulator-min-microvolt = <900000>;
+                regulator-name = "vcc0v9_soc";
+                regulator-state-mem {
+                    regulator-on-in-suspend;
+                    regulator-suspend-microvolt = <900000>;
+                };
+            };
+
+            vcca_1v8: LDO_REG4 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-max-microvolt = <1800000>;
+                regulator-min-microvolt = <1800000>;
+                regulator-name = "vcca_1v8";
+                regulator-state-mem {
+                    regulator-off-in-suspend;
+                };
+            };
+
+            vdd1v5_dvp: LDO_REG5 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-max-microvolt = <1500000>;
+                regulator-min-microvolt = <1500000>;
+                regulator-name = "vdd1v5_dvp";
+                regulator-state-mem {
+                    regulator-off-in-suspend;
+                };
+            };
+
+            vcc_1v5: LDO_REG6 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-max-microvolt = <1500000>;
+                regulator-min-microvolt = <1500000>;
+                regulator-name = "vcc_1v5";
+                regulator-state-mem {
+                    regulator-off-in-suspend;
+                };
+            };
+
+            vcc_3v0: LDO_REG7 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-max-microvolt = <3000000>;
+                regulator-min-microvolt = <3000000>;
+                regulator-name = "vcc_3v0";
+                regulator-state-mem {
+                    regulator-off-in-suspend;
+                };
+            };
+
+            vccio_sd: LDO_REG8 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-max-microvolt = <3300000>;
+                regulator-min-microvolt = <1800000>;
+                regulator-name = "vccio_sd";
+                regulator-state-mem {
+                    regulator-off-in-suspend;
+                };
+            };
+
+            vcc_sd: LDO_REG9 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-max-microvolt = <3300000>;
+                regulator-min-microvolt = <3300000>;
+                regulator-name = "vcc_sd";
+                regulator-state-mem {
+                    regulator-off-in-suspend;
+                };
+            };
+
+            vcc5v0_usb: SWITCH_REG1 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-name = "vcc5v0_usb";
+                regulator-state-mem {
+                    regulator-on-in-suspend;
+                };
+            };
+
+            vccio_3v3: SWITCH_REG2 {
+                regulator-always-on;
+                regulator-boot-on;
+                regulator-name = "vccio_3v3";
+                regulator-state-mem {
+                    regulator-off-in-suspend;
Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 290

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +6 -0
+                };
+            };
+        };
+    };
+
+    vdd_cpu_b: tcs4525@1c {

Please set the node name to regulator@1c.

Will fix in v3.

Quoted 20 lines
Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +8 -0
+        compatible = "tcs,tcs4525";
+        reg = <0x1c>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&vsel1_gpio>;
+        fcs,suspend-voltage-selector = <1>;
+        vin-supply = <&vcc5v0_sys>;
+        vsel-gpios = <&gpio1 RK_PC1 GPIO_ACTIVE_HIGH>;
+        regulator-compatible = "fan53555-reg";

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 308

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+        regulator-always-on;
+        regulator-boot-on;
+        regulator-initial-state = <3>;
+        regulator-max-microvolt = <1500000>;
+        regulator-min-microvolt = <712500>;
+        regulator-name = "vdd_cpu_b";
+        regulator-ramp-delay = <1000>;
+        regulator-state-mem {
+            regulator-off-in-suspend;
+        };
Quoted 1 line

Properties order and blank line before child node, see https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html

Will fix in v3.

Quoted 7 lines

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 311

Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +3 -0
+    };
+
+    vdd_gpu: tcs4526@10 {

Please set node name to regulator@10.

Quoted 7 lines

Please order child nodes in busses based on their address, i.e.:

vdd_gpu
vdd_cpu_b
rk809

in this case.

Will fix in v3.

Quoted 21 lines
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +8 -0
+        compatible = "tcs,tcs4525";
+        reg = <0x10>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&vsel2_gpio>;
+        fcs,suspend-voltage-selector = <1>;
+        vin-supply = <&vcc5v0_sys>;
+        vsel-gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_HIGH>;
+        regulator-compatible = "fan53555-reg";

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 329

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+        regulator-always-on;
+        regulator-boot-on;
+        regulator-initial-state = <3>;
+        regulator-max-microvolt = <1500000>;
+        regulator-min-microvolt = <712500>;
+        regulator-name = "vdd_gpu";
+        regulator-ramp-delay = <1000>;
+        regulator-state-mem {
+            regulator-off-in-suspend;
+        };
Quoted 1 line

Properties order and blank line before child node, see https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html

Will fix in v3.

Quoted 14 lines

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 339

Quoted 11 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +10 -0
+    };
+};
+
+&io_domains {
+    audio-supply = <&vcca_1v8>;
+    bt656-supply = <&vcc_3v0>;
+    gpio1830-supply = <&vcc_3v0>;
+    sdmmc-supply = <&vccio_sd>;
+    status = "okay";
+};

What about pmu_io_domains too?

Sorry, I missed it. Will fix in v3.

Quoted 11 lines
Quoted 11 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +11 -0
+
+&sdmmc {
+    bus-width = <4>;
+    cap-mmc-highspeed;
+    cap-sd-highspeed;
+    disable-wp;
+    no-sdio;
+    no-mmc;
+    pinctrl-names = "default";
+    pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
+    sd-uhs-sdr104;
Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 356

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +6 -0
+    vmmc-supply = <&vcc_sd>;
+    vqmmc-supply = <&vccio_sd>;
+    status = "okay";
+};
+
+&sdhci {

This should be before sdmmc

Will fix in v3.

Quoted 13 lines
Quoted 13 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +12 -0
+    bus-width = <8>;
+    keep-power-in-suspend;
+    mmc-hs400-1_8v;
+    mmc-hs400-enhanced-strobe;
+    no-sdio;
+    no-sd;
+    non-removable;
+    status = "okay";
+};
+
+&tcphy0 {
+    status = "okay";
Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 374

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +6 -0
+};
+
+&tcphy1 {
+    status = "okay";
+};
+

What about tsadc?

Oh, there's a tsadc. I'll add it in v3.

Quoted 57 lines
Quoted 57 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +56 -0
+&u2phy0 {
+    status = "okay";
+};
+
+&u2phy0_host {
+    status = "okay";
+};
+
+&u2phy0_otg {
+    status = "okay";
+};
+
+&u2phy1 {
+    status = "okay";
+};
+
+&u2phy1_host {
+    status = "okay";
+};
+
+&u2phy1_otg {
+    status = "okay";
+};
+
+&uart2 {
+    status = "okay";
+};
+
+&usbdrd_dwc3_0 {
+    status = "okay";
+};
+
+&usbdrd3_0 {
+    status = "okay";
+};
+
+&usbdrd3_1 {
+    status = "okay";
+};
+
+&usbdrd_dwc3_1 {
+    dr_mode = "host";
+    status = "okay";
+};
+
+&usb_host0_ehci {
+    status = "okay";
+};
+
+&usb_host0_ohci {
+    status = "okay";
+};
+
+&usb_host1_ehci {
+    status = "okay";
+};
Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts line 436

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts new file +6 -0
+
+&usb_host1_ohci {
+    status = "okay";
+};
+
+&pinctrl {

This needs to be ordered alphabetically, see https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html (so before sdhci here).

Thank you for the quick reply! I will fix them in v3.

Quoted 4 lines

Cheers,
Quentin

#8 lore raw
In reply to Chaoyi Chen
Quoted 28 lines · Chaoyi Chen

From: Chaoyi Chen <[email protected]>

General feature for rk3399 industry evaluation board:
- Rockchip RK3399
- 4GB LPDDR4
- emmc5.1
- SDIO3.0 compatible TF card
- 1x HDMI2.0a TX
- 1x HDMI1.4b RX with TC358749XBG HDMI to MIPI CSI2 bridge chip
- 1x type-c DisplayPort
- 3x USB3.0 Host
- 1x USB2.0 Host
- 1x Ethernet / USB3.0 to Ethernet

Tested with HDMI/GPU/USB2.0/USB3.0/TF card/emmc.

Changes in v2:
- Link to V1: https://lore.kernel.org/all/[email protected]/
- Remove gmac
- Add rk809 PMIC
- Add CPU supply
- Fix io-domain for sdmmc
- Enable vopl

Chaoyi Chen (2):
dt-bindings: arm: rockchip: Add rk3399 industry evaluation board
arm64: dts: rockchip: Add rk3399-evb-ind board

Quoted 11 lines
 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3399-evb-ind.dts      | 466 ++++++++++++++++++
 3 files changed, 472 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dts

--
2.49.0

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/v6.15-rc1-23-g0d0947766d87 (exact match)

If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for [email protected]:

arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: /dp@fec00000: failed to match any schema with compatible: ['rockchip,rk3399-cdn-dp'] arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: pmic@20 (rockchip,rk809): 'pmic-reset-func' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk817.yaml#
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: tcs4525@1c (tcs,tcs4525): Unevaluated properties are not allowed ('regulator-compatible', 'regulator-initial-state' were unexpected)
from schema $id: http://devicetree.org/schemas/regulator/fcs,fan53555.yaml#
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: tcs4526@10 (tcs,tcs4525): Unevaluated properties are not allowed ('regulator-compatible', 'regulator-initial-state' were unexpected)
from schema $id: http://devicetree.org/schemas/regulator/fcs,fan53555.yaml#
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: /syscon@ff770000/pcie-phy: failed to match any schema with compatible: ['rockchip,rk3399-pcie-phy'] arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: /phy@ff7c0000: failed to match any schema with compatible: ['rockchip,rk3399-typec-phy'] arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: /phy@ff800000: failed to match any schema with compatible: ['rockchip,rk3399-typec-phy'] arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: pmic: vsel1-gpio: {'rockchip,pins': [[1, 17, 0, 169]], 'phandle': 117} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3399-evb-ind.dtb: pmic: vsel2-gpio: {'rockchip,pins': [[1, 14, 0, 169]], 'phandle': 118} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#