Skip to contentSkip to conversation

dt-bindings: interrupt-controller: Convert marvell,cp110-icu to DT schema

PATCH In review Rob Herring (Arm) 2 participants 2 messages May 5, 2025 – May 12, 2025

Subsystems (2)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: interrupt-controller: Convert marvell,cp110-icu to DT schema

Convert the Marvell ICU interrupt controller to DT schema format.

Add the missing addressing properties to read and translate child node addresses.

Drop the legacy binding description and example.

---
 .../marvell,cp110-icu.yaml                    |  98 +++++++++++++++
 .../interrupt-controller/marvell,icu.txt      | 112 ------------------
 2 files changed, 98 insertions(+), 112 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,cp110-icu.yaml
 delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,icu.txt
Documentation/devicetree/bindings/interrupt-controller/marvell,cp110-icu.yaml new file +98 -0
new file mode 100644
index 000000000000..9d4f06f45372
@@ -0,0 +1,98 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/marvell,cp110-icu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+maintainers:
+  - Miquel Raynal <[email protected]>
+  - Thomas Petazzoni <[email protected]>
+
+title: Marvell ICU Interrupt Controller
+
+description:
+  The Marvell ICU (Interrupt Consolidation Unit) controller is responsible for
+  collecting all wired-interrupt sources in the CP and communicating them to the
+  GIC in the AP. The unit translates interrupt requests on input wires to MSG
+  memory mapped transactions to the GIC. These messages access different GIC
+  memory areas depending on their type (NSR, SR, SEI, REI, etc).
+
+properties:
+  compatible:
+    const: marvell,cp110-icu
+
+  reg:
+    maxItems: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 1
+
+  ranges: true
+
+patternProperties:
+  "^interrupt-controller@":
+    type: object
+    description: Interrupt group child nodes
+    additionalProperties: false
+
+    properties:
+      compatible:
+        enum:
+          - marvell,cp110-icu-nsr
+          - marvell,cp110-icu-sr
+          - marvell,cp110-icu-sei
+          - marvell,cp110-icu-rei
+
+      reg:
+        maxItems: 1
+
+      '#interrupt-cells':
+        const: 2
+
+      interrupt-controller: true
+
+      msi-parent:
+        maxItems: 1
+        description: Phandle to the GICP controller
+
+    required:
+      - compatible
+      - reg
+      - '#interrupt-cells'
+      - interrupt-controller
+      - msi-parent
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    interrupt-controller@1e0000 {
+        compatible = "marvell,cp110-icu";
+        reg = <0x1e0000 0x440>;
+        #address-cells = <1>;
+        #size-cells = <1>;
+        ranges;
+
+        interrupt-controller@10 {
+                compatible = "marvell,cp110-icu-nsr";
+                reg = <0x10 0x20>;
+                #interrupt-cells = <2>;
+                interrupt-controller;
+                msi-parent = <&gicp>;
+        };
+
+        interrupt-controller@50 {
+                compatible = "marvell,cp110-icu-sei";
+                reg = <0x50 0x10>;
+                #interrupt-cells = <2>;
+                interrupt-controller;
+                msi-parent = <&sei>;
+        };
+    };
Documentation/devicetree/bindings/interrupt-controller/marvell,icu.txt deleted +0 -112

112 lines not on this page · raw message

Signature · 1 line
2.47.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Rob,

Quoted 6 lines · Rob Herring (Arm)

Convert the Marvell ICU interrupt controller to DT schema format.

Add the missing addressing properties to read and translate child node addresses.

Drop the legacy binding description and example.

I thought these should be kept, but in general I am fine dropping them. Thanks for the conversion.

Miquèl