Skip to contentSkip to conversation

dt-bindings: interrupt-controller: Convert marvell,orion-bridge-intc to DT schema

PATCH In review Rob Herring (Arm) 2 participants 4 messages May 5, 2025

Subsystems (2)
Device tree bindings irqchip drivers
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: interrupt-controller: Convert marvell,orion-bridge-intc to DT schema

Convert the Marvell Orion bridge interrupt controller binding to schema format.

marvell,orion-intc is already covered by mrvl,intc.yaml schema, so it can be dropped.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 .../marvell,orion-bridge-intc.yaml            | 53 +++++++++++++++++++
 .../marvell,orion-intc.txt                    | 48 -----------------
 2 files changed, 53 insertions(+), 48 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml
 delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,orion-intc.txt
Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml new file +53 -0
new file mode 100644
index 000000000000..d71ae877f488
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+---
+$id: http://devicetree.org/schemas/interrupt-controller/marvell,orion-bridge-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Orion SoC Bridge Interrupt Controller
+
+maintainers:
+  - Andrew Lunn <[email protected]>
+  - Sebastian Hesselbarth <[email protected]>
+  - Gregory Clement <[email protected]>
+
+properties:
+  compatible:
+    const: marvell,orion-bridge-intc
+
+  reg:
+    minItems: 1
+    maxItems: 2
+
+  interrupt-controller: true
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupts:
+    description: Bridge interrupt of the main interrupt controller
+
+  marvell,#interrupts:
+    description: Number of interrupts provided by bridge interrupt controller.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    default: 32
+
+required:
+  - compatible
+  - reg
+  - interrupt-controller
+  - '#interrupt-cells'
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    interrupt-controller@20110 {
+        compatible = "marvell,orion-bridge-intc";
+        reg = <0x20110 0x8>;
+        interrupt-controller;
+        #interrupt-cells = <1>;
+        interrupts = <0>;
+        /* Dove bridge provides 5 interrupts */
+        marvell,#interrupts = <5>;
+    };
Documentation/devicetree/bindings/interrupt-controller/marvell,orion-intc.txt deleted +0 -48

48 lines not on this page · raw message

Signature · 1 line
2.47.2
Reviewed-by on v1 1/1
#1 lore raw

Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml line 10

Quoted 12 lines

+++ b/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml

Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml new file +10 -0
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+---
+$id: http://devicetree.org/schemas/interrupt-controller/marvell,orion-bridge-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Orion SoC Bridge Interrupt Controller
+
+maintainers:
+  - Andrew Lunn <[email protected]>
+  - Sebastian Hesselbarth <[email protected]>

You should probably drop Sebastian. I've not heard from him in years.

Apart from that:

Reviewed-by Andrew Lunn <[email protected]>

Andrew

author maintainer
#2 lore raw
Quoted 15 lines · Andrew Lunn

Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml line 10

Quoted 13 lines

+++ b/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml

Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml new file +10 -0
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+---
+$id: http://devicetree.org/schemas/interrupt-controller/marvell,orion-bridge-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Orion SoC Bridge Interrupt Controller
+
+maintainers:
+  - Andrew Lunn <[email protected]>
+  - Sebastian Hesselbarth <[email protected]>

You should probably drop Sebastian. I've not heard from him in years.

Okay. I would have (probably) if he was not still listed in MAINTAINERS. Perhaps should be dropped from there too?

Note that the lists here were all generated from what MAINTAINERS said (if anything) or the author(s) of the original .txt binding.

Rob

#3 lore raw
Quoted 17 lines · Rob Herring
Quoted 15 lines · Andrew Lunn

Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml line 10

Quoted 13 lines

+++ b/Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml

Documentation/devicetree/bindings/interrupt-controller/marvell,orion-bridge-intc.yaml new file +10 -0
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+---
+$id: http://devicetree.org/schemas/interrupt-controller/marvell,orion-bridge-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Orion SoC Bridge Interrupt Controller
+
+maintainers:
+  - Andrew Lunn <[email protected]>
+  - Sebastian Hesselbarth <[email protected]>

You should probably drop Sebastian. I've not heard from him in years.

Quoted 2 lines

Okay. I would have (probably) if he was not still listed in MAINTAINERS. Perhaps should be dropped from there too?

Yes.

Jakub Kicinski has a script he runs about once a year which compares MAINTAINER entries for networking against activity on the netdev list. Any email address which has not been active for a few years gets a patch to remove it from MAINTAINERS and sometimes add an entry to CREDITs. Maybe this can be generalised, run it against all the lore archive?

Andrew