Skip to contentSkip to conversation

dt-bindings: interrupt-controller: Convert chrp,open-pic to DT schema

PATCH In review Rob Herring (Arm) 2 participants 2 messages May 5, 2025 – May 13, 2025

Subsystems (2)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: interrupt-controller: Convert chrp,open-pic to DT schema

Convert the Open PIC interrupt controller binding to schema format.

While the Linux kernel supports the "open-pic" compatible, that's not used in any upstream .dts file. It used for "device_type" though. Add "fsl,mpic" compatible which was not documented.

---
 .../interrupt-controller/chrp,open-pic.yaml   | 63 ++++++++++++
 .../interrupt-controller/open-pic.txt         | 97 -------------------
 2 files changed, 63 insertions(+), 97 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/chrp,open-pic.yaml
 delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/open-pic.txt
Documentation/devicetree/bindings/interrupt-controller/chrp,open-pic.yaml new file +63 -0
new file mode 100644
index 000000000000..f0d9bbd7d510
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/chrp,open-pic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Open PIC Interrupt Controller
+
+maintainers:
+  - Rob Herring <[email protected]>
+
+description:
+  This binding specifies what properties must be available in the device tree
+  representation of an Open PIC compliant interrupt controller.  This binding is
+  based on the binding defined for Open PIC in [1] and is a superset of that
+  binding.
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - const: fsl,mpic
+          - const: chrp,open-pic
+      - const: chrp,open-pic
+
+  device_type:
+    const: open-pci
+    deprecated: true
+
+  reg:
+    maxItems: 1
+
+  interrupt-controller: true
+
+  '#address-cells':
+    const: 0
+
+  '#interrupt-cells':
+    const: 2
+
+  pic-no-reset:
+    description: Indicates the PIC shall not be reset during runtime initialization.
+    type: boolean
+
+required:
+  - compatible
+  - reg
+  - interrupt-controller
+  - '#address-cells'
+  - '#interrupt-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    interrupt-controller@40000 {
+        compatible = "chrp,open-pic";
+        reg = <0x40000 0x40000>;
+        interrupt-controller;
+        #address-cells = <0>;
+        #interrupt-cells = <2>;
+        pic-no-reset;
+    };
Documentation/devicetree/bindings/interrupt-controller/open-pic.txt deleted +0 -97

97 lines not on this page · raw message

Signature · 1 line
2.47.2
#1 lore raw

Hi Rob,

Quoted 7 lines · Rob Herring (Arm)

Convert the Open PIC interrupt controller binding to schema format.

While the Linux kernel supports the "open-pic" compatible, that's not used in any upstream .dts file. It used for "device_type" though. Add "fsl,mpic" compatible which was not documented.

Thanks for your patch, which is now commit 45168cd2df5019cf ("dt-bindings: interrupt-controller: Convert chrp,open-pic to DT schema") in dt-rh/for-next.

FTR, the real Open Firmware in CHRP LongTail also used the full "chrp,open-pic" compatible value.
http://g33rt.be/migrated/Linux/PPC/pci/mac-ioAT2/open-picAT40000/

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds