Skip to contentSkip to conversation

coreutils: remove outdated comment

PATCH Superseded [email protected] 2 participants 2 messages May 6, 2025

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 coreutils: remove outdated comment

From: Etienne Cordonnier <[email protected]>

The comment about hostname not being included in base_bindir_progs is wrong after https://git.yoctoproject.org/poky/commit/?id=b9bf37ec6792f82753fe265fdcfc19db7dd51ab6 , so remove it to avoid confusion.

---
 meta/recipes-core/coreutils/coreutils_9.6.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-core/coreutils/coreutils_9.6.bb +1 -2
index b876a8fdd0..16f56ac772 100644
@@ -50,7 +50,7 @@ PACKAGECONFIG[single-binary] = "--enable-single-binary,--disable-single-binary,,
 PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
 PACKAGECONFIG[openssl] = "--with-openssl=yes,--with-openssl=no,openssl"
 
-# [ df mktemp nice printenv base64 gets a special treatment and is not included in this
+# base32 base64 df mktemp nice printenv get a special treatment and are not included in this
 bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors dirname du \
                 env expand expr factor fmt fold groups head hostid id install \
                 join link logname md5sum mkfifo nl nohup nproc od paste pathchk \
@@ -58,7 +58,6 @@ bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors dirname
                 sha384sum sha512sum shred shuf sort split sum tac tail tee test timeout \
                 tr truncate tsort tty unexpand uniq unlink uptime users vdir wc who whoami yes"
 
-# hostname gets a special treatment and is not included in this
 base_bindir_progs = "cat chgrp chmod chown cp date dd echo false hostname kill ln ls mkdir \
                      mknod mv pwd rm rmdir sleep stty sync touch true uname stat"
 
Signature · 1 line
2.43.0
#1 lore raw
Quoted 24 lines · Etienne Cordonnier via lists.openembedded.org

From: Etienne Cordonnier <[email protected]>

The comment about hostname not being included in base_bindir_progs is wrong after
https://git.yoctoproject.org/poky/commit/?id=b9bf37ec6792f82753fe265fdcfc19db7dd51ab6
,
so remove it to avoid confusion.

---
 meta/recipes-core/coreutils/coreutils_9.6.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-core/coreutils/coreutils_9.6.bb +0 -1
index b876a8fdd0..16f56ac772 100644
@@ -50,7 +50,7 @@ PACKAGECONFIG[single-binary] =
 "--enable-single-binary,--disable-single-binary,,
 PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
 PACKAGECONFIG[openssl] = "--with-openssl=yes,--with-openssl=no,openssl"
 
-# [ df mktemp nice printenv base64 gets a special treatment and is not
Quoted 4 lines

included in this
+# base32 base64 df mktemp nice printenv get a special treatment and are not included in this

You dropped the '[' here which in this context is "alias of test" if I'm not wrong.
Also, this hunk is not related to the commit message so maybe you did not want to add it?

Quoted 34 lines

bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors
dirname du \
env expand expr factor fmt fold groups head hostid id
install \
join link logname md5sum mkfifo nl nohup nproc od paste
pathchk \

meta/recipes-core/coreutils/coreutils_9.6.bb +0 -0
@@ -58,7 +58,6 @@ bindir_progs = "arch basename chcon cksum comm csplit

cut dir dircolors dirname
sha384sum sha512sum shred shuf sort split sum tac tail
tee test timeout \
tr truncate tsort tty unexpand uniq unlink uptime users
vdir wc who whoami yes"

-# hostname gets a special treatment and is not included in this
base_bindir_progs = "cat chgrp chmod chown cp date dd echo false hostname
kill ln ls mkdir \
mknod mv pwd rm rmdir sleep stty sync touch true
uname stat"

--
2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#216035):
https://lists.openembedded.org/g/openembedded-core/message/216035
Mute This Topic: https://lists.openembedded.org/mt/112646299/4316185
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 2 lines
Yoann Congal
Smile ECS