Skip to contentSkip to conversation

dt-bindings: display/msm: hdmi: Fix constraints on additional 'port' properties

PATCH In review Rob Herring (Arm) 2 participants 4 messages May 7, 2025 – May 9, 2025

Subsystems (5)
Device tree bindings DRM drivers DRM misc Arm Qualcomm mailing list +1 more subsystems
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: display/msm: hdmi: Fix constraints on additional 'port' properties

The MSM HDMI port nodes are missing any restrictions on additional properties. The $ref should be to "/properties/port" rather than "/$defs/port-base" as there are not additional properties in the nodes to define.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 Documentation/devicetree/bindings/display/msm/hdmi.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/msm/hdmi.yaml +2 -2
index d4a2033afea8..099274d35680 100644
@@ -89,12 +89,12 @@ properties:
     $ref: /schemas/graph.yaml#/properties/ports
     properties:
       port@0:
-        $ref: /schemas/graph.yaml#/$defs/port-base
+        $ref: /schemas/graph.yaml#/properties/port
         description: |
           Input endpoints of the controller.
 
       port@1:
-        $ref: /schemas/graph.yaml#/$defs/port-base
+        $ref: /schemas/graph.yaml#/properties/port
         description: |
           Output endpoints of the controller.
Signature · 1 line
2.47.2
author maintainer
#1 lore raw
Quoted 10 lines · Rob Herring (Arm)

The MSM HDMI port nodes are missing any restrictions on additional properties. The $ref should be to "/properties/port" rather than "/$defs/port-base" as there are not additional properties in the nodes to define.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 Documentation/devicetree/bindings/display/msm/hdmi.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.

Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 9 lines · Rob Herring (Arm)

The MSM HDMI port nodes are missing any restrictions on additional properties. The $ref should be to "/properties/port" rather than "/$defs/port-base" as there are not additional properties in the nodes to define.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 Documentation/devicetree/bindings/display/msm/hdmi.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by Dmitry Baryshkov <[email protected]>

I've verified, it applies on top of msm-next and produces no errors. I don't see a meaningful error in the bot's message (Rob, is there a chance to fix the bot?).

Quoted 23 lines
Documentation/devicetree/bindings/display/msm/hdmi.yaml +2 -2
index d4a2033afea8..099274d35680 100644
@@ -89,12 +89,12 @@ properties:
     $ref: /schemas/graph.yaml#/properties/ports
     properties:
       port@0:
-        $ref: /schemas/graph.yaml#/$defs/port-base
+        $ref: /schemas/graph.yaml#/properties/port
         description: |
           Input endpoints of the controller.
 
       port@1:
-        $ref: /schemas/graph.yaml#/$defs/port-base
+        $ref: /schemas/graph.yaml#/properties/port
         description: |
           Output endpoints of the controller.
Signature · 1 line
2.47.2
Signature · 2 lines
With best wishes
Dmitry
author maintainer
#3 lore raw
Quoted 12 lines · Dmitry Baryshkov
Quoted 9 lines · Rob Herring (Arm)

The MSM HDMI port nodes are missing any restrictions on additional properties. The $ref should be to "/properties/port" rather than "/$defs/port-base" as there are not additional properties in the nodes to define.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 Documentation/devicetree/bindings/display/msm/hdmi.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines
Reviewed-by Dmitry Baryshkov <[email protected]>

I've verified, it applies on top of msm-next and produces no errors. I don't see a meaningful error in the bot's message (Rob, is there a chance to fix the bot?).

The problem was I broke dtschema on python 3.11 and earlier. It's now fixed.

Rob