Skip to contentSkip to conversation

net: mlx4: add SOF_TIMESTAMPING_TX_SOFTWARE flag when getting ts info

PATCH Applied Jason Xing 3 participants 3 messages May 10, 2025 – May 13, 2025

Subsystems (4)
Networking Network drivers Mellanox MLX4 core VPI driver Mellanox Ethernet driver (mlx4_en)
lore
Share & tools
lore

Jason Xing

author
#0 lore raw

PATCH 1/1 net: mlx4: add SOF_TIMESTAMPING_TX_SOFTWARE flag when getting ts info

From: Jason Xing <[email protected]>

As mlx4 has implemented skb_tx_timestamp() in mlx4_en_xmit(), the SOFTWARE flag is surely needed when users are trying to get timestamp information.

Signed-off-by Jason Xing <[email protected]>
---
 drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c +1 -0
index cd17a3f4faf8..a68cd3f0304c 100644
@@ -1897,6 +1897,7 @@ static int mlx4_en_get_ts_info(struct net_device *dev,
 	if (mdev->dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_TS) {
 		info->so_timestamping |=
 			SOF_TIMESTAMPING_TX_HARDWARE |
+			SOF_TIMESTAMPING_TX_SOFTWARE |
 			SOF_TIMESTAMPING_RX_HARDWARE |
 			SOF_TIMESTAMPING_RAW_HARDWARE;
Signature · 1 line
2.43.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Jason Xing

From: Jason Xing <[email protected]>

As mlx4 has implemented skb_tx_timestamp() in mlx4_en_xmit(), the SOFTWARE flag is surely needed when users are trying to get timestamp information.

Signed-off-by Jason Xing <[email protected]>
---
  drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 1 +
  1 file changed, 1 insertion(+)
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c +0 -0
index cd17a3f4faf8..a68cd3f0304c 100644

drivers/net/ethernet/mellanox/mlx4/en_ethtool.c static int mlx4_en_get_ts_info(struct net_device *dev, · line 1903

Quoted 7 lines
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c +1 -0
@@ -1897,6 +1897,7 @@ static int mlx4_en_get_ts_info(struct net_device *dev,
  	if (mdev->dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_TS) {
  		info->so_timestamping |=
  			SOF_TIMESTAMPING_TX_HARDWARE |
+			SOF_TIMESTAMPING_TX_SOFTWARE |
  			SOF_TIMESTAMPING_RX_HARDWARE |
  			SOF_TIMESTAMPING_RAW_HARDWARE;

Thanks for your patch.

Reviewed-by Tariq Toukan <[email protected]>
CI Applied
#2 lore raw
In reply to Jason Xing
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Sat, 10 May 2025 17:34:42 +0800 you wrote:

From: Jason Xing <[email protected]>

As mlx4 has implemented skb_tx_timestamp() in mlx4_en_xmit(), the SOFTWARE flag is surely needed when users are trying to get timestamp information.

Signed-off-by Jason Xing <[email protected]>

[...]

Here is the summary with links:
- [net-next] net: mlx4: add SOF_TIMESTAMPING_TX_SOFTWARE flag when getting ts info

    https://git.kernel.org/netdev/net-next/c/b86bcfee3057

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html