Skip to contentSkip to conversation

libsoup-2.4: fix CVE-2024-52532

PATCH New [email protected] 1 participant 1 message May 12, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libsoup-2.4: fix CVE-2024-52532

From: Changqing Li <[email protected]>

CVE-2024-52532:
GNOME libsoup before 3.6.1 has an infinite loop, and memory consumption. during the reading of certain patterns of WebSocket data from clients.

Refer:
https://nvd.nist.gov/vuln/detail/CVE-2024-52532

---
 .../libsoup-2.4/CVE-2024-52532-1.patch        | 37 ++++++++++++++
 .../libsoup-2.4/CVE-2024-52532-2.patch        | 43 +++++++++++++++++
 .../libsoup-2.4/CVE-2024-52532-3.patch        | 48 +++++++++++++++++++
 .../libsoup/libsoup-2.4_2.74.3.bb             |  5 +-
 4 files changed, 132 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-support/libsoup/libsoup-2.4/CVE-2024-52532-1.patch
 create mode 100644 meta/recipes-support/libsoup/libsoup-2.4/CVE-2024-52532-2.patch
 create mode 100644 meta/recipes-support/libsoup/libsoup-2.4/CVE-2024-52532-3.patch
meta/recipes-support/libsoup/libsoup-2.4/CVE-2024-52532-1.patch new file +37 -0
new file mode 100644
index 0000000000..cb1f096110
@@ -0,0 +1,37 @@
+From a693d49bff058fc20a448dc4e7d324ff0dc6597e Mon Sep 17 00:00:00 2001
+From: Ignacio Casal Quinteiro <[email protected]>
+Date: Wed, 11 Sep 2024 11:52:11 +0200
+Subject: [PATCH 1/3] websocket: process the frame as soon as we read data
+
+Otherwise we can enter in a read loop because we were not
+validating the data until the all the data was read.
+
+Fixes #391
+
+CVE: CVE-2024-52532
+Upstream-Status: Backport [https://gitlab.gnome.org/GNOME/libsoup/-/commit/6adc0e3eb74c257ed4e2a23eb4b2774fdb0d67be#f1d67ca0386b145ea201cf88d27f72724d7c6715]
+
+Signed-off-by: Changqing Li <[email protected]>
+---
+ libsoup/soup-websocket-connection.c | 5 ++---
+ 1 file changed, 2 insertions(+), 3 deletions(-)
+
+diff --git a/libsoup/soup-websocket-connection.c b/libsoup/soup-websocket-connection.c
+index a4095e1..65c1492 100644
+--- a/libsoup/soup-websocket-connection.c
++++ b/libsoup/soup-websocket-connection.c
+@@ -1140,9 +1140,8 @@ soup_websocket_connection_read (SoupWebsocketConnection *self)
+ 		}
+ 
+ 		pv->incoming->len = len + count;
+-	} while (count > 0);
+-
+-	process_incoming (self);
++		process_incoming (self);
++	} while (count > 0 && !pv->close_sent && !pv->io_closing);
+ 
+ 	if (end) {
+ 		if (!pv->close_sent || !pv->close_received) {
+-- 
+2.34.1
+
meta/recipes-support/libsoup/libsoup-2.4/CVE-2024-52532-2.patch new file +43 -0

43 lines not on this page · raw message

meta/recipes-support/libsoup/libsoup-2.4/CVE-2024-52532-3.patch new file +48 -0

48 lines not on this page · raw message

meta/recipes-support/libsoup/libsoup-2.4_2.74.3.bb +4 -1
index 25e0d7dcbc..22cbbdb1b8 100644
@@ -13,7 +13,10 @@ SHRT_VER = "${@d.getVar('PV').split('.')[0]}.${@d.getVar('PV').split('.')[1]}"
 
 SRC_URI = "${GNOME_MIRROR}/libsoup/${SHRT_VER}/libsoup-${PV}.tar.xz \
            file://0001-Fix-build-with-libxml2-2.12.0-and-clang-17.patch \
-           file://0001-CVE-2025-32911.patch"
+           file://0001-CVE-2025-32911.patch \
+           file://CVE-2024-52532-1.patch \
+           file://CVE-2024-52532-2.patch \
+           file://CVE-2024-52532-3.patch"
 SRC_URI[sha256sum] = "e4b77c41cfc4c8c5a035fcdc320c7bc6cfb75ef7c5a034153df1413fa1d92f13"
 
 CVE_PRODUCT = "libsoup"
Signature · 1 line
2.34.1