glibc-y2038-tests: remove glibc-y2038-tests_2.39.bb recipe
PATCH 1/1 glibc-y2038-tests: remove glibc-y2038-tests_2.39.bb recipe
This recipe takes longer time >20min when bitbake for package write stage. When cross-verified for longer time duration, found that do_check() stage taking 20min while other stages completes before 6min.
This recipe gives only below two test binaries in the packages to test (ptest: glibc-y2038-tests):
io/ftwtest
io/ftwtest-time64
The above test binaries are already included for testing in recipe glibc-testsuite_2.39.bb.
It is by now well established that glibc itself works as it should, that all affected 32 bit targets are configured to use 64 bit time_t, and that any lingering y2038 issues are in components other than the c library, and usually come from C programming mistakes (e.g. storing timestamps in long). So this recipe seems to be redundant and can be removed.
Review comments for fixing above longer time duration ended up in removing this recipe as a proposal is below
https://lists.openembedded.org/g/openembedded-core/topic/112188476#msg214636
Removed lines having reference to glibc-y2038-tests in the files.
For master branch requested for integration and below is the link
https://lists.openembedded.org/g/openembedded-core/message/215655
--- meta/conf/distro/include/maintainers.inc | 1 - .../distro/include/ptest-packagelists.inc | 2 - meta/conf/distro/include/time64.inc | 2 - .../glibc/glibc-y2038-tests_2.39.bb | 119 ------------------ meta/recipes-core/glibc/glibc/run-ptest | 37 ------ 5 files changed, 161 deletions(-) delete mode 100644 meta/recipes-core/glibc/glibc-y2038-tests_2.39.bb delete mode 100755 meta/recipes-core/glibc/glibc/run-ptest
meta/conf/distro/include/maintainers.inc +0 -1
@@ -210,7 +210,6 @@ RECIPE_MAINTAINER:pn-glibc = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-locale = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-mtrace = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glibc-scripts = "Khem Raj <[email protected]>" -RECIPE_MAINTAINER:pn-glibc-y2038-tests = "Lukasz Majewski <[email protected]>" RECIPE_MAINTAINER:pn-glibc-testsuite = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-gmp = "Khem Raj <[email protected]>" RECIPE_MAINTAINER:pn-glslang = "Jose Quaresma <[email protected]>"
meta/conf/distro/include/ptest-packagelists.inc +0 -2
@@ -81,8 +81,6 @@ PTESTS_FAST = "\ zlib \ libexif \ " -PTESTS_FAST:append:libc-glibc = " glibc-y2038-tests" -PTESTS_PROBLEMS:remove:libc-glibc = "glibc-y2038-tests" PTESTS_FAST:remove:mips64 = "qemu" PTESTS_PROBLEMS:append:mips64 = " qemu" PTESTS_FAST:remove:riscv32 = "qemu"
meta/conf/distro/include/time64.inc +0 -2
@@ -19,7 +19,6 @@ TARGET_CC_ARCH:append:powerpc = "${@bb.utils.contains('TUNE_FEATURES', 'm32', '$ TARGET_CC_ARCH:append:x86 = "${@bb.utils.contains('TUNE_FEATURES', 'm32', '${GLIBC_64BIT_TIME_FLAGS}', '', d)}" GLIBC_64BIT_TIME_FLAGS:pn-glibc = "" -GLIBC_64BIT_TIME_FLAGS:pn-glibc-y2038-tests = "" GLIBC_64BIT_TIME_FLAGS:pn-glibc-testsuite = "" # pipewire-v4l2 explicitly sets _FILE_OFFSET_BITS=32 to get access to # both 32 and 64 bit file APIs. But it does not handle the time side?
@@ -36,7 +35,6 @@ GLIBC_64BIT_TIME_FLAGS:pn-gcc-sanitizers = "" # Caused by the flags exceptions above INSANE_SKIP:append:pn-gcc-sanitizers = " 32bit-time" INSANE_SKIP:append:pn-glibc = " 32bit-time" -INSANE_SKIP:append:pn-glibc-y2038-tests = " 32bit-time" INSANE_SKIP:append:pn-pulseaudio = " 32bit-time" # Strace has tests that call 32 bit API directly, which is fair enough, e.g.
meta/recipes-core/glibc/glibc-y2038-tests_2.39.bb deleted +0 -119
119 lines not on this page · raw message
meta/recipes-core/glibc/glibc/run-ptest deleted +0 -37
@@ -1,37 +0,0 @@ -#!/bin/bash -# ptest script for glibc - to run time related tests to -# facilitate Y2038 validation -# Run with 'ptest-runner glibc-tests' - -output() { - retcode=$? - if [ $retcode -eq 0 ] - then echo "PASS: $i" - elif [ $retcode -eq 77 ] - then echo "SKIP: $i" - else echo "FAIL: $i" - fi -} - -# Allow altering time on the target -export GLIBC_TEST_ALLOW_TIME_SETTING="1" - -tst_time64=$(ls -r ${PWD}/tests/glibc-ptest/*-time64) - -# Remove '-time64' suffix - those tests are also time -# related -tst_time_tmp=$(sed -e "s/-time64$//" <<< ${tst_time64}) - -# Do not run tests supporting only 32 bit time -#for i in ${tst_time_tmp} -#do -# $i >/dev/null 2>&1 -# output -#done - -# Run tests supporting only 64 bit time -for i in ${tst_time64} -do - $i >/dev/null 2>&1 - output -done
Signature · 1 line
2.34.1