dt-bindings: ata: Convert marvell,orion-sata to DT schema
Subsystems (2)
Rob Herring (Arm)
maintainerPATCH 1/1 dt-bindings: ata: Convert marvell,orion-sata to DT schema
Convert the Marvell Orion SATA Controller to DT schema format.
The clocks and clock-names properties were missing. The names for phy-names were incorrect. The maximum "nr-ports" was determined from the Linux driver.
--- .../bindings/ata/marvell,orion-sata.yaml | 83 +++++++++++++++++++ .../devicetree/bindings/ata/marvell.txt | 22 ----- 2 files changed, 83 insertions(+), 22 deletions(-) create mode 100644 Documentation/devicetree/bindings/ata/marvell,orion-sata.yaml delete mode 100644 Documentation/devicetree/bindings/ata/marvell.txt
Documentation/devicetree/bindings/ata/marvell,orion-sata.yaml new file +83 -0
@@ -0,0 +1,83 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/ata/marvell,orion-sata.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Marvell Orion SATA + +maintainers: + - Andrew Lunn <[email protected]> + - Gregory Clement <[email protected]> + +allOf: + - $ref: sata-common.yaml# + +properties: + compatible: + enum: + - marvell,orion-sata + - marvell,armada-370-sata + + reg: + maxItems: 1 + + clocks: + minItems: 1 + maxItems: 8 + + clock-names: + minItems: 1 + items: + - const: '0' + - const: '1' + - const: '2' + - const: '3' + - const: '4' + - const: '5' + - const: '6' + - const: '7' + + interrupts: + maxItems: 1 + + nr-ports: + description: + Number of SATA ports in use. + $ref: /schemas/types.yaml#/definitions/uint32 + maximum: 8 + + phys: + minItems: 1 + maxItems: 8 + + phy-names: + minItems: 1 + items: + - const: port0 + - const: port1 + - const: port2 + - const: port3 + - const: port4 + - const: port5 + - const: port6 + - const: port7 + +required: + - compatible + - reg + - interrupts + - nr-ports + +unevaluatedProperties: false + +examples: + - | + sata@80000 { + compatible = "marvell,orion-sata"; + reg = <0x80000 0x5000>; + interrupts = <21>; + phys = <&sata_phy0>, <&sata_phy1>; + phy-names = "port0", "port1"; + nr-ports = <2>; + };
Documentation/devicetree/bindings/ata/marvell.txt deleted +0 -22
@@ -1,22 +0,0 @@ -* Marvell Orion SATA - -Required Properties: -- compatibility : "marvell,orion-sata" or "marvell,armada-370-sata" -- reg : Address range of controller -- interrupts : Interrupt controller is using -- nr-ports : Number of SATA ports in use. - -Optional Properties: -- phys : List of phandles to sata phys -- phy-names : Should be "0", "1", etc, one number per phandle - -Example: - - sata@80000 { - compatible = "marvell,orion-sata"; - reg = <0x80000 0x5000>; - interrupts = <21>; - phys = <&sata_phy0>, <&sata_phy1>; - phy-names = "0", "1"; - nr-ports = <2>; - }
Signature · 1 line
2.47.2
Quoted 5 lines · Rob Herring (Arm)
Convert the Marvell Orion SATA Controller to DT schema format.
The clocks and clock-names properties were missing. The names for phy-names were incorrect. The maximum "nr-ports" was determined from the Linux driver.
Hi Rob
All the SoCs using this IP have either 1 or 2 ports. There was a PCI card using the same IP which had more ports, but that obviously does not use the binding.
So if you want you could reduce down all the lists to two items.
Andrew
Quoted 7 lines · Rob Herring (Arm)
Convert the Marvell Orion SATA Controller to DT schema format.
The clocks and clock-names properties were missing. The names for phy-names were incorrect. The maximum "nr-ports" was determined from the Linux driver.
Signed-off-by Rob Herring (Arm) <[email protected]>
Applied to for-6.16. Thanks !
Signature · 2 lines
Damien Le Moal Western Digital Research