Skip to contentSkip to conversation

xfs: remove the EXPERIMENTAL warning for pNFS

PATCH Superseded Christoph Hellwig 3 participants 3 messages May 13, 2025 XFS filesystem

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: remove the EXPERIMENTAL warning for pNFS

The pNFS layout support has been around for 10 years without major issues, drop the EXPERIMENTAL warning.

---

This is ontop of "xfs: remove some EXPERIMENTAL warnings" from Darrick.

 fs/xfs/xfs_message.c | 4 ----
 fs/xfs/xfs_message.h | 1 -
 fs/xfs/xfs_pnfs.c    | 2 --
 3 files changed, 7 deletions(-)
fs/xfs/xfs_message.c +0 -4
index 54fc5ada519c..19aba2c3d525 100644
@@ -141,10 +141,6 @@ xfs_warn_experimental(
 		const char		*name;
 		long			opstate;
 	} features[] = {
-		[XFS_EXPERIMENTAL_PNFS] = {
-			.opstate	= XFS_OPSTATE_WARNED_PNFS,
-			.name		= "pNFS",
-		},
 		[XFS_EXPERIMENTAL_SHRINK] = {
 			.opstate	= XFS_OPSTATE_WARNED_SHRINK,
 			.name		= "online shrink",
fs/xfs/xfs_message.h +0 -1
index bce9942f394a..d68e72379f9d 100644
@@ -91,7 +91,6 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
 			       const char *fmt, ...);
 
 enum xfs_experimental_feat {
-	XFS_EXPERIMENTAL_PNFS,
 	XFS_EXPERIMENTAL_SHRINK,
 	XFS_EXPERIMENTAL_LARP,
 	XFS_EXPERIMENTAL_LBS,
fs/xfs/xfs_pnfs.c +0 -2
index 6f4479deac6d..afe7497012d4 100644
@@ -58,8 +58,6 @@ xfs_fs_get_uuid(
 {
 	struct xfs_mount	*mp = XFS_M(sb);
 
-	xfs_warn_experimental(mp, XFS_EXPERIMENTAL_PNFS);
-
 	if (*len < sizeof(uuid_t))
 		return -EINVAL;
 
Signature · 1 line
2.47.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Christoph Hellwig

The pNFS layout support has been around for 10 years without major issues, drop the EXPERIMENTAL warning.

10 years is fair enough :)

Quoted 53 lines

---

This is ontop of "xfs: remove some EXPERIMENTAL warnings" from Darrick.

 fs/xfs/xfs_message.c | 4 ----
 fs/xfs/xfs_message.h | 1 -
 fs/xfs/xfs_pnfs.c    | 2 --
 3 files changed, 7 deletions(-)
fs/xfs/xfs_message.c +0 -4
index 54fc5ada519c..19aba2c3d525 100644
@@ -141,10 +141,6 @@ xfs_warn_experimental(
 		const char		*name;
 		long			opstate;
 	} features[] = {
-		[XFS_EXPERIMENTAL_PNFS] = {
-			.opstate	= XFS_OPSTATE_WARNED_PNFS,
-			.name		= "pNFS",
-		},
 		[XFS_EXPERIMENTAL_SHRINK] = {
 			.opstate	= XFS_OPSTATE_WARNED_SHRINK,
 			.name		= "online shrink",
fs/xfs/xfs_message.h +0 -1
index bce9942f394a..d68e72379f9d 100644
@@ -91,7 +91,6 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
 			       const char *fmt, ...);
 
 enum xfs_experimental_feat {
-	XFS_EXPERIMENTAL_PNFS,
 	XFS_EXPERIMENTAL_SHRINK,
 	XFS_EXPERIMENTAL_LARP,
 	XFS_EXPERIMENTAL_LBS,
fs/xfs/xfs_pnfs.c +0 -3
index 6f4479deac6d..afe7497012d4 100644
@@ -58,8 +58,6 @@ xfs_fs_get_uuid(
 {
 	struct xfs_mount	*mp = XFS_M(sb);
 
-	xfs_warn_experimental(mp, XFS_EXPERIMENTAL_PNFS);
-
 	if (*len < sizeof(uuid_t))
 		return -EINVAL;
 
--

2.47.2

#2 lore raw
In reply to Christoph Hellwig
Quoted 18 lines · Christoph Hellwig

The pNFS layout support has been around for 10 years without major issues, drop the EXPERIMENTAL warning.

---

This is ontop of "xfs: remove some EXPERIMENTAL warnings" from Darrick.

 fs/xfs/xfs_message.c | 4 ----
 fs/xfs/xfs_message.h | 1 -
 fs/xfs/xfs_pnfs.c    | 2 --
 3 files changed, 7 deletions(-)
fs/xfs/xfs_message.c +0 -0
index 54fc5ada519c..19aba2c3d525 100644

fs/xfs/xfs_message.c xfs_warn_experimental( · line 145

Quoted 5 lines
fs/xfs/xfs_message.c +0 -2
@@ -141,10 +141,6 @@ xfs_warn_experimental(
 		const char		*name;
 		long			opstate;
 	} features[] = {
-		[XFS_EXPERIMENTAL_PNFS] = {
-			.opstate	= XFS_OPSTATE_WARNED_PNFS,

Looks fine, but you ought to remove XFS_OPSTATE_WARNED_PNFS from xfs_mount.h as I forgot to do in my patch. :(

--D

Quoted 34 lines
fs/xfs/xfs_message.c +0 -2
-			.name		= "pNFS",
-		},
 		[XFS_EXPERIMENTAL_SHRINK] = {
 			.opstate	= XFS_OPSTATE_WARNED_SHRINK,
 			.name		= "online shrink",
fs/xfs/xfs_message.h +0 -1
index bce9942f394a..d68e72379f9d 100644
@@ -91,7 +91,6 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
 			       const char *fmt, ...);
 
 enum xfs_experimental_feat {
-	XFS_EXPERIMENTAL_PNFS,
 	XFS_EXPERIMENTAL_SHRINK,
 	XFS_EXPERIMENTAL_LARP,
 	XFS_EXPERIMENTAL_LBS,
fs/xfs/xfs_pnfs.c +0 -2
index 6f4479deac6d..afe7497012d4 100644
@@ -58,8 +58,6 @@ xfs_fs_get_uuid(
 {
 	struct xfs_mount	*mp = XFS_M(sb);
 
-	xfs_warn_experimental(mp, XFS_EXPERIMENTAL_PNFS);
-
 	if (*len < sizeof(uuid_t))
 		return -EINVAL;
 
Signature · 1 line
2.47.2