Skip to contentSkip to conversation

hwmon: (lm75) Fix I3C transfer buffer pointer for incoming data

PATCH Applied Jarkko Nikula 3 participants 3 messages May 13, 2025 – May 14, 2025 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (lm75) Fix I3C transfer buffer pointer for incoming data

Use the I3C private transfer input buffer pointer for incoming data instead of output buffer. For now this is harmless since both of those pointers are union members but may confuse when reading the code.

---
Build tested only.

---
 drivers/hwmon/lm75.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/lm75.c +1 -1
index d95a3c6c245c..9b4875e2fd8d 100644
@@ -622,7 +622,7 @@ static int lm75_i3c_reg_read(void *context, unsigned int reg, unsigned int *val)
 		{
 			.rnw = true,
 			.len = 2,
-			.data.out = data->val_buf,
+			.data.in = data->val_buf,
 		},
 	};
 	int ret;
Signature · 1 line
2.47.2
maintainer Applied
#1 lore raw
Quoted 5 lines · Jarkko Nikula

Use the I3C private transfer input buffer pointer for incoming data instead of output buffer. For now this is harmless since both of those pointers are union members but may confuse when reading the code.

Applied.

Thanks,
Guenter

Reviewed-by on v1 1/1
#2 lore raw
In reply to Jarkko Nikula
Quoted 5 lines · Jarkko Nikula

Use the I3C private transfer input buffer pointer for incoming data instead of output buffer. For now this is harmless since both of those pointers are union members but may confuse when reading the code.

FTR:

I am on the road, so I cannot test it currently. I wanted to do this once I am back.