drm/msm: sparse / "VM_BIND" support
Subsystems (10)
v4 cover drm/msm: sparse / "VM_BIND" support
From: Rob Clark <[email protected]>
Conversion to DRM GPU VA Manager[1], and adding support for Vulkan Sparse Memory[2] in the form of:
1. A new VM_BIND submitqueue type for executing VM MSM_SUBMIT_BO_OP_MAP/ MAP_NULL/UNMAP commands
2. A new VM_BIND ioctl to allow submitting batches of one or more MAP/MAP_NULL/UNMAP commands to a VM_BIND submitqueue
I did not implement support for synchronous VM_BIND commands. Since userspace could just immediately wait for the SUBMIT to complete, I don't think we need this extra complexity in the kernel. Synchronous/immediate VM_BIND operations could be implemented with a 2nd VM_BIND submitqueue.
The corresponding mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32533
Changes in v4:
- Various locking/etc fixes
- Optimize the pgtable preallocation. If userspace sorts the VM_BIND ops then the kernel detects ops that fall into the same 2MB last level PTD to avoid duplicate page preallocation.
- Add way to throttle pushing jobs to the scheduler, to cap the amount of potentially temporary prealloc'd pgtable pages.
- Add vm_log to devcoredump for debugging. If the vm_log_shift module param is set, keep a log of the last 1<<vm_log_shift VM updates for easier debugging of faults/crashes.
- Link to v3: https://lore.kernel.org/all/[email protected]/
Changes in v3:
- Switched to seperate VM_BIND ioctl. This makes the UABI a bit cleaner, but OTOH the userspace code was cleaner when the end result of either type of VkQueue lead to the same ioctl. So I'm a bit on the fence.
- Switched to doing the gpuvm bookkeeping synchronously, and only deferring the pgtable updates. This avoids needing to hold any resv locks in the fence signaling path, resolving the last shrinker related lockdep complaints. OTOH it means userspace can trigger invalid pgtable updates with multiple VM_BIND queues. In this case, we ensure that unmaps happen completely (to prevent userspace from using this to access free'd pages), mark the context as unusable, and move on with life.
- Link to v2: https://lore.kernel.org/all/[email protected]/
Changes in v2:
- Dropped Bibek Kumar Patro's arm-smmu patches[3], which have since been
merged.
- Pre-allocate all the things, and drop HACK patch which disabled shrinker.
This includes ensuring that vm_bo objects are allocated up front, pre-
allocating VMA objects, and pre-allocating pages used for pgtable updates.
The latter utilizes io_pgtable_cfg callbacks for pgtable alloc/free, that
were initially added for panthor.
- Add back support for BO dumping for devcoredump.
- Link to v1 (RFC): https://lore.kernel.org/dri-devel/[email protected]/T/#t
[1] https://www.kernel.org/doc/html/next/gpu/drm-mm.html#drm-gpuvm
[2] https://docs.vulkan.org/spec/latest/chapters/sparsemem.html
[3] https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=909700
Rob Clark (40):
drm/gpuvm: Don't require obj lock in destructor path drm/gpuvm: Allow VAs to hold soft reference to BOs drm/gem: Add ww_acquire_ctx support to drm_gem_lru_scan() drm/sched: Add enqueue credit limit iommu/io-pgtable-arm: Add quirk to quiet WARN_ON() drm/msm: Rename msm_file_private -> msm_context drm/msm: Improve msm_context comments
drm/msm: Rename msm_gem_address_space -> msm_gem_vm drm/msm: Remove vram carveout support
drm/msm: Collapse vma allocation and initialization drm/msm: Collapse vma close and delete
drm/msm: Don't close VMAs on purge
drm/msm: drm_gpuvm conversion
drm/msm: Convert vm locking
drm/msm: Use drm_gpuvm types more
drm/msm: Split out helper to get iommu prot flags drm/msm: Add mmu support for non-zero offset drm/msm: Add PRR support
drm/msm: Rename msm_gem_vma_purge() -> _unmap() drm/msm: Drop queued submits on lastclose() drm/msm: Lazily create context VM
drm/msm: Add opt-in for VM_BIND
drm/msm: Mark VM as unusable on GPU hangs drm/msm: Add _NO_SHARE flag
drm/msm: Crashdump prep for sparse mappings drm/msm: rd dumping prep for sparse mappings drm/msm: Crashdec support for sparse
drm/msm: rd dumping support for sparse
drm/msm: Extract out syncobj helpers
drm/msm: Use DMA_RESV_USAGE_BOOKKEEP/KERNEL drm/msm: Add VM_BIND submitqueue
drm/msm: Support IO_PGTABLE_QUIRK_NO_WARN_ON drm/msm: Support pgtable preallocation
drm/msm: Split out map/unmap ops
drm/msm: Add VM_BIND ioctl
drm/msm: Add VM logging for VM_BIND updates drm/msm: Add VMA unmap reason
drm/msm: Add mmu prealloc tracepoint
drm/msm: use trylock for debugfs
drm/msm: Bump UAPI version
drivers/gpu/drm/drm_gem.c | 14 +- drivers/gpu/drm/drm_gpuvm.c | 15 +- drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 25 +- drivers/gpu/drm/msm/adreno/a2xx_gpummu.c | 5 +- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 17 +- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 17 +- drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 22 +- drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 10 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 32 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 49 +- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 6 +- drivers/gpu/drm/msm/adreno/a6xx_preempt.c | 10 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 4 - drivers/gpu/drm/msm/adreno/adreno_gpu.c | 99 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 23 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 14 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 18 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 14 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 4 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 6 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 28 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 12 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 19 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 12 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 14 +- drivers/gpu/drm/msm/msm_drv.c | 184 +-- drivers/gpu/drm/msm/msm_drv.h | 35 +- drivers/gpu/drm/msm/msm_fb.c | 18 +- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- drivers/gpu/drm/msm/msm_gem.c | 494 +++--- drivers/gpu/drm/msm/msm_gem.h | 247 ++- drivers/gpu/drm/msm/msm_gem_prime.c | 15 + drivers/gpu/drm/msm/msm_gem_shrinker.c | 104 +- drivers/gpu/drm/msm/msm_gem_submit.c | 295 ++-- drivers/gpu/drm/msm/msm_gem_vma.c | 1471 ++++++++++++++++- drivers/gpu/drm/msm/msm_gpu.c | 214 ++- drivers/gpu/drm/msm/msm_gpu.h | 144 +- drivers/gpu/drm/msm/msm_gpu_trace.h | 14 + drivers/gpu/drm/msm/msm_iommu.c | 302 +++- drivers/gpu/drm/msm/msm_kms.c | 18 +- drivers/gpu/drm/msm/msm_kms.h | 2 +- drivers/gpu/drm/msm/msm_mmu.h | 38 +- drivers/gpu/drm/msm/msm_rd.c | 62 +- drivers/gpu/drm/msm/msm_ringbuffer.c | 10 +- drivers/gpu/drm/msm/msm_submitqueue.c | 96 +- drivers/gpu/drm/msm/msm_syncobj.c | 172 ++ drivers/gpu/drm/msm/msm_syncobj.h | 37 + drivers/gpu/drm/scheduler/sched_entity.c | 16 +- drivers/gpu/drm/scheduler/sched_main.c | 3 + drivers/iommu/io-pgtable-arm.c | 27 +- include/drm/drm_gem.h | 10 +- include/drm/drm_gpuvm.h | 12 +- include/drm/gpu_scheduler.h | 13 +- include/linux/io-pgtable.h | 8 + include/uapi/drm/msm_drm.h | 149 +- 63 files changed, 3484 insertions(+), 1251 deletions(-) create mode 100644 drivers/gpu/drm/msm/msm_syncobj.c create mode 100644 drivers/gpu/drm/msm/msm_syncobj.h
Signature · 1 line
2.49.0
PATCH v4 1/40 drm/gpuvm: Don't require obj lock in destructor path
From: Rob Clark <[email protected]>
See commit a414fe3a2129 ("drm/msm/gem: Drop obj lock in msm_gem_free_object()") for justification.
--- drivers/gpu/drm/drm_gpuvm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_gpuvm.c +5 -2
@@ -1511,7 +1511,9 @@ drm_gpuvm_bo_destroy(struct kref *kref)drm_gpuvm_bo_list_del (vm_bo, extobj, lock);drm_gpuvm_bo_list_del (vm_bo, evict, lock); -drm_gem_gpuva_assert_lock_held (obj); +if (kref_read (&obj->refcount) >0 ) +drm_gem_gpuva_assert_lock_held (obj); +list_del (&vm_bo->list.entry.gem);if (ops && ops->vm_bo_free)
@@ -1871,7 +1873,8 @@ drm_gpuva_unlink(struct drm_gpuva *va)if (unlikely (!obj))return ; -drm_gem_gpuva_assert_lock_held (obj); +if (kref_read (&obj->refcount) >0 ) +drm_gem_gpuva_assert_lock_held (obj);list_del_init (&va->gem.entry); va->vm_bo =NULL ;
Signature · 1 line
2.49.0
Danilo Krummrich
maintainerRe: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Hi Rob,
Can you please CC me on patches for GPUVM?
Quoted 4 lines · Rob Clark
From: Rob Clark <[email protected]>
See commit
a414fe3a2129("drm/msm/gem: Drop obj lock inmsm_gem_free_object()") for justification.
Please write a proper commit message that explains the problem and the solution. Please don't just refer to another commit and leave it to the reviewer of the patch to figure this out.
Quoted 11 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/drm_gpuvm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_gpuvm.c +0
-0
drivers/gpu/drm/drm_gpuvm.c drm_gpuvm_bo_destroy(struct kref *kref) · line 1517
Quoted 8 lines
drivers/gpu/drm/drm_gpuvm.c +3
-1@@ -1511,7 +1511,9 @@ drm_gpuvm_bo_destroy(struct kref *kref)drm_gpuvm_bo_list_del (vm_bo, extobj, lock);drm_gpuvm_bo_list_del (vm_bo, evict, lock); -drm_gem_gpuva_assert_lock_held (obj); +if (kref_read (&obj->refcount) >0 ) +drm_gem_gpuva_assert_lock_held (obj); +list_del (&vm_bo->list.entry.gem);
This seems wrong.
A VM_BO object keeps a reference of the underlying GEM object, so this should never happen.
This function calls drm_gem_object_put() before it returns.
Quoted 15 lines
drivers/gpu/drm/drm_gpuvm.c +2
-1if (ops && ops->vm_bo_free)@@ -1871,7 +1873,8 @@ drm_gpuva_unlink(struct drm_gpuva *va)if (unlikely (!obj))return ; -drm_gem_gpuva_assert_lock_held (obj); +if (kref_read (&obj->refcount) >0 ) +drm_gem_gpuva_assert_lock_held (obj);list_del_init (&va->gem.entry); va->vm_bo =NULL ;Signature · 1 line
2.49.0
Danilo Krummrich
maintainerRe: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 36 lines · Danilo Krummrich
Hi Rob,
Can you please CC me on patches for GPUVM?
Quoted 4 lines · Rob Clark
From: Rob Clark <[email protected]>
See commit
a414fe3a2129("drm/msm/gem: Drop obj lock inmsm_gem_free_object()") for justification.Please write a proper commit message that explains the problem and the solution. Please don't just refer to another commit and leave it to the reviewer of the patch to figure this out.
Quoted 11 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/drm_gpuvm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_gpuvm.c +0
-0drivers/gpu/drm/drm_gpuvm.c drm_gpuvm_bo_destroy(struct kref *kref) · line 1517
Quoted 8 lines
drivers/gpu/drm/drm_gpuvm.c +3
-1@@ -1511,7 +1511,9 @@ drm_gpuvm_bo_destroy(struct kref *kref)drm_gpuvm_bo_list_del (vm_bo, extobj, lock);drm_gpuvm_bo_list_del (vm_bo, evict, lock); -drm_gem_gpuva_assert_lock_held (obj); +if (kref_read (&obj->refcount) >0 ) +drm_gem_gpuva_assert_lock_held (obj); +list_del (&vm_bo->list.entry.gem);This seems wrong.
Quoted 4 lines
A
VM_BOobject keeps a reference of the underlying GEM object, so this should never happen.This function calls
drm_gem_object_put()before it returns.
I noticed your subsequent patch that allows VM_BO structures to have weak references to GEM objects.
However, even with that this seems wrong. If the reference count of the GEM object is zero when drm_gpuvm_bo_destroy() is called it means that the GEM object is dead. However, until drm_gpuvm_bo_destroy() is called the GEM object potentially remains to be on the extobj and eviced list, which means that other code paths might fetch it from those lists and consider it to be a valid GEM object.
Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 46 lines · Danilo Krummrich
Quoted 36 lines · Danilo Krummrich
Hi Rob,
Can you please CC me on patches for GPUVM?
Quoted 4 lines · Rob Clark
From: Rob Clark <[email protected]>
See commit
a414fe3a2129("drm/msm/gem: Drop obj lock inmsm_gem_free_object()") for justification.Please write a proper commit message that explains the problem and the solution. Please don't just refer to another commit and leave it to the reviewer of the patch to figure this out.
Quoted 11 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/drm_gpuvm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_gpuvm.c +0
-0drivers/gpu/drm/drm_gpuvm.c drm_gpuvm_bo_destroy(struct kref *kref) · line 1517
Quoted 8 lines
drivers/gpu/drm/drm_gpuvm.c +3
-1@@ -1511,7 +1511,9 @@ drm_gpuvm_bo_destroy(struct kref *kref)drm_gpuvm_bo_list_del (vm_bo, extobj, lock);drm_gpuvm_bo_list_del (vm_bo, evict, lock); -drm_gem_gpuva_assert_lock_held (obj); +if (kref_read (&obj->refcount) >0 ) +drm_gem_gpuva_assert_lock_held (obj); +list_del (&vm_bo->list.entry.gem);This seems wrong.
Quoted 4 lines
A
VM_BOobject keeps a reference of the underlying GEM object, so this should never happen.This function calls
drm_gem_object_put()before it returns.I noticed your subsequent patch that allows
VM_BOstructures to have weak references to GEM objects.
Quoted 6 lines
However, even with that this seems wrong. If the reference count of the GEM object is zero when
drm_gpuvm_bo_destroy()is called it means that the GEM object is dead. However, untildrm_gpuvm_bo_destroy()is called the GEM object potentially remains to be on the extobj and eviced list, which means that other code paths might fetch it from those lists and consider it to be a valid GEM object.
We only iterate extobj or evicted in VM_BIND mode, where we aren't using WEAK_REF. I suppose some WARN_ON()s or BUG_ON()s could make this more clear.
BR,
-R
Danilo Krummrich
maintainerRe: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 54 lines · Rob Clark
Quoted 46 lines · Danilo Krummrich
Quoted 36 lines · Danilo Krummrich
Hi Rob,
Can you please CC me on patches for GPUVM?
Quoted 4 lines · Rob Clark
From: Rob Clark <[email protected]>
See commit
a414fe3a2129("drm/msm/gem: Drop obj lock inmsm_gem_free_object()") for justification.Please write a proper commit message that explains the problem and the solution. Please don't just refer to another commit and leave it to the reviewer of the patch to figure this out.
Quoted 11 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/drm_gpuvm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_gpuvm.c +0
-0drivers/gpu/drm/drm_gpuvm.c drm_gpuvm_bo_destroy(struct kref *kref) · line 1517
Quoted 8 lines
drivers/gpu/drm/drm_gpuvm.c +3
-1@@ -1511,7 +1511,9 @@ drm_gpuvm_bo_destroy(struct kref *kref)drm_gpuvm_bo_list_del (vm_bo, extobj, lock);drm_gpuvm_bo_list_del (vm_bo, evict, lock); -drm_gem_gpuva_assert_lock_held (obj); +if (kref_read (&obj->refcount) >0 ) +drm_gem_gpuva_assert_lock_held (obj); +list_del (&vm_bo->list.entry.gem);This seems wrong.
Quoted 4 lines
A
VM_BOobject keeps a reference of the underlying GEM object, so this should never happen.This function calls
drm_gem_object_put()before it returns.I noticed your subsequent patch that allows
VM_BOstructures to have weak references to GEM objects.Quoted 6 lines
However, even with that this seems wrong. If the reference count of the GEM object is zero when
drm_gpuvm_bo_destroy()is called it means that the GEM object is dead. However, untildrm_gpuvm_bo_destroy()is called the GEM object potentially remains to be on the extobj and eviced list, which means that other code paths might fetch it from those lists and consider it to be a valid GEM object.
Quoted 3 lines
We only iterate extobj or evicted in
VM_BINDmode, where we aren't usingWEAK_REF. I suppose some WARN_ON()s or BUG_ON()s could make this more clear.
There is also the GEM object's list of VM_BOs, are you using that?
Anyways, I don't agree with that. Even if you can tweak your driver to not run into trouble with this, we can't introduce a mode that violates GOUVM's internal lifetimes and subsequently fix it up with WARN_ON() or BUG_ON().
I still don't see a real technical reason why msm can't be reworked to follow those lifetime rules.
Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 56 lines · Danilo Krummrich
Quoted 54 lines · Rob Clark
Quoted 52 lines · Danilo Krummrich
Quoted 36 lines · Danilo Krummrich
Hi Rob,
Can you please CC me on patches for GPUVM?
Quoted 4 lines · Rob Clark
From: Rob Clark <[email protected]>
See commit
a414fe3a2129("drm/msm/gem: Drop obj lock inmsm_gem_free_object()") for justification.Please write a proper commit message that explains the problem and the solution. Please don't just refer to another commit and leave it to the reviewer of the patch to figure this out.
Quoted 11 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/drm_gpuvm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_gpuvm.c +0
-0drivers/gpu/drm/drm_gpuvm.c drm_gpuvm_bo_destroy(struct kref *kref) · line 1517
Quoted 8 lines
drivers/gpu/drm/drm_gpuvm.c +3
-1@@ -1511,7 +1511,9 @@ drm_gpuvm_bo_destroy(struct kref *kref)drm_gpuvm_bo_list_del (vm_bo, extobj, lock);drm_gpuvm_bo_list_del (vm_bo, evict, lock); -drm_gem_gpuva_assert_lock_held (obj); +if (kref_read (&obj->refcount) >0 ) +drm_gem_gpuva_assert_lock_held (obj); +list_del (&vm_bo->list.entry.gem);This seems wrong.
Quoted 4 lines
A
VM_BOobject keeps a reference of the underlying GEM object, so this should never happen.This function calls
drm_gem_object_put()before it returns.I noticed your subsequent patch that allows
VM_BOstructures to have weak references to GEM objects.However, even with that this seems wrong. If the reference count of the GEM object is zero when
drm_gpuvm_bo_destroy()is called it means that the GEM object is dead. However, untildrm_gpuvm_bo_destroy()is called the GEM object potentially remains to be on the extobj and eviced list, which means that other code paths might fetch it from those lists and consider it to be a valid GEM object.
Quoted 5 lines
Quoted 3 lines
We only iterate extobj or evicted in
VM_BINDmode, where we aren't usingWEAK_REF. I suppose some WARN_ON()s or BUG_ON()s could make this more clear.There is also the GEM object's list of
VM_BOs, are you using that?
yes, but at this point there are no more ref's to the obj, and that list is obj specific
Quoted 6 lines
Anyways, I don't agree with that. Even if you can tweak your driver to not run into trouble with this, we can't introduce a mode that violates GOUVM's internal lifetimes and subsequently fix it up with
WARN_ON()orBUG_ON().I still don't see a real technical reason why msm can't be reworked to follow those lifetime rules.
The basic issue is that (a) it would be really awkward to have two side-by-side VM/VMA management/tracking systems. But in legacy mode, we have the opposite direction of reference holding. (But at the same time, don't need/use most of the features of gpuvm.)
BR,
-R
Danilo Krummrich
maintainerRe: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 5 lines · Rob Clark
Quoted 4 lines · Danilo Krummrich
Anyways, I don't agree with that. Even if you can tweak your driver to not run into trouble with this, we can't introduce a mode that violates GOUVM's internal lifetimes and subsequently fix it up with
WARN_ON()orBUG_ON().
Quoted 7 lines
Quoted 2 lines
I still don't see a real technical reason why msm can't be reworked to follow those lifetime rules.
The basic issue is that (a) it would be really awkward to have two side-by-side VM/VMA management/tracking systems. But in legacy mode, we have the opposite direction of reference holding. (But at the same time, don't need/use most of the features of gpuvm.)
Ok, let's try to move this forward; I see three options (in order of descending preference):
1) Rework the legacy code to properly work with GPUVM.
2) Don't use GPUVM for the legacy mode.
.
.
.
3) Get an ACK from Dave / Sima to implement those workarounds for MSM in GPUVM.
If you go for 3), the code introduced by those two patches should be guarded with a flag that makes it very clear that this is a workaround specifically for MSM legacy mode and does not give any guarantees in terms of correctness regarding lifetimes etc., e.g. DRM_GPUVM_MSM_LEGACY_QUIRK.
- Danilo
Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 26 lines · Danilo Krummrich
Quoted 5 lines · Rob Clark
Quoted 4 lines · Danilo Krummrich
Anyways, I don't agree with that. Even if you can tweak your driver to not run into trouble with this, we can't introduce a mode that violates GOUVM's internal lifetimes and subsequently fix it up with
WARN_ON()orBUG_ON().Quoted 7 lines
Quoted 2 lines
I still don't see a real technical reason why msm can't be reworked to follow those lifetime rules.
The basic issue is that (a) it would be really awkward to have two side-by-side VM/VMA management/tracking systems. But in legacy mode, we have the opposite direction of reference holding. (But at the same time, don't need/use most of the features of gpuvm.)
Ok, let's try to move this forward; I see three options (in order of descending preference):
1) Rework the legacy code to properly work with GPUVM.
2) Don't use GPUVM for the legacy mode.
.
.
.
3) Get an ACK from Dave / Sima to implement those workarounds for MSM in GPUVM.
Quoted 4 lines
If you go for 3), the code introduced by those two patches should be guarded with a flag that makes it very clear that this is a workaround specifically for MSM legacy mode and does not give any guarantees in terms of correctness regarding lifetimes etc., e.g.
DRM_GPUVM_MSM_LEGACY_QUIRK.
I'm not even sure how #2 would work, other than just copy/pasta all of drm_gpuvm into msm, which doesn't really seem great.
As for #1, even if I could get it to work, it would still be a lot more mmu map/unmap (like on every pageflip, vs the current state that the vma is kept around until the object is freed). For the non-VM_BIND world, there are advantages to the BO holding the ref to the VMA, rather than the other way around. Even at just a modest single layer 1080p the map takes ~.2ms and unmap ~.3ms (plus the unmap costs a tlbinv). So from that standpoint, #3 is the superior option.
BR,
-R
Dave Airlie
maintainerRe: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 36 lines · Rob Clark
Quoted 26 lines · Danilo Krummrich
Quoted 5 lines · Rob Clark
Quoted 4 lines · Danilo Krummrich
Anyways, I don't agree with that. Even if you can tweak your driver to not run into trouble with this, we can't introduce a mode that violates GOUVM's internal lifetimes and subsequently fix it up with
WARN_ON()orBUG_ON().Quoted 7 lines
Quoted 2 lines
I still don't see a real technical reason why msm can't be reworked to follow those lifetime rules.
The basic issue is that (a) it would be really awkward to have two side-by-side VM/VMA management/tracking systems. But in legacy mode, we have the opposite direction of reference holding. (But at the same time, don't need/use most of the features of gpuvm.)
Ok, let's try to move this forward; I see three options (in order of descending preference):
1) Rework the legacy code to properly work with GPUVM.
2) Don't use GPUVM for the legacy mode.
.
.
.
3) Get an ACK from Dave / Sima to implement those workarounds for MSM in GPUVM.Quoted 4 lines
If you go for 3), the code introduced by those two patches should be guarded with a flag that makes it very clear that this is a workaround specifically for MSM legacy mode and does not give any guarantees in terms of correctness regarding lifetimes etc., e.g.
DRM_GPUVM_MSM_LEGACY_QUIRK.I'm not even sure how #2 would work, other than just copy/pasta all of
drm_gpuvminto msm, which doesn't really seem great.
Quoted 8 lines
As for #1, even if I could get it to work, it would still be a lot more mmu map/unmap (like on every pageflip, vs the current state that the vma is kept around until the object is freed). For the non-VM_BIND world, there are advantages to the BO holding the ref to the VMA, rather than the other way around. Even at just a modest single layer 1080p the map takes ~.2ms and unmap ~.3ms (plus the unmap costs a tlbinv). So from that standpoint, #3 is the superior option.
Before we get to #3, I'll need a bit more info here on why you have to map/unmap the VMA on every pageflip.
But actually I think 2 is the best option, I think in nouveau this is where we ended up, we didn't modify the old submission paths at all and kept the old bo/vm lifetimes.
We just added completely new bind/exec ioctls and you can only use one method once you've opened an fd.
Dave.
Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 47 lines · Dave Airlie
Quoted 36 lines · Rob Clark
Quoted 26 lines · Danilo Krummrich
Quoted 5 lines · Rob Clark
Quoted 4 lines · Danilo Krummrich
Anyways, I don't agree with that. Even if you can tweak your driver to not run into trouble with this, we can't introduce a mode that violates GOUVM's internal lifetimes and subsequently fix it up with
WARN_ON()orBUG_ON().Quoted 7 lines
Quoted 2 lines
I still don't see a real technical reason why msm can't be reworked to follow those lifetime rules.
The basic issue is that (a) it would be really awkward to have two side-by-side VM/VMA management/tracking systems. But in legacy mode, we have the opposite direction of reference holding. (But at the same time, don't need/use most of the features of gpuvm.)
Ok, let's try to move this forward; I see three options (in order of descending preference):
1) Rework the legacy code to properly work with GPUVM.
2) Don't use GPUVM for the legacy mode.
.
.
.
3) Get an ACK from Dave / Sima to implement those workarounds for MSM in GPUVM.Quoted 4 lines
If you go for 3), the code introduced by those two patches should be guarded with a flag that makes it very clear that this is a workaround specifically for MSM legacy mode and does not give any guarantees in terms of correctness regarding lifetimes etc., e.g.
DRM_GPUVM_MSM_LEGACY_QUIRK.I'm not even sure how #2 would work, other than just copy/pasta all of
drm_gpuvminto msm, which doesn't really seem great.Quoted 8 lines
As for #1, even if I could get it to work, it would still be a lot more mmu map/unmap (like on every pageflip, vs the current state that the vma is kept around until the object is freed). For the non-VM_BIND world, there are advantages to the BO holding the ref to the VMA, rather than the other way around. Even at just a modest single layer 1080p the map takes ~.2ms and unmap ~.3ms (plus the unmap costs a tlbinv). So from that standpoint, #3 is the superior option.
Quoted 2 lines
Before we get to #3, I'll need a bit more info here on why you have to map/unmap the VMA on every pageflip.
Previously we'd keep the VMA hanging around until the GEM obj is freed. But that can't work if the VMA (via the VM_BO) is holding a reference to the GEM obj.
I was kinda thinking about keeping the VMA around until the handle is closed.. but that doesn't cover the dma-buf case (ie. when you re-import the dma-buf fd each frame.. I know android does this, unsure about other wsi's).
Quoted 6 lines
But actually I think 2 is the best option, I think in nouveau this is where we ended up, we didn't modify the old submission paths at all and kept the old bo/vm lifetimes.
We just added completely new bind/exec ioctls and you can only use one method once you've opened an fd.
hmm, but that means tracking VMAs against a single BO differently.. which.. at least seems ugly..
BR,
-R
Dave Airlie
maintainerRe: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 65 lines · Rob Clark
Quoted 47 lines · Dave Airlie
Quoted 36 lines · Rob Clark
Quoted 26 lines · Danilo Krummrich
Quoted 5 lines · Rob Clark
Quoted 4 lines · Danilo Krummrich
Anyways, I don't agree with that. Even if you can tweak your driver to not run into trouble with this, we can't introduce a mode that violates GOUVM's internal lifetimes and subsequently fix it up with
WARN_ON()orBUG_ON().Quoted 7 lines
Quoted 2 lines
I still don't see a real technical reason why msm can't be reworked to follow those lifetime rules.
The basic issue is that (a) it would be really awkward to have two side-by-side VM/VMA management/tracking systems. But in legacy mode, we have the opposite direction of reference holding. (But at the same time, don't need/use most of the features of gpuvm.)
Ok, let's try to move this forward; I see three options (in order of descending preference):
1) Rework the legacy code to properly work with GPUVM.
2) Don't use GPUVM for the legacy mode.
.
.
.
3) Get an ACK from Dave / Sima to implement those workarounds for MSM in GPUVM.Quoted 4 lines
If you go for 3), the code introduced by those two patches should be guarded with a flag that makes it very clear that this is a workaround specifically for MSM legacy mode and does not give any guarantees in terms of correctness regarding lifetimes etc., e.g.
DRM_GPUVM_MSM_LEGACY_QUIRK.I'm not even sure how #2 would work, other than just copy/pasta all of
drm_gpuvminto msm, which doesn't really seem great.Quoted 8 lines
As for #1, even if I could get it to work, it would still be a lot more mmu map/unmap (like on every pageflip, vs the current state that the vma is kept around until the object is freed). For the non-VM_BIND world, there are advantages to the BO holding the ref to the VMA, rather than the other way around. Even at just a modest single layer 1080p the map takes ~.2ms and unmap ~.3ms (plus the unmap costs a tlbinv). So from that standpoint, #3 is the superior option.
Quoted 2 lines
Before we get to #3, I'll need a bit more info here on why you have to map/unmap the VMA on every pageflip.
Previously we'd keep the VMA hanging around until the GEM obj is freed. But that can't work if the VMA (via the
VM_BO) is holding a reference to the GEM obj.I was kinda thinking about keeping the VMA around until the handle is closed.. but that doesn't cover the dma-buf case (ie. when you re-import the dma-buf fd each frame.. I know android does this, unsure about other wsi's).
Quoted 4 lines
But actually I think 2 is the best option, I think in nouveau this is where we ended up, we didn't modify the old submission paths at all and kept the old bo/vm lifetimes.
Quoted 5 lines
Quoted 2 lines
We just added completely new bind/exec ioctls and you can only use one method once you've opened an fd.
hmm, but that means tracking VMAs against a single BO differently.. which.. at least seems ugly..
I don't think it is if you already have the code to do that, and just add gpuvm support in parallel.
You also have to figure out that the world is moving towards Vulkan for everything so any optimisations you've made for particular legacy paths will need to be dealt with in the future picture anyways.
But I'd rather not hack gpuvm into being something it isn't, if there is a meaningful commonality in legacy bo/vm bindings across drivers, we could create something new, but the ref counting and handling is pretty fundamental to gpuvm architecture.
There should only be two paths, legacy and gpuvm, and you shouldn't ever be mixing them on a particular exec path, since you should only have a vm per userspace fd, and can pick which way to use it the first time someone calls it.
Dave.
Dave.
Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 73 lines · Dave Airlie
Quoted 65 lines · Rob Clark
Quoted 47 lines · Dave Airlie
Quoted 36 lines · Rob Clark
Quoted 26 lines · Danilo Krummrich
Quoted 5 lines · Rob Clark
Quoted 4 lines · Danilo Krummrich
Anyways, I don't agree with that. Even if you can tweak your driver to not run into trouble with this, we can't introduce a mode that violates GOUVM's internal lifetimes and subsequently fix it up with
WARN_ON()orBUG_ON().Quoted 7 lines
Quoted 2 lines
I still don't see a real technical reason why msm can't be reworked to follow those lifetime rules.
The basic issue is that (a) it would be really awkward to have two side-by-side VM/VMA management/tracking systems. But in legacy mode, we have the opposite direction of reference holding. (But at the same time, don't need/use most of the features of gpuvm.)
Ok, let's try to move this forward; I see three options (in order of descending preference):
1) Rework the legacy code to properly work with GPUVM.
2) Don't use GPUVM for the legacy mode.
.
.
.
3) Get an ACK from Dave / Sima to implement those workarounds for MSM in GPUVM.Quoted 4 lines
If you go for 3), the code introduced by those two patches should be guarded with a flag that makes it very clear that this is a workaround specifically for MSM legacy mode and does not give any guarantees in terms of correctness regarding lifetimes etc., e.g.
DRM_GPUVM_MSM_LEGACY_QUIRK.I'm not even sure how #2 would work, other than just copy/pasta all of
drm_gpuvminto msm, which doesn't really seem great.Quoted 8 lines
As for #1, even if I could get it to work, it would still be a lot more mmu map/unmap (like on every pageflip, vs the current state that the vma is kept around until the object is freed). For the non-VM_BIND world, there are advantages to the BO holding the ref to the VMA, rather than the other way around. Even at just a modest single layer 1080p the map takes ~.2ms and unmap ~.3ms (plus the unmap costs a tlbinv). So from that standpoint, #3 is the superior option.
Quoted 2 lines
Before we get to #3, I'll need a bit more info here on why you have to map/unmap the VMA on every pageflip.
Previously we'd keep the VMA hanging around until the GEM obj is freed. But that can't work if the VMA (via the
VM_BO) is holding a reference to the GEM obj.I was kinda thinking about keeping the VMA around until the handle is closed.. but that doesn't cover the dma-buf case (ie. when you re-import the dma-buf fd each frame.. I know android does this, unsure about other wsi's).
Quoted 4 lines
But actually I think 2 is the best option, I think in nouveau this is where we ended up, we didn't modify the old submission paths at all and kept the old bo/vm lifetimes.
Quoted 5 lines
Quoted 2 lines
We just added completely new bind/exec ioctls and you can only use one method once you've opened an fd.
hmm, but that means tracking VMAs against a single BO differently.. which.. at least seems ugly..
Quoted 6 lines
I don't think it is if you already have the code to do that, and just add gpuvm support in parallel.
You also have to figure out that the world is moving towards Vulkan for everything so any optimisations you've made for particular legacy paths will need to be dealt with in the future picture anyways.
fwiw, the case I'm more worried about is the kms vm for scanout, that won't be using vk
BR,
-R
Quoted 12 lines
But I'd rather not hack gpuvm into being something it isn't, if there is a meaningful commonality in legacy bo/vm bindings across drivers, we could create something new, but the ref counting and handling is pretty fundamental to gpuvm architecture.
There should only be two paths, legacy and gpuvm, and you shouldn't ever be mixing them on a particular exec path, since you should only have a vm per userspace fd, and can pick which way to use it the first time someone calls it.
Dave.
Dave.
Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
In reply to Dave AirlieQuoted 85 lines · Dave Airlie
Quoted 65 lines · Rob Clark
Quoted 47 lines · Dave Airlie
Quoted 36 lines · Rob Clark
Quoted 26 lines · Danilo Krummrich
Quoted 5 lines · Rob Clark
Quoted 4 lines · Danilo Krummrich
Anyways, I don't agree with that. Even if you can tweak your driver to not run into trouble with this, we can't introduce a mode that violates GOUVM's internal lifetimes and subsequently fix it up with
WARN_ON()orBUG_ON().Quoted 7 lines
Quoted 2 lines
I still don't see a real technical reason why msm can't be reworked to follow those lifetime rules.
The basic issue is that (a) it would be really awkward to have two side-by-side VM/VMA management/tracking systems. But in legacy mode, we have the opposite direction of reference holding. (But at the same time, don't need/use most of the features of gpuvm.)
Ok, let's try to move this forward; I see three options (in order of descending preference):
1) Rework the legacy code to properly work with GPUVM.
2) Don't use GPUVM for the legacy mode.
.
.
.
3) Get an ACK from Dave / Sima to implement those workarounds for MSM in GPUVM.Quoted 4 lines
If you go for 3), the code introduced by those two patches should be guarded with a flag that makes it very clear that this is a workaround specifically for MSM legacy mode and does not give any guarantees in terms of correctness regarding lifetimes etc., e.g.
DRM_GPUVM_MSM_LEGACY_QUIRK.I'm not even sure how #2 would work, other than just copy/pasta all of
drm_gpuvminto msm, which doesn't really seem great.Quoted 8 lines
As for #1, even if I could get it to work, it would still be a lot more mmu map/unmap (like on every pageflip, vs the current state that the vma is kept around until the object is freed). For the non-VM_BIND world, there are advantages to the BO holding the ref to the VMA, rather than the other way around. Even at just a modest single layer 1080p the map takes ~.2ms and unmap ~.3ms (plus the unmap costs a tlbinv). So from that standpoint, #3 is the superior option.
Quoted 2 lines
Before we get to #3, I'll need a bit more info here on why you have to map/unmap the VMA on every pageflip.
Previously we'd keep the VMA hanging around until the GEM obj is freed. But that can't work if the VMA (via the
VM_BO) is holding a reference to the GEM obj.I was kinda thinking about keeping the VMA around until the handle is closed.. but that doesn't cover the dma-buf case (ie. when you re-import the dma-buf fd each frame.. I know android does this, unsure about other wsi's).
Quoted 4 lines
But actually I think 2 is the best option, I think in nouveau this is where we ended up, we didn't modify the old submission paths at all and kept the old bo/vm lifetimes.
Quoted 5 lines
Quoted 2 lines
We just added completely new bind/exec ioctls and you can only use one method once you've opened an fd.
hmm, but that means tracking VMAs against a single BO differently.. which.. at least seems ugly..
I don't think it is if you already have the code to do that, and just add gpuvm support in parallel.
You also have to figure out that the world is moving towards Vulkan for everything so any optimisations you've made for particular legacy paths will need to be dealt with in the future picture anyways.
But I'd rather not hack gpuvm into being something it isn't, if there is a meaningful commonality in legacy bo/vm bindings across drivers, we could create something new, but the ref counting and handling is pretty fundamental to gpuvm architecture.
Quoted 4 lines
There should only be two paths, legacy and gpuvm, and you shouldn't ever be mixing them on a particular exec path, since you should only have a vm per userspace fd, and can pick which way to use it the first time someone calls it.
It's not as much about the exec path, as it is about making all the non-exec paths (like shrinker/residency) have to deal with two completely different things..
But I think I have figured out something workable. I add an extra refcnt per BO for the vma, incremented by userspace holding a gem handle, userspace holding a dma-buf fd, or (ofc) actual pin for scanout. When the refcount is above zero I defer teardown in the kms->vm until it drops to zero. It isn't _exactly_ the same as lazy VMA teardown when the BO is freed, but it is effectively the same thing. And whenever the vma_ref is greater than zero, the BO has something else holding a ref so the ref loop doesn't matter. If there is no userspace process holding a reference to the BO via handle or dma-buf fd, then it isn't going to be used again in a swapchain, so the difference btwn tearing down the VMA when the vma_ref drops to zero vs when the BO is freed doesn't amount to anything.
It's a bit weird adding some extra mechanism specifically for the scanout vm, and maybe a bit uglier (depending on eye-of-beholder) than making gpuvm work in either way (since the latter was a pretty straightforward patch), but less ugly than having to parallel mechanisms. So if you _really_ don't like the WEAK_REF flag, I have a workable alternative that addresses the performance problems.
BR,
-R
Danilo Krummrich
maintainerRe: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path
Quoted 2 lines · Rob Clark
So if you _really_ don't like the
WEAK_REFflag, I have a workable alternative that addresses the performance problems.
The mode you want to introduce is broken, and I don't understand why you don't want to accept that.
1. It obviously breaks some features, which is why you have to add lots of WARN_ON() calls to the corresponding code paths, such that drivers won't call into them any more.
2. It requires conditionals based on kref_read(), which is oviously racy, and can cause UAF bugs.
3. I'm sure, if we look closely, we'll find more subtle bugs, because GPUVM was designed with a clear ownership and lifetime model, that this mode undermines entirely.
The only reason why your MSM implementation does not run into trouble is because it upholds certain contitions such that the racy kref_read() code does not cause issues.
So, we would need to document all those extra requirements that drivers would need to uphold using this mode, which eliminates more perfectly normal use cases, that people expect to just work, one example for that would be to have the same GEM object in multiple VMs.
This would be a huge mess and a mode full of footguns for drivers, and hence a NACK from my side.
PATCH v4 2/40 drm/gpuvm: Allow VAs to hold soft reference to BOs
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Eases migration for drivers where VAs don't hold hard references to their associated BO, avoiding reference loops.
In particular, msm uses soft references to optimistically keep around mappings until the BO is distroyed. Which obviously won't work if the VA (the mapping) is holding a reference to the BO.
By making this a per-VM flag, we can use normal hard-references for mappings in a "VM_BIND" managed VM, but soft references in other cases, such as kernel-internal VMs (for display scanout, etc).
--- drivers/gpu/drm/drm_gpuvm.c | 8 ++++++-- include/drm/drm_gpuvm.h | 12 ++++++++++-- 2 files changed, 16 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_gpuvm.c +6 -2
@@ -1482,7 +1482,9 @@ drm_gpuvm_bo_create(struct drm_gpuvm *gpuvm, vm_bo->vm =drm_gpuvm_get (gpuvm); vm_bo->obj = obj; -drm_gem_object_get (obj); + +if (!(gpuvm->flags &DRM_GPUVM_VA_WEAK_REF )) +drm_gem_object_get (obj);kref_init (&vm_bo->kref);INIT_LIST_HEAD (&vm_bo->list.gpuva);
@@ -1504,6 +1506,7 @@ drm_gpuvm_bo_destroy(struct kref *kref)const struct drm_gpuvm_ops *ops = gpuvm->ops;struct drm_gem_object *obj = vm_bo->obj;bool lock = !drm_gpuvm_resv_protected (gpuvm); +bool unref = !(gpuvm->flags &DRM_GPUVM_VA_WEAK_REF );if (!lock)drm_gpuvm_resv_assert_held (gpuvm);
@@ -1522,7 +1525,8 @@ drm_gpuvm_bo_destroy(struct kref *kref)kfree (vm_bo);drm_gpuvm_put (gpuvm); -drm_gem_object_put (obj); +if (unref) +drm_gem_object_put (obj); }/**
include/drm/drm_gpuvm.h +10 -2
@@ -205,10 +205,18 @@ enum drm_gpuvm_flags {*/ DRM_GPUVM_RESV_PROTECTED =BIT (0 ), +/** +* @DRM_GPUVM_VA_WEAK_REF: +* +* Flag indicating that the &drm_gpuva (or more correctly, the +* &drm_gpuvm_bo) only holds a weak reference to the &drm_gem_object. +*/ +DRM_GPUVM_VA_WEAK_REF =BIT (1 ), +/** * @DRM_GPUVM_USERBITS: user defined bits */ - DRM_GPUVM_USERBITS = BIT(1), + DRM_GPUVM_USERBITS = BIT(2), };/**
@@ -651,7 +659,7 @@ struct drm_gpuvm_bo {/** * @obj: The &drm_gem_object being mapped in @vm. This is a reference -* counted pointer. +* counted pointer, unless the &DRM_GPUVM_VA_WEAK_REF flag is set. */ struct drm_gem_object *obj;
Signature · 1 line
2.49.0
Danilo Krummrich
maintainerRe: [PATCH v4 02/40] drm/gpuvm: Allow VAs to hold soft reference to BOs
Quoted 8 lines · Rob Clark
From: Rob Clark <[email protected]>
Eases migration for drivers where VAs don't hold hard references to their associated BO, avoiding reference loops.
In particular, msm uses soft references to optimistically keep around mappings until the BO is distroyed. Which obviously won't work if the VA (the mapping) is holding a reference to the BO.
Ick! This is all complicated enough. Allow drivers to bypass the proper reference counting for GEM objects in the context of VM_BO structures seems like an insane footgun.
I don't understand why MSM would need weak references here. Why does msm need that, but nouveau, Xe, panthor, PowerVR do not?
Re: [PATCH v4 02/40] drm/gpuvm: Allow VAs to hold soft reference to BOs
Quoted 11 lines · Danilo Krummrich
Quoted 8 lines · Rob Clark
From: Rob Clark <[email protected]>
Eases migration for drivers where VAs don't hold hard references to their associated BO, avoiding reference loops.
In particular, msm uses soft references to optimistically keep around mappings until the BO is distroyed. Which obviously won't work if the VA (the mapping) is holding a reference to the BO.
Quoted 6 lines
Ick! This is all complicated enough. Allow drivers to bypass the proper reference counting for GEM objects in the context of
VM_BOstructures seems like an insane footgun.I don't understand why MSM would need weak references here. Why does msm need that, but nouveau, Xe, panthor, PowerVR do not?
Most of those drivers were designed (and had their UABI designed) with gpuvm, or at least sparse, in mind from the get go. I'm not sure about nouveau, but I guess it just got lucky that it's UABI semantics fit having the VMA hold a reference to the BO.
Unfortunately, msm pre-dates sparse.. and in the beginning there was only a single global VM, multiple VMs was something retrofitted ~6yrs (?) back. For existing msm, the VMA(s) are implicitly torn down when the GEM obj is freed. This won't work with the VMA(s) holding hard references to the BO.
When userspace opts-in to "VM_BIND" mode, which it has to do before the VM is created, then we don't set this flag, the VMA holds a hard reference to the BO as it does with other drivers. But consider this use-case, which is perfectly valid for old (existing) userspace:
1) Userspace creates a BO
2) Submits rendering referencing the BO
3) Immediately closes the BO handle, without waiting for the submit to complete
In this case, the submit holds a reference to the BO which holds a reference to the VMA. Everything is torn down gracefully when the submit completes. But if the VMA held a hard reference to the BO then you'd have a reference loop.
So there really is no other way to use gpuvm _and_ maintain backwards compatibility with the semantics of the pre-VM_BIND UAPI without this flag.
Fortunately DRM_GPUVM_VA_WEAK_REF is minimally intrusive. Otherwise I probably would have had to fork my own copy of gpuvm.
BR,
-R
Danilo Krummrich
maintainerRe: [PATCH v4 02/40] drm/gpuvm: Allow VAs to hold soft reference to BOs
On Thu, May 15, 2025 at 07:59:16AM -0700, Rob Clark wrote:
Thanks for the detailed explanation!
Quoted 24 lines · Danilo Krummrich
Quoted 11 lines · Rob Clark
Quoted 8 lines
From: Rob Clark <[email protected]>
Eases migration for drivers where VAs don't hold hard references to their associated BO, avoiding reference loops.
In particular, msm uses soft references to optimistically keep around mappings until the BO is distroyed. Which obviously won't work if the VA (the mapping) is holding a reference to the BO.
Quoted 6 lines
Ick! This is all complicated enough. Allow drivers to bypass the proper reference counting for GEM objects in the context of
VM_BOstructures seems like an insane footgun.I don't understand why MSM would need weak references here. Why does msm need that, but nouveau, Xe, panthor, PowerVR do not?
Most of those drivers were designed (and had their UABI designed) with gpuvm, or at least sparse, in mind from the get go. I'm not sure about nouveau, but I guess it just got lucky that it's UABI semantics fit having the VMA hold a reference to the BO.
Quoted 5 lines
Unfortunately, msm pre-dates sparse.. and in the beginning there was only a single global VM, multiple VMs was something retrofitted ~6yrs (?) back. For existing msm, the VMA(s) are implicitly torn down when the GEM obj is freed. This won't work with the VMA(s) holding hard references to the BO.
Ok, that makes sense to me, but why can't this be changed? I don't see how the uAPI would be affected, this is just an implementation detail, no?
Quoted 11 lines
When userspace opts-in to "
VM_BIND" mode, which it has to do before the VM is created, then we don't set this flag, the VMA holds a hard reference to the BO as it does with other drivers. But consider this use-case, which is perfectly valid for old (existing) userspace:1) Userspace creates a BO
2) Submits rendering referencing the BO
3) Immediately closes the BO handle, without waiting for the submit to completeIn this case, the submit holds a reference to the BO which holds a reference to the VMA.
Can't you just instead create the VMAs, which hold a reference to the VM_BO, which holds a reference to the BO, then drop the drop the original BO reference and finally, when everything is completed, remove all VMAs of the VM_BO?
This should do exactly the same *and* be conformant with GPUVM design.
Quoted 7 lines
Everything is torn down gracefully when the
submit completes. But if the VMA held a hard reference to the BO then you'd have a reference loop.So there really is no other way to use gpuvm _and_ maintain backwards compatibility with the semantics of the pre-VM_BIND UAPI without this flag.
Again, how is this important for maintaining backwards compatibility with the uAPI? This all seems like a driver internal implementation detail to me.
So, is there a technical reason, or is it more that it would be more effort on the driver end to rework things accordingly?
Quoted 5 lines
Fortunately
DRM_GPUVM_VA_WEAK_REFis minimally intrusive. Otherwise I probably would have had to fork my own copy of gpuvm.BR,
-R
Re: [PATCH v4 02/40] drm/gpuvm: Allow VAs to hold soft reference to BOs
Quoted 29 lines · Danilo Krummrich
On Thu, May 15, 2025 at 07:59:16AM -0700, Rob Clark wrote:
Thanks for the detailed explanation!
Quoted 24 lines · Danilo Krummrich
Quoted 11 lines · Rob Clark
Quoted 8 lines
From: Rob Clark <[email protected]>
Eases migration for drivers where VAs don't hold hard references to their associated BO, avoiding reference loops.
In particular, msm uses soft references to optimistically keep around mappings until the BO is distroyed. Which obviously won't work if the VA (the mapping) is holding a reference to the BO.
Quoted 6 lines
Ick! This is all complicated enough. Allow drivers to bypass the proper reference counting for GEM objects in the context of
VM_BOstructures seems like an insane footgun.I don't understand why MSM would need weak references here. Why does msm need that, but nouveau, Xe, panthor, PowerVR do not?
Most of those drivers were designed (and had their UABI designed) with gpuvm, or at least sparse, in mind from the get go. I'm not sure about nouveau, but I guess it just got lucky that it's UABI semantics fit having the VMA hold a reference to the BO.
Quoted 8 lines
Quoted 5 lines
Unfortunately, msm pre-dates sparse.. and in the beginning there was only a single global VM, multiple VMs was something retrofitted ~6yrs (?) back. For existing msm, the VMA(s) are implicitly torn down when the GEM obj is freed. This won't work with the VMA(s) holding hard references to the BO.
Ok, that makes sense to me, but why can't this be changed? I don't see how the uAPI would be affected, this is just an implementation detail, no?
It's about the behaviour of the API, there is no explicit VMA creation/destruction in the uAPI.
Quoted 9 lines
Quoted 9 lines
When userspace opts-in to "
VM_BIND" mode, which it has to do before the VM is created, then we don't set this flag, the VMA holds a hard reference to the BO as it does with other drivers. But consider this use-case, which is perfectly valid for old (existing) userspace:1) Userspace creates a BO
2) Submits rendering referencing the BO
3) Immediately closes the BO handle, without waiting for the submit to complete
Quoted 6 lines
Quoted 2 lines
In this case, the submit holds a reference to the BO which holds a reference to the VMA.
Can't you just instead create the VMAs, which hold a reference to the
VM_BO, which holds a reference to the BO, then drop the drop the original BO reference and finally, when everything is completed, remove all VMAs of theVM_BO?
Perhaps the submit could hold a ref to the VM_BO instead of the BO to cover that particular case.
But for the legacy world, the VMA is implicitly torn down when the BO is freed. Which will never happen if the VM_BO holds a reference to the BO.
Quoted 10 lines
This should do exactly the same *and* be conformant with GPUVM design.
Quoted 7 lines
Everything is torn down gracefully when the
submit completes. But if the VMA held a hard reference to the BO then you'd have a reference loop.So there really is no other way to use gpuvm _and_ maintain backwards compatibility with the semantics of the pre-VM_BIND UAPI without this flag.
Quoted 5 lines
Again, how is this important for maintaining backwards compatibility with the uAPI? This all seems like a driver internal implementation detail to me.
So, is there a technical reason, or is it more that it would be more effort on the driver end to rework things accordingly?
If there were a way to work without WEAK_REF, it seems like it would be harder and much less of a drop in change.
BR,
-R
Quoted 5 lines
Quoted 5 lines
Fortunately
DRM_GPUVM_VA_WEAK_REFis minimally intrusive. Otherwise I probably would have had to fork my own copy of gpuvm.BR,
-R
Danilo Krummrich
maintainerRe: [PATCH v4 02/40] drm/gpuvm: Allow VAs to hold soft reference to BOs
Quoted 36 lines · Rob Clark
Quoted 35 lines · Danilo Krummrich
On Thu, May 15, 2025 at 07:59:16AM -0700, Rob Clark wrote:
Thanks for the detailed explanation!
Quoted 29 lines · Danilo Krummrich
Quoted 11 lines · Rob Clark
Quoted 8 lines
From: Rob Clark <[email protected]>
Eases migration for drivers where VAs don't hold hard references to their associated BO, avoiding reference loops.
In particular, msm uses soft references to optimistically keep around mappings until the BO is distroyed. Which obviously won't work if the VA (the mapping) is holding a reference to the BO.
Quoted 6 lines
Ick! This is all complicated enough. Allow drivers to bypass the proper reference counting for GEM objects in the context of
VM_BOstructures seems like an insane footgun.I don't understand why MSM would need weak references here. Why does msm need that, but nouveau, Xe, panthor, PowerVR do not?
Most of those drivers were designed (and had their UABI designed) with gpuvm, or at least sparse, in mind from the get go. I'm not sure about nouveau, but I guess it just got lucky that it's UABI semantics fit having the VMA hold a reference to the BO.
Unfortunately, msm pre-dates sparse.. and in the beginning there was only a single global VM, multiple VMs was something retrofitted ~6yrs (?) back. For existing msm, the VMA(s) are implicitly torn down when the GEM obj is freed. This won't work with the VMA(s) holding hard references to the BO.
Quoted 5 lines
Quoted 2 lines
Ok, that makes sense to me, but why can't this be changed? I don't see how the uAPI would be affected, this is just an implementation detail, no?
It's about the behaviour of the API, there is no explicit VMA creation/destruction in the uAPI.
But that shouldn't matter? Userspace gives you a BO, the driver creates VMAs itself, which can have a reference on the VM_BO, which references the original BO. At this point you can drop the original reference of the BO and just destroy all corresponding VMAs once the driver fulfilled the request from userspace?
Quoted 16 lines
Quoted 9 lines
Quoted 9 lines
When userspace opts-in to "
VM_BIND" mode, which it has to do before the VM is created, then we don't set this flag, the VMA holds a hard reference to the BO as it does with other drivers. But consider this use-case, which is perfectly valid for old (existing) userspace:1) Userspace creates a BO
2) Submits rendering referencing the BO
3) Immediately closes the BO handle, without waiting for the submit to completeQuoted 6 lines
Quoted 2 lines
In this case, the submit holds a reference to the BO which holds a reference to the VMA.
Can't you just instead create the VMAs, which hold a reference to the
VM_BO, which holds a reference to the BO, then drop the drop the original BO reference and finally, when everything is completed, remove all VMAs of theVM_BO?
Quoted 6 lines
Perhaps the submit could hold a ref to the
VM_BOinstead of the BO to cover that particular case.But for the legacy world, the VMA is implicitly torn down when the BO is freed. Which will never happen if the
VM_BOholds a reference to the BO.
Sure, I get that; what I do not get is why it can't be changed, e.g. in the way described above.
Quoted 10 lines
Quoted 10 lines
This should do exactly the same *and* be conformant with GPUVM design.
Quoted 7 lines
Everything is torn down gracefully when the
submit completes. But if the VMA held a hard reference to the BO then you'd have a reference loop.So there really is no other way to use gpuvm _and_ maintain backwards compatibility with the semantics of the pre-VM_BIND UAPI without this flag.
Quoted 8 lines
Quoted 5 lines
Again, how is this important for maintaining backwards compatibility with the uAPI? This all seems like a driver internal implementation detail to me.
So, is there a technical reason, or is it more that it would be more effort on the driver end to rework things accordingly?
If there were a way to work without
WEAK_REF, it seems like it would be harder and much less of a drop in change.
So, you're saying there is no technical blocker to rework it?
Re: [PATCH v4 02/40] drm/gpuvm: Allow VAs to hold soft reference to BOs
Quoted 41 lines · Danilo Krummrich
Quoted 39 lines · Rob Clark
Quoted 37 lines · Danilo Krummrich
On Thu, May 15, 2025 at 07:59:16AM -0700, Rob Clark wrote:
Thanks for the detailed explanation!
Quoted 24 lines · Danilo Krummrich
Quoted 11 lines · Rob Clark
Quoted 8 lines
From: Rob Clark <[email protected]>
Eases migration for drivers where VAs don't hold hard references to their associated BO, avoiding reference loops.
In particular, msm uses soft references to optimistically keep around mappings until the BO is distroyed. Which obviously won't work if the VA (the mapping) is holding a reference to the BO.
Quoted 6 lines
Ick! This is all complicated enough. Allow drivers to bypass the proper reference counting for GEM objects in the context of
VM_BOstructures seems like an insane footgun.I don't understand why MSM would need weak references here. Why does msm need that, but nouveau, Xe, panthor, PowerVR do not?
Most of those drivers were designed (and had their UABI designed) with gpuvm, or at least sparse, in mind from the get go. I'm not sure about nouveau, but I guess it just got lucky that it's UABI semantics fit having the VMA hold a reference to the BO.
Quoted 5 lines
Unfortunately, msm pre-dates sparse.. and in the beginning there was only a single global VM, multiple VMs was something retrofitted ~6yrs (?) back. For existing msm, the VMA(s) are implicitly torn down when the GEM obj is freed. This won't work with the VMA(s) holding hard references to the BO.
Ok, that makes sense to me, but why can't this be changed? I don't see how the uAPI would be affected, this is just an implementation detail, no?
Quoted 7 lines
Quoted 2 lines
It's about the behaviour of the API, there is no explicit VMA creation/destruction in the uAPI.
But that shouldn't matter? Userspace gives you a BO, the driver creates VMAs itself, which can have a reference on the
VM_BO, which references the original BO. At this point you can drop the original reference of the BO and just destroy all corresponding VMAs once the driver fulfilled the request from userspace?
Having the submit hold a reference to the VM_BO, and then this funny looking bit of code in gem_close() gets us part way there:
vm_bo = drm_gpuvm_bo_find(ctx->vm, obj);
if (vm_bo) {
drm_gpuvm_bo_put(vm_bo);
drm_gpuvm_bo_put(vm_bo);
}But we still leak BO's used in other VMs.. scanout, and various other fw and other internal BOs... those would all have to be tracked down and to find _someplace_ to break the VM_BO circular reference loop.
Quoted 39 lines
Quoted 16 lines
Quoted 9 lines
Quoted 9 lines
When userspace opts-in to "
VM_BIND" mode, which it has to do before the VM is created, then we don't set this flag, the VMA holds a hard reference to the BO as it does with other drivers. But consider this use-case, which is perfectly valid for old (existing) userspace:1) Userspace creates a BO
2) Submits rendering referencing the BO
3) Immediately closes the BO handle, without waiting for the submit to completeQuoted 6 lines
Quoted 2 lines
In this case, the submit holds a reference to the BO which holds a reference to the VMA.
Can't you just instead create the VMAs, which hold a reference to the
VM_BO, which holds a reference to the BO, then drop the drop the original BO reference and finally, when everything is completed, remove all VMAs of theVM_BO?Quoted 6 lines
Perhaps the submit could hold a ref to the
VM_BOinstead of the BO to cover that particular case.But for the legacy world, the VMA is implicitly torn down when the BO is freed. Which will never happen if the
VM_BOholds a reference to the BO.Sure, I get that; what I do not get is why it can't be changed, e.g. in the way described above.
Quoted 13 lines
Quoted 13 lines
This should do exactly the same *and* be conformant with GPUVM design.
Quoted 7 lines
Everything is torn down gracefully when the
submit completes. But if the VMA held a hard reference to the BO then you'd have a reference loop.So there really is no other way to use gpuvm _and_ maintain backwards compatibility with the semantics of the pre-VM_BIND UAPI without this flag.
Again, how is this important for maintaining backwards compatibility with the uAPI? This all seems like a driver internal implementation detail to me.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
So, is there a technical reason, or is it more that it would be more effort on the driver end to rework things accordingly?
If there were a way to work without
WEAK_REF, it seems like it would be harder and much less of a drop in change.So, you're saying there is no technical blocker to rework it?
Not clear.. it would certainly make conversion to gpuvm a much bigger flag-day, because without WEAK_REF the way gpuvm works is exactly backwards from how the thing it is replacing works.
BR,
-R
PATCH v4 3/40 drm/gem: Add ww_acquire_ctx support to drm_gem_lru_scan()
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
If the callback is going to have to attempt to grab more locks, it is useful to have an ww_acquire_ctx to avoid locking order problems.
Why not use the drm_exec helper instead? Mainly because (a) where ww_acquire_init() is called is awkward, and (b) we don't really need to retry after backoff, we can just move on to the next object.
--- drivers/gpu/drm/drm_gem.c | 14 +++++++++++--- drivers/gpu/drm/msm/msm_gem_shrinker.c | 24 +++++++++++++----------- include/drm/drm_gem.h | 10 ++++++---- 3 files changed, 30 insertions(+), 18 deletions(-)
drivers/gpu/drm/drm_gem.c +11 -3
@@ -1460,12 +1460,14 @@ EXPORT_SYMBOL(drm_gem_lru_move_tail);* @nr_to_scan: The number of pages to try to reclaim * @remaining: The number of pages left to reclaim, should be initialized by caller * @shrink: Callback to try to shrink/reclaim the object. +* @ticket: Optional ww_acquire_ctx context to use for locking */ unsigned long drm_gem_lru_scan (struct drm_gem_lru *lru,unsigned int nr_to_scan,unsigned long *remaining, -bool (*shrink)(struct drm_gem_object *obj)) +bool (*shrink)(struct drm_gem_object *obj,struct ww_acquire_ctx *ticket), +struct ww_acquire_ctx *ticket) {struct drm_gem_lru still_in_lru;struct drm_gem_object *obj;
@@ -1498,17 +1500,20 @@ drm_gem_lru_scan(struct drm_gem_lru *lru,*/ mutex_unlock (lru->lock); +if (ticket) +ww_acquire_init (ticket, &reservation_ww_class); +/* * Note that this still needs to be trylock, since we can * hit shrinker in response to trying to get backing pages * for this obj (ie. while it's lock is already held) */ -if (!dma_resv_trylock (obj->resv)) { +if (!ww_mutex_trylock (&obj->resv->lock, ticket)) { *remaining += obj->size >>PAGE_SHIFT ; goto tail; } -if (shrink (obj)) { +if (shrink (obj, ticket)) { freed += obj->size >>PAGE_SHIFT ;/*
@@ -1522,6 +1527,9 @@ drm_gem_lru_scan(struct drm_gem_lru *lru,dma_resv_unlock (obj->resv); +if (ticket) +ww_acquire_fini (ticket); + tail:drm_gem_object_put (obj);mutex_lock (lru->lock);
drivers/gpu/drm/msm/msm_gem_shrinker.c +13 -11
@@ -44,7 +44,7 @@ msm_gem_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc) }static bool -purge (struct drm_gem_object *obj) +purge (struct drm_gem_object *obj,struct ww_acquire_ctx *ticket) {if (!is_purgeable (to_msm_bo (obj)))return false;
@@ -58,7 +58,7 @@ purge(struct drm_gem_object *obj) }static bool -evict (struct drm_gem_object *obj) +evict (struct drm_gem_object *obj,struct ww_acquire_ctx *ticket) {if (is_unevictable (to_msm_bo (obj)))return false;
@@ -79,21 +79,21 @@ wait_for_idle(struct drm_gem_object *obj) }static bool -active_purge (struct drm_gem_object *obj) +active_purge (struct drm_gem_object *obj,struct ww_acquire_ctx *ticket) {if (!wait_for_idle (obj))return false; -return purge (obj); +return purge (obj, ticket); }static bool -active_evict (struct drm_gem_object *obj) +active_evict (struct drm_gem_object *obj,struct ww_acquire_ctx *ticket) {if (!wait_for_idle (obj))return false; -return evict (obj); +return evict (obj, ticket); } static unsigned long
@@ -102,7 +102,7 @@ msm_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc)struct msm_drm_private *priv = shrinker->private_data;struct {struct drm_gem_lru *lru; -bool (*shrink)(struct drm_gem_object *obj); +bool (*shrink)(struct drm_gem_object *obj,struct ww_acquire_ctx *ticket);bool cond;unsigned long freed;unsigned long remaining;
@@ -122,8 +122,9 @@ msm_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc)continue ; stages[i].freed =drm_gem_lru_scan (stages[i].lru, nr, - &stages[i].remaining, - stages[i].shrink); + &stages[i].remaining, + stages[i].shrink, +NULL ); nr -= stages[i].freed; freed += stages[i].freed; remaining += stages[i].remaining;
@@ -164,7 +165,7 @@ msm_gem_shrinker_shrink(struct drm_device *dev, unsigned long nr_to_scan)static const int vmap_shrink_limit =15 ;static bool -vmap_shrink (struct drm_gem_object *obj) +vmap_shrink (struct drm_gem_object *obj,struct ww_acquire_ctx *ticket) {if (!is_vunmapable (to_msm_bo (obj)))return false;
@@ -192,7 +193,8 @@ msm_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptr) unmapped +=drm_gem_lru_scan (lrus[idx], vmap_shrink_limit - unmapped, &remaining, - vmap_shrink); + vmap_shrink, +NULL ); } *(unsigned long *)ptr += unmapped;
include/drm/drm_gem.h +6 -4
@@ -555,10 +555,12 @@ void drm_gem_lru_init(struct drm_gem_lru *lru, struct mutex *lock);void drm_gem_lru_remove (struct drm_gem_object *obj);void drm_gem_lru_move_tail_locked (struct drm_gem_lru *lru,struct drm_gem_object *obj);void drm_gem_lru_move_tail (struct drm_gem_lru *lru,struct drm_gem_object *obj); -unsigned long drm_gem_lru_scan (struct drm_gem_lru *lru, -unsigned int nr_to_scan, -unsigned long *remaining, -bool (*shrink)(struct drm_gem_object *obj)); +unsigned long +drm_gem_lru_scan (struct drm_gem_lru *lru, +unsigned int nr_to_scan, +unsigned long *remaining, +bool (*shrink)(struct drm_gem_object *obj,struct ww_acquire_ctx *ticket), +struct ww_acquire_ctx *ticket);int drm_gem_evict (struct drm_gem_object *obj);
Signature · 1 line
2.49.0
PATCH v4 4/40 drm/sched: Add enqueue credit limit
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Similar to the existing credit limit mechanism, but applying to jobs enqueued to the scheduler but not yet run.
The use case is to put an upper bound on preallocated, and potentially unneeded, pgtable pages. When this limit is exceeded, pushing new jobs will block until the count drops below the limit.
--- drivers/gpu/drm/scheduler/sched_entity.c | 16 ++++++++++++++-- drivers/gpu/drm/scheduler/sched_main.c | 3 +++ include/drm/gpu_scheduler.h | 13 ++++++++++++- 3 files changed, 29 insertions(+), 3 deletions(-)
drivers/gpu/drm/scheduler/sched_entity.c +14 -2
@@ -580,11 +580,21 @@ void drm_sched_entity_select_rq(struct drm_sched_entity *entity)* under common lock for the struct drm_sched_entity that was set up for * @sched_job in drm_sched_job_init(). */ -void drm_sched_entity_push_job (struct drm_sched_job *sched_job) +int drm_sched_entity_push_job (struct drm_sched_job *sched_job) {struct drm_sched_entity *entity = sched_job->entity; +struct drm_gpu_scheduler *sched = sched_job->sched;bool first;ktime_t submit_ts; +int ret; + + ret =wait_event_interruptible ( + sched->job_scheduled, +atomic_read (&sched->enqueue_credit_count) <= + sched->enqueue_credit_limit); +if (ret) +return ret; +atomic_add (sched_job->enqueue_credits, &sched->enqueue_credit_count);trace_drm_sched_job (sched_job, entity);atomic_inc (entity->rq->sched->score);
@@ -609,7 +619,7 @@ void drm_sched_entity_push_job(struct drm_sched_job *sched_job)spin_unlock (&entity->lock);DRM_ERROR ("Trying to push to a killed entity\n" ); -return ; +return -EINVAL ; } rq = entity->rq;
@@ -626,5 +636,7 @@ void drm_sched_entity_push_job(struct drm_sched_job *sched_job)drm_sched_wakeup (sched); } + +return 0 ; }EXPORT_SYMBOL (drm_sched_entity_push_job);
drivers/gpu/drm/scheduler/sched_main.c +3 -0
@@ -1217,6 +1217,7 @@ static void drm_sched_run_job_work(struct work_struct *w)trace_drm_run_job (sched_job, entity); fence = sched->ops->run_job (sched_job); +atomic_sub (sched_job->enqueue_credits, &sched->enqueue_credit_count);complete_all (&entity->entity_idle);drm_sched_fence_scheduled (s_fence, fence);
@@ -1253,6 +1254,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched, const struct drm_sched_init_ sched->ops = args->ops; sched->credit_limit = args->credit_limit; + sched->enqueue_credit_limit = args->enqueue_credit_limit; sched->name = args->name; sched->timeout = args->timeout; sched->hang_limit = args->hang_limit;
@@ -1308,6 +1310,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched, const struct drm_sched_init_INIT_LIST_HEAD (&sched->pending_list);spin_lock_init (&sched->job_list_lock);atomic_set (&sched->credit_count,0 ); +atomic_set (&sched->enqueue_credit_count,0 );INIT_DELAYED_WORK (&sched->work_tdr, drm_sched_job_timedout);INIT_WORK (&sched->work_run_job, drm_sched_run_job_work);INIT_WORK (&sched->work_free_job, drm_sched_free_job_work);
include/drm/gpu_scheduler.h +12 -1
@@ -329,6 +329,7 @@ struct drm_sched_fence *to_drm_sched_fence(struct dma_fence *f);* @s_fence: contains the fences for the scheduling of job. * @finish_cb: the callback for the finished fence. * @credits: the number of credits this job contributes to the scheduler +* @enqueue_credits: the number of enqueue credits this job contributes * @work: Helper to reschedule job kill to different context. * @id: a unique id assigned to each job scheduled on the scheduler. * @karma: increment on every hang caused by this job. If this exceeds the hang
@@ -366,6 +367,7 @@ struct drm_sched_job {enum drm_sched_priority s_priority;u32 credits; +u32 enqueue_credits;/** @last_dependency: tracks @dependencies as they signal */ unsigned int last_dependency;atomic_t karma;
@@ -485,6 +487,10 @@ struct drm_sched_backend_ops {* @ops: backend operations provided by the driver. * @credit_limit: the credit limit of this scheduler * @credit_count: the current credit count of this scheduler +* @enqueue_credit_limit: the credit limit of jobs pushed to scheduler and not +* yet run +* @enqueue_credit_count: the current crdit count of jobs pushed to scheduler +* but not yet run * @timeout: the time after which a job is removed from the scheduler. * @name: name of the ring for which this scheduler is being used. * @num_rqs: Number of run-queues. This is at most DRM_SCHED_PRIORITY_COUNT,
@@ -518,6 +524,8 @@ struct drm_gpu_scheduler {const struct drm_sched_backend_ops *ops;u32 credit_limit;atomic_t credit_count; +u32 enqueue_credit_limit; +atomic_t enqueue_credit_count;long timeout;const char *name;u32 num_rqs;
@@ -550,6 +558,8 @@ struct drm_gpu_scheduler {* @num_rqs: Number of run-queues. This may be at most DRM_SCHED_PRIORITY_COUNT, * as there's usually one run-queue per priority, but may be less. * @credit_limit: the number of credits this scheduler can hold from all jobs +* @enqueue_credit_limit: the number of credits that can be enqueued before +* drm_sched_entity_push_job() blocks * @hang_limit: number of times to allow a job to hang before dropping it. * This mechanism is DEPRECATED. Set it to 0. * @timeout: timeout value in jiffies for submitted jobs.
@@ -564,6 +574,7 @@ struct drm_sched_init_args {struct workqueue_struct *timeout_wq;u32 num_rqs;u32 credit_limit; +u32 enqueue_credit_limit;unsigned int hang_limit;long timeout;atomic_t *score;
@@ -600,7 +611,7 @@ int drm_sched_job_init(struct drm_sched_job *job,struct drm_sched_entity *entity, u32 credits, void *owner);void drm_sched_job_arm (struct drm_sched_job *job); -void drm_sched_entity_push_job (struct drm_sched_job *sched_job); +int drm_sched_entity_push_job (struct drm_sched_job *sched_job);int drm_sched_job_add_dependency (struct drm_sched_job *job,struct dma_fence *fence); int drm_sched_job_add_syncobj_dependency(struct drm_sched_job *job,
Signature · 1 line
2.49.0
PATCH v4 5/40 iommu/io-pgtable-arm: Add quirk to quiet WARN_ON()
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
In situations where mapping/unmapping sequence can be controlled by userspace, attempting to map over a region that has not yet been unmapped is an error. But not something that should spam dmesg.
Now that there is a quirk, we can also drop the selftest_running flag, and use the quirk instead for selftests.
--- drivers/iommu/io-pgtable-arm.c | 27 ++++++++++++++------------- include/linux/io-pgtable.h | 8 ++++++++ 2 files changed, 22 insertions(+), 13 deletions(-)
drivers/iommu/io-pgtable-arm.c +14 -13
@@ -253,8 +253,6 @@ static inline bool arm_lpae_concat_mandatory(struct io_pgtable_cfg *cfg, (data->start_level ==1 ) && (oas ==40 ); } -static bool selftest_running = false; -static dma_addr_t __arm_lpae_dma_addr (void *pages) {return (dma_addr_t )virt_to_phys (pages);
@@ -373,7 +371,7 @@ static int arm_lpae_init_pte(struct arm_lpae_io_pgtable *data,for (i =0 ; i < num_entries; i++)if (iopte_leaf (ptep[i], lvl, data->iop.fmt)) {/* We require an unmap first */ -WARN_ON (!selftest_running); +WARN_ON (!(data->iop.cfg.quirks &IO_PGTABLE_QUIRK_NO_WARN_ON ));return -EEXIST ; }else if (iopte_type (ptep[i]) ==ARM_LPAE_PTE_TYPE_TABLE ) {/*
@@ -475,7 +473,7 @@ static int __arm_lpae_map(struct arm_lpae_io_pgtable *data, unsigned long iova, cptep =iopte_deref (pte, data); }else if (pte) {/* We require an unmap first */ -WARN_ON (!selftest_running); +WARN_ON (!(cfg->quirks &IO_PGTABLE_QUIRK_NO_WARN_ON ));return -EEXIST ; }
@@ -649,8 +647,10 @@ static size_t __arm_lpae_unmap(struct arm_lpae_io_pgtable *data, unmap_idx_start =ARM_LPAE_LVL_IDX (iova, lvl, data); ptep += unmap_idx_start; pte =READ_ONCE (*ptep); -if (WARN_ON (!pte)) -return 0 ; +if (!pte) { +WARN_ON (!(data->iop.cfg.quirks &IO_PGTABLE_QUIRK_NO_WARN_ON )); +return -ENOENT ; + }/* If the size matches this level, we're in the right place */ if (size ==ARM_LPAE_BLOCK_SIZE (lvl, data)) {
@@ -660,8 +660,10 @@ static size_t __arm_lpae_unmap(struct arm_lpae_io_pgtable *data,/* Find and handle non-leaf entries */ for (i =0 ; i < num_entries; i++) { pte =READ_ONCE (ptep[i]); -if (WARN_ON (!pte)) +if (!pte) { +WARN_ON (!(data->iop.cfg.quirks &IO_PGTABLE_QUIRK_NO_WARN_ON ));break ; + }if (!iopte_leaf (pte, lvl, iop->fmt)) {__arm_lpae_clear_pte (&ptep[i], &iop->cfg,1 );
@@ -976,7 +978,8 @@ arm_64_lpae_alloc_pgtable_s1(struct io_pgtable_cfg *cfg, void *cookie)if (cfg->quirks & ~(IO_PGTABLE_QUIRK_ARM_NS |IO_PGTABLE_QUIRK_ARM_TTBR1 |IO_PGTABLE_QUIRK_ARM_OUTER_WBWA | -IO_PGTABLE_QUIRK_ARM_HD )) +IO_PGTABLE_QUIRK_ARM_HD | +IO_PGTABLE_QUIRK_NO_WARN_ON ))return NULL ; data =arm_lpae_alloc_pgtable (cfg);
@@ -1079,7 +1082,8 @@ arm_64_lpae_alloc_pgtable_s2(struct io_pgtable_cfg *cfg, void *cookie)struct arm_lpae_io_pgtable *data; typeof(&cfg->arm_lpae_s2_cfg.vtcr) vtcr = &cfg->arm_lpae_s2_cfg.vtcr; -if (cfg->quirks & ~(IO_PGTABLE_QUIRK_ARM_S2FWB )) +if (cfg->quirks & ~(IO_PGTABLE_QUIRK_ARM_S2FWB | +IO_PGTABLE_QUIRK_NO_WARN_ON ))return NULL ; data =arm_lpae_alloc_pgtable (cfg);
@@ -1320,7 +1324,6 @@ static void __init arm_lpae_dump_ops(struct io_pgtable_ops *ops)#define __FAIL (ops, i) ({ \ WARN(1, "selftest: test failed for fmt idx %d\n", (i)); \ arm_lpae_dump_ops(ops); \ - selftest_running = false; \ -EFAULT; \ })
@@ -1336,8 +1339,6 @@ static int __init arm_lpae_run_tests(struct io_pgtable_cfg *cfg)size_t size, mapped;struct io_pgtable_ops *ops; - selftest_running = true; -for (i =0 ; i <ARRAY_SIZE (fmts); ++i) { cfg_cookie = cfg; ops =alloc_io_pgtable_ops (fmts[i], cfg, cfg);
@@ -1426,7 +1427,6 @@ static int __init arm_lpae_run_tests(struct io_pgtable_cfg *cfg)free_io_pgtable_ops (ops); } - selftest_running = false;return 0 ; }
@@ -1448,6 +1448,7 @@ static int __init arm_lpae_do_selftests(void) .tlb = &dummy_tlb_ops, .coherent_walk = true, .iommu_dev = &dev, + .quirks = IO_PGTABLE_QUIRK_NO_WARN_ON, };/* __arm_lpae_alloc_pages() merely needs dev_to_node() to work */
include/linux/io-pgtable.h +8 -0
@@ -88,6 +88,13 @@ struct io_pgtable_cfg {* * IO_PGTABLE_QUIRK_ARM_HD: Enables dirty tracking in stage 1 pagetable. * IO_PGTABLE_QUIRK_ARM_S2FWB: Use the FWB format for the MemAttrs bits +* +* IO_PGTABLE_QUIRK_NO_WARN_ON: Do not WARN_ON() on conflicting +* mappings, but silently return -EEXISTS. Normally an attempt +* to map over an existing mapping would indicate some sort of +* kernel bug, which would justify the WARN_ON(). But for GPU +* drivers, this could be under control of userspace. Which +* deserves an error return, but not to spam dmesg. */ #define IO_PGTABLE_QUIRK_ARM_NS BIT(0)#define IO_PGTABLE_QUIRK_NO_PERMS BIT(1)
@@ -97,6 +104,7 @@ struct io_pgtable_cfg {#define IO_PGTABLE_QUIRK_ARM_OUTER_WBWA BIT(6)#define IO_PGTABLE_QUIRK_ARM_HD BIT(7)#define IO_PGTABLE_QUIRK_ARM_S2FWB BIT(8) +#define IO_PGTABLE_QUIRK_NO_WARN_ON BIT(9)unsigned long quirks;unsigned long pgsize_bitmap;unsigned int ias;
Signature · 1 line
2.49.0
Will Deacon
maintainerRe: [PATCH v4 05/40] iommu/io-pgtable-arm: Add quirk to quiet WARN_ON()
Quoted 16 lines · Rob Clark
From: Rob Clark <[email protected]>
In situations where mapping/unmapping sequence can be controlled by userspace, attempting to map over a region that has not yet been unmapped is an error. But not something that should spam dmesg.
Now that there is a quirk, we can also drop the
selftest_runningflag, and use the quirk instead for selftests.Signed-off-by Rob Clark <[email protected]>Acked-by Robin Murphy <[email protected]>Signed-off-by Rob Clark <[email protected]>--- drivers/iommu/io-pgtable-arm.c | 27 ++++++++++++++------------- include/linux/io-pgtable.h | 8 ++++++++ 2 files changed, 22 insertions(+), 13 deletions(-)
[...]
Quoted 19 lines
include/linux/io-pgtable.h +7
-0@@ -88,6 +88,13 @@ struct io_pgtable_cfg {* * IO_PGTABLE_QUIRK_ARM_HD: Enables dirty tracking in stage 1 pagetable. * IO_PGTABLE_QUIRK_ARM_S2FWB: Use the FWB format for the MemAttrs bits +* +* IO_PGTABLE_QUIRK_NO_WARN_ON: Do not WARN_ON() on conflicting +* mappings, but silently return -EEXISTS. Normally an attempt +* to map over an existing mapping would indicate some sort of +* kernel bug, which would justify the WARN_ON(). But for GPU +* drivers, this could be under control of userspace. Which +* deserves an error return, but not to spam dmesg. */ #define IO_PGTABLE_QUIRK_ARM_NS BIT(0)#define IO_PGTABLE_QUIRK_NO_PERMS BIT(1)
include/linux/io-pgtable.h struct io_pgtable_cfg { · line 107
Quoted 4 lines
include/linux/io-pgtable.h +1
-0@@ -97,6 +104,7 @@ struct io_pgtable_cfg {#define IO_PGTABLE_QUIRK_ARM_OUTER_WBWA BIT(6)#define IO_PGTABLE_QUIRK_ARM_HD BIT(7)#define IO_PGTABLE_QUIRK_ARM_S2FWB BIT(8) +#define IO_PGTABLE_QUIRK_NO_WARN_ON BIT(9)
This feels a bit fragile to me:
* IOMMU-API users of io-pgtable shouldn't be passing this quirk but might end up doing so to paper over driver bugs.
* Low-level users of io-pgtable who expose page-table operations to userspace need to pass the quirk, but might well not bother because well-behaved userspace doesn't trigger the warning.
So overall, it's all a bit unsatisfactory. Is there a way we could have the warnings only when invoked via the IOMMU API?
Will
Re: [PATCH v4 05/40] iommu/io-pgtable-arm: Add quirk to quiet WARN_ON()
Quoted 49 lines · Will Deacon
Quoted 16 lines · Rob Clark
From: Rob Clark <[email protected]>
In situations where mapping/unmapping sequence can be controlled by userspace, attempting to map over a region that has not yet been unmapped is an error. But not something that should spam dmesg.
Now that there is a quirk, we can also drop the
selftest_runningflag, and use the quirk instead for selftests.Signed-off-by Rob Clark <[email protected]>Acked-by Robin Murphy <[email protected]>Signed-off-by Rob Clark <[email protected]>--- drivers/iommu/io-pgtable-arm.c | 27 ++++++++++++++------------- include/linux/io-pgtable.h | 8 ++++++++ 2 files changed, 22 insertions(+), 13 deletions(-)[...]
Quoted 19 lines
include/linux/io-pgtable.h +7
-0@@ -88,6 +88,13 @@ struct io_pgtable_cfg {* * IO_PGTABLE_QUIRK_ARM_HD: Enables dirty tracking in stage 1 pagetable. * IO_PGTABLE_QUIRK_ARM_S2FWB: Use the FWB format for the MemAttrs bits +* +* IO_PGTABLE_QUIRK_NO_WARN_ON: Do not WARN_ON() on conflicting +* mappings, but silently return -EEXISTS. Normally an attempt +* to map over an existing mapping would indicate some sort of +* kernel bug, which would justify the WARN_ON(). But for GPU +* drivers, this could be under control of userspace. Which +* deserves an error return, but not to spam dmesg. */ #define IO_PGTABLE_QUIRK_ARM_NS BIT(0)#define IO_PGTABLE_QUIRK_NO_PERMS BIT(1)include/linux/io-pgtable.h struct io_pgtable_cfg { · line 107
Quoted 4 lines
include/linux/io-pgtable.h +1
-0@@ -97,6 +104,7 @@ struct io_pgtable_cfg {#define IO_PGTABLE_QUIRK_ARM_OUTER_WBWA BIT(6)#define IO_PGTABLE_QUIRK_ARM_HD BIT(7)#define IO_PGTABLE_QUIRK_ARM_S2FWB BIT(8) +#define IO_PGTABLE_QUIRK_NO_WARN_ON BIT(9)This feels a bit fragile to me:
* IOMMU-API users of io-pgtable shouldn't be passing this quirk but might end up doing so to paper over driver bugs.
Quoted 6 lines
* Low-level users of io-pgtable who expose page-table operations to userspace need to pass the quirk, but might well not bother because well-behaved userspace doesn't trigger the warning.
So overall, it's all a bit unsatisfactory. Is there a way we could have the warnings only when invoked via the IOMMU API?
iommu drivers _not_ setting this flag seems like a good way to achieve that ;-)
The alternative is to move the warns to the iommu driver... but they could just as easily remove the WARN_ON()s as they could set the NO_WARN_ON quirk, so :shrug:?
BR,
-R
Will Deacon
maintainerRe: [PATCH v4 05/40] iommu/io-pgtable-arm: Add quirk to quiet WARN_ON()
Quoted 54 lines · Rob Clark
Quoted 53 lines · Will Deacon
Quoted 16 lines · Rob Clark
From: Rob Clark <[email protected]>
In situations where mapping/unmapping sequence can be controlled by userspace, attempting to map over a region that has not yet been unmapped is an error. But not something that should spam dmesg.
Now that there is a quirk, we can also drop the
selftest_runningflag, and use the quirk instead for selftests.Signed-off-by Rob Clark <[email protected]>Acked-by Robin Murphy <[email protected]>Signed-off-by Rob Clark <[email protected]>--- drivers/iommu/io-pgtable-arm.c | 27 ++++++++++++++------------- include/linux/io-pgtable.h | 8 ++++++++ 2 files changed, 22 insertions(+), 13 deletions(-)[...]
Quoted 19 lines
include/linux/io-pgtable.h +7
-0@@ -88,6 +88,13 @@ struct io_pgtable_cfg {* * IO_PGTABLE_QUIRK_ARM_HD: Enables dirty tracking in stage 1 pagetable. * IO_PGTABLE_QUIRK_ARM_S2FWB: Use the FWB format for the MemAttrs bits +* +* IO_PGTABLE_QUIRK_NO_WARN_ON: Do not WARN_ON() on conflicting +* mappings, but silently return -EEXISTS. Normally an attempt +* to map over an existing mapping would indicate some sort of +* kernel bug, which would justify the WARN_ON(). But for GPU +* drivers, this could be under control of userspace. Which +* deserves an error return, but not to spam dmesg. */ #define IO_PGTABLE_QUIRK_ARM_NS BIT(0)#define IO_PGTABLE_QUIRK_NO_PERMS BIT(1)include/linux/io-pgtable.h struct io_pgtable_cfg { · line 107
Quoted 4 lines
include/linux/io-pgtable.h +1
-0@@ -97,6 +104,7 @@ struct io_pgtable_cfg {#define IO_PGTABLE_QUIRK_ARM_OUTER_WBWA BIT(6)#define IO_PGTABLE_QUIRK_ARM_HD BIT(7)#define IO_PGTABLE_QUIRK_ARM_S2FWB BIT(8) +#define IO_PGTABLE_QUIRK_NO_WARN_ON BIT(9)This feels a bit fragile to me:
* IOMMU-API users of io-pgtable shouldn't be passing this quirk but might end up doing so to paper over driver bugs.* Low-level users of io-pgtable who expose page-table operations to userspace need to pass the quirk, but might well not bother because well-behaved userspace doesn't trigger the warning.
Quoted 8 lines
Quoted 2 lines
So overall, it's all a bit unsatisfactory. Is there a way we could have the warnings only when invoked via the IOMMU API?
iommu drivers _not_ setting this flag seems like a good way to achieve that ;-)
The alternative is to move the warns to the iommu driver... but they could just as easily remove the WARN_ON()s as they could set the
NO_WARN_ONquirk, so :shrug:?
Bah, I also don't have a good idea to improve this, so I guess I'll take what you have for now.
Will
Robin Murphy
reviewerRe: [PATCH v4 05/40] iommu/io-pgtable-arm: Add quirk to quiet WARN_ON()
Quoted 58 lines · Will Deacon
Quoted 57 lines · Rob Clark
Quoted 55 lines · Will Deacon
Quoted 16 lines · Rob Clark
From: Rob Clark <[email protected]>
In situations where mapping/unmapping sequence can be controlled by userspace, attempting to map over a region that has not yet been unmapped is an error. But not something that should spam dmesg.
Now that there is a quirk, we can also drop the
selftest_runningflag, and use the quirk instead for selftests.Signed-off-by Rob Clark <[email protected]>Acked-by Robin Murphy <[email protected]>Signed-off-by Rob Clark <[email protected]>--- drivers/iommu/io-pgtable-arm.c | 27 ++++++++++++++------------- include/linux/io-pgtable.h | 8 ++++++++ 2 files changed, 22 insertions(+), 13 deletions(-)[...]
Quoted 19 lines
include/linux/io-pgtable.h +7
-0@@ -88,6 +88,13 @@ struct io_pgtable_cfg {* * IO_PGTABLE_QUIRK_ARM_HD: Enables dirty tracking in stage 1 pagetable. * IO_PGTABLE_QUIRK_ARM_S2FWB: Use the FWB format for the MemAttrs bits +* +* IO_PGTABLE_QUIRK_NO_WARN_ON: Do not WARN_ON() on conflicting +* mappings, but silently return -EEXISTS. Normally an attempt +* to map over an existing mapping would indicate some sort of +* kernel bug, which would justify the WARN_ON(). But for GPU +* drivers, this could be under control of userspace. Which +* deserves an error return, but not to spam dmesg. */ #define IO_PGTABLE_QUIRK_ARM_NS BIT(0)#define IO_PGTABLE_QUIRK_NO_PERMS BIT(1)include/linux/io-pgtable.h struct io_pgtable_cfg { · line 107
Quoted 4 lines
include/linux/io-pgtable.h +1
-0@@ -97,6 +104,7 @@ struct io_pgtable_cfg {#define IO_PGTABLE_QUIRK_ARM_OUTER_WBWA BIT(6)#define IO_PGTABLE_QUIRK_ARM_HD BIT(7)#define IO_PGTABLE_QUIRK_ARM_S2FWB BIT(8) +#define IO_PGTABLE_QUIRK_NO_WARN_ON BIT(9)This feels a bit fragile to me:
* IOMMU-API users of io-pgtable shouldn't be passing this quirk but might end up doing so to paper over driver bugs.* Low-level users of io-pgtable who expose page-table operations to userspace need to pass the quirk, but might well not bother because well-behaved userspace doesn't trigger the warning.
So overall, it's all a bit unsatisfactory. Is there a way we could have the warnings only when invoked via the IOMMU API?
Quoted 8 lines
Quoted 5 lines
iommu drivers _not_ setting this flag seems like a good way to achieve that ;-)
The alternative is to move the warns to the iommu driver... but they could just as easily remove the WARN_ON()s as they could set the
NO_WARN_ONquirk, so :shrug:?Bah, I also don't have a good idea to improve this, so I guess I'll take what you have for now.
Hmm, just a nit on reflection, how about fixing up the name to just IO_PGTABLE_QUIRK_NO_WARN? Given that it's already quite long, and we have a well-established DMA_ATTR_NO_WARN with equivalent semantics over in the DMA API.
Cheers,
Robin.
Will Deacon
maintainerRe: [PATCH v4 05/40] iommu/io-pgtable-arm: Add quirk to quiet WARN_ON()
Quoted 45 lines · Robin Murphy
Quoted 44 lines · Will Deacon
Quoted 42 lines · Rob Clark
Quoted 29 lines · Will Deacon
Quoted 19 lines · Rob Clark
include/linux/io-pgtable.h +7
-0@@ -88,6 +88,13 @@ struct io_pgtable_cfg {* * IO_PGTABLE_QUIRK_ARM_HD: Enables dirty tracking in stage 1 pagetable. * IO_PGTABLE_QUIRK_ARM_S2FWB: Use the FWB format for the MemAttrs bits +* +* IO_PGTABLE_QUIRK_NO_WARN_ON: Do not WARN_ON() on conflicting +* mappings, but silently return -EEXISTS. Normally an attempt +* to map over an existing mapping would indicate some sort of +* kernel bug, which would justify the WARN_ON(). But for GPU +* drivers, this could be under control of userspace. Which +* deserves an error return, but not to spam dmesg. */ #define IO_PGTABLE_QUIRK_ARM_NS BIT(0)#define IO_PGTABLE_QUIRK_NO_PERMS BIT(1)include/linux/io-pgtable.h struct io_pgtable_cfg { · line 107
Quoted 4 lines
include/linux/io-pgtable.h +1
-0@@ -97,6 +104,7 @@ struct io_pgtable_cfg {#define IO_PGTABLE_QUIRK_ARM_OUTER_WBWA BIT(6)#define IO_PGTABLE_QUIRK_ARM_HD BIT(7)#define IO_PGTABLE_QUIRK_ARM_S2FWB BIT(8) +#define IO_PGTABLE_QUIRK_NO_WARN_ON BIT(9)This feels a bit fragile to me:
* IOMMU-API users of io-pgtable shouldn't be passing this quirk but might end up doing so to paper over driver bugs.Quoted 6 lines
* Low-level users of io-pgtable who expose page-table operations to userspace need to pass the quirk, but might well not bother because well-behaved userspace doesn't trigger the warning.
So overall, it's all a bit unsatisfactory. Is there a way we could have the warnings only when invoked via the IOMMU API?
iommu drivers _not_ setting this flag seems like a good way to achieve that ;-)
The alternative is to move the warns to the iommu driver... but they could just as easily remove the WARN_ON()s as they could set the
NO_WARN_ONquirk, so :shrug:?
Quoted 7 lines
Quoted 2 lines
Bah, I also don't have a good idea to improve this, so I guess I'll take what you have for now.
Hmm, just a nit on reflection, how about fixing up the name to just
IO_PGTABLE_QUIRK_NO_WARN? Given that it's already quite long, and we have a well-establishedDMA_ATTR_NO_WARNwith equivalent semantics over in the DMA API.
Sure, I'll do that now...
Will
PATCH v4 6/40 drm/msm: Rename msm_file_private -> msm_context
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
This is a more descriptive name.
--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 6 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 +-- drivers/gpu/drm/msm/msm_drv.c | 14 ++++----- drivers/gpu/drm/msm/msm_gem.c | 2 +- drivers/gpu/drm/msm/msm_gem_submit.c | 2 +- drivers/gpu/drm/msm/msm_gpu.c | 4 +-- drivers/gpu/drm/msm/msm_gpu.h | 39 ++++++++++++------------- drivers/gpu/drm/msm/msm_submitqueue.c | 27 +++++++++-------- 9 files changed, 49 insertions(+), 51 deletions(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +1 -1
@@ -111,7 +111,7 @@ static void a6xx_set_pagetable(struct a6xx_gpu *a6xx_gpu, struct msm_ringbuffer *ring, struct msm_gem_submit *submit) { bool sysprof = refcount_read(&a6xx_gpu->base.base.sysprof_active) > 1; -struct msm_file_private *ctx = submit->queue->ctx; +struct msm_context *ctx = submit->queue->ctx;struct adreno_gpu *adreno_gpu = &a6xx_gpu->base;phys_addr_t ttbr;u32 asid;
drivers/gpu/drm/msm/adreno/adreno_gpu.c +3 -3
@@ -356,7 +356,7 @@ int adreno_fault_handler(struct msm_gpu *gpu, unsigned long iova, int flags,return 0 ; } -int adreno_get_param (struct msm_gpu *gpu,struct msm_file_private *ctx, +int adreno_get_param (struct msm_gpu *gpu,struct msm_context *ctx,uint32_t param,uint64_t *value,uint32_t *len) {struct adreno_gpu *adreno_gpu =to_adreno_gpu (gpu);
@@ -444,7 +444,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_file_private *ctx, } } -int adreno_set_param (struct msm_gpu *gpu,struct msm_file_private *ctx, +int adreno_set_param (struct msm_gpu *gpu,struct msm_context *ctx,uint32_t param,uint64_t value,uint32_t len) {struct drm_device *drm = gpu->dev;
@@ -490,7 +490,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_file_private *ctx,case MSM_PARAM_SYSPROF :if (!capable (CAP_SYS_ADMIN ))return UERR (EPERM , drm,"invalid permissions" ); -return msm_file_private_set_sysprof (ctx, gpu, value); +return msm_context_set_sysprof (ctx, gpu, value);default :return UERR (EINVAL , drm,"%s: invalid param: %u" , gpu->name, param); }
drivers/gpu/drm/msm/adreno/adreno_gpu.h +2 -2
@@ -603,9 +603,9 @@ static inline int adreno_is_a7xx(struct adreno_gpu *gpu)/* Put vm_start above 32b to catch issues with not setting xyz_BASE_HI */ #define ADRENO_VM_START 0x100000000ULLu64 adreno_private_address_space_size (struct msm_gpu *gpu); -int adreno_get_param (struct msm_gpu *gpu,struct msm_file_private *ctx, +int adreno_get_param (struct msm_gpu *gpu,struct msm_context *ctx,uint32_t param,uint64_t *value,uint32_t *len); -int adreno_set_param (struct msm_gpu *gpu,struct msm_file_private *ctx, +int adreno_set_param (struct msm_gpu *gpu,struct msm_context *ctx,uint32_t param,uint64_t value,uint32_t len);const struct firmware *adreno_request_fw (struct adreno_gpu *adreno_gpu,const char *fwname);
drivers/gpu/drm/msm/msm_drv.c +7 -7
@@ -333,7 +333,7 @@ static int context_init(struct drm_device *dev, struct drm_file *file) {static atomic_t ident =ATOMIC_INIT (0 );struct msm_drm_private *priv = dev->dev_private; -struct msm_file_private *ctx; +struct msm_context *ctx; ctx =kzalloc (sizeof (*ctx),GFP_KERNEL );if (!ctx)
@@ -363,23 +363,23 @@ static int msm_open(struct drm_device *dev, struct drm_file *file)return context_init (dev, file); } -static void context_close (struct msm_file_private *ctx) +static void context_close (struct msm_context *ctx) {msm_submitqueue_close (ctx); -msm_file_private_put (ctx); +msm_context_put (ctx); }static void msm_postclose (struct drm_device *dev,struct drm_file *file) {struct msm_drm_private *priv = dev->dev_private; -struct msm_file_private *ctx = file->driver_priv; +struct msm_context *ctx = file->driver_priv;/* * It is not possible to set sysprof param to non-zero if gpu * is not initialized: */ if (priv->gpu) -msm_file_private_set_sysprof (ctx, priv->gpu,0 ); +msm_context_set_sysprof (ctx, priv->gpu,0 );context_close (ctx); }
@@ -511,7 +511,7 @@ static int msm_ioctl_gem_info_iova(struct drm_device *dev, uint64_t *iova) {struct msm_drm_private *priv = dev->dev_private; -struct msm_file_private *ctx = file->driver_priv; +struct msm_context *ctx = file->driver_priv;if (!priv->gpu)return -EINVAL ;
@@ -531,7 +531,7 @@ static int msm_ioctl_gem_info_set_iova(struct drm_device *dev, uint64_t iova) {struct msm_drm_private *priv = dev->dev_private; -struct msm_file_private *ctx = file->driver_priv; +struct msm_context *ctx = file->driver_priv;if (!priv->gpu)return -EINVAL ;
drivers/gpu/drm/msm/msm_gem.c +1 -1
@@ -48,7 +48,7 @@ static void update_device_mem(struct msm_drm_private *priv, ssize_t size)static void update_ctx_mem (struct drm_file *file,ssize_t size) { -struct msm_file_private *ctx = file->driver_priv; +struct msm_context *ctx = file->driver_priv;uint64_t ctx_mem =atomic64_add_return (size, &ctx->ctx_mem);rcu_read_lock ();/* Locks file->pid! */
drivers/gpu/drm/msm/msm_gem_submit.c +1 -1
@@ -651,7 +651,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, {struct msm_drm_private *priv = dev->dev_private;struct drm_msm_gem_submit *args = data; -struct msm_file_private *ctx = file->driver_priv; +struct msm_context *ctx = file->driver_priv;struct msm_gem_submit *submit =NULL ;struct msm_gpu *gpu = priv->gpu;struct msm_gpu_submitqueue *queue;
drivers/gpu/drm/msm/msm_gpu.c +2 -2
@@ -148,7 +148,7 @@ int msm_gpu_pm_suspend(struct msm_gpu *gpu)return 0 ; } -void msm_gpu_show_fdinfo (struct msm_gpu *gpu,struct msm_file_private *ctx, +void msm_gpu_show_fdinfo (struct msm_gpu *gpu,struct msm_context *ctx,struct drm_printer *p) {drm_printf (p,"drm-engine-gpu:\t%llu ns\n" , ctx->elapsed_ns);
@@ -339,7 +339,7 @@ static void retire_submits(struct msm_gpu *gpu);static void get_comm_cmdline (struct msm_gem_submit *submit,char **comm,char **cmd) { -struct msm_file_private *ctx = submit->queue->ctx; +struct msm_context *ctx = submit->queue->ctx;struct task_struct *task;WARN_ON (!mutex_is_locked (&submit->gpu->lock));
drivers/gpu/drm/msm/msm_gpu.h +19 -20
@@ -22,7 +22,7 @@struct msm_gem_submit ;struct msm_gpu_perfcntr ;struct msm_gpu_state ; -struct msm_file_private ; +struct msm_context ;struct msm_gpu_config {const char *ioname;
@@ -44,9 +44,9 @@ struct msm_gpu_config {* + z180_gpu */ struct msm_gpu_funcs { -int (*get_param)(struct msm_gpu *gpu,struct msm_file_private *ctx, +int (*get_param)(struct msm_gpu *gpu,struct msm_context *ctx,uint32_t param,uint64_t *value,uint32_t *len); -int (*set_param)(struct msm_gpu *gpu,struct msm_file_private *ctx, +int (*set_param)(struct msm_gpu *gpu,struct msm_context *ctx,uint32_t param,uint64_t value,uint32_t len);int (*hw_init)(struct msm_gpu *gpu);
@@ -347,7 +347,7 @@ struct msm_gpu_perfcntr {#define NR_SCHED_PRIORITIES (1 + DRM_SCHED_PRIORITY_LOW - DRM_SCHED_PRIORITY_HIGH)/** -* struct msm_file_private - per-drm_file context +* struct msm_context - per-drm_file context * * @queuelock: synchronizes access to submitqueues list * @submitqueues: list of &msm_gpu_submitqueue created by userspace
@@ -357,7 +357,7 @@ struct msm_gpu_perfcntr {* @ref: reference count * @seqno: unique per process seqno */ -struct msm_file_private { +struct msm_context {rwlock_t queuelock;struct list_head submitqueues;int queueid;
@@ -512,7 +512,7 @@ struct msm_gpu_submitqueue {u32 ring_nr;int faults;uint32_t last_fence; -struct msm_file_private *ctx; +struct msm_context *ctx;struct list_head node;struct idr fence_idr;struct spinlock idr_lock;
@@ -608,33 +608,32 @@ static inline void gpu_write64(struct msm_gpu *gpu, u32 reg, u64 val)int msm_gpu_pm_suspend (struct msm_gpu *gpu);int msm_gpu_pm_resume (struct msm_gpu *gpu); -void msm_gpu_show_fdinfo (struct msm_gpu *gpu,struct msm_file_private *ctx, +void msm_gpu_show_fdinfo (struct msm_gpu *gpu,struct msm_context *ctx,struct drm_printer *p); -int msm_submitqueue_init (struct drm_device *drm,struct msm_file_private *ctx); -struct msm_gpu_submitqueue *msm_submitqueue_get (struct msm_file_private *ctx, +int msm_submitqueue_init (struct drm_device *drm,struct msm_context *ctx); +struct msm_gpu_submitqueue *msm_submitqueue_get (struct msm_context *ctx,u32 id);int msm_submitqueue_create (struct drm_device *drm, -struct msm_file_private *ctx, +struct msm_context *ctx,u32 prio,u32 flags,u32 *id); -int msm_submitqueue_query (struct drm_device *drm,struct msm_file_private *ctx, +int msm_submitqueue_query (struct drm_device *drm,struct msm_context *ctx,struct drm_msm_submitqueue_query *args); -int msm_submitqueue_remove (struct msm_file_private *ctx,u32 id); -void msm_submitqueue_close (struct msm_file_private *ctx); +int msm_submitqueue_remove (struct msm_context *ctx,u32 id); +void msm_submitqueue_close (struct msm_context *ctx);void msm_submitqueue_destroy (struct kref *kref); -int msm_file_private_set_sysprof (struct msm_file_private *ctx, -struct msm_gpu *gpu,int sysprof); -void __msm_file_private_destroy (struct kref *kref); +int msm_context_set_sysprof (struct msm_context *ctx,struct msm_gpu *gpu,int sysprof); +void __msm_context_destroy (struct kref *kref); -static inline void msm_file_private_put (struct msm_file_private *ctx) +static inline void msm_context_put (struct msm_context *ctx) { -kref_put (&ctx->ref, __msm_file_private_destroy); +kref_put (&ctx->ref, __msm_context_destroy); } -static inline struct msm_file_private *msm_file_private_get ( -struct msm_file_private *ctx) +static inline struct msm_context *msm_context_get ( +struct msm_context *ctx) {kref_get (&ctx->ref);return ctx;
drivers/gpu/drm/msm/msm_submitqueue.c +13 -14
@@ -7,8 +7,7 @@#include "msm_gpu.h" -int msm_file_private_set_sysprof (struct msm_file_private *ctx, -struct msm_gpu *gpu,int sysprof) +int msm_context_set_sysprof (struct msm_context *ctx,struct msm_gpu *gpu,int sysprof) {/* * Since pm_runtime and sysprof_active are both refcounts, we
@@ -46,10 +45,10 @@ int msm_file_private_set_sysprof(struct msm_file_private *ctx,return 0 ; } -void __msm_file_private_destroy (struct kref *kref) +void __msm_context_destroy (struct kref *kref) { -struct msm_file_private *ctx =container_of (kref, - struct msm_file_private, ref); +struct msm_context *ctx =container_of (kref, + struct msm_context, ref);int i;for (i =0 ; i <ARRAY_SIZE (ctx->entities); i++) {
@@ -73,12 +72,12 @@ void msm_submitqueue_destroy(struct kref *kref)idr_destroy (&queue->fence_idr); -msm_file_private_put (queue->ctx); +msm_context_put (queue->ctx);kfree (queue); } -struct msm_gpu_submitqueue *msm_submitqueue_get (struct msm_file_private *ctx, +struct msm_gpu_submitqueue *msm_submitqueue_get (struct msm_context *ctx,u32 id) {struct msm_gpu_submitqueue *entry;
@@ -101,7 +100,7 @@ struct msm_gpu_submitqueue *msm_submitqueue_get(struct msm_file_private *ctx,return NULL ; } -void msm_submitqueue_close (struct msm_file_private *ctx) +void msm_submitqueue_close (struct msm_context *ctx) {struct msm_gpu_submitqueue *entry, *tmp;
@@ -119,7 +118,7 @@ void msm_submitqueue_close(struct msm_file_private *ctx) }static struct drm_sched_entity * -get_sched_entity (struct msm_file_private *ctx,struct msm_ringbuffer *ring, +get_sched_entity (struct msm_context *ctx,struct msm_ringbuffer *ring,unsigned ring_nr,enum drm_sched_priority sched_prio) {static DEFINE_MUTEX (entity_lock);
@@ -155,7 +154,7 @@ get_sched_entity(struct msm_file_private *ctx, struct msm_ringbuffer *ring,return ctx->entities[idx]; } -int msm_submitqueue_create (struct drm_device *drm,struct msm_file_private *ctx, +int msm_submitqueue_create (struct drm_device *drm,struct msm_context *ctx,u32 prio,u32 flags,u32 *id) {struct msm_drm_private *priv = drm->dev_private;
@@ -200,7 +199,7 @@ int msm_submitqueue_create(struct drm_device *drm, struct msm_file_private *ctx,write_lock (&ctx->queuelock); - queue->ctx =msm_file_private_get (ctx); + queue->ctx =msm_context_get (ctx); queue->id = ctx->queueid++;if (id)
@@ -221,7 +220,7 @@ int msm_submitqueue_create(struct drm_device *drm, struct msm_file_private *ctx,* Create the default submit-queue (id==0), used for backwards compatibility * for userspace that pre-dates the introduction of submitqueues. */ -int msm_submitqueue_init (struct drm_device *drm,struct msm_file_private *ctx) +int msm_submitqueue_init (struct drm_device *drm,struct msm_context *ctx) {struct msm_drm_private *priv = drm->dev_private;int default_prio, max_priority;
@@ -261,7 +260,7 @@ static int msm_submitqueue_query_faults(struct msm_gpu_submitqueue *queue,return ret ? -EFAULT :0 ; } -int msm_submitqueue_query (struct drm_device *drm,struct msm_file_private *ctx, +int msm_submitqueue_query (struct drm_device *drm,struct msm_context *ctx,struct drm_msm_submitqueue_query *args) {struct msm_gpu_submitqueue *queue;
@@ -282,7 +281,7 @@ int msm_submitqueue_query(struct drm_device *drm, struct msm_file_private *ctx,return ret; } -int msm_submitqueue_remove (struct msm_file_private *ctx,u32 id) +int msm_submitqueue_remove (struct msm_context *ctx,u32 id) {struct msm_gpu_submitqueue *entry;
Signature · 1 line
2.49.0
PATCH v4 7/40 drm/msm: Improve msm_context comments
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Just some tidying up.
--- drivers/gpu/drm/msm/msm_gpu.h | 44 +++++++++++++++++++++++------------ 1 file changed, 29 insertions(+), 15 deletions(-)
drivers/gpu/drm/msm/msm_gpu.h +29 -15
@@ -348,25 +348,39 @@ struct msm_gpu_perfcntr {/** * struct msm_context - per-drm_file context -* -* @queuelock: synchronizes access to submitqueues list -* @submitqueues: list of &msm_gpu_submitqueue created by userspace -* @queueid: counter incremented each time a submitqueue is created, -* used to assign &msm_gpu_submitqueue.id -* @aspace: the per-process GPU address-space -* @ref: reference count -* @seqno: unique per process seqno */ struct msm_context { +/** @queuelock: synchronizes access to submitqueues list */ rwlock_t queuelock; + +/** @submitqueues: list of &msm_gpu_submitqueue created by userspace */ struct list_head submitqueues; + +/** +* @queueid: +* +* Counter incremented each time a submitqueue is created, used to +* assign &msm_gpu_submitqueue.id +*/ int queueid; + +/** @aspace: the per-process GPU address-space */ struct msm_gem_address_space *aspace; + +/** @kref: the reference count */ struct kref ref; + +/** +* @seqno: +* +* A unique per-process sequence number. Used to detect context +* switches, without relying on keeping a, potentially dangling, +* pointer to the previous context. +*/ int seqno;/** -* sysprof: +* @sysprof: * * The value of MSM_PARAM_SYSPROF set by userspace. This is * intended to be used by system profiling tools like Mesa's
@@ -384,21 +398,21 @@ struct msm_context {int sysprof;/** -* comm: Overridden task comm, see MSM_PARAM_COMM +* @comm: Overridden task comm, see MSM_PARAM_COMM * * Accessed under msm_gpu::lock */ char *comm;/** -* cmdline: Overridden task cmdline, see MSM_PARAM_CMDLINE +* @cmdline: Overridden task cmdline, see MSM_PARAM_CMDLINE * * Accessed under msm_gpu::lock */ char *cmdline;/** -* elapsed: +* @elapsed: * * The total (cumulative) elapsed time GPU was busy with rendering * from this context in ns.
@@ -406,7 +420,7 @@ struct msm_context {uint64_t elapsed_ns;/** -* cycles: +* @cycles: * * The total (cumulative) GPU cycles elapsed attributed to this * context.
@@ -414,7 +428,7 @@ struct msm_context {uint64_t cycles;/** -* entities: +* @entities: * * Table of per-priority-level sched entities used by submitqueues * associated with this &drm_file. Because some userspace apps
@@ -427,7 +441,7 @@ struct msm_context {struct drm_sched_entity *entities[NR_SCHED_PRIORITIES *MSM_GPU_MAX_RINGS ];/** -* ctx_mem: +* @ctx_mem: * * Total amount of memory of GEM buffers with handles attached for * this context.
Signature · 1 line
2.49.0
PATCH v4 8/40 drm/msm: Rename msm_gem_address_space -> msm_gem_vm
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Re-aligning naming to better match drm_gpuvm terminology will make things less confusing at the end of the drm_gpuvm conversion.
This is just rename churn, no functional change.
--- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 18 ++-- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 4 +- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 4 +- drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 22 ++--- drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 10 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 26 +++--- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 45 +++++---- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 6 +- drivers/gpu/drm/msm/adreno/a6xx_preempt.c | 10 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 47 +++++----- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 18 ++-- .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 14 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 18 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 14 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 4 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 6 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 24 ++--- drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 12 +-- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 18 ++-- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 12 +-- drivers/gpu/drm/msm/dsi/dsi_host.c | 14 +-- drivers/gpu/drm/msm/msm_drv.c | 8 +- drivers/gpu/drm/msm/msm_drv.h | 10 +- drivers/gpu/drm/msm/msm_fb.c | 10 +- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- drivers/gpu/drm/msm/msm_gem.c | 74 +++++++-------- drivers/gpu/drm/msm/msm_gem.h | 34 +++---- drivers/gpu/drm/msm/msm_gem_submit.c | 6 +- drivers/gpu/drm/msm/msm_gem_vma.c | 93 +++++++++---------- drivers/gpu/drm/msm/msm_gpu.c | 48 +++++----- drivers/gpu/drm/msm/msm_gpu.h | 16 ++-- drivers/gpu/drm/msm/msm_kms.c | 16 ++-- drivers/gpu/drm/msm/msm_kms.h | 2 +- drivers/gpu/drm/msm/msm_ringbuffer.c | 4 +- drivers/gpu/drm/msm/msm_submitqueue.c | 2 +- 41 files changed, 349 insertions(+), 354 deletions(-)
drivers/gpu/drm/msm/adreno/a2xx_gpu.c +9 -9
@@ -113,7 +113,7 @@ static int a2xx_hw_init(struct msm_gpu *gpu)uint32_t *ptr, len;int i, ret; -a2xx_gpummu_params (gpu->aspace->mmu, &pt_base, &tran_error); +a2xx_gpummu_params (gpu->vm->mmu, &pt_base, &tran_error);DBG ("%s" , gpu->name);
@@ -466,19 +466,19 @@ static struct msm_gpu_state *a2xx_gpu_state_get(struct msm_gpu *gpu)return state; } -static struct msm_gem_address_space * -a2xx_create_address_space (struct msm_gpu *gpu,struct platform_device *pdev) +static struct msm_gem_vm * +a2xx_create_vm (struct msm_gpu *gpu,struct platform_device *pdev) {struct msm_mmu *mmu =a2xx_gpummu_new (&pdev->dev, gpu); -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm; - aspace =msm_gem_address_space_create (mmu,"gpu" ,SZ_16M , + vm =msm_gem_vm_create (mmu,"gpu" ,SZ_16M ,0xfff *SZ_64K ); -if (IS_ERR (aspace) && !IS_ERR (mmu)) +if (IS_ERR (vm) && !IS_ERR (mmu)) mmu->funcs->destroy (mmu); -return aspace; +return vm; }static u32 a2xx_get_rptr (struct msm_gpu *gpu,struct msm_ringbuffer *ring)
@@ -504,7 +504,7 @@ static const struct adreno_gpu_funcs funcs = {#endif .gpu_state_get = a2xx_gpu_state_get, .gpu_state_put = adreno_gpu_state_put, - .create_address_space = a2xx_create_address_space, + .create_vm = a2xx_create_vm, .get_rptr = a2xx_get_rptr, }, };
@@ -551,7 +551,7 @@ struct msm_gpu *a2xx_gpu_init(struct drm_device *dev)else adreno_gpu->registers = a220_registers; -if (!gpu->aspace) { +if (!gpu->vm) {dev_err (dev->dev,"No memory protection without MMU\n" );if (!allow_vram_carveout) { ret = -ENXIO ;
drivers/gpu/drm/msm/adreno/a3xx_gpu.c +2 -2
@@ -526,7 +526,7 @@ static const struct adreno_gpu_funcs funcs = { .gpu_busy = a3xx_gpu_busy, .gpu_state_get = a3xx_gpu_state_get, .gpu_state_put = adreno_gpu_state_put, - .create_address_space = adreno_create_address_space, + .create_vm = adreno_create_vm, .get_rptr = a3xx_get_rptr, }, };
@@ -581,7 +581,7 @@ struct msm_gpu *a3xx_gpu_init(struct drm_device *dev) goto fail; } -if (!gpu->aspace) { +if (!gpu->vm) {/* TODO we think it is possible to configure the GPU to * restrict access to VRAM carveout. But the required * registers are unknown. For now just bail out and
drivers/gpu/drm/msm/adreno/a4xx_gpu.c +2 -2
@@ -645,7 +645,7 @@ static const struct adreno_gpu_funcs funcs = { .gpu_busy = a4xx_gpu_busy, .gpu_state_get = a4xx_gpu_state_get, .gpu_state_put = adreno_gpu_state_put, - .create_address_space = adreno_create_address_space, + .create_vm = adreno_create_vm, .get_rptr = a4xx_get_rptr, }, .get_timestamp = a4xx_get_timestamp,
@@ -695,7 +695,7 @@ struct msm_gpu *a4xx_gpu_init(struct drm_device *dev) adreno_gpu->uche_trap_base =0xffff0000ffff0000ull ; -if (!gpu->aspace) { +if (!gpu->vm) {/* TODO we think it is possible to configure the GPU to * restrict access to VRAM carveout. But the required * registers are unknown. For now just bail out and
drivers/gpu/drm/msm/adreno/a5xx_debugfs.c +2 -2
@@ -116,13 +116,13 @@ reset_set(void *data, u64 val) adreno_gpu->fw[ADRENO_FW_PFP ] =NULL ;if (a5xx_gpu->pm4_bo) { -msm_gem_unpin_iova (a5xx_gpu->pm4_bo, gpu->aspace); +msm_gem_unpin_iova (a5xx_gpu->pm4_bo, gpu->vm);drm_gem_object_put (a5xx_gpu->pm4_bo); a5xx_gpu->pm4_bo =NULL ; }if (a5xx_gpu->pfp_bo) { -msm_gem_unpin_iova (a5xx_gpu->pfp_bo, gpu->aspace); +msm_gem_unpin_iova (a5xx_gpu->pfp_bo, gpu->vm);drm_gem_object_put (a5xx_gpu->pfp_bo); a5xx_gpu->pfp_bo =NULL ; }
drivers/gpu/drm/msm/adreno/a5xx_gpu.c +11 -11
@@ -622,7 +622,7 @@ static int a5xx_ucode_load(struct msm_gpu *gpu) a5xx_gpu->shadow =msm_gem_kernel_new (gpu->dev,sizeof (u32) * gpu->nr_rings,MSM_BO_WC |MSM_BO_MAP_PRIV , - gpu->aspace, &a5xx_gpu->shadow_bo, + gpu->vm, &a5xx_gpu->shadow_bo, &a5xx_gpu->shadow_iova);if (IS_ERR (a5xx_gpu->shadow))
@@ -1042,22 +1042,22 @@ static void a5xx_destroy(struct msm_gpu *gpu)a5xx_preempt_fini (gpu);if (a5xx_gpu->pm4_bo) { -msm_gem_unpin_iova (a5xx_gpu->pm4_bo, gpu->aspace); +msm_gem_unpin_iova (a5xx_gpu->pm4_bo, gpu->vm);drm_gem_object_put (a5xx_gpu->pm4_bo); }if (a5xx_gpu->pfp_bo) { -msm_gem_unpin_iova (a5xx_gpu->pfp_bo, gpu->aspace); +msm_gem_unpin_iova (a5xx_gpu->pfp_bo, gpu->vm);drm_gem_object_put (a5xx_gpu->pfp_bo); }if (a5xx_gpu->gpmu_bo) { -msm_gem_unpin_iova (a5xx_gpu->gpmu_bo, gpu->aspace); +msm_gem_unpin_iova (a5xx_gpu->gpmu_bo, gpu->vm);drm_gem_object_put (a5xx_gpu->gpmu_bo); }if (a5xx_gpu->shadow_bo) { -msm_gem_unpin_iova (a5xx_gpu->shadow_bo, gpu->aspace); +msm_gem_unpin_iova (a5xx_gpu->shadow_bo, gpu->vm);drm_gem_object_put (a5xx_gpu->shadow_bo); }
@@ -1457,7 +1457,7 @@ static int a5xx_crashdumper_init(struct msm_gpu *gpu, struct a5xx_crashdumper *dumper) { dumper->ptr =msm_gem_kernel_new (gpu->dev, -SZ_1M ,MSM_BO_WC , gpu->aspace, +SZ_1M ,MSM_BO_WC , gpu->vm, &dumper->bo, &dumper->iova);if (!IS_ERR (dumper->ptr))
@@ -1557,7 +1557,7 @@ static void a5xx_gpu_state_get_hlsq_regs(struct msm_gpu *gpu,if (a5xx_crashdumper_run (gpu, &dumper)) {kfree (a5xx_state->hlsqregs); -msm_gem_kernel_put (dumper.bo, gpu->aspace); +msm_gem_kernel_put (dumper.bo, gpu->vm);return ; }
@@ -1565,7 +1565,7 @@ static void a5xx_gpu_state_get_hlsq_regs(struct msm_gpu *gpu,memcpy (a5xx_state->hlsqregs, dumper.ptr + (256 *SZ_1K ), count *sizeof (u32)); -msm_gem_kernel_put (dumper.bo, gpu->aspace); +msm_gem_kernel_put (dumper.bo, gpu->vm); }static struct msm_gpu_state *a5xx_gpu_state_get (struct msm_gpu *gpu)
@@ -1713,7 +1713,7 @@ static const struct adreno_gpu_funcs funcs = { .gpu_busy = a5xx_gpu_busy, .gpu_state_get = a5xx_gpu_state_get, .gpu_state_put = a5xx_gpu_state_put, - .create_address_space = adreno_create_address_space, + .create_vm = adreno_create_vm, .get_rptr = a5xx_get_rptr, }, .get_timestamp = a5xx_get_timestamp,
@@ -1786,8 +1786,8 @@ struct msm_gpu *a5xx_gpu_init(struct drm_device *dev)return ERR_PTR (ret); } -if (gpu->aspace) -msm_mmu_set_fault_handler (gpu->aspace->mmu, gpu, a5xx_fault_handler); +if (gpu->vm) +msm_mmu_set_fault_handler (gpu->vm->mmu, gpu, a5xx_fault_handler);/* Set up the preemption specific bits and pieces for each ringbuffer */ a5xx_preempt_init (gpu);
drivers/gpu/drm/msm/adreno/a5xx_power.c +1 -1
@@ -363,7 +363,7 @@ void a5xx_gpmu_ucode_init(struct msm_gpu *gpu) bosize = (cmds_size + (cmds_size /TYPE4_MAX_PAYLOAD ) +1 ) <<2 ; ptr =msm_gem_kernel_new (drm, bosize, -MSM_BO_WC |MSM_BO_GPU_READONLY , gpu->aspace, +MSM_BO_WC |MSM_BO_GPU_READONLY , gpu->vm, &a5xx_gpu->gpmu_bo, &a5xx_gpu->gpmu_iova);if (IS_ERR (ptr))return ;
drivers/gpu/drm/msm/adreno/a5xx_preempt.c +5 -5
@@ -254,7 +254,7 @@ static int preempt_init_ring(struct a5xx_gpu *a5xx_gpu, ptr =msm_gem_kernel_new (gpu->dev,A5XX_PREEMPT_RECORD_SIZE +A5XX_PREEMPT_COUNTER_SIZE , -MSM_BO_WC |MSM_BO_MAP_PRIV , gpu->aspace, &bo, &iova); +MSM_BO_WC |MSM_BO_MAP_PRIV , gpu->vm, &bo, &iova);if (IS_ERR (ptr))return PTR_ERR (ptr);
@@ -262,9 +262,9 @@ static int preempt_init_ring(struct a5xx_gpu *a5xx_gpu,/* The buffer to store counters needs to be unprivileged */ counters =msm_gem_kernel_new (gpu->dev,A5XX_PREEMPT_COUNTER_SIZE , -MSM_BO_WC , gpu->aspace, &counters_bo, &counters_iova); +MSM_BO_WC , gpu->vm, &counters_bo, &counters_iova);if (IS_ERR (counters)) { -msm_gem_kernel_put (bo, gpu->aspace); +msm_gem_kernel_put (bo, gpu->vm);return PTR_ERR (counters); }
@@ -295,8 +295,8 @@ void a5xx_preempt_fini(struct msm_gpu *gpu)int i;for (i =0 ; i < gpu->nr_rings; i++) { -msm_gem_kernel_put (a5xx_gpu->preempt_bo[i], gpu->aspace); -msm_gem_kernel_put (a5xx_gpu->preempt_counters_bo[i], gpu->aspace); +msm_gem_kernel_put (a5xx_gpu->preempt_bo[i], gpu->vm); +msm_gem_kernel_put (a5xx_gpu->preempt_counters_bo[i], gpu->vm); } }
drivers/gpu/drm/msm/adreno/a6xx_gmu.c +13 -13
@@ -1259,15 +1259,15 @@ int a6xx_gmu_stop(struct a6xx_gpu *a6xx_gpu)static void a6xx_gmu_memory_free (struct a6xx_gmu *gmu) { -msm_gem_kernel_put (gmu->hfi.obj, gmu->aspace); -msm_gem_kernel_put (gmu->debug.obj, gmu->aspace); -msm_gem_kernel_put (gmu->icache.obj, gmu->aspace); -msm_gem_kernel_put (gmu->dcache.obj, gmu->aspace); -msm_gem_kernel_put (gmu->dummy.obj, gmu->aspace); -msm_gem_kernel_put (gmu->log.obj, gmu->aspace); - - gmu->aspace->mmu->funcs->detach (gmu->aspace->mmu); -msm_gem_address_space_put (gmu->aspace); +msm_gem_kernel_put (gmu->hfi.obj, gmu->vm); +msm_gem_kernel_put (gmu->debug.obj, gmu->vm); +msm_gem_kernel_put (gmu->icache.obj, gmu->vm); +msm_gem_kernel_put (gmu->dcache.obj, gmu->vm); +msm_gem_kernel_put (gmu->dummy.obj, gmu->vm); +msm_gem_kernel_put (gmu->log.obj, gmu->vm); + + gmu->vm->mmu->funcs->detach (gmu->vm->mmu); +msm_gem_vm_put (gmu->vm); } static int a6xx_gmu_memory_alloc(struct a6xx_gmu *gmu, struct a6xx_gmu_bo *bo,
@@ -1296,7 +1296,7 @@ static int a6xx_gmu_memory_alloc(struct a6xx_gmu *gmu, struct a6xx_gmu_bo *bo,if (IS_ERR (bo->obj))return PTR_ERR (bo->obj); - ret =msm_gem_get_and_pin_iova_range (bo->obj, gmu->aspace, &bo->iova, + ret =msm_gem_get_and_pin_iova_range (bo->obj, gmu->vm, &bo->iova, range_start, range_end);if (ret) {drm_gem_object_put (bo->obj);
@@ -1321,9 +1321,9 @@ static int a6xx_gmu_memory_probe(struct a6xx_gmu *gmu)if (IS_ERR (mmu))return PTR_ERR (mmu); - gmu->aspace =msm_gem_address_space_create (mmu,"gmu" ,0x0 ,0x80000000 ); -if (IS_ERR (gmu->aspace)) -return PTR_ERR (gmu->aspace); + gmu->vm =msm_gem_vm_create (mmu,"gmu" ,0x0 ,0x80000000 ); +if (IS_ERR (gmu->vm)) +return PTR_ERR (gmu->vm);return 0 ; }
drivers/gpu/drm/msm/adreno/a6xx_gmu.h +1 -1
@@ -62,7 +62,7 @@ struct a6xx_gmu {/* For serializing communication with the GMU: */ struct mutex lock; -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;void __iomem *mmio;void __iomem *rscc;
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +22 -23
125 lines not on this page · raw message
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +3 -3
@@ -132,7 +132,7 @@ static int a6xx_crashdumper_init(struct msm_gpu *gpu, struct a6xx_crashdumper *dumper) { dumper->ptr =msm_gem_kernel_new (gpu->dev, -SZ_1M ,MSM_BO_WC , gpu->aspace, +SZ_1M ,MSM_BO_WC , gpu->vm, &dumper->bo, &dumper->iova);if (!IS_ERR (dumper->ptr))
@@ -1619,7 +1619,7 @@ struct msm_gpu_state *a6xx_gpu_state_get(struct msm_gpu *gpu)a7xx_get_clusters (gpu, a6xx_state, dumper);a7xx_get_dbgahb_clusters (gpu, a6xx_state, dumper); -msm_gem_kernel_put (dumper->bo, gpu->aspace); +msm_gem_kernel_put (dumper->bo, gpu->vm); }a7xx_get_post_crashdumper_registers (gpu, a6xx_state);
@@ -1631,7 +1631,7 @@ struct msm_gpu_state *a6xx_gpu_state_get(struct msm_gpu *gpu)a6xx_get_clusters (gpu, a6xx_state, dumper);a6xx_get_dbgahb_clusters (gpu, a6xx_state, dumper); -msm_gem_kernel_put (dumper->bo, gpu->aspace); +msm_gem_kernel_put (dumper->bo, gpu->vm); } }
drivers/gpu/drm/msm/adreno/a6xx_preempt.c +5 -5
@@ -343,7 +343,7 @@ static int preempt_init_ring(struct a6xx_gpu *a6xx_gpu, ptr =msm_gem_kernel_new (gpu->dev,PREEMPT_RECORD_SIZE (adreno_gpu), -MSM_BO_WC |MSM_BO_MAP_PRIV , gpu->aspace, &bo, &iova); +MSM_BO_WC |MSM_BO_MAP_PRIV , gpu->vm, &bo, &iova);if (IS_ERR (ptr))return PTR_ERR (ptr);
@@ -361,7 +361,7 @@ static int preempt_init_ring(struct a6xx_gpu *a6xx_gpu, ptr =msm_gem_kernel_new (gpu->dev,PREEMPT_SMMU_INFO_SIZE ,MSM_BO_WC |MSM_BO_MAP_PRIV |MSM_BO_GPU_READONLY , - gpu->aspace, &bo, &iova); + gpu->vm, &bo, &iova);if (IS_ERR (ptr))return PTR_ERR (ptr);
@@ -376,7 +376,7 @@ static int preempt_init_ring(struct a6xx_gpu *a6xx_gpu,struct a7xx_cp_smmu_info *smmu_info_ptr = ptr; -msm_iommu_pagetable_params (gpu->aspace->mmu, &ttbr, &asid); +msm_iommu_pagetable_params (gpu->vm->mmu, &ttbr, &asid); smmu_info_ptr->magic =GEN7_CP_SMMU_INFO_MAGIC ; smmu_info_ptr->ttbr0 = ttbr;
@@ -404,7 +404,7 @@ void a6xx_preempt_fini(struct msm_gpu *gpu)int i;for (i =0 ; i < gpu->nr_rings; i++) -msm_gem_kernel_put (a6xx_gpu->preempt_bo[i], gpu->aspace); +msm_gem_kernel_put (a6xx_gpu->preempt_bo[i], gpu->vm); }void a6xx_preempt_init (struct msm_gpu *gpu)
@@ -430,7 +430,7 @@ void a6xx_preempt_init(struct msm_gpu *gpu) a6xx_gpu->preempt_postamble_ptr =msm_gem_kernel_new (gpu->dev,PAGE_SIZE ,MSM_BO_WC |MSM_BO_MAP_PRIV |MSM_BO_GPU_READONLY , - gpu->aspace, &a6xx_gpu->preempt_postamble_bo, + gpu->vm, &a6xx_gpu->preempt_postamble_bo, &a6xx_gpu->preempt_postamble_iova);preempt_prepare_postamble (a6xx_gpu);
drivers/gpu/drm/msm/adreno/adreno_gpu.c +23 -24
110 lines not on this page · raw message
drivers/gpu/drm/msm/adreno/adreno_gpu.h +9 -9
@@ -602,7 +602,7 @@ static inline int adreno_is_a7xx(struct adreno_gpu *gpu)/* Put vm_start above 32b to catch issues with not setting xyz_BASE_HI */ #define ADRENO_VM_START 0x100000000ULL -u64 adreno_private_address_space_size (struct msm_gpu *gpu); +u64 adreno_private_vm_size (struct msm_gpu *gpu);int adreno_get_param (struct msm_gpu *gpu,struct msm_context *ctx,uint32_t param,uint64_t *value,uint32_t *len); int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx,
@@ -645,14 +645,14 @@ void adreno_show_object(struct drm_printer *p, void **ptr, int len,* Common helper function to initialize the default address space for arm-smmu * attached targets */ -struct msm_gem_address_space * -adreno_create_address_space (struct msm_gpu *gpu, -struct platform_device *pdev); - -struct msm_gem_address_space * -adreno_iommu_create_address_space (struct msm_gpu *gpu, -struct platform_device *pdev, -unsigned long quirks); +struct msm_gem_vm * +adreno_create_vm (struct msm_gpu *gpu, +struct platform_device *pdev); + +struct msm_gem_vm * +adreno_iommu_create_vm (struct msm_gpu *gpu, +struct platform_device *pdev, +unsigned long quirks); int adreno_fault_handler(struct msm_gpu *gpu, unsigned long iova, int flags, struct adreno_smmu_fault_info *info, const char *block,
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c +7 -7
@@ -566,7 +566,7 @@ static void dpu_encoder_phys_wb_prepare_wb_job(struct dpu_encoder_phys *phys_enc struct drm_writeback_job *job) {const struct msm_format *format; -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;struct dpu_hw_wb_cfg *wb_cfg;int ret;struct dpu_encoder_phys_wb *wb_enc =to_dpu_encoder_phys_wb (phys_enc);
@@ -576,13 +576,13 @@ static void dpu_encoder_phys_wb_prepare_wb_job(struct dpu_encoder_phys *phys_enc wb_enc->wb_job = job; wb_enc->wb_conn = job->connector; - aspace = phys_enc->dpu_kms->base.aspace; + vm = phys_enc->dpu_kms->base.vm; wb_cfg = &wb_enc->wb_cfg;memset (wb_cfg,0 ,sizeof (struct dpu_hw_wb_cfg )); - ret =msm_framebuffer_prepare (job->fb, aspace, false); + ret =msm_framebuffer_prepare (job->fb, vm, false);if (ret) {DPU_ERROR ("prep fb failed, %d\n" , ret);return ;
@@ -596,7 +596,7 @@ static void dpu_encoder_phys_wb_prepare_wb_job(struct dpu_encoder_phys *phys_encreturn ; } -dpu_format_populate_addrs (aspace, job->fb, &wb_cfg->dest); +dpu_format_populate_addrs (vm, job->fb, &wb_cfg->dest); wb_cfg->dest.width = job->fb->width; wb_cfg->dest.height = job->fb->height;
@@ -619,14 +619,14 @@ static void dpu_encoder_phys_wb_cleanup_wb_job(struct dpu_encoder_phys *phys_enc struct drm_writeback_job *job) {struct dpu_encoder_phys_wb *wb_enc =to_dpu_encoder_phys_wb (phys_enc); -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;if (!job->fb)return ; - aspace = phys_enc->dpu_kms->base.aspace; + vm = phys_enc->dpu_kms->base.vm; -msm_framebuffer_cleanup (job->fb, aspace, false); +msm_framebuffer_cleanup (job->fb, vm, false); wb_enc->wb_job =NULL ; wb_enc->wb_conn =NULL ; }
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +9 -9
@@ -274,7 +274,7 @@ int dpu_format_populate_plane_sizes(return _dpu_format_populate_plane_sizes_linear (fmt, fb, layout); } -static void _dpu_format_populate_addrs_ubwc (struct msm_gem_address_space *aspace, +static void _dpu_format_populate_addrs_ubwc (struct msm_gem_vm *vm,struct drm_framebuffer *fb,struct dpu_hw_fmt_layout *layout) {
@@ -282,7 +282,7 @@ static void _dpu_format_populate_addrs_ubwc(struct msm_gem_address_space *aspaceuint32_t base_addr =0 ;bool meta; - base_addr =msm_framebuffer_iova (fb, aspace,0 ); + base_addr =msm_framebuffer_iova (fb, vm,0 ); fmt =msm_framebuffer_format (fb); meta =MSM_FORMAT_IS_UBWC (fmt);
@@ -355,7 +355,7 @@ static void _dpu_format_populate_addrs_ubwc(struct msm_gem_address_space *aspace } } -static void _dpu_format_populate_addrs_linear (struct msm_gem_address_space *aspace, +static void _dpu_format_populate_addrs_linear (struct msm_gem_vm *vm,struct drm_framebuffer *fb,struct dpu_hw_fmt_layout *layout) {
@@ -363,17 +363,17 @@ static void _dpu_format_populate_addrs_linear(struct msm_gem_address_space *aspa/* Populate addresses for simple formats here */ for (i =0 ; i < layout->num_planes; ++i) - layout->plane_addr[i] =msm_framebuffer_iova (fb, aspace, i); -} + layout->plane_addr[i] =msm_framebuffer_iova (fb, vm, i); + }/** * dpu_format_populate_addrs - populate buffer addresses based on * mmu, fb, and format found in the fb -* @aspace: address space pointer +* @vm: address space pointer * @fb: framebuffer pointer * @layout: format layout structure to populate */ -void dpu_format_populate_addrs (struct msm_gem_address_space *aspace, +void dpu_format_populate_addrs (struct msm_gem_vm *vm,struct drm_framebuffer *fb,struct dpu_hw_fmt_layout *layout) {
@@ -384,7 +384,7 @@ void dpu_format_populate_addrs(struct msm_gem_address_space *aspace,/* Populate the addresses given the fb */ if (MSM_FORMAT_IS_UBWC (fmt) ||MSM_FORMAT_IS_TILE (fmt)) -_dpu_format_populate_addrs_ubwc (aspace, fb, layout); +_dpu_format_populate_addrs_ubwc (vm, fb, layout);else -_dpu_format_populate_addrs_linear (aspace, fb, layout); +_dpu_format_populate_addrs_linear (vm, fb, layout); }
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h +1 -1
@@ -31,7 +31,7 @@ static inline bool dpu_find_format(u32 format, const u32 *supported_formats,return false; } -void dpu_format_populate_addrs (struct msm_gem_address_space *aspace, +void dpu_format_populate_addrs (struct msm_gem_vm *vm,struct drm_framebuffer *fb,struct dpu_hw_fmt_layout *layout);
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +9 -9
@@ -1095,26 +1095,26 @@ static void _dpu_kms_mmu_destroy(struct dpu_kms *dpu_kms) {struct msm_mmu *mmu; -if (!dpu_kms->base.aspace) +if (!dpu_kms->base.vm)return ; - mmu = dpu_kms->base.aspace->mmu; + mmu = dpu_kms->base.vm->mmu; mmu->funcs->detach (mmu); -msm_gem_address_space_put (dpu_kms->base.aspace); +msm_gem_vm_put (dpu_kms->base.vm); - dpu_kms->base.aspace =NULL ; + dpu_kms->base.vm =NULL ; }static int _dpu_kms_mmu_init (struct dpu_kms *dpu_kms) { -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm; - aspace =msm_kms_init_aspace (dpu_kms->dev); -if (IS_ERR (aspace)) -return PTR_ERR (aspace); + vm =msm_kms_init_vm (dpu_kms->dev); +if (IS_ERR (vm)) +return PTR_ERR (vm); - dpu_kms->base.aspace = aspace; + dpu_kms->base.vm = vm;return 0 ; }
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +7 -7
@@ -71,7 +71,7 @@ static const uint32_t qcom_compressed_supported_formats[] = {/* * struct dpu_plane - local dpu plane structure -* @aspace: address space pointer +* @vm: address space pointer * @csc_ptr: Points to dpu_csc_cfg structure to use for current * @catalog: Points to dpu catalog structure * @revalidate: force revalidation of all the plane properties
@@ -654,8 +654,8 @@ static int dpu_plane_prepare_fb(struct drm_plane *plane,DPU_DEBUG_PLANE (pdpu,"FB[%u]\n" , fb->base.id); -/* cache aspace */ - pstate->aspace = kms->base.aspace; +/* cache vm */ + pstate->vm = kms->base.vm;/* * TODO: Need to sort out the msm_framebuffer_prepare() call below so
@@ -664,9 +664,9 @@ static int dpu_plane_prepare_fb(struct drm_plane *plane,*/ drm_gem_plane_helper_prepare_fb (plane, new_state); -if (pstate->aspace) { +if (pstate->vm) { ret =msm_framebuffer_prepare (new_state->fb, - pstate->aspace, pstate->needs_dirtyfb); + pstate->vm, pstate->needs_dirtyfb);if (ret) {DPU_ERROR ("failed to prepare framebuffer\n" );return ret;
@@ -689,7 +689,7 @@ static void dpu_plane_cleanup_fb(struct drm_plane *plane,DPU_DEBUG_PLANE (pdpu,"FB[%u]\n" , old_state->fb->base.id); -msm_framebuffer_cleanup (old_state->fb, old_pstate->aspace, +msm_framebuffer_cleanup (old_state->fb, old_pstate->vm, old_pstate->needs_dirtyfb); }
@@ -1349,7 +1349,7 @@ static void dpu_plane_sspp_atomic_update(struct drm_plane *plane, pstate->needs_qos_remap |= (is_rt_pipe != pdpu->is_rt_pipe); pdpu->is_rt_pipe = is_rt_pipe; -dpu_format_populate_addrs (pstate->aspace, new_state->fb, &pstate->layout); +dpu_format_populate_addrs (pstate->vm, new_state->fb, &pstate->layout); DPU_DEBUG_PLANE(pdpu, "FB[%u] " DRM_RECT_FP_FMT "->crtc%u " DRM_RECT_FMT ", %p4cc ubwc %d\n", fb->base.id, DRM_RECT_FP_ARG(&state->src),
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h +2 -2
@@ -17,7 +17,7 @@/** * struct dpu_plane_state: Define dpu extension of drm plane state object * @base: base drm plane state object -* @aspace: pointer to address space for input/output buffers +* @vm: pointer to address space for input/output buffers * @pipe: software pipe description * @r_pipe: software pipe description of the second pipe * @pipe_cfg: software pipe configuration
@@ -34,7 +34,7 @@*/ struct dpu_plane_state {struct drm_plane_state base; -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;struct dpu_sw_pipe pipe;struct dpu_sw_pipe r_pipe;struct dpu_sw_pipe_cfg pipe_cfg;
drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c +3 -3
@@ -120,7 +120,7 @@ static void unref_cursor_worker(struct drm_flip_work *work, void *val)struct mdp4_kms *mdp4_kms =get_kms (&mdp4_crtc->base);struct msm_kms *kms = &mdp4_kms->base.base; -msm_gem_unpin_iova (val, kms->aspace); +msm_gem_unpin_iova (val, kms->vm);drm_gem_object_put (val); }
@@ -369,7 +369,7 @@ static void update_cursor(struct drm_crtc *crtc)if (next_bo) {/* take a obj ref + iova ref when we start scanning out: */ drm_gem_object_get (next_bo); -msm_gem_get_and_pin_iova (next_bo, kms->aspace, &iova); +msm_gem_get_and_pin_iova (next_bo, kms->vm, &iova);/* enable cursor: */ mdp4_write(mdp4_kms, REG_MDP4_DMA_CURSOR_SIZE(dma),
@@ -427,7 +427,7 @@ static int mdp4_crtc_cursor_set(struct drm_crtc *crtc, }if (cursor_bo) { - ret =msm_gem_get_and_pin_iova (cursor_bo, kms->aspace, &iova); + ret =msm_gem_get_and_pin_iova (cursor_bo, kms->vm, &iova);if (ret) goto fail; }else {
drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c +12 -12
@@ -120,15 +120,15 @@ static void mdp4_destroy(struct msm_kms *kms) {struct mdp4_kms *mdp4_kms =to_mdp4_kms (to_mdp_kms (kms));struct device *dev = mdp4_kms->dev->dev; -struct msm_gem_address_space *aspace = kms->aspace; +struct msm_gem_vm *vm = kms->vm;if (mdp4_kms->blank_cursor_iova) -msm_gem_unpin_iova (mdp4_kms->blank_cursor_bo, kms->aspace); +msm_gem_unpin_iova (mdp4_kms->blank_cursor_bo, kms->vm);drm_gem_object_put (mdp4_kms->blank_cursor_bo); -if (aspace) { - aspace->mmu->funcs->detach (aspace->mmu); -msm_gem_address_space_put (aspace); +if (vm) { + vm->mmu->funcs->detach (vm->mmu); +msm_gem_vm_put (vm); }if (mdp4_kms->rpm_enabled)
@@ -380,7 +380,7 @@ static int mdp4_kms_init(struct drm_device *dev)struct mdp4_kms *mdp4_kms =to_mdp4_kms (to_mdp_kms (priv->kms));struct msm_kms *kms =NULL ;struct msm_mmu *mmu; -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;int ret;u32 major, minor;unsigned long max_clk;
@@ -449,19 +449,19 @@ static int mdp4_kms_init(struct drm_device *dev) }else if (!mmu) {DRM_DEV_INFO (dev->dev,"no iommu, fallback to phys " "contig buffers for scanout\n" ); - aspace =NULL ; + vm =NULL ; }else { - aspace =msm_gem_address_space_create (mmu, + vm =msm_gem_vm_create (mmu,"mdp4" ,0x1000 ,0x100000000 -0x1000 ); -if (IS_ERR (aspace)) { +if (IS_ERR (vm)) {if (!IS_ERR (mmu)) mmu->funcs->destroy (mmu); - ret =PTR_ERR (aspace); + ret =PTR_ERR (vm); goto fail; } - kms->aspace = aspace; + kms->vm = vm; } ret =modeset_init (mdp4_kms);
@@ -478,7 +478,7 @@ static int mdp4_kms_init(struct drm_device *dev) goto fail; } - ret =msm_gem_get_and_pin_iova (mdp4_kms->blank_cursor_bo, kms->aspace, + ret =msm_gem_get_and_pin_iova (mdp4_kms->blank_cursor_bo, kms->vm, &mdp4_kms->blank_cursor_iova);if (ret) {DRM_DEV_ERROR (dev->dev,"could not pin blank-cursor bo: %d\n" , ret);
drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c +6 -6
@@ -87,7 +87,7 @@ static int mdp4_plane_prepare_fb(struct drm_plane *plane,drm_gem_plane_helper_prepare_fb (plane, new_state); -return msm_framebuffer_prepare (new_state->fb, kms->aspace, false); +return msm_framebuffer_prepare (new_state->fb, kms->vm, false); } static void mdp4_plane_cleanup_fb(struct drm_plane *plane,
@@ -102,7 +102,7 @@ static void mdp4_plane_cleanup_fb(struct drm_plane *plane,return ;DBG ("%s: cleanup: FB[%u]" , mdp4_plane->name, fb->base.id); -msm_framebuffer_cleanup (fb, kms->aspace, false); +msm_framebuffer_cleanup (fb, kms->vm, false); }
@@ -153,13 +153,13 @@ static void mdp4_plane_set_scanout(struct drm_plane *plane, MDP4_PIPE_SRC_STRIDE_B_P3(fb->pitches[3]));mdp4_write (mdp4_kms,REG_MDP4_PIPE_SRCP0_BASE (pipe), -msm_framebuffer_iova (fb, kms->aspace,0 )); +msm_framebuffer_iova (fb, kms->vm,0 ));mdp4_write (mdp4_kms,REG_MDP4_PIPE_SRCP1_BASE (pipe), -msm_framebuffer_iova (fb, kms->aspace,1 )); +msm_framebuffer_iova (fb, kms->vm,1 ));mdp4_write (mdp4_kms,REG_MDP4_PIPE_SRCP2_BASE (pipe), -msm_framebuffer_iova (fb, kms->aspace,2 )); +msm_framebuffer_iova (fb, kms->vm,2 ));mdp4_write (mdp4_kms,REG_MDP4_PIPE_SRCP3_BASE (pipe), -msm_framebuffer_iova (fb, kms->aspace,3 )); +msm_framebuffer_iova (fb, kms->vm,3 )); } static void mdp4_write_csc_config(struct mdp4_kms *mdp4_kms,
drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c +2 -2
@@ -169,7 +169,7 @@ static void unref_cursor_worker(struct drm_flip_work *work, void *val)struct mdp5_kms *mdp5_kms =get_kms (&mdp5_crtc->base);struct msm_kms *kms = &mdp5_kms->base.base; -msm_gem_unpin_iova (val, kms->aspace); +msm_gem_unpin_iova (val, kms->vm);drm_gem_object_put (val); }
@@ -993,7 +993,7 @@ static int mdp5_crtc_cursor_set(struct drm_crtc *crtc,if (!cursor_bo)return -ENOENT ; - ret =msm_gem_get_and_pin_iova (cursor_bo, kms->aspace, + ret =msm_gem_get_and_pin_iova (cursor_bo, kms->vm, &mdp5_crtc->cursor.iova);if (ret) {drm_gem_object_put (cursor_bo);
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c +9 -9
@@ -198,11 +198,11 @@ static void mdp5_destroy(struct mdp5_kms *mdp5_kms);static void mdp5_kms_destroy (struct msm_kms *kms) {struct mdp5_kms *mdp5_kms =to_mdp5_kms (to_mdp_kms (kms)); -struct msm_gem_address_space *aspace = kms->aspace; +struct msm_gem_vm *vm = kms->vm; -if (aspace) { - aspace->mmu->funcs->detach (aspace->mmu); -msm_gem_address_space_put (aspace); +if (vm) { + vm->mmu->funcs->detach (vm->mmu); +msm_gem_vm_put (vm); }mdp_kms_destroy (&mdp5_kms->base);
@@ -500,7 +500,7 @@ static int mdp5_kms_init(struct drm_device *dev)struct mdp5_kms *mdp5_kms;struct mdp5_cfg *config;struct msm_kms *kms = priv->kms; -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;int i, ret; ret =mdp5_init (to_platform_device (dev->dev), dev);
@@ -534,13 +534,13 @@ static int mdp5_kms_init(struct drm_device *dev) }mdelay (16 ); - aspace =msm_kms_init_aspace (mdp5_kms->dev); -if (IS_ERR (aspace)) { - ret =PTR_ERR (aspace); + vm =msm_kms_init_vm (mdp5_kms->dev); +if (IS_ERR (vm)) { + ret =PTR_ERR (vm); goto fail; } - kms->aspace = aspace; + kms->vm = vm;pm_runtime_put_sync (&pdev->dev);
drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c +6 -6
@@ -144,7 +144,7 @@ static int mdp5_plane_prepare_fb(struct drm_plane *plane,drm_gem_plane_helper_prepare_fb (plane, new_state); -return msm_framebuffer_prepare (new_state->fb, kms->aspace, needs_dirtyfb); +return msm_framebuffer_prepare (new_state->fb, kms->vm, needs_dirtyfb); } static void mdp5_plane_cleanup_fb(struct drm_plane *plane,
@@ -159,7 +159,7 @@ static void mdp5_plane_cleanup_fb(struct drm_plane *plane,return ;DBG ("%s: cleanup: FB[%u]" , plane->name, fb->base.id); -msm_framebuffer_cleanup (fb, kms->aspace, needed_dirtyfb); +msm_framebuffer_cleanup (fb, kms->vm, needed_dirtyfb); } static int mdp5_plane_atomic_check_with_state(struct drm_crtc_state *crtc_state,
@@ -478,13 +478,13 @@ static void set_scanout_locked(struct mdp5_kms *mdp5_kms, MDP5_PIPE_SRC_STRIDE_B_P3(fb->pitches[3]));mdp5_write (mdp5_kms,REG_MDP5_PIPE_SRC0_ADDR (pipe), -msm_framebuffer_iova (fb, kms->aspace,0 )); +msm_framebuffer_iova (fb, kms->vm,0 ));mdp5_write (mdp5_kms,REG_MDP5_PIPE_SRC1_ADDR (pipe), -msm_framebuffer_iova (fb, kms->aspace,1 )); +msm_framebuffer_iova (fb, kms->vm,1 ));mdp5_write (mdp5_kms,REG_MDP5_PIPE_SRC2_ADDR (pipe), -msm_framebuffer_iova (fb, kms->aspace,2 )); +msm_framebuffer_iova (fb, kms->vm,2 ));mdp5_write (mdp5_kms,REG_MDP5_PIPE_SRC3_ADDR (pipe), -msm_framebuffer_iova (fb, kms->aspace,3 )); +msm_framebuffer_iova (fb, kms->vm,3 )); }/* Note: mdp5_plane->pipe_lock must be locked */
drivers/gpu/drm/msm/dsi/dsi_host.c +7 -7
@@ -143,7 +143,7 @@ struct msm_dsi_host {/* DSI 6G TX buffer*/ struct drm_gem_object *tx_gem_obj; -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;/* DSI v2 TX buffer */ void *tx_buf;
@@ -1146,10 +1146,10 @@ int dsi_tx_buf_alloc_6g(struct msm_dsi_host *msm_host, int size)uint64_t iova;u8 *data; - msm_host->aspace =msm_gem_address_space_get (priv->kms->aspace); + msm_host->vm =msm_gem_vm_get (priv->kms->vm); data =msm_gem_kernel_new (dev, size,MSM_BO_WC , - msm_host->aspace, + msm_host->vm, &msm_host->tx_gem_obj, &iova);if (IS_ERR (data)) {
@@ -1193,10 +1193,10 @@ void msm_dsi_tx_buf_free(struct mipi_dsi_host *host)return ;if (msm_host->tx_gem_obj) { -msm_gem_kernel_put (msm_host->tx_gem_obj, msm_host->aspace); -msm_gem_address_space_put (msm_host->aspace); +msm_gem_kernel_put (msm_host->tx_gem_obj, msm_host->vm); +msm_gem_vm_put (msm_host->vm); msm_host->tx_gem_obj =NULL ; - msm_host->aspace =NULL ; + msm_host->vm =NULL ; }if (msm_host->tx_buf)
@@ -1327,7 +1327,7 @@ int dsi_dma_base_get_6g(struct msm_dsi_host *msm_host, uint64_t *dma_base)return -EINVAL ;return msm_gem_get_and_pin_iova (msm_host->tx_gem_obj, - priv->kms->aspace, dma_base); + priv->kms->vm, dma_base); }int dsi_dma_base_get_v2 (struct msm_dsi_host *msm_host,uint64_t *dma_base)
drivers/gpu/drm/msm/msm_drv.c +4 -4
@@ -345,7 +345,7 @@ static int context_init(struct drm_device *dev, struct drm_file *file)kref_init (&ctx->ref);msm_submitqueue_init (dev, ctx); - ctx->aspace =msm_gpu_create_private_address_space (priv->gpu, current); + ctx->vm =msm_gpu_create_private_vm (priv->gpu, current); file->driver_priv = ctx; ctx->seqno =atomic_inc_return (&ident);
@@ -523,7 +523,7 @@ static int msm_ioctl_gem_info_iova(struct drm_device *dev,* Don't pin the memory here - just get an address so that userspace can * be productive */ -return msm_gem_get_iova (obj, ctx->aspace, iova); +return msm_gem_get_iova (obj, ctx->vm, iova); } static int msm_ioctl_gem_info_set_iova(struct drm_device *dev,
@@ -537,13 +537,13 @@ static int msm_ioctl_gem_info_set_iova(struct drm_device *dev,return -EINVAL ;/* Only supported if per-process address space is supported: */ -if (priv->gpu->aspace == ctx->aspace) +if (priv->gpu->vm == ctx->vm)return UERR (EOPNOTSUPP , dev,"requires per-process pgtables" );if (should_fail (&fail_gem_iova, obj->size))return -ENOMEM ; -return msm_gem_set_iova (obj, ctx->aspace, iova); +return msm_gem_set_iova (obj, ctx->vm, iova); } static int msm_ioctl_gem_info_set_metadata(struct drm_gem_object *obj,
drivers/gpu/drm/msm/msm_drv.h +5 -5
@@ -48,7 +48,7 @@ struct msm_rd_state;struct msm_perf_state ;struct msm_gem_submit ;struct msm_fence_context ; -struct msm_gem_address_space ; +struct msm_gem_vm ;struct msm_gem_vma ;struct msm_disp_state ;
@@ -241,7 +241,7 @@ void msm_crtc_disable_vblank(struct drm_crtc *crtc);int msm_register_mmu (struct drm_device *dev,struct msm_mmu *mmu);void msm_unregister_mmu (struct drm_device *dev,struct msm_mmu *mmu); -struct msm_gem_address_space *msm_kms_init_aspace (struct drm_device *dev); +struct msm_gem_vm *msm_kms_init_vm (struct drm_device *dev);bool msm_use_mmu (struct drm_device *dev); int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
@@ -263,11 +263,11 @@ int msm_gem_prime_pin(struct drm_gem_object *obj);void msm_gem_prime_unpin (struct drm_gem_object *obj);int msm_framebuffer_prepare (struct drm_framebuffer *fb, -struct msm_gem_address_space *aspace,bool needs_dirtyfb); +struct msm_gem_vm *vm,bool needs_dirtyfb);void msm_framebuffer_cleanup (struct drm_framebuffer *fb, -struct msm_gem_address_space *aspace,bool needed_dirtyfb); +struct msm_gem_vm *vm,bool needed_dirtyfb);uint32_t msm_framebuffer_iova (struct drm_framebuffer *fb, -struct msm_gem_address_space *aspace,int plane); +struct msm_gem_vm *vm,int plane);struct drm_gem_object *msm_framebuffer_bo (struct drm_framebuffer *fb,int plane);const struct msm_format *msm_framebuffer_format (struct drm_framebuffer *fb); struct drm_framebuffer *msm_framebuffer_create(struct drm_device *dev,
drivers/gpu/drm/msm/msm_fb.c +5 -5
@@ -76,7 +76,7 @@ void msm_framebuffer_describe(struct drm_framebuffer *fb, struct seq_file *m)/* prepare/pin all the fb's bo's for scanout. */ int msm_framebuffer_prepare (struct drm_framebuffer *fb, -struct msm_gem_address_space *aspace, +struct msm_gem_vm *vm,bool needs_dirtyfb) {struct msm_framebuffer *msm_fb =to_msm_framebuffer (fb);
@@ -88,7 +88,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb,atomic_inc (&msm_fb->prepare_count);for (i =0 ; i < n; i++) { - ret =msm_gem_get_and_pin_iova (fb->obj[i], aspace, &msm_fb->iova[i]); + ret =msm_gem_get_and_pin_iova (fb->obj[i], vm, &msm_fb->iova[i]);drm_dbg_state (fb->dev,"FB[%u]: iova[%d]: %08llx (%d)\n" , fb->base.id, i, msm_fb->iova[i], ret);if (ret)
@@ -99,7 +99,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb, }void msm_framebuffer_cleanup (struct drm_framebuffer *fb, -struct msm_gem_address_space *aspace, +struct msm_gem_vm *vm,bool needed_dirtyfb) {struct msm_framebuffer *msm_fb =to_msm_framebuffer (fb);
@@ -109,14 +109,14 @@ void msm_framebuffer_cleanup(struct drm_framebuffer *fb,refcount_dec (&msm_fb->dirtyfb);for (i =0 ; i < n; i++) -msm_gem_unpin_iova (fb->obj[i], aspace); +msm_gem_unpin_iova (fb->obj[i], vm);if (!atomic_dec_return (&msm_fb->prepare_count))memset (msm_fb->iova,0 ,sizeof (msm_fb->iova)); }uint32_t msm_framebuffer_iova (struct drm_framebuffer *fb, -struct msm_gem_address_space *aspace,int plane) +struct msm_gem_vm *vm,int plane) {struct msm_framebuffer *msm_fb =to_msm_framebuffer (fb);return msm_fb->iova[plane] + fb->offsets[plane];
drivers/gpu/drm/msm/msm_fbdev.c +1 -1
@@ -122,7 +122,7 @@ int msm_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,* in panic (ie. lock-safe, etc) we could avoid pinning the * buffer now: */ - ret =msm_gem_get_and_pin_iova (bo, priv->kms->aspace, &paddr); + ret =msm_gem_get_and_pin_iova (bo, priv->kms->vm, &paddr);if (ret) {DRM_DEV_ERROR (dev->dev,"failed to get buffer obj iova: %d\n" , ret); goto fail;
drivers/gpu/drm/msm/msm_gem.c +37 -37
244 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gem.h +17 -17
@@ -22,7 +22,7 @@#define MSM_BO_STOLEN 0x10000000/* try to use stolen/splash memory */ #define MSM_BO_MAP_PRIV 0x20000000/* use IOMMU_PRIV when mapping */ -struct msm_gem_address_space { +struct msm_gem_vm {const char *name;/* NOTE: mm managed at the page level, size is in # of pages * and position mm_node->start is in # of pages:
@@ -47,13 +47,13 @@ struct msm_gem_address_space {uint64_t va_size; }; -struct msm_gem_address_space * -msm_gem_address_space_get (struct msm_gem_address_space *aspace); +struct msm_gem_vm * +msm_gem_vm_get (struct msm_gem_vm *vm); -void msm_gem_address_space_put (struct msm_gem_address_space *aspace); +void msm_gem_vm_put (struct msm_gem_vm *vm); -struct msm_gem_address_space * -msm_gem_address_space_create (struct msm_mmu *mmu,const char *name, +struct msm_gem_vm * +msm_gem_vm_create (struct msm_mmu *mmu,const char *name,u64 va_start,u64 size);struct msm_fence_context ;
@@ -61,12 +61,12 @@ struct msm_fence_context;struct msm_gem_vma {struct drm_mm_node node;uint64_t iova; -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;struct list_head list;/* node in msm_gem_object::vmas */ bool mapped; }; -struct msm_gem_vma *msm_gem_vma_new (struct msm_gem_address_space *aspace); +struct msm_gem_vma *msm_gem_vma_new (struct msm_gem_vm *vm);int msm_gem_vma_init (struct msm_gem_vma *vma,int size,u64 range_start,u64 range_end);void msm_gem_vma_purge (struct msm_gem_vma *vma);
@@ -127,18 +127,18 @@ int msm_gem_pin_vma_locked(struct drm_gem_object *obj, struct msm_gem_vma *vma);void msm_gem_unpin_locked (struct drm_gem_object *obj);void msm_gem_unpin_active (struct drm_gem_object *obj);struct msm_gem_vma *msm_gem_get_vma_locked (struct drm_gem_object *obj, -struct msm_gem_address_space *aspace); +struct msm_gem_vm *vm);int msm_gem_get_iova (struct drm_gem_object *obj, -struct msm_gem_address_space *aspace,uint64_t *iova); +struct msm_gem_vm *vm,uint64_t *iova);int msm_gem_set_iova (struct drm_gem_object *obj, -struct msm_gem_address_space *aspace,uint64_t iova); +struct msm_gem_vm *vm,uint64_t iova);int msm_gem_get_and_pin_iova_range (struct drm_gem_object *obj, -struct msm_gem_address_space *aspace,uint64_t *iova, +struct msm_gem_vm *vm,uint64_t *iova,u64 range_start,u64 range_end);int msm_gem_get_and_pin_iova (struct drm_gem_object *obj, -struct msm_gem_address_space *aspace,uint64_t *iova); +struct msm_gem_vm *vm,uint64_t *iova);void msm_gem_unpin_iova (struct drm_gem_object *obj, -struct msm_gem_address_space *aspace); +struct msm_gem_vm *vm);void msm_gem_pin_obj_locked (struct drm_gem_object *obj);struct page **msm_gem_pin_pages_locked (struct drm_gem_object *obj);void msm_gem_unpin_pages_locked (struct drm_gem_object *obj);
@@ -160,10 +160,10 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,struct drm_gem_object *msm_gem_new (struct drm_device *dev,uint32_t size,uint32_t flags);void *msm_gem_kernel_new (struct drm_device *dev,uint32_t size, -uint32_t flags,struct msm_gem_address_space *aspace, +uint32_t flags,struct msm_gem_vm *vm,struct drm_gem_object **bo,uint64_t *iova);void msm_gem_kernel_put (struct drm_gem_object *bo, -struct msm_gem_address_space *aspace); +struct msm_gem_vm *vm);struct drm_gem_object *msm_gem_import (struct drm_device *dev,struct dma_buf *dmabuf,struct sg_table *sgt);__printf (2 ,3 )
@@ -257,7 +257,7 @@ struct msm_gem_submit {struct kref ref;struct drm_device *dev;struct msm_gpu *gpu; -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;struct list_head node;/* node in ring submit list */ struct drm_exec exec;uint32_t seqno;/* Sequence number of the submit on the ring */
drivers/gpu/drm/msm/msm_gem_submit.c +3 -3
@@ -63,7 +63,7 @@ static struct msm_gem_submit *submit_create(struct drm_device *dev,kref_init (&submit->ref); submit->dev = dev; - submit->aspace = queue->ctx->aspace; + submit->vm = queue->ctx->vm; submit->gpu = gpu; submit->cmd = (void *)&submit->bos[nr_bos]; submit->queue = queue;
@@ -311,7 +311,7 @@ static int submit_pin_objects(struct msm_gem_submit *submit)struct msm_gem_vma *vma;/* if locking succeeded, pin bo: */ - vma =msm_gem_get_vma_locked (obj, submit->aspace); + vma =msm_gem_get_vma_locked (obj, submit->vm);if (IS_ERR (vma)) { ret =PTR_ERR (vma);break ;
@@ -669,7 +669,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,if (args->pad)return -EINVAL ; -if (unlikely (!ctx->aspace) && !capable (CAP_SYS_RAWIO )) { +if (unlikely (!ctx->vm) && !capable (CAP_SYS_RAWIO )) {DRM_ERROR_RATELIMITED ("IOMMU support or CAP_SYS_RAWIO required!\n" );return -EPERM ; }
drivers/gpu/drm/msm/msm_gem_vma.c +46 -47
193 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gpu.c +24 -24
108 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gpu.h +7 -9
@@ -78,10 +78,8 @@ struct msm_gpu_funcs {/* note: gpu_set_freq() can assume that we have been pm_resumed */ void (*gpu_set_freq)(struct msm_gpu *gpu,struct dev_pm_opp *opp,bool suspended); -struct msm_gem_address_space *(*create_address_space) - (struct msm_gpu *gpu,struct platform_device *pdev); -struct msm_gem_address_space *(*create_private_address_space) - (struct msm_gpu *gpu); +struct msm_gem_vm *(*create_vm)(struct msm_gpu *gpu,struct platform_device *pdev); +struct msm_gem_vm *(*create_private_vm)(struct msm_gpu *gpu);uint32_t (*get_rptr)(struct msm_gpu *gpu,struct msm_ringbuffer *ring);/**
@@ -236,7 +234,7 @@ struct msm_gpu {void __iomem *mmio;int irq; -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;/* Power Control: */ struct regulator *gpu_reg, *gpu_cx;
@@ -364,8 +362,8 @@ struct msm_context {*/ int queueid; -/** @aspace: the per-process GPU address-space */ -struct msm_gem_address_space *aspace; +/** @vm: the per-process GPU address-space */ +struct msm_gem_vm *vm;/** @kref: the reference count */ struct kref ref;
@@ -675,8 +673,8 @@ int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev, struct msm_gpu *gpu, const struct msm_gpu_funcs *funcs, const char *name, struct msm_gpu_config *config); -struct msm_gem_address_space * -msm_gpu_create_private_address_space (struct msm_gpu *gpu,struct task_struct *task); +struct msm_gem_vm * +msm_gpu_create_private_vm (struct msm_gpu *gpu,struct task_struct *task);void msm_gpu_cleanup (struct msm_gpu *gpu);
drivers/gpu/drm/msm/msm_kms.c +8 -8
@@ -176,9 +176,9 @@ static int msm_kms_fault_handler(void *arg, unsigned long iova, int flags, voidreturn -ENOSYS ; } -struct msm_gem_address_space *msm_kms_init_aspace (struct drm_device *dev) +struct msm_gem_vm *msm_kms_init_vm (struct drm_device *dev) { -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;struct msm_mmu *mmu;struct device *mdp_dev = dev->dev;struct device *mdss_dev = mdp_dev->parent;
@@ -204,17 +204,17 @@ struct msm_gem_address_space *msm_kms_init_aspace(struct drm_device *dev)return NULL ; } - aspace =msm_gem_address_space_create (mmu,"mdp_kms" , + vm =msm_gem_vm_create (mmu,"mdp_kms" ,0x1000 ,0x100000000 -0x1000 ); -if (IS_ERR (aspace)) { -dev_err (mdp_dev,"aspace create, error %pe\n" , aspace); +if (IS_ERR (vm)) { +dev_err (mdp_dev,"vm create, error %pe\n" , vm); mmu->funcs->destroy (mmu); -return aspace; +return vm; } -msm_mmu_set_fault_handler (aspace->mmu, kms, msm_kms_fault_handler); +msm_mmu_set_fault_handler (vm->mmu, kms, msm_kms_fault_handler); -return aspace; +return vm; }void msm_drm_kms_uninit (struct device *dev)
drivers/gpu/drm/msm/msm_kms.h +1 -1
@@ -139,7 +139,7 @@ struct msm_kms {atomic_t fault_snapshot_capture;/* mapper-id used to request GEM buffer mapped for scanout: */ -struct msm_gem_address_space *aspace; +struct msm_gem_vm *vm;/* disp snapshot support */ struct kthread_worker *dump_worker;
drivers/gpu/drm/msm/msm_ringbuffer.c +2 -2
@@ -84,7 +84,7 @@ struct msm_ringbuffer *msm_ringbuffer_new(struct msm_gpu *gpu, int id, ring->start =msm_gem_kernel_new (gpu->dev,MSM_GPU_RINGBUFFER_SZ ,check_apriv (gpu,MSM_BO_WC |MSM_BO_GPU_READONLY ), - gpu->aspace, &ring->bo, &ring->iova); + gpu->vm, &ring->bo, &ring->iova);if (IS_ERR (ring->start)) { ret =PTR_ERR (ring->start);
@@ -131,7 +131,7 @@ void msm_ringbuffer_destroy(struct msm_ringbuffer *ring)msm_fence_context_free (ring->fctx); -msm_gem_kernel_put (ring->bo, ring->gpu->aspace); +msm_gem_kernel_put (ring->bo, ring->gpu->vm);kfree (ring); }
drivers/gpu/drm/msm/msm_submitqueue.c +1 -1
@@ -59,7 +59,7 @@ void __msm_context_destroy(struct kref *kref)kfree (ctx->entities[i]); } -msm_gem_address_space_put (ctx->aspace); +msm_gem_vm_put (ctx->vm);kfree (ctx->comm);kfree (ctx->cmdline);kfree (ctx);
Signature · 1 line
2.49.0
PATCH v4 9/40 drm/msm: Remove vram carveout support
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
It is standing in the way of drm_gpuvm / VM_BIND support. Not to mention frequently broken and rarely tested. And I think only needed for a 10yr old not quite upstream SoC (msm8974).
Maybe we can add support back in later, but I'm doubtful.
--- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 8 -- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 15 --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 15 --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 3 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 3 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 4 - drivers/gpu/drm/msm/adreno/adreno_gpu.c | 4 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 1 - drivers/gpu/drm/msm/msm_drv.c | 117 +----------------- drivers/gpu/drm/msm/msm_drv.h | 11 -- drivers/gpu/drm/msm/msm_gem.c | 131 ++------------------- drivers/gpu/drm/msm/msm_gem.h | 5 - drivers/gpu/drm/msm/msm_gem_submit.c | 5 - drivers/gpu/drm/msm/msm_gpu.c | 6 +- 14 files changed, 19 insertions(+), 309 deletions(-)
drivers/gpu/drm/msm/adreno/a2xx_gpu.c +0 -8
@@ -551,14 +551,6 @@ struct msm_gpu *a2xx_gpu_init(struct drm_device *dev)else adreno_gpu->registers = a220_registers; -if (!gpu->vm) { -dev_err (dev->dev,"No memory protection without MMU\n" ); -if (!allow_vram_carveout) { - ret = -ENXIO ; - goto fail; - } - } -return gpu; fail:
drivers/gpu/drm/msm/adreno/a3xx_gpu.c +0 -15
@@ -581,21 +581,6 @@ struct msm_gpu *a3xx_gpu_init(struct drm_device *dev) goto fail; } -if (!gpu->vm) { -/* TODO we think it is possible to configure the GPU to -* restrict access to VRAM carveout. But the required -* registers are unknown. For now just bail out and -* limp along with just modesetting. If it turns out -* to not be possible to restrict access, then we must -* implement a cmdstream validator. -*/ -DRM_DEV_ERROR (dev->dev,"No memory protection without IOMMU\n" ); -if (!allow_vram_carveout) { - ret = -ENXIO ; - goto fail; - } - } - icc_path =devm_of_icc_get (&pdev->dev,"gfx-mem" );if (IS_ERR (icc_path)) { ret =PTR_ERR (icc_path);
drivers/gpu/drm/msm/adreno/a4xx_gpu.c +0 -15
@@ -695,21 +695,6 @@ struct msm_gpu *a4xx_gpu_init(struct drm_device *dev) adreno_gpu->uche_trap_base =0xffff0000ffff0000ull ; -if (!gpu->vm) { -/* TODO we think it is possible to configure the GPU to -* restrict access to VRAM carveout. But the required -* registers are unknown. For now just bail out and -* limp along with just modesetting. If it turns out -* to not be possible to restrict access, then we must -* implement a cmdstream validator. -*/ -DRM_DEV_ERROR (dev->dev,"No memory protection without IOMMU\n" ); -if (!allow_vram_carveout) { - ret = -ENXIO ; - goto fail; - } - } - icc_path =devm_of_icc_get (&pdev->dev,"gfx-mem" );if (IS_ERR (icc_path)) { ret =PTR_ERR (icc_path);
drivers/gpu/drm/msm/adreno/a5xx_gpu.c +1 -2
@@ -1786,8 +1786,7 @@ struct msm_gpu *a5xx_gpu_init(struct drm_device *dev)return ERR_PTR (ret); } -if (gpu->vm) -msm_mmu_set_fault_handler (gpu->vm->mmu, gpu, a5xx_fault_handler); +msm_mmu_set_fault_handler (gpu->vm->mmu, gpu, a5xx_fault_handler);/* Set up the preemption specific bits and pieces for each ringbuffer */ a5xx_preempt_init (gpu);
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +1 -2
@@ -2547,8 +2547,7 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev) adreno_gpu->uche_trap_base =0x1fffffffff000ull ; -if (gpu->vm) -msm_mmu_set_fault_handler (gpu->vm->mmu, gpu, a6xx_fault_handler); +msm_mmu_set_fault_handler (gpu->vm->mmu, gpu, a6xx_fault_handler);a6xx_calc_ubwc_config (adreno_gpu);/* Set up the preemption specific bits and pieces for each ringbuffer */
drivers/gpu/drm/msm/adreno/adreno_device.c +0 -4
@@ -16,10 +16,6 @@ bool snapshot_debugbus = false;MODULE_PARM_DESC (snapshot_debugbus,"Include debugbus sections in GPU devcoredump (if not fused off)" );module_param_named (snapshot_debugbus, snapshot_debugbus, bool,0600 ); -bool allow_vram_carveout = false; -MODULE_PARM_DESC (allow_vram_carveout,"Allow using VRAM Carveout, in place of IOMMU" ); -module_param_named (allow_vram_carveout, allow_vram_carveout, bool,0600 ); -int enable_preemption =-1 ;MODULE_PARM_DESC (enable_preemption,"Enable preemption (A7xx only) (1=on , 0=disable, -1=auto (default))" );module_param (enable_preemption, int,0600 );
drivers/gpu/drm/msm/adreno/adreno_gpu.c +3 -1
@@ -209,7 +209,9 @@ adreno_iommu_create_vm(struct msm_gpu *gpu,u64 start, size; mmu =msm_iommu_gpu_new (&pdev->dev, gpu, quirks); -if (IS_ERR_OR_NULL (mmu)) +if (!mmu) +return ERR_PTR (-ENODEV ); +else if (IS_ERR_OR_NULL (mmu))return ERR_CAST (mmu); geometry =msm_iommu_get_geometry (mmu);
drivers/gpu/drm/msm/adreno/adreno_gpu.h +0 -1
@@ -18,7 +18,6 @@#include "adreno_pm4.xml.h" extern bool snapshot_debugbus; -extern bool allow_vram_carveout;enum {ADRENO_FW_PM4 =0 ,
drivers/gpu/drm/msm/msm_drv.c +1 -116
152 lines not on this page · raw message
drivers/gpu/drm/msm/msm_drv.h +0 -11
@@ -183,17 +183,6 @@ struct msm_drm_private {struct msm_drm_thread event_thread[MAX_CRTCS ]; -/* VRAM carveout, used when no IOMMU: */ -struct { -unsigned long size; -dma_addr_t paddr; -/* NOTE: mm managed at the page level, size is in # of pages -* and position mm_node->start is in # of pages: -*/ -struct drm_mm mm; -spinlock_t lock;/* Protects drm_mm node allocation/removal */ - } vram; -struct notifier_block vmap_notifier;struct shrinker *shrinker;
drivers/gpu/drm/msm/msm_gem.c +12 -119
185 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gem.h +0 -5
@@ -102,11 +102,6 @@ struct msm_gem_object {struct list_head vmas;/* list of msm_gem_vma */ -/* For physically contiguous buffers. Used when we don't have -* an IOMMU. Also used for stolen/splashscreen buffer. -*/ -struct drm_mm_node *vram_node; -char name[32 ];/* Identifier to print for the debugfs files */ /* userspace metadata backchannel */
drivers/gpu/drm/msm/msm_gem_submit.c +0 -5
@@ -669,11 +669,6 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,if (args->pad)return -EINVAL ; -if (unlikely (!ctx->vm) && !capable (CAP_SYS_RAWIO )) { -DRM_ERROR_RATELIMITED ("IOMMU support or CAP_SYS_RAWIO required!\n" ); -return -EPERM ; - } -/* for now, we just have 3d pipe.. eventually this would need to * be more clever to dispatch to appropriate gpu module: */
drivers/gpu/drm/msm/msm_gpu.c +1 -5
@@ -944,12 +944,8 @@ int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev,msm_devfreq_init (gpu); - gpu->vm = gpu->funcs->create_vm (gpu, pdev); - -if (gpu->vm ==NULL ) -DRM_DEV_INFO (drm->dev,"%s: no IOMMU, fallback to VRAM carveout!\n" , name); -else if (IS_ERR (gpu->vm)) { +if (IS_ERR (gpu->vm)) { ret =PTR_ERR (gpu->vm); goto fail; }
Signature · 1 line
2.49.0
PATCH v4 10/40 drm/msm: Collapse vma allocation and initialization
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Now that we've dropped vram carveout support, we can collapse vma allocation and initialization. This better matches how things work with drm_gpuvm.
--- drivers/gpu/drm/msm/msm_gem.c | 30 +++----------------------- drivers/gpu/drm/msm/msm_gem.h | 4 ++-- drivers/gpu/drm/msm/msm_gem_vma.c | 36 +++++++++++++------------------ 3 files changed, 20 insertions(+), 50 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +3 -27
@@ -337,23 +337,6 @@ uint64_t msm_gem_mmap_offset(struct drm_gem_object *obj)return offset; } -static struct msm_gem_vma *add_vma (struct drm_gem_object *obj, -struct msm_gem_vm *vm) -{ -struct msm_gem_object *msm_obj =to_msm_bo (obj); -struct msm_gem_vma *vma; - -msm_gem_assert_locked (obj); - - vma =msm_gem_vma_new (vm); -if (!vma) -return ERR_PTR (-ENOMEM ); - -list_add_tail (&vma->list, &msm_obj->vmas); - -return vma; -} -static struct msm_gem_vma *lookup_vma (struct drm_gem_object *obj,struct msm_gem_vm *vm) {
@@ -420,6 +403,7 @@ static struct msm_gem_vma *get_vma_locked(struct drm_gem_object *obj,struct msm_gem_vm *vm, u64 range_start, u64 range_end) { + struct msm_gem_object *msm_obj = to_msm_bo(obj);struct msm_gem_vma *vma;msm_gem_assert_locked (obj);
@@ -427,18 +411,10 @@ static struct msm_gem_vma *get_vma_locked(struct drm_gem_object *obj, vma =lookup_vma (obj, vm);if (!vma) { -int ret; - - vma =add_vma (obj, vm); + vma =msm_gem_vma_new (vm, obj, range_start, range_end);if (IS_ERR (vma))return vma; - - ret =msm_gem_vma_init (vma, obj->size, - range_start, range_end); -if (ret) { -del_vma (vma); -return ERR_PTR (ret); - } +list_add_tail (&vma->list, &msm_obj->vmas); }else {GEM_WARN_ON (vma->iova < range_start);GEM_WARN_ON ((vma->iova + obj->size) > range_end);
drivers/gpu/drm/msm/msm_gem.h +2 -2
@@ -66,8 +66,8 @@ struct msm_gem_vma {bool mapped; }; -struct msm_gem_vma *msm_gem_vma_new (struct msm_gem_vm *vm); -int msm_gem_vma_init (struct msm_gem_vma *vma,int size, +struct msm_gem_vma * +msm_gem_vma_new (struct msm_gem_vm *vm,struct drm_gem_object *obj,u64 range_start,u64 range_end);void msm_gem_vma_purge (struct msm_gem_vma *vma);int msm_gem_vma_map (struct msm_gem_vma *vma,int prot,struct sg_table *sgt,int size);
drivers/gpu/drm/msm/msm_gem_vma.c +15 -21
@@ -106,47 +106,41 @@ void msm_gem_vma_close(struct msm_gem_vma *vma)msm_gem_vm_put (vm); } -struct msm_gem_vma *msm_gem_vma_new (struct msm_gem_vm *vm) +/* Create a new vma and allocate an iova for it */ +struct msm_gem_vma * +msm_gem_vma_new (struct msm_gem_vm *vm,struct drm_gem_object *obj, +u64 range_start,u64 range_end) {struct msm_gem_vma *vma; +int ret; vma =kzalloc (sizeof (*vma),GFP_KERNEL );if (!vma) -return NULL ; +return ERR_PTR (-ENOMEM ); vma->vm = vm; -return vma; -} - -/* Initialize a new vma and allocate an iova for it */ -int msm_gem_vma_init (struct msm_gem_vma *vma,int size, -u64 range_start,u64 range_end) -{ -struct msm_gem_vm *vm = vma->vm; -int ret; - -if (GEM_WARN_ON (!vm)) -return -EINVAL ; - -if (GEM_WARN_ON (vma->iova)) -return -EBUSY ; -spin_lock (&vm->lock); ret =drm_mm_insert_node_in_range (&vm->mm, &vma->node, - size,PAGE_SIZE ,0 , + obj->size,PAGE_SIZE ,0 , range_start, range_end,0 );spin_unlock (&vm->lock);if (ret) -return ret; + goto err_free_vma; vma->iova = vma->node.start; vma->mapped = false; +INIT_LIST_HEAD (&vma->list); +kref_get (&vm->kref); -return 0 ; +return vma; + +err_free_vma: +kfree (vma); +return ERR_PTR (ret); } struct msm_gem_vm *
Signature · 1 line
2.49.0
PATCH v4 11/40 drm/msm: Collapse vma close and delete
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
This fits better drm_gpuvm/drm_gpuva.
--- drivers/gpu/drm/msm/msm_gem.c | 16 +++------------- drivers/gpu/drm/msm/msm_gem_vma.c | 2 ++ 2 files changed, 5 insertions(+), 13 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +3 -13
@@ -353,15 +353,6 @@ static struct msm_gem_vma *lookup_vma(struct drm_gem_object *obj,return NULL ; } -static void del_vma (struct msm_gem_vma *vma) -{ -if (!vma) -return ; - -list_del (&vma->list); -kfree (vma); -} -/* * If close is true, this also closes the VMA (releasing the allocated * iova range) in addition to removing the iommu mapping. In the eviction
@@ -372,11 +363,11 @@ static void put_iova_spaces(struct drm_gem_object *obj, bool close) {struct msm_gem_object *msm_obj =to_msm_bo (obj); -struct msm_gem_vma *vma; +struct msm_gem_vma *vma, *tmp;msm_gem_assert_locked (obj); -list_for_each_entry (vma, &msm_obj->vmas, list) { +list_for_each_entry_safe (vma, tmp, &msm_obj->vmas, list) {if (vma->vm) {msm_gem_vma_purge (vma);if (close)
@@ -395,7 +386,7 @@ put_iova_vmas(struct drm_gem_object *obj)msm_gem_assert_locked (obj);list_for_each_entry_safe (vma, tmp, &msm_obj->vmas, list) { -del_vma (vma); +msm_gem_vma_close (vma); } }
@@ -564,7 +555,6 @@ static int clear_iova(struct drm_gem_object *obj,msm_gem_vma_purge (vma);msm_gem_vma_close (vma); -del_vma (vma);return 0 ; }
drivers/gpu/drm/msm/msm_gem_vma.c +2 -0
@@ -102,8 +102,10 @@ void msm_gem_vma_close(struct msm_gem_vma *vma)spin_unlock (&vm->lock); vma->iova =0 ; +list_del (&vma->list);msm_gem_vm_put (vm); +kfree (vma); }/* Create a new vma and allocate an iova for it */
Signature · 1 line
2.49.0
PATCH v4 12/40 drm/msm: Don't close VMAs on purge
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Previously we'd also tear down the VMA, making the address space available again. But with drm_gpuvm conversion, this would require holding the locks of all VMs the GEM object is mapped in. Which is problematic for the shrinker.
Instead just let the VMA hang around until the GEM object is freed.
--- drivers/gpu/drm/msm/msm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/msm_gem.c +1 -1
@@ -763,7 +763,7 @@ void msm_gem_purge(struct drm_gem_object *obj)GEM_WARN_ON (!is_purgeable (msm_obj));/* Get rid of any iommu mapping(s): */ -put_iova_spaces (obj, true); +put_iova_spaces (obj, false);msm_gem_vunmap (obj);
Signature · 1 line
2.49.0
PATCH v4 13/40 drm/msm: drm_gpuvm conversion
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Now that we've realigned deletion and allocation, switch over to using drm_gpuvm/drm_gpuva. This allows us to support multiple VMAs per BO per VM, to allow mapping different parts of a single BO at different virtual addresses, which is a key requirement for sparse/VM_BIND.
This prepares us for using drm_gpuvm to translate a batch of MAP/ MAP_NULL/UNMAP operations from userspace into a sequence of map/remap/ unmap steps for updating the page tables.
--- drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 3 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 6 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 5 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 7 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 5 +- drivers/gpu/drm/msm/msm_drv.c | 1 + drivers/gpu/drm/msm/msm_gem.c | 142 ++++++++++++++--------- drivers/gpu/drm/msm/msm_gem.h | 89 +++++++++++--- drivers/gpu/drm/msm/msm_gem_submit.c | 2 +- drivers/gpu/drm/msm/msm_gem_vma.c | 140 +++++++++++++++------- drivers/gpu/drm/msm/msm_kms.c | 4 +- 12 files changed, 271 insertions(+), 134 deletions(-)
drivers/gpu/drm/msm/Kconfig +1 -0
@@ -21,6 +21,7 @@ config DRM_MSM select DRM_DISPLAY_HELPER select DRM_BRIDGE_CONNECTOR select DRM_EXEC + select DRM_GPUVM select DRM_KMS_HELPER select DRM_PANEL select DRM_BRIDGE
drivers/gpu/drm/msm/adreno/a2xx_gpu.c +1 -2
@@ -472,8 +472,7 @@ a2xx_create_vm(struct msm_gpu *gpu, struct platform_device *pdev)struct msm_mmu *mmu =a2xx_gpummu_new (&pdev->dev, gpu);struct msm_gem_vm *vm; - vm =msm_gem_vm_create (mmu,"gpu" ,SZ_16M , -0xfff *SZ_64K ); + vm =msm_gem_vm_create (gpu->dev, mmu,"gpu" ,SZ_16M ,0xfff *SZ_64K , true);if (IS_ERR (vm) && !IS_ERR (mmu)) mmu->funcs->destroy (mmu);
drivers/gpu/drm/msm/adreno/a6xx_gmu.c +3 -3
@@ -1311,7 +1311,7 @@ static int a6xx_gmu_memory_alloc(struct a6xx_gmu *gmu, struct a6xx_gmu_bo *bo,return 0 ; } -static int a6xx_gmu_memory_probe (struct a6xx_gmu *gmu) +static int a6xx_gmu_memory_probe (struct drm_device *drm,struct a6xx_gmu *gmu) {struct msm_mmu *mmu;
@@ -1321,7 +1321,7 @@ static int a6xx_gmu_memory_probe(struct a6xx_gmu *gmu)if (IS_ERR (mmu))return PTR_ERR (mmu); - gmu->vm =msm_gem_vm_create (mmu,"gmu" ,0x0 ,0x80000000 ); + gmu->vm =msm_gem_vm_create (drm, mmu,"gmu" ,0x0 ,0x80000000 , true);if (IS_ERR (gmu->vm))return PTR_ERR (gmu->vm);
@@ -1940,7 +1940,7 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)if (ret) goto err_put_device; - ret =a6xx_gmu_memory_probe (gmu); + ret =a6xx_gmu_memory_probe (adreno_gpu->base.dev, gmu);if (ret) goto err_put_device;
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +2 -3
@@ -2271,9 +2271,8 @@ a6xx_create_private_vm(struct msm_gpu *gpu)if (IS_ERR (mmu))return ERR_CAST (mmu); -return msm_gem_vm_create (mmu, -"gpu" ,ADRENO_VM_START , -adreno_private_vm_size (gpu)); +return msm_gem_vm_create (gpu->dev, mmu,"gpu" ,ADRENO_VM_START , +adreno_private_vm_size (gpu), true); }static uint32_t a6xx_get_rptr (struct msm_gpu *gpu,struct msm_ringbuffer *ring)
drivers/gpu/drm/msm/adreno/adreno_gpu.c +4 -3
@@ -226,7 +226,8 @@ adreno_iommu_create_vm(struct msm_gpu *gpu, start =max_t (u64,SZ_16M , geometry->aperture_start); size = geometry->aperture_end - start +1 ; - vm =msm_gem_vm_create (mmu,"gpu" , start &GENMASK_ULL (48 ,0 ), size); + vm =msm_gem_vm_create (gpu->dev, mmu,"gpu" , start &GENMASK_ULL (48 ,0 ), + size, true);if (IS_ERR (vm) && !IS_ERR (mmu)) mmu->funcs->destroy (mmu);
@@ -418,12 +419,12 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx,case MSM_PARAM_VA_START :if (ctx->vm == gpu->vm)return UERR (EINVAL , drm,"requires per-process pgtables" ); - *value = ctx->vm->va_start; + *value = ctx->vm->base.mm_start;return 0 ;case MSM_PARAM_VA_SIZE :if (ctx->vm == gpu->vm)return UERR (EINVAL , drm,"requires per-process pgtables" ); - *value = ctx->vm->va_size; + *value = ctx->vm->base.mm_range;return 0 ;case MSM_PARAM_HIGHEST_BANK_BIT : *value = adreno_gpu->ubwc_config.highest_bank_bit;
drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c +3 -2
@@ -451,8 +451,9 @@ static int mdp4_kms_init(struct drm_device *dev) "contig buffers for scanout\n"); vm =NULL ; }else { - vm =msm_gem_vm_create (mmu, -"mdp4" ,0x1000 ,0x100000000 -0x1000 ); + vm =msm_gem_vm_create (dev, mmu,"mdp4" , +0x1000 ,0x100000000 -0x1000 , + true);if (IS_ERR (vm)) {if (!IS_ERR (mmu))
drivers/gpu/drm/msm/msm_drv.c +1 -0
@@ -776,6 +776,7 @@ static const struct file_operations fops = {static const struct drm_driver msm_driver = { .driver_features =DRIVER_GEM | +DRIVER_GEM_GPUVA |DRIVER_RENDER |DRIVER_ATOMIC | DRIVER_MODESET |
drivers/gpu/drm/msm/msm_gem.c +84 -58
273 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gem.h +70 -19
132 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gem_submit.c +1 -1
@@ -321,7 +321,7 @@ static int submit_pin_objects(struct msm_gem_submit *submit)if (ret)break ; - submit->bos[i].iova = vma->iova; + submit->bos[i].iova = vma->base.va.addr; }/*
drivers/gpu/drm/msm/msm_gem_vma.c +99 -41
243 lines not on this page · raw message
drivers/gpu/drm/msm/msm_kms.c +2 -2
@@ -204,8 +204,8 @@ struct msm_gem_vm *msm_kms_init_vm(struct drm_device *dev)return NULL ; } - vm =msm_gem_vm_create (mmu,"mdp_kms" , -0x1000 ,0x100000000 -0x1000 ); + vm =msm_gem_vm_create (dev, mmu,"mdp_kms" , +0x1000 ,0x100000000 -0x1000 , true);if (IS_ERR (vm)) {dev_err (mdp_dev,"vm create, error %pe\n" , vm); mmu->funcs->destroy (mmu);
Signature · 1 line
2.49.0
PATCH v4 14/40 drm/msm: Convert vm locking
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Convert to using the gpuvm's r_obj for serializing access to the VM. This way we can use the drm_exec helper for dealing with deadlock detection and backoff.
This will let us deal with upcoming locking order conflicts with the VM_BIND implmentation (ie. in some scenarious we need to acquire the obj lock first, for ex. to iterate all the VMs an obj is bound in, and in other scenarious we need to acquire the VM lock first).
--- drivers/gpu/drm/msm/msm_gem.c | 35 ++++++++--- drivers/gpu/drm/msm/msm_gem.h | 37 ++++++++++-- drivers/gpu/drm/msm/msm_gem_shrinker.c | 80 +++++++++++++++++++++++--- drivers/gpu/drm/msm/msm_gem_submit.c | 9 ++- drivers/gpu/drm/msm/msm_gem_vma.c | 27 ++++----- 5 files changed, 150 insertions(+), 38 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +27 -8
@@ -52,6 +52,7 @@ static void put_iova_spaces(struct drm_gem_object *obj, struct drm_gpuvm *vm, bostatic void msm_gem_close (struct drm_gem_object *obj,struct drm_file *file) {struct msm_context *ctx = file->driver_priv; +struct drm_exec exec;update_ctx_mem (file, -obj->size);
@@ -70,9 +71,9 @@ static void msm_gem_close(struct drm_gem_object *obj, struct drm_file *file)dma_resv_wait_timeout (obj->resv,DMA_RESV_USAGE_READ , false,msecs_to_jiffies (1000 )); -msm_gem_lock (obj); +msm_gem_lock_vm_and_obj (&exec, obj, ctx->vm);put_iova_spaces (obj, &ctx->vm->base, true); -msm_gem_unlock (obj); +drm_exec_fini (&exec);/* drop locks */ }/*
@@ -538,11 +539,12 @@ int msm_gem_get_and_pin_iova_range(struct drm_gem_object *obj, struct msm_gem_vm *vm, uint64_t *iova, u64 range_start, u64 range_end) { + struct drm_exec exec;int ret; -msm_gem_lock (obj); +msm_gem_lock_vm_and_obj (&exec, obj, vm); ret =get_and_pin_iova_range_locked (obj, vm, iova, range_start, range_end); -msm_gem_unlock (obj); +drm_exec_fini (&exec);/* drop locks */ return ret; }
@@ -562,16 +564,17 @@ int msm_gem_get_iova(struct drm_gem_object *obj, struct msm_gem_vm *vm, uint64_t *iova) { struct msm_gem_vma *vma; +struct drm_exec exec;int ret =0 ; -msm_gem_lock (obj); +msm_gem_lock_vm_and_obj (&exec, obj, vm); vma =get_vma_locked (obj, vm,0 ,U64_MAX );if (IS_ERR (vma)) { ret =PTR_ERR (vma); }else { *iova = vma->base.va.addr; } -msm_gem_unlock (obj); +drm_exec_fini (&exec);/* drop locks */ return ret; }
@@ -600,9 +603,10 @@ static int clear_iova(struct drm_gem_object *obj,int msm_gem_set_iova (struct drm_gem_object *obj,struct msm_gem_vm *vm,uint64_t iova) { +struct drm_exec exec;int ret =0 ; -msm_gem_lock (obj); +msm_gem_lock_vm_and_obj (&exec, obj, vm);if (!iova) { ret =clear_iova (obj, vm); }else {
@@ -615,7 +619,7 @@ int msm_gem_set_iova(struct drm_gem_object *obj, ret = -EBUSY ; } } -msm_gem_unlock (obj); +drm_exec_fini (&exec);/* drop locks */ return ret; }
@@ -1007,12 +1011,27 @@ static void msm_gem_free_object(struct drm_gem_object *obj)struct msm_gem_object *msm_obj =to_msm_bo (obj);struct drm_device *dev = obj->dev;struct msm_drm_private *priv = dev->dev_private; +struct drm_exec exec;mutex_lock (&priv->obj_lock);list_del (&msm_obj->node);mutex_unlock (&priv->obj_lock); +/* +* We need to lock any VMs the object is still attached to, but not +* the object itself (see explaination in msm_gem_assert_locked()), +* so just open-code this special case: +*/ +drm_exec_init (&exec,0 ,0 ); + drm_exec_until_all_locked (&exec) { +struct drm_gpuvm_bo *vm_bo; + drm_gem_for_each_gpuvm_bo (vm_bo, obj) { +drm_exec_lock_obj (&exec,drm_gpuvm_resv_obj (vm_bo->vm)); +drm_exec_retry_on_contention (&exec); + } + }put_iova_spaces (obj,NULL , true); +drm_exec_fini (&exec);/* drop locks */ if (obj->import_attach) {GEM_WARN_ON (msm_obj->vaddr);
drivers/gpu/drm/msm/msm_gem.h +31 -6
@@ -62,12 +62,6 @@ struct msm_gem_vm {*/ struct drm_mm mm; -/** @mm_lock: protects @mm node allocation/removal */ -struct spinlock mm_lock; - -/** @vm_lock: protects gpuvm insert/remove/traverse */ -struct mutex vm_lock; -/** @mmu: The mmu object which manages the pgtables */ struct msm_mmu *mmu;
@@ -246,6 +240,37 @@ msm_gem_unlock(struct drm_gem_object *obj)dma_resv_unlock (obj->resv); } +/** +* msm_gem_lock_vm_and_obj() - Helper to lock an obj + VM +* @exec: the exec context helper which will be initalized +* @obj: the GEM object to lock +* @vm: the VM to lock +* +* Operations which modify a VM frequently need to lock both the VM and +* the object being mapped/unmapped/etc. This helper uses drm_exec to +* acquire both locks, dealing with potential deadlock/backoff scenarios +* which arise when multiple locks are involved. +*/ +static inline int +msm_gem_lock_vm_and_obj (struct drm_exec *exec, +struct drm_gem_object *obj, +struct msm_gem_vm *vm) +{ +int ret =0 ; + +drm_exec_init (exec,0 ,2 ); +drm_exec_until_all_locked (exec) { + ret =drm_exec_lock_obj (exec,drm_gpuvm_resv_obj (&vm->base)); +if (!ret && (obj->resv !=drm_gpuvm_resv (&vm->base))) + ret =drm_exec_lock_obj (exec, obj); +drm_exec_retry_on_contention (exec); +if (GEM_WARN_ON (ret)) +break ; + } + +return ret; +} +static inline void msm_gem_assert_locked (struct drm_gem_object *obj) {
drivers/gpu/drm/msm/msm_gem_shrinker.c +73 -7
110 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gem_submit.c +8 -1
@@ -256,11 +256,18 @@ static int submit_lookup_cmds(struct msm_gem_submit *submit,/* This is where we make sure all the bo's are reserved and pin'd: */ static int submit_lock_objects (struct msm_gem_submit *submit) { +unsigned flags =DRM_EXEC_IGNORE_DUPLICATES |DRM_EXEC_INTERRUPTIBLE_WAIT ;int ret; -drm_exec_init (&submit->exec,DRM_EXEC_INTERRUPTIBLE_WAIT , submit->nr_bos); +// TODO need to add vm_bind path which locks vm resv + external objs +drm_exec_init (&submit->exec, flags, submit->nr_bos); drm_exec_until_all_locked (&submit->exec) { + ret =drm_exec_lock_obj (&submit->exec, +drm_gpuvm_resv_obj (&submit->vm->base)); +drm_exec_retry_on_contention (&submit->exec); +if (ret) + goto error;for (unsigned i =0 ; i < submit->nr_bos; i++) {struct drm_gem_object *obj = submit->bos[i].obj; ret =drm_exec_prepare_obj (&submit->exec, obj,1 );
drivers/gpu/drm/msm/msm_gem_vma.c +11 -16
@@ -92,15 +92,13 @@ void msm_gem_vma_close(struct msm_gem_vma *vma)GEM_WARN_ON (vma->mapped); -spin_lock (&vm->mm_lock); +drm_gpuvm_resv_assert_held (&vm->base); +if (vma->base.va.addr)drm_mm_remove_node (&vma->node); -spin_unlock (&vm->mm_lock); -mutex_lock (&vm->vm_lock);drm_gpuva_remove (&vma->base);drm_gpuva_unlink (&vma->base); -mutex_unlock (&vm->vm_lock);kfree (vma); }
@@ -114,16 +112,16 @@ msm_gem_vma_new(struct msm_gem_vm *vm, struct drm_gem_object *obj,struct msm_gem_vma *vma;int ret; +drm_gpuvm_resv_assert_held (&vm->base); + vma =kzalloc (sizeof (*vma),GFP_KERNEL );if (!vma)return ERR_PTR (-ENOMEM );if (vm->managed) { -spin_lock (&vm->mm_lock); ret =drm_mm_insert_node_in_range (&vm->mm, &vma->node, obj->size,PAGE_SIZE ,0 , range_start, range_end,0 ); -spin_unlock (&vm->mm_lock);if (ret) goto err_free_vma;
@@ -137,9 +135,7 @@ msm_gem_vma_new(struct msm_gem_vm *vm, struct drm_gem_object *obj,drm_gpuva_init (&vma->base, range_start, range_end - range_start, obj,0 ); vma->mapped = false; -mutex_lock (&vm->vm_lock); ret =drm_gpuva_insert (&vm->base, &vma->base); -mutex_unlock (&vm->vm_lock);if (ret) goto err_free_range;
@@ -149,18 +145,14 @@ msm_gem_vma_new(struct msm_gem_vm *vm, struct drm_gem_object *obj, goto err_va_remove; } -mutex_lock (&vm->vm_lock);drm_gpuvm_bo_extobj_add (vm_bo);drm_gpuva_link (&vma->base, vm_bo); -mutex_unlock (&vm->vm_lock);GEM_WARN_ON (drm_gpuvm_bo_put (vm_bo));return vma; err_va_remove: -mutex_lock (&vm->vm_lock);drm_gpuva_remove (&vma->base); -mutex_unlock (&vm->vm_lock); err_free_range:if (vm->managed)drm_mm_remove_node (&vma->node);
@@ -191,7 +183,13 @@ struct msm_gem_vm * msm_gem_vm_create(struct drm_device *drm, struct msm_mmu *mmu, const char *name, u64 va_start, u64 va_size, bool managed) { - enum drm_gpuvm_flags flags = managed ? DRM_GPUVM_VA_WEAK_REF : 0; + /* + * We mostly want to use DRM_GPUVM_RESV_PROTECTED, except that + * makes drm_gpuvm_bo_evict() a no-op for extobjs (ie. we loose + * tracking that an extobj is evicted) :facepalm: + */ + enum drm_gpuvm_flags flags = + (managed ?DRM_GPUVM_VA_WEAK_REF :0 );struct msm_gem_vm *vm;struct drm_gem_object *dummy_gem;int ret =0 ;
@@ -213,9 +211,6 @@ msm_gem_vm_create(struct drm_device *drm, struct msm_mmu *mmu, const char *name, va_start, va_size, 0, 0, &msm_gpuvm_ops);drm_gem_object_put (dummy_gem); -spin_lock_init (&vm->mm_lock); -mutex_init (&vm->vm_lock); - vm->mmu = mmu; vm->managed = managed;
Signature · 1 line
2.49.0
PATCH v4 15/40 drm/msm: Use drm_gpuvm types more
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Most of the driver code doesn't need to reach in to msm specific fields, so just use the drm_gpuvm/drm_gpuva types directly. This should hopefully improve commonality with other drivers and make the code easier to understand.
--- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 6 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 3 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 6 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 11 +-- drivers/gpu/drm/msm/adreno/a6xx_preempt.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 21 +++-- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 6 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 11 +-- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 11 +-- drivers/gpu/drm/msm/dsi/dsi_host.c | 6 +- drivers/gpu/drm/msm/msm_drv.h | 19 ++--- drivers/gpu/drm/msm/msm_fb.c | 14 ++-- drivers/gpu/drm/msm/msm_gem.c | 82 +++++++++---------- drivers/gpu/drm/msm/msm_gem.h | 59 ++++++------- drivers/gpu/drm/msm/msm_gem_submit.c | 6 +- drivers/gpu/drm/msm/msm_gem_vma.c | 70 +++++++--------- drivers/gpu/drm/msm/msm_gpu.c | 21 +++-- drivers/gpu/drm/msm/msm_gpu.h | 10 +-- drivers/gpu/drm/msm/msm_kms.c | 6 +- drivers/gpu/drm/msm/msm_kms.h | 2 +- drivers/gpu/drm/msm/msm_submitqueue.c | 2 +- 27 files changed, 190 insertions(+), 204 deletions(-)
drivers/gpu/drm/msm/adreno/a2xx_gpu.c +3 -3
@@ -113,7 +113,7 @@ static int a2xx_hw_init(struct msm_gpu *gpu)uint32_t *ptr, len;int i, ret; -a2xx_gpummu_params (gpu->vm->mmu, &pt_base, &tran_error); +a2xx_gpummu_params (to_msm_vm (gpu->vm)->mmu, &pt_base, &tran_error);DBG ("%s" , gpu->name);
@@ -466,11 +466,11 @@ static struct msm_gpu_state *a2xx_gpu_state_get(struct msm_gpu *gpu)return state; } -static struct msm_gem_vm * +static struct drm_gpuvm *a2xx_create_vm (struct msm_gpu *gpu,struct platform_device *pdev) {struct msm_mmu *mmu =a2xx_gpummu_new (&pdev->dev, gpu); -struct msm_gem_vm *vm; +struct drm_gpuvm *vm; vm =msm_gem_vm_create (gpu->dev, mmu,"gpu" ,SZ_16M ,0xfff *SZ_64K , true);
drivers/gpu/drm/msm/adreno/a5xx_gpu.c +2 -1
@@ -1786,7 +1786,8 @@ struct msm_gpu *a5xx_gpu_init(struct drm_device *dev)return ERR_PTR (ret); } -msm_mmu_set_fault_handler (gpu->vm->mmu, gpu, a5xx_fault_handler); +msm_mmu_set_fault_handler (to_msm_vm (gpu->vm)->mmu, gpu, + a5xx_fault_handler);/* Set up the preemption specific bits and pieces for each ringbuffer */ a5xx_preempt_init (gpu);
drivers/gpu/drm/msm/adreno/a6xx_gmu.c +4 -2
@@ -1259,6 +1259,8 @@ int a6xx_gmu_stop(struct a6xx_gpu *a6xx_gpu)static void a6xx_gmu_memory_free (struct a6xx_gmu *gmu) { +struct msm_mmu *mmu =to_msm_vm (gmu->vm)->mmu; +msm_gem_kernel_put (gmu->hfi.obj, gmu->vm);msm_gem_kernel_put (gmu->debug.obj, gmu->vm);msm_gem_kernel_put (gmu->icache.obj, gmu->vm);
@@ -1266,8 +1268,8 @@ static void a6xx_gmu_memory_free(struct a6xx_gmu *gmu)msm_gem_kernel_put (gmu->dummy.obj, gmu->vm);msm_gem_kernel_put (gmu->log.obj, gmu->vm); - gmu->vm->mmu->funcs->detach (gmu->vm->mmu); -msm_gem_vm_put (gmu->vm); + mmu->funcs->detach (mmu); +drm_gpuvm_put (gmu->vm); } static int a6xx_gmu_memory_alloc(struct a6xx_gmu *gmu, struct a6xx_gmu_bo *bo,
drivers/gpu/drm/msm/adreno/a6xx_gmu.h +1 -1
@@ -62,7 +62,7 @@ struct a6xx_gmu {/* For serializing communication with the GMU: */ struct mutex lock; -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;void __iomem *mmio;void __iomem *rscc;
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +6 -5
@@ -120,7 +120,7 @@ static void a6xx_set_pagetable(struct a6xx_gpu *a6xx_gpu,if (ctx->seqno == ring->cur_ctx_seqno)return ; -if (msm_iommu_pagetable_params (ctx->vm->mmu, &ttbr, &asid)) +if (msm_iommu_pagetable_params (to_msm_vm (ctx->vm)->mmu, &ttbr, &asid))return ;if (adreno_gpu->info->family >=ADRENO_7XX_GEN1 ) {
@@ -2243,7 +2243,7 @@ static void a6xx_gpu_set_freq(struct msm_gpu *gpu, struct dev_pm_opp *opp,mutex_unlock (&a6xx_gpu->gmu.lock); } -static struct msm_gem_vm * +static struct drm_gpuvm *a6xx_create_vm (struct msm_gpu *gpu,struct platform_device *pdev) {struct adreno_gpu *adreno_gpu =to_adreno_gpu (gpu);
@@ -2261,12 +2261,12 @@ a6xx_create_vm(struct msm_gpu *gpu, struct platform_device *pdev)return adreno_iommu_create_vm (gpu, pdev, quirks); } -static struct msm_gem_vm * +static struct drm_gpuvm *a6xx_create_private_vm (struct msm_gpu *gpu) {struct msm_mmu *mmu; - mmu =msm_iommu_pagetable_create (gpu->vm->mmu); + mmu =msm_iommu_pagetable_create (to_msm_vm (gpu->vm)->mmu);if (IS_ERR (mmu))return ERR_CAST (mmu);
@@ -2546,7 +2546,8 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev) adreno_gpu->uche_trap_base =0x1fffffffff000ull ; -msm_mmu_set_fault_handler (gpu->vm->mmu, gpu, a6xx_fault_handler); +msm_mmu_set_fault_handler (to_msm_vm (gpu->vm)->mmu, gpu, + a6xx_fault_handler);a6xx_calc_ubwc_config (adreno_gpu);/* Set up the preemption specific bits and pieces for each ringbuffer */
drivers/gpu/drm/msm/adreno/a6xx_preempt.c +1 -1
@@ -376,7 +376,7 @@ static int preempt_init_ring(struct a6xx_gpu *a6xx_gpu,struct a7xx_cp_smmu_info *smmu_info_ptr = ptr; -msm_iommu_pagetable_params (gpu->vm->mmu, &ttbr, &asid); +msm_iommu_pagetable_params (to_msm_vm (gpu->vm)->mmu, &ttbr, &asid); smmu_info_ptr->magic =GEN7_CP_SMMU_INFO_MAGIC ; smmu_info_ptr->ttbr0 = ttbr;
drivers/gpu/drm/msm/adreno/adreno_gpu.c +12 -9
@@ -191,21 +191,21 @@ int adreno_zap_shader_load(struct msm_gpu *gpu, u32 pasid)return zap_shader_load_mdt (gpu, adreno_gpu->info->zapfw, pasid); } -struct msm_gem_vm * +struct drm_gpuvm *adreno_create_vm (struct msm_gpu *gpu,struct platform_device *pdev) {return adreno_iommu_create_vm (gpu, pdev,0 ); } -struct msm_gem_vm * +struct drm_gpuvm *adreno_iommu_create_vm (struct msm_gpu *gpu,struct platform_device *pdev,unsigned long quirks) {struct iommu_domain_geometry *geometry;struct msm_mmu *mmu; -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;u64 start, size; mmu =msm_iommu_gpu_new (&pdev->dev, gpu, quirks);
@@ -274,9 +274,10 @@ void adreno_check_and_reenable_stall(struct adreno_gpu *adreno_gpu)if (!adreno_gpu->stall_enabled &&ktime_after (ktime_get (), adreno_gpu->stall_reenable_time) && !READ_ONCE (gpu->crashstate)) { +struct msm_mmu *mmu =to_msm_vm (gpu->vm)->mmu; adreno_gpu->stall_enabled = true; - gpu->vm->mmu->funcs->set_stall (gpu->vm->mmu, true); + mmu->funcs->set_stall (mmu, true); }spin_unlock_irqrestore (&adreno_gpu->fault_stall_lock, flags); }
@@ -290,6 +291,7 @@ int adreno_fault_handler(struct msm_gpu *gpu, unsigned long iova, int flags, struct adreno_smmu_fault_info *info, const char *block, u32 scratch[4]) { + struct msm_mmu *mmu = to_msm_vm(gpu->vm)->mmu;struct adreno_gpu *adreno_gpu =to_adreno_gpu (gpu);const char *type ="UNKNOWN" ; bool do_devcoredump = info && (info->fsr & ARM_SMMU_FSR_SS) &&
@@ -302,9 +304,10 @@ int adreno_fault_handler(struct msm_gpu *gpu, unsigned long iova, int flags,*/ spin_lock_irqsave (&adreno_gpu->fault_stall_lock, irq_flags);if (adreno_gpu->stall_enabled) { + adreno_gpu->stall_enabled = false; - gpu->vm->mmu->funcs->set_stall (gpu->vm->mmu, false); + mmu->funcs->set_stall (mmu, false); } adreno_gpu->stall_reenable_time =ktime_add_ms (ktime_get (),500 );spin_unlock_irqrestore (&adreno_gpu->fault_stall_lock, irq_flags);
@@ -314,7 +317,7 @@ int adreno_fault_handler(struct msm_gpu *gpu, unsigned long iova, int flags,* it now. */ if (!do_devcoredump) { - gpu->vm->mmu->funcs->resume_translation (gpu->vm->mmu); + mmu->funcs->resume_translation (mmu); }/*
@@ -409,7 +412,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx,return 0 ;case MSM_PARAM_FAULTS :if (ctx->vm) - *value = gpu->global_faults + ctx->vm->faults; + *value = gpu->global_faults +to_msm_vm (ctx->vm)->faults;else *value = gpu->global_faults;return 0 ;
@@ -419,12 +422,12 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx,case MSM_PARAM_VA_START :if (ctx->vm == gpu->vm)return UERR (EINVAL , drm,"requires per-process pgtables" ); - *value = ctx->vm->base.mm_start; + *value = ctx->vm->mm_start;return 0 ;case MSM_PARAM_VA_SIZE :if (ctx->vm == gpu->vm)return UERR (EINVAL , drm,"requires per-process pgtables" ); - *value = ctx->vm->base.mm_range; + *value = ctx->vm->mm_range;return 0 ;case MSM_PARAM_HIGHEST_BANK_BIT : *value = adreno_gpu->ubwc_config.highest_bank_bit;
drivers/gpu/drm/msm/adreno/adreno_gpu.h +2 -2
@@ -644,11 +644,11 @@ void adreno_show_object(struct drm_printer *p, void **ptr, int len,* Common helper function to initialize the default address space for arm-smmu * attached targets */ -struct msm_gem_vm * +struct drm_gpuvm *adreno_create_vm (struct msm_gpu *gpu,struct platform_device *pdev); -struct msm_gem_vm * +struct drm_gpuvm *adreno_iommu_create_vm (struct msm_gpu *gpu,struct platform_device *pdev,unsigned long quirks);
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c +2 -2
@@ -566,7 +566,7 @@ static void dpu_encoder_phys_wb_prepare_wb_job(struct dpu_encoder_phys *phys_enc struct drm_writeback_job *job) {const struct msm_format *format; -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;struct dpu_hw_wb_cfg *wb_cfg;int ret;struct dpu_encoder_phys_wb *wb_enc =to_dpu_encoder_phys_wb (phys_enc);
@@ -619,7 +619,7 @@ static void dpu_encoder_phys_wb_cleanup_wb_job(struct dpu_encoder_phys *phys_enc struct drm_writeback_job *job) {struct dpu_encoder_phys_wb *wb_enc =to_dpu_encoder_phys_wb (phys_enc); -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;if (!job->fb)return ;
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +3 -3
@@ -274,7 +274,7 @@ int dpu_format_populate_plane_sizes(return _dpu_format_populate_plane_sizes_linear (fmt, fb, layout); } -static void _dpu_format_populate_addrs_ubwc (struct msm_gem_vm *vm, +static void _dpu_format_populate_addrs_ubwc (struct drm_gpuvm *vm,struct drm_framebuffer *fb,struct dpu_hw_fmt_layout *layout) {
@@ -355,7 +355,7 @@ static void _dpu_format_populate_addrs_ubwc(struct msm_gem_vm *vm, } } -static void _dpu_format_populate_addrs_linear (struct msm_gem_vm *vm, +static void _dpu_format_populate_addrs_linear (struct drm_gpuvm *vm,struct drm_framebuffer *fb,struct dpu_hw_fmt_layout *layout) {
@@ -373,7 +373,7 @@ static void _dpu_format_populate_addrs_linear(struct msm_gem_vm *vm,* @fb: framebuffer pointer * @layout: format layout structure to populate */ -void dpu_format_populate_addrs (struct msm_gem_vm *vm, +void dpu_format_populate_addrs (struct drm_gpuvm *vm,struct drm_framebuffer *fb,struct dpu_hw_fmt_layout *layout) {
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h +1 -1
@@ -31,7 +31,7 @@ static inline bool dpu_find_format(u32 format, const u32 *supported_formats,return false; } -void dpu_format_populate_addrs (struct msm_gem_vm *vm, +void dpu_format_populate_addrs (struct drm_gpuvm *vm,struct drm_framebuffer *fb,struct dpu_hw_fmt_layout *layout);
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +3 -3
@@ -1098,17 +1098,17 @@ static void _dpu_kms_mmu_destroy(struct dpu_kms *dpu_kms)if (!dpu_kms->base.vm)return ; - mmu = dpu_kms->base.vm->mmu; + mmu =to_msm_vm (dpu_kms->base.vm)->mmu; mmu->funcs->detach (mmu); -msm_gem_vm_put (dpu_kms->base.vm); +drm_gpuvm_put (dpu_kms->base.vm); dpu_kms->base.vm =NULL ; }static int _dpu_kms_mmu_init (struct dpu_kms *dpu_kms) { -struct msm_gem_vm *vm; +struct drm_gpuvm *vm; vm =msm_kms_init_vm (dpu_kms->dev);if (IS_ERR (vm))
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h +1 -1
@@ -34,7 +34,7 @@*/ struct dpu_plane_state {struct drm_plane_state base; -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;struct dpu_sw_pipe pipe;struct dpu_sw_pipe r_pipe;struct dpu_sw_pipe_cfg pipe_cfg;
drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c +6 -5
@@ -120,15 +120,16 @@ static void mdp4_destroy(struct msm_kms *kms) {struct mdp4_kms *mdp4_kms =to_mdp4_kms (to_mdp_kms (kms));struct device *dev = mdp4_kms->dev->dev; -struct msm_gem_vm *vm = kms->vm;if (mdp4_kms->blank_cursor_iova)msm_gem_unpin_iova (mdp4_kms->blank_cursor_bo, kms->vm);drm_gem_object_put (mdp4_kms->blank_cursor_bo); -if (vm) { - vm->mmu->funcs->detach (vm->mmu); -msm_gem_vm_put (vm); +if (kms->vm) { +struct msm_mmu *mmu =to_msm_vm (kms->vm)->mmu; + + mmu->funcs->detach (mmu); +drm_gpuvm_put (kms->vm); }if (mdp4_kms->rpm_enabled)
@@ -380,7 +381,7 @@ static int mdp4_kms_init(struct drm_device *dev)struct mdp4_kms *mdp4_kms =to_mdp4_kms (to_mdp_kms (priv->kms));struct msm_kms *kms =NULL ;struct msm_mmu *mmu; -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;int ret;u32 major, minor;unsigned long max_clk;
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c +6 -5
@@ -198,11 +198,12 @@ static void mdp5_destroy(struct mdp5_kms *mdp5_kms);static void mdp5_kms_destroy (struct msm_kms *kms) {struct mdp5_kms *mdp5_kms =to_mdp5_kms (to_mdp_kms (kms)); -struct msm_gem_vm *vm = kms->vm; -if (vm) { - vm->mmu->funcs->detach (vm->mmu); -msm_gem_vm_put (vm); +if (kms->vm) { +struct msm_mmu *mmu =to_msm_vm (kms->vm)->mmu; + + mmu->funcs->detach (mmu); +drm_gpuvm_put (kms->vm); }mdp_kms_destroy (&mdp5_kms->base);
@@ -500,7 +501,7 @@ static int mdp5_kms_init(struct drm_device *dev)struct mdp5_kms *mdp5_kms;struct mdp5_cfg *config;struct msm_kms *kms = priv->kms; -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;int i, ret; ret =mdp5_init (to_platform_device (dev->dev), dev);
drivers/gpu/drm/msm/dsi/dsi_host.c +3 -3
@@ -143,7 +143,7 @@ struct msm_dsi_host {/* DSI 6G TX buffer*/ struct drm_gem_object *tx_gem_obj; -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;/* DSI v2 TX buffer */ void *tx_buf;
@@ -1146,7 +1146,7 @@ int dsi_tx_buf_alloc_6g(struct msm_dsi_host *msm_host, int size)uint64_t iova;u8 *data; - msm_host->vm =msm_gem_vm_get (priv->kms->vm); + msm_host->vm =drm_gpuvm_get (priv->kms->vm); data = msm_gem_kernel_new(dev, size, MSM_BO_WC, msm_host->vm,
@@ -1194,7 +1194,7 @@ void msm_dsi_tx_buf_free(struct mipi_dsi_host *host)if (msm_host->tx_gem_obj) {msm_gem_kernel_put (msm_host->tx_gem_obj, msm_host->vm); -msm_gem_vm_put (msm_host->vm); +drm_gpuvm_put (msm_host->vm); msm_host->tx_gem_obj =NULL ; msm_host->vm =NULL ; }
drivers/gpu/drm/msm/msm_drv.h +9 -10
@@ -48,8 +48,6 @@ struct msm_rd_state;struct msm_perf_state ;struct msm_gem_submit ;struct msm_fence_context ; -struct msm_gem_vm ; -struct msm_gem_vma ;struct msm_disp_state ;#define MAX_CRTCS 8
@@ -230,7 +228,7 @@ void msm_crtc_disable_vblank(struct drm_crtc *crtc);int msm_register_mmu (struct drm_device *dev,struct msm_mmu *mmu);void msm_unregister_mmu (struct drm_device *dev,struct msm_mmu *mmu); -struct msm_gem_vm *msm_kms_init_vm (struct drm_device *dev); +struct drm_gpuvm *msm_kms_init_vm (struct drm_device *dev);bool msm_use_mmu (struct drm_device *dev); int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
@@ -251,13 +249,14 @@ struct drm_gem_object *msm_gem_prime_import_sg_table(struct drm_device *dev,int msm_gem_prime_pin (struct drm_gem_object *obj);void msm_gem_prime_unpin (struct drm_gem_object *obj); -int msm_framebuffer_prepare (struct drm_framebuffer *fb, -struct msm_gem_vm *vm,bool needs_dirtyfb); -void msm_framebuffer_cleanup (struct drm_framebuffer *fb, -struct msm_gem_vm *vm,bool needed_dirtyfb); -uint32_t msm_framebuffer_iova (struct drm_framebuffer *fb, -struct msm_gem_vm *vm,int plane); -struct drm_gem_object *msm_framebuffer_bo (struct drm_framebuffer *fb,int plane); +int msm_framebuffer_prepare (struct drm_framebuffer *fb,struct drm_gpuvm *vm, +bool needs_dirtyfb); +void msm_framebuffer_cleanup (struct drm_framebuffer *fb,struct drm_gpuvm *vm, +bool needed_dirtyfb); +uint32_t msm_framebuffer_iova (struct drm_framebuffer *fb,struct drm_gpuvm *vm, +int plane); +struct drm_gem_object *msm_framebuffer_bo (struct drm_framebuffer *fb, +int plane);const struct msm_format *msm_framebuffer_format (struct drm_framebuffer *fb);struct drm_framebuffer *msm_framebuffer_create (struct drm_device *dev,struct drm_file *file,const struct drm_mode_fb_cmd2 *mode_cmd);
drivers/gpu/drm/msm/msm_fb.c +6 -8
@@ -75,9 +75,8 @@ void msm_framebuffer_describe(struct drm_framebuffer *fb, struct seq_file *m)/* prepare/pin all the fb's bo's for scanout. */ -int msm_framebuffer_prepare (struct drm_framebuffer *fb, -struct msm_gem_vm *vm, -bool needs_dirtyfb) +int msm_framebuffer_prepare (struct drm_framebuffer *fb,struct drm_gpuvm *vm, +bool needs_dirtyfb) {struct msm_framebuffer *msm_fb =to_msm_framebuffer (fb);int ret, i, n = fb->format->num_planes;
@@ -98,9 +97,8 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb,return 0 ; } -void msm_framebuffer_cleanup (struct drm_framebuffer *fb, -struct msm_gem_vm *vm, -bool needed_dirtyfb) +void msm_framebuffer_cleanup (struct drm_framebuffer *fb,struct drm_gpuvm *vm, +bool needed_dirtyfb) {struct msm_framebuffer *msm_fb =to_msm_framebuffer (fb);int i, n = fb->format->num_planes;
@@ -115,8 +113,8 @@ void msm_framebuffer_cleanup(struct drm_framebuffer *fb,memset (msm_fb->iova,0 ,sizeof (msm_fb->iova)); } -uint32_t msm_framebuffer_iova (struct drm_framebuffer *fb, -struct msm_gem_vm *vm,int plane) +uint32_t msm_framebuffer_iova (struct drm_framebuffer *fb,struct drm_gpuvm *vm, +int plane) {struct msm_framebuffer *msm_fb =to_msm_framebuffer (fb);return msm_fb->iova[plane] + fb->offsets[plane];
drivers/gpu/drm/msm/msm_gem.c +39 -43
214 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gem.h +26 -33
104 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gem_submit.c +3 -3
@@ -264,7 +264,7 @@ static int submit_lock_objects(struct msm_gem_submit *submit) drm_exec_until_all_locked (&submit->exec) { ret =drm_exec_lock_obj (&submit->exec, -drm_gpuvm_resv_obj (&submit->vm->base)); +drm_gpuvm_resv_obj (submit->vm));drm_exec_retry_on_contention (&submit->exec);if (ret) goto error;
@@ -315,7 +315,7 @@ static int submit_pin_objects(struct msm_gem_submit *submit)for (i =0 ; i < submit->nr_bos; i++) {struct drm_gem_object *obj = submit->bos[i].obj; -struct msm_gem_vma *vma; +struct drm_gpuva *vma;/* if locking succeeded, pin bo: */ vma =msm_gem_get_vma_locked (obj, submit->vm);
@@ -328,7 +328,7 @@ static int submit_pin_objects(struct msm_gem_submit *submit)if (ret)break ; - submit->bos[i].iova = vma->base.va.addr; + submit->bos[i].iova = vma->va.addr; }/*
drivers/gpu/drm/msm/msm_gem_vma.c +29 -41
140 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gpu.c +12 -9
@@ -283,7 +283,7 @@ static void msm_gpu_crashstate_capture(struct msm_gpu *gpu,if (state->fault_info.ttbr0) {struct msm_gpu_fault_info *info = &state->fault_info; -struct msm_mmu *mmu = submit->vm->mmu; +struct msm_mmu *mmu =to_msm_vm (submit->vm)->mmu;msm_iommu_pagetable_params (mmu, &info->pgtbl_ttbr0, &info->asid);
@@ -387,7 +387,7 @@ static void recover_worker(struct kthread_work *work)/* Increment the fault counts */ submit->queue->faults++;if (submit->vm) - submit->vm->faults++; +to_msm_vm (submit->vm)->faults++;get_comm_cmdline (submit, &comm, &cmd);
@@ -463,6 +463,7 @@ static void fault_worker(struct kthread_work *work) { struct msm_gpu *gpu = container_of(work, struct msm_gpu, fault_work);struct msm_gem_submit *submit; +struct msm_mmu *mmu =to_msm_vm (gpu->vm)->mmu;struct msm_ringbuffer *cur_ring = gpu->funcs->active_ring (gpu);char *comm =NULL , *cmd =NULL ;
@@ -492,7 +493,7 @@ static void fault_worker(struct kthread_work *work) resume_smmu:memset (&gpu->fault_info,0 ,sizeof (gpu->fault_info)); - gpu->vm->mmu->funcs->resume_translation (gpu->vm->mmu); + mmu->funcs->resume_translation (mmu);mutex_unlock (&gpu->lock); }
@@ -829,10 +830,11 @@ static int get_clocks(struct platform_device *pdev, struct msm_gpu *gpu) }/* Return a new address space for a msm_drm_private instance */ -struct msm_gem_vm * +struct drm_gpuvm *msm_gpu_create_private_vm (struct msm_gpu *gpu,struct task_struct *task) { -struct msm_gem_vm *vm =NULL ; +struct drm_gpuvm *vm =NULL ; +if (!gpu)return NULL ;
@@ -843,11 +845,11 @@ msm_gpu_create_private_vm(struct msm_gpu *gpu, struct task_struct *task)if (gpu->funcs->create_private_vm) { vm = gpu->funcs->create_private_vm (gpu);if (!IS_ERR (vm)) - vm->pid =get_pid (task_pid (task)); +to_msm_vm (vm)->pid =get_pid (task_pid (task)); }if (IS_ERR_OR_NULL (vm)) - vm =msm_gem_vm_get (gpu->vm); + vm =drm_gpuvm_get (gpu->vm);return vm; }
@@ -1016,8 +1018,9 @@ void msm_gpu_cleanup(struct msm_gpu *gpu)msm_gem_kernel_put (gpu->memptrs_bo, gpu->vm);if (!IS_ERR_OR_NULL (gpu->vm)) { - gpu->vm->mmu->funcs->detach (gpu->vm->mmu); -msm_gem_vm_put (gpu->vm); +struct msm_mmu *mmu =to_msm_vm (gpu->vm)->mmu; + mmu->funcs->detach (mmu); +drm_gpuvm_put (gpu->vm); }if (gpu->worker) {
drivers/gpu/drm/msm/msm_gpu.h +5 -5
@@ -78,8 +78,8 @@ struct msm_gpu_funcs {/* note: gpu_set_freq() can assume that we have been pm_resumed */ void (*gpu_set_freq)(struct msm_gpu *gpu,struct dev_pm_opp *opp,bool suspended); -struct msm_gem_vm *(*create_vm)(struct msm_gpu *gpu,struct platform_device *pdev); -struct msm_gem_vm *(*create_private_vm)(struct msm_gpu *gpu); +struct drm_gpuvm *(*create_vm)(struct msm_gpu *gpu,struct platform_device *pdev); +struct drm_gpuvm *(*create_private_vm)(struct msm_gpu *gpu);uint32_t (*get_rptr)(struct msm_gpu *gpu,struct msm_ringbuffer *ring);/**
@@ -234,7 +234,7 @@ struct msm_gpu {void __iomem *mmio;int irq; -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;/* Power Control: */ struct regulator *gpu_reg, *gpu_cx;
@@ -363,7 +363,7 @@ struct msm_context {int queueid;/** @vm: the per-process GPU address-space */ -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;/** @kref: the reference count */ struct kref ref;
@@ -673,7 +673,7 @@ int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev, struct msm_gpu *gpu, const struct msm_gpu_funcs *funcs, const char *name, struct msm_gpu_config *config); -struct msm_gem_vm * +struct drm_gpuvm *msm_gpu_create_private_vm (struct msm_gpu *gpu,struct task_struct *task);void msm_gpu_cleanup (struct msm_gpu *gpu);
drivers/gpu/drm/msm/msm_kms.c +3 -3
@@ -176,9 +176,9 @@ static int msm_kms_fault_handler(void *arg, unsigned long iova, int flags, voidreturn -ENOSYS ; } -struct msm_gem_vm *msm_kms_init_vm (struct drm_device *dev) +struct drm_gpuvm *msm_kms_init_vm (struct drm_device *dev) { -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;struct msm_mmu *mmu;struct device *mdp_dev = dev->dev;struct device *mdss_dev = mdp_dev->parent;
@@ -212,7 +212,7 @@ struct msm_gem_vm *msm_kms_init_vm(struct drm_device *dev)return vm; } -msm_mmu_set_fault_handler (vm->mmu, kms, msm_kms_fault_handler); +msm_mmu_set_fault_handler (to_msm_vm (vm)->mmu, kms, msm_kms_fault_handler);return vm; }
drivers/gpu/drm/msm/msm_kms.h +1 -1
@@ -139,7 +139,7 @@ struct msm_kms {atomic_t fault_snapshot_capture;/* mapper-id used to request GEM buffer mapped for scanout: */ -struct msm_gem_vm *vm; +struct drm_gpuvm *vm;/* disp snapshot support */ struct kthread_worker *dump_worker;
drivers/gpu/drm/msm/msm_submitqueue.c +1 -1
@@ -59,7 +59,7 @@ void __msm_context_destroy(struct kref *kref)kfree (ctx->entities[i]); } -msm_gem_vm_put (ctx->vm); +drm_gpuvm_put (ctx->vm);kfree (ctx->comm);kfree (ctx->cmdline);kfree (ctx);
Signature · 1 line
2.49.0
PATCH v4 16/40 drm/msm: Split out helper to get iommu prot flags
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
We'll re-use this in the vm_bind path.
--- drivers/gpu/drm/msm/msm_gem.c | 12 ++++++++++-- drivers/gpu/drm/msm/msm_gem.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +10 -2
@@ -444,10 +444,9 @@ static struct drm_gpuva *get_vma_locked(struct drm_gem_object *obj,return vma; } -int msm_gem_pin_vma_locked (struct drm_gem_object *obj,struct drm_gpuva *vma) +int msm_gem_prot (struct drm_gem_object *obj) {struct msm_gem_object *msm_obj =to_msm_bo (obj); -struct page **pages;int prot =IOMMU_READ ;if (!(msm_obj->flags &MSM_BO_GPU_READONLY ))
@@ -463,6 +462,15 @@ int msm_gem_pin_vma_locked(struct drm_gem_object *obj, struct drm_gpuva *vma)else if (prot ==2 ) prot |=IOMMU_USE_LLC_NWA ; +return prot; +} + +int msm_gem_pin_vma_locked (struct drm_gem_object *obj,struct drm_gpuva *vma) +{ +struct msm_gem_object *msm_obj =to_msm_bo (obj); +struct page **pages; +int prot =msm_gem_prot (obj); +msm_gem_assert_locked (obj); pages =msm_gem_get_pages_locked (obj,MSM_MADV_WILLNEED );
drivers/gpu/drm/msm/msm_gem.h +1 -0
@@ -158,6 +158,7 @@ struct msm_gem_object {#define to_msm_bo (x) container_of(x, struct msm_gem_object, base)uint64_t msm_gem_mmap_offset (struct drm_gem_object *obj); +int msm_gem_prot (struct drm_gem_object *obj);int msm_gem_pin_vma_locked (struct drm_gem_object *obj,struct drm_gpuva *vma);void msm_gem_unpin_locked (struct drm_gem_object *obj);void msm_gem_unpin_active (struct drm_gem_object *obj);
Signature · 1 line
2.49.0
PATCH v4 17/40 drm/msm: Add mmu support for non-zero offset
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Only needs to be supported for iopgtables mmu, the other cases are either only used for kernel managed mappings (where offset is always zero) or devices which do not support sparse bindings.
--- drivers/gpu/drm/msm/adreno/a2xx_gpummu.c | 5 ++++- drivers/gpu/drm/msm/msm_gem.c | 4 ++-- drivers/gpu/drm/msm/msm_gem.h | 4 ++-- drivers/gpu/drm/msm/msm_gem_vma.c | 13 +++++++------ drivers/gpu/drm/msm/msm_iommu.c | 22 ++++++++++++++++++++-- drivers/gpu/drm/msm/msm_mmu.h | 2 +- 6 files changed, 36 insertions(+), 14 deletions(-)
drivers/gpu/drm/msm/adreno/a2xx_gpummu.c +4 -1
@@ -29,13 +29,16 @@ static void a2xx_gpummu_detach(struct msm_mmu *mmu) }static int a2xx_gpummu_map (struct msm_mmu *mmu,uint64_t iova, -struct sg_table *sgt,size_t len,int prot) +struct sg_table *sgt,size_t off,size_t len, +int prot) {struct a2xx_gpummu *gpummu =to_a2xx_gpummu (mmu);unsigned idx = (iova -GPUMMU_VA_START ) /GPUMMU_PAGE_SIZE ;struct sg_dma_page_iter dma_iter;unsigned prot_bits =0 ; +WARN_ON (off !=0 ); +if (prot &IOMMU_WRITE ) prot_bits |=1 ;if (prot &IOMMU_READ )
drivers/gpu/drm/msm/msm_gem.c +2 -2
@@ -435,7 +435,7 @@ static struct drm_gpuva *get_vma_locked(struct drm_gem_object *obj, vma =lookup_vma (obj, vm);if (!vma) { - vma =msm_gem_vma_new (vm, obj, range_start, range_end); + vma =msm_gem_vma_new (vm, obj,0 , range_start, range_end); }else {GEM_WARN_ON (vma->va.addr < range_start);GEM_WARN_ON ((vma->va.addr + obj->size) > range_end);
@@ -477,7 +477,7 @@ int msm_gem_pin_vma_locked(struct drm_gem_object *obj, struct drm_gpuva *vma)if (IS_ERR (pages))return PTR_ERR (pages); -return msm_gem_vma_map (vma, prot, msm_obj->sgt, obj->size); +return msm_gem_vma_map (vma, prot, msm_obj->sgt); }void msm_gem_unpin_locked (struct drm_gem_object *obj)
drivers/gpu/drm/msm/msm_gem.h +2 -2
@@ -110,9 +110,9 @@ struct msm_gem_vma {struct drm_gpuva *msm_gem_vma_new (struct drm_gpuvm *vm,struct drm_gem_object *obj, -u64 range_start,u64 range_end); +u64 offset,u64 range_start,u64 range_end);void msm_gem_vma_purge (struct drm_gpuva *vma); -int msm_gem_vma_map (struct drm_gpuva *vma,int prot,struct sg_table *sgt,int size); +int msm_gem_vma_map (struct drm_gpuva *vma,int prot,struct sg_table *sgt);void msm_gem_vma_close (struct drm_gpuva *vma);struct msm_gem_object {
drivers/gpu/drm/msm/msm_gem_vma.c +7 -6
@@ -38,8 +38,7 @@ void msm_gem_vma_purge(struct drm_gpuva *vma)/* Map and pin vma: */ int -msm_gem_vma_map (struct drm_gpuva *vma,int prot, -struct sg_table *sgt,int size) +msm_gem_vma_map (struct drm_gpuva *vma,int prot,struct sg_table *sgt) {struct msm_gem_vma *msm_vma =to_msm_vma (vma);struct msm_gem_vm *vm =to_msm_vm (vma->vm);
@@ -62,8 +61,9 @@ msm_gem_vma_map(struct drm_gpuva *vma, int prot,* Revisit this if we can come up with a scheme to pre-alloc pages * for the pgtable in map/unmap ops. */ - ret = vm->mmu->funcs->map (vm->mmu, vma->va.addr, sgt, size, prot); - + ret = vm->mmu->funcs->map (vm->mmu, vma->va.addr, sgt, + vma->gem.offset, vma->va.range, + prot);if (ret) { msm_vma->mapped = false; }
@@ -93,7 +93,7 @@ void msm_gem_vma_close(struct drm_gpuva *vma)/* Create a new vma and allocate an iova for it */ struct drm_gpuva *msm_gem_vma_new (struct drm_gpuvm *gpuvm,struct drm_gem_object *obj, -u64 range_start,u64 range_end) +u64 offset,u64 range_start,u64 range_end) {struct msm_gem_vm *vm =to_msm_vm (gpuvm);struct drm_gpuvm_bo *vm_bo;
@@ -107,6 +107,7 @@ msm_gem_vma_new(struct drm_gpuvm *gpuvm, struct drm_gem_object *obj,return ERR_PTR (-ENOMEM );if (vm->managed) { +BUG_ON (offset !=0 ); ret =drm_mm_insert_node_in_range (&vm->mm, &vma->node, obj->size,PAGE_SIZE ,0 , range_start, range_end,0 );
@@ -120,7 +121,7 @@ msm_gem_vma_new(struct drm_gpuvm *gpuvm, struct drm_gem_object *obj,GEM_WARN_ON ((range_end - range_start) > obj->size); -drm_gpuva_init (&vma->base, range_start, range_end - range_start, obj,0 ); +drm_gpuva_init (&vma->base, range_start, range_end - range_start, obj, offset); vma->mapped = false; ret =drm_gpuva_insert (&vm->base, &vma->base);
drivers/gpu/drm/msm/msm_iommu.c +20 -2
@@ -113,7 +113,8 @@ static int msm_iommu_pagetable_unmap(struct msm_mmu *mmu, u64 iova, }static int msm_iommu_pagetable_map (struct msm_mmu *mmu,u64 iova, -struct sg_table *sgt,size_t len,int prot) +struct sg_table *sgt,size_t off,size_t len, +int prot) {struct msm_iommu_pagetable *pagetable =to_pagetable (mmu);struct io_pgtable_ops *ops = pagetable->pgtbl_ops;
@@ -125,6 +126,19 @@ static int msm_iommu_pagetable_map(struct msm_mmu *mmu, u64 iova,size_t size = sg->length;phys_addr_t phys =sg_phys (sg); +if (!len) +break ; + +if (size <= off) { + off -= size; +continue ; + } + + phys += off; + size -= off; + size =min_t (size_t, size, len); + off =0 ; +while (size) {size_t pgsize, count, mapped =0 ;int ret;
@@ -140,6 +154,7 @@ static int msm_iommu_pagetable_map(struct msm_mmu *mmu, u64 iova, phys += mapped; addr += mapped; size -= mapped; + len -= mapped;if (ret) {msm_iommu_pagetable_unmap (mmu, iova, addr - iova);
@@ -400,11 +415,14 @@ static void msm_iommu_detach(struct msm_mmu *mmu) }static int msm_iommu_map (struct msm_mmu *mmu,uint64_t iova, -struct sg_table *sgt,size_t len,int prot) +struct sg_table *sgt,size_t off,size_t len, +int prot) {struct msm_iommu *iommu =to_msm_iommu (mmu);size_t ret; +WARN_ON (off !=0 ); +/* The arm-smmu driver expects the addresses to be sign extended */ if (iova &BIT_ULL (48 )) iova |=GENMASK_ULL (63 ,49 );
drivers/gpu/drm/msm/msm_mmu.h +1 -1
@@ -12,7 +12,7 @@struct msm_mmu_funcs {void (*detach)(struct msm_mmu *mmu);int (*map)(struct msm_mmu *mmu,uint64_t iova,struct sg_table *sgt, -size_t len,int prot); +size_t off,size_t len,int prot);int (*unmap)(struct msm_mmu *mmu,uint64_t iova,size_t len);void (*destroy)(struct msm_mmu *mmu);void (*resume_translation)(struct msm_mmu *mmu);
Signature · 1 line
2.49.0
PATCH v4 18/40 drm/msm: Add PRR support
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Add PRR (Partial Resident Region) is a bypass address which make GPU writes go to /dev/null and reads return zero. This is used to implement vulkan sparse residency.
To support PRR/NULL mappings, we allocate a page to reserve a physical address which we know will not be used as part of a GEM object, and configure the SMMU to use this address for PRR/NULL mappings.
--- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 ++++ drivers/gpu/drm/msm/msm_iommu.c | 62 ++++++++++++++++++++++++- include/uapi/drm/msm_drm.h | 2 + 3 files changed, 73 insertions(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/adreno_gpu.c +10 -0
@@ -361,6 +361,13 @@ int adreno_fault_handler(struct msm_gpu *gpu, unsigned long iova, int flags,return 0 ; } +static bool +adreno_smmu_has_prr (struct msm_gpu *gpu) +{ +struct adreno_smmu_priv *adreno_smmu =dev_get_drvdata (&gpu->pdev->dev); +return adreno_smmu && adreno_smmu->set_prr_addr; +} +int adreno_get_param (struct msm_gpu *gpu,struct msm_context *ctx,uint32_t param,uint64_t *value,uint32_t *len) {
@@ -444,6 +451,9 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx,case MSM_PARAM_UCHE_TRAP_BASE : *value = adreno_gpu->uche_trap_base;return 0 ; +case MSM_PARAM_HAS_PRR : + *value =adreno_smmu_has_prr (gpu); +return 0 ;default :return UERR (EINVAL , drm,"%s: invalid param: %u" , gpu->name, param); }
drivers/gpu/drm/msm/msm_iommu.c +61 -1
94 lines not on this page · raw message
include/uapi/drm/msm_drm.h +2 -0
@@ -91,6 +91,8 @@ struct drm_msm_timespec {#define MSM_PARAM_UBWC_SWIZZLE 0x12/* RO */ #define MSM_PARAM_MACROTILE_MODE 0x13/* RO */ #define MSM_PARAM_UCHE_TRAP_BASE 0x14/* RO */ +/* PRR (Partially Resident Region) is required for sparse residency: */ +#define MSM_PARAM_HAS_PRR 0x15/* RO */ /* For backwards compat. The original support for preemption was based on * a single ring per priority level so # of priority levels equals the #
Signature · 1 line
2.49.0
PATCH v4 19/40 drm/msm: Rename msm_gem_vma_purge() -> _unmap()
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
This is a more descriptive name.
--- drivers/gpu/drm/msm/msm_gem.c | 4 ++-- drivers/gpu/drm/msm/msm_gem.h | 2 +- drivers/gpu/drm/msm/msm_gem_vma.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +2 -2
@@ -415,7 +415,7 @@ put_iova_spaces(struct drm_gem_object *obj, struct drm_gpuvm *vm, bool close)drm_gpuvm_bo_get (vm_bo); drm_gpuvm_bo_for_each_va_safe (vma, vmatmp, vm_bo) { -msm_gem_vma_purge (vma); +msm_gem_vma_unmap (vma);if (close)msm_gem_vma_close (vma); }
@@ -593,7 +593,7 @@ static int clear_iova(struct drm_gem_object *obj,if (!vma)return 0 ; -msm_gem_vma_purge (vma); +msm_gem_vma_unmap (vma);msm_gem_vma_close (vma);return 0 ;
drivers/gpu/drm/msm/msm_gem.h +1 -1
@@ -111,7 +111,7 @@ struct msm_gem_vma {struct drm_gpuva *msm_gem_vma_new (struct drm_gpuvm *vm,struct drm_gem_object *obj,u64 offset,u64 range_start,u64 range_end); -void msm_gem_vma_purge (struct drm_gpuva *vma); +void msm_gem_vma_unmap (struct drm_gpuva *vma);int msm_gem_vma_map (struct drm_gpuva *vma,int prot,struct sg_table *sgt);void msm_gem_vma_close (struct drm_gpuva *vma);
drivers/gpu/drm/msm/msm_gem_vma.c +1 -1
@@ -21,7 +21,7 @@ msm_gem_vm_free(struct drm_gpuvm *gpuvm) }/* Actually unmap memory for the vma */ -void msm_gem_vma_purge (struct drm_gpuva *vma) +void msm_gem_vma_unmap (struct drm_gpuva *vma) {struct msm_gem_vma *msm_vma =to_msm_vma (vma);struct msm_gem_vm *vm =to_msm_vm (vma->vm);
Signature · 1 line
2.49.0
PATCH v4 20/40 drm/msm: Drop queued submits on lastclose()
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
If we haven't written the submit into the ringbuffer yet, then drop it. The submit still retires through the normal path, to preserve fence signalling order, but we can skip the IB's to userspace cmdstream.
--- drivers/gpu/drm/msm/msm_drv.c | 1 + drivers/gpu/drm/msm/msm_gpu.h | 8 ++++++++ drivers/gpu/drm/msm/msm_ringbuffer.c | 6 ++++++ 3 files changed, 15 insertions(+)
drivers/gpu/drm/msm/msm_drv.c +1 -0
@@ -250,6 +250,7 @@ static int msm_open(struct drm_device *dev, struct drm_file *file)static void context_close (struct msm_context *ctx) { + ctx->closed = true;msm_submitqueue_close (ctx);msm_context_put (ctx); }
drivers/gpu/drm/msm/msm_gpu.h +8 -0
@@ -362,6 +362,14 @@ struct msm_context {*/ int queueid; +/** +* @closed: The device file associated with this context has been closed. +* +* Once the device is closed, any submits that have not been written +* to the ring buffer are no-op'd. +*/ +bool closed; +/** @vm: the per-process GPU address-space */ struct drm_gpuvm *vm;
drivers/gpu/drm/msm/msm_ringbuffer.c +6 -0
@@ -17,6 +17,7 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job)struct msm_fence_context *fctx = submit->ring->fctx;struct msm_gpu *gpu = submit->gpu;struct msm_drm_private *priv = gpu->dev->dev_private; +unsigned nr_cmds = submit->nr_cmds;int i;msm_fence_init (submit->hw_fence, fctx);
@@ -36,8 +37,13 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job)/* TODO move submit path over to using a per-ring lock.. */ mutex_lock (&gpu->lock); +if (submit->queue->ctx->closed) + submit->nr_cmds =0 ; +msm_gpu_submit (gpu, submit); + submit->nr_cmds = nr_cmds; +mutex_unlock (&gpu->lock);return dma_fence_get (submit->hw_fence);
Signature · 1 line
2.49.0
PATCH v4 21/40 drm/msm: Lazily create context VM
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
In the next commit, a way for userspace to opt-in to userspace managed VM is added. For this to work, we need to defer creation of the VM until it is needed.
--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 3 ++- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 14 +++++++----- drivers/gpu/drm/msm/msm_drv.c | 29 ++++++++++++++++++++----- drivers/gpu/drm/msm/msm_gem_submit.c | 2 +- drivers/gpu/drm/msm/msm_gpu.h | 9 +++++++- 5 files changed, 43 insertions(+), 14 deletions(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +2 -1
@@ -112,6 +112,7 @@ static void a6xx_set_pagetable(struct a6xx_gpu *a6xx_gpu, {bool sysprof =refcount_read (&a6xx_gpu->base.base.sysprof_active) >1 ;struct msm_context *ctx = submit->queue->ctx; +struct drm_gpuvm *vm =msm_context_vm (submit->dev, ctx);struct adreno_gpu *adreno_gpu = &a6xx_gpu->base;phys_addr_t ttbr;u32 asid;
@@ -120,7 +121,7 @@ static void a6xx_set_pagetable(struct a6xx_gpu *a6xx_gpu,if (ctx->seqno == ring->cur_ctx_seqno)return ; -if (msm_iommu_pagetable_params (to_msm_vm (ctx->vm)->mmu, &ttbr, &asid)) +if (msm_iommu_pagetable_params (to_msm_vm (vm)->mmu, &ttbr, &asid))return ;if (adreno_gpu->info->family >=ADRENO_7XX_GEN1 ) {
drivers/gpu/drm/msm/adreno/adreno_gpu.c +8 -6
@@ -373,6 +373,8 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx, {struct adreno_gpu *adreno_gpu =to_adreno_gpu (gpu);struct drm_device *drm = gpu->dev; +/* Note ctx can be NULL when called from rd_open(): */ +struct drm_gpuvm *vm = ctx ?msm_context_vm (drm, ctx) :NULL ;/* No pointer params yet */ if (*len !=0 )
@@ -418,8 +420,8 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx, *value =0 ;return 0 ;case MSM_PARAM_FAULTS : -if (ctx->vm) - *value = gpu->global_faults +to_msm_vm (ctx->vm)->faults; +if (vm) + *value = gpu->global_faults +to_msm_vm (vm)->faults;else *value = gpu->global_faults;return 0 ;
@@ -427,14 +429,14 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx, *value = gpu->suspend_count;return 0 ;case MSM_PARAM_VA_START : -if (ctx->vm == gpu->vm) +if (vm == gpu->vm)return UERR (EINVAL , drm,"requires per-process pgtables" ); - *value = ctx->vm->mm_start; + *value = vm->mm_start;return 0 ;case MSM_PARAM_VA_SIZE : -if (ctx->vm == gpu->vm) +if (vm == gpu->vm)return UERR (EINVAL , drm,"requires per-process pgtables" ); - *value = ctx->vm->mm_range; + *value = vm->mm_range;return 0 ;case MSM_PARAM_HIGHEST_BANK_BIT : *value = adreno_gpu->ubwc_config.highest_bank_bit;
drivers/gpu/drm/msm/msm_drv.c +24 -5
@@ -214,10 +214,29 @@ static void load_gpu(struct drm_device *dev)mutex_unlock (&init_lock); } +/** +* msm_context_vm - lazily create the context's VM +* +* @dev: the drm device +* @ctx: the context +* +* The VM is lazily created, so that userspace has a chance to opt-in to having +* a userspace managed VM before the VM is created. +* +* Note that this does not return a reference to the VM. Once the VM is created, +* it exists for the lifetime of the context. +*/ +struct drm_gpuvm *msm_context_vm (struct drm_device *dev,struct msm_context *ctx) +{ +struct msm_drm_private *priv = dev->dev_private; +if (!ctx->vm) + ctx->vm =msm_gpu_create_private_vm (priv->gpu, current); +return ctx->vm; +} +static int context_init (struct drm_device *dev,struct drm_file *file) {static atomic_t ident =ATOMIC_INIT (0 ); -struct msm_drm_private *priv = dev->dev_private;struct msm_context *ctx; ctx =kzalloc (sizeof (*ctx),GFP_KERNEL );
@@ -230,7 +249,6 @@ static int context_init(struct drm_device *dev, struct drm_file *file)kref_init (&ctx->ref);msm_submitqueue_init (dev, ctx); - ctx->vm =msm_gpu_create_private_vm (priv->gpu, current); file->driver_priv = ctx; ctx->seqno =atomic_inc_return (&ident);
@@ -409,7 +427,7 @@ static int msm_ioctl_gem_info_iova(struct drm_device *dev,* Don't pin the memory here - just get an address so that userspace can * be productive */ -return msm_gem_get_iova (obj, ctx->vm, iova); +return msm_gem_get_iova (obj,msm_context_vm (dev, ctx), iova); } static int msm_ioctl_gem_info_set_iova(struct drm_device *dev,
@@ -418,18 +436,19 @@ static int msm_ioctl_gem_info_set_iova(struct drm_device *dev, {struct msm_drm_private *priv = dev->dev_private;struct msm_context *ctx = file->driver_priv; +struct drm_gpuvm *vm =msm_context_vm (dev, ctx);if (!priv->gpu)return -EINVAL ;/* Only supported if per-process address space is supported: */ -if (priv->gpu->vm == ctx->vm) +if (priv->gpu->vm == vm)return UERR (EOPNOTSUPP , dev,"requires per-process pgtables" );if (should_fail (&fail_gem_iova, obj->size))return -ENOMEM ; -return msm_gem_set_iova (obj, ctx->vm, iova); +return msm_gem_set_iova (obj, vm, iova); } static int msm_ioctl_gem_info_set_metadata(struct drm_gem_object *obj,
drivers/gpu/drm/msm/msm_gem_submit.c +1 -1
@@ -63,7 +63,7 @@ static struct msm_gem_submit *submit_create(struct drm_device *dev,kref_init (&submit->ref); submit->dev = dev; - submit->vm = queue->ctx->vm; + submit->vm =msm_context_vm (dev, queue->ctx); submit->gpu = gpu; submit->cmd = (void *)&submit->bos[nr_bos]; submit->queue = queue;
drivers/gpu/drm/msm/msm_gpu.h +8 -1
@@ -370,7 +370,12 @@ struct msm_context {*/ bool closed; -/** @vm: the per-process GPU address-space */ +/** +* @vm: +* +* The per-process GPU address-space. Do not access directly, use +* msm_context_vm(). +*/ struct drm_gpuvm *vm;/** @kref: the reference count */
@@ -455,6 +460,8 @@ struct msm_context {atomic64_t ctx_mem; }; +struct drm_gpuvm *msm_context_vm (struct drm_device *dev,struct msm_context *ctx); +/** * msm_gpu_convert_priority - Map userspace priority to ring # and sched priority *
Signature · 1 line
2.49.0
PATCH v4 22/40 drm/msm: Add opt-in for VM_BIND
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Add a SET_PARAM for userspace to request to manage to the VM itself, instead of getting a kernel managed VM.
In order to transition to a userspace managed VM, this param must be set before any mappings are created.
--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 15 +++++++++++++ drivers/gpu/drm/msm/msm_drv.c | 22 +++++++++++++++++-- drivers/gpu/drm/msm/msm_gem.c | 8 +++++++ drivers/gpu/drm/msm/msm_gpu.c | 5 +++-- drivers/gpu/drm/msm/msm_gpu.h | 29 +++++++++++++++++++++++-- include/uapi/drm/msm_drm.h | 24 ++++++++++++++++++++ 7 files changed, 99 insertions(+), 8 deletions(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +2 -2
@@ -2263,7 +2263,7 @@ a6xx_create_vm(struct msm_gpu *gpu, struct platform_device *pdev) }static struct drm_gpuvm * -a6xx_create_private_vm (struct msm_gpu *gpu) +a6xx_create_private_vm (struct msm_gpu *gpu,bool kernel_managed) {struct msm_mmu *mmu;
@@ -2273,7 +2273,7 @@ a6xx_create_private_vm(struct msm_gpu *gpu)return ERR_CAST (mmu);return msm_gem_vm_create (gpu->dev, mmu,"gpu" ,ADRENO_VM_START , -adreno_private_vm_size (gpu), true); +adreno_private_vm_size (gpu), kernel_managed); }static uint32_t a6xx_get_rptr (struct msm_gpu *gpu,struct msm_ringbuffer *ring)
drivers/gpu/drm/msm/adreno/adreno_gpu.c +15 -0
@@ -508,6 +508,21 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx,if (!capable (CAP_SYS_ADMIN ))return UERR (EPERM , drm,"invalid permissions" );return msm_context_set_sysprof (ctx, gpu, value); +case MSM_PARAM_EN_VM_BIND : +/* We can only support VM_BIND with per-process pgtables: */ +if (ctx->vm == gpu->vm) +return UERR (EINVAL , drm,"requires per-process pgtables" ); + +/* +* We can only swtich to VM_BIND mode if the VM has not yet +* been created: +*/ +if (ctx->vm) +return UERR (EBUSY , drm,"VM already created" ); + + ctx->userspace_managed_vm = value; + +return 0 ;default :return UERR (EINVAL , drm,"%s: invalid param: %u" , gpu->name, param); }
drivers/gpu/drm/msm/msm_drv.c +20 -2
@@ -228,9 +228,21 @@ static void load_gpu(struct drm_device *dev)*/ struct drm_gpuvm *msm_context_vm (struct drm_device *dev,struct msm_context *ctx) { +static DEFINE_MUTEX (init_lock);struct msm_drm_private *priv = dev->dev_private; -if (!ctx->vm) - ctx->vm =msm_gpu_create_private_vm (priv->gpu, current); + +/* Once ctx->vm is created it is valid for the lifetime of the context: */ +if (ctx->vm) +return ctx->vm; + +mutex_lock (&init_lock); +if (!ctx->vm) { + ctx->vm =msm_gpu_create_private_vm ( + priv->gpu, current, !ctx->userspace_managed_vm); + + } +mutex_unlock (&init_lock); +return ctx->vm; }
@@ -420,6 +432,9 @@ static int msm_ioctl_gem_info_iova(struct drm_device *dev,if (!priv->gpu)return -EINVAL ; +if (msm_context_is_vmbind (ctx)) +return UERR (EINVAL , dev,"VM_BIND is enabled" ); +if (should_fail (&fail_gem_iova, obj->size))return -ENOMEM ;
@@ -441,6 +456,9 @@ static int msm_ioctl_gem_info_set_iova(struct drm_device *dev,if (!priv->gpu)return -EINVAL ; +if (msm_context_is_vmbind (ctx)) +return UERR (EINVAL , dev,"VM_BIND is enabled" ); +/* Only supported if per-process address space is supported: */ if (priv->gpu->vm == vm)return UERR (EOPNOTSUPP , dev,"requires per-process pgtables" );
drivers/gpu/drm/msm/msm_gem.c +8 -0
@@ -64,6 +64,14 @@ static void msm_gem_close(struct drm_gem_object *obj, struct drm_file *file)if (!ctx->vm)return ; +/* +* VM_BIND does not depend on implicit teardown of VMAs on handle +* close, but instead on implicit teardown of the VM when the device +* is closed (see msm_gem_vm_close()) +*/ +if (msm_context_is_vmbind (ctx)) +return ; +/* * TODO we might need to kick this to a queue to avoid blocking * in CLOSE ioctl
drivers/gpu/drm/msm/msm_gpu.c +3 -2
@@ -831,7 +831,8 @@ static int get_clocks(struct platform_device *pdev, struct msm_gpu *gpu)/* Return a new address space for a msm_drm_private instance */ struct drm_gpuvm * -msm_gpu_create_private_vm (struct msm_gpu *gpu,struct task_struct *task) +msm_gpu_create_private_vm (struct msm_gpu *gpu,struct task_struct *task, +bool kernel_managed) {struct drm_gpuvm *vm =NULL ;
@@ -843,7 +844,7 @@ msm_gpu_create_private_vm(struct msm_gpu *gpu, struct task_struct *task)* the global one */ if (gpu->funcs->create_private_vm) { - vm = gpu->funcs->create_private_vm (gpu); + vm = gpu->funcs->create_private_vm (gpu, kernel_managed);if (!IS_ERR (vm))to_msm_vm (vm)->pid =get_pid (task_pid (task)); }
drivers/gpu/drm/msm/msm_gpu.h +27 -2
@@ -79,7 +79,7 @@ struct msm_gpu_funcs {void (*gpu_set_freq)(struct msm_gpu *gpu,struct dev_pm_opp *opp,bool suspended);struct drm_gpuvm *(*create_vm)(struct msm_gpu *gpu,struct platform_device *pdev); -struct drm_gpuvm *(*create_private_vm)(struct msm_gpu *gpu); +struct drm_gpuvm *(*create_private_vm)(struct msm_gpu *gpu,bool kernel_managed);uint32_t (*get_rptr)(struct msm_gpu *gpu,struct msm_ringbuffer *ring);/**
@@ -370,6 +370,14 @@ struct msm_context {*/ bool closed; +/** +* @userspace_managed_vm: +* +* Has userspace opted-in to userspace managed VM (ie. VM_BIND) via +* MSM_PARAM_EN_VM_BIND? +*/ +bool userspace_managed_vm; +/** * @vm: *
@@ -462,6 +470,22 @@ struct msm_context {struct drm_gpuvm *msm_context_vm (struct drm_device *dev,struct msm_context *ctx); +/** +* msm_context_is_vm_bind() - has userspace opted in to VM_BIND? +* +* @ctx: the drm_file context +* +* See MSM_PARAM_EN_VM_BIND. If userspace is managing the VM, it can +* do sparse binding including having multiple, potentially partial, +* mappings in the VM. Therefore certain legacy uabi (ie. GET_IOVA, +* SET_IOVA) are rejected because they don't have a sensible meaning. +*/ +static inline bool +msm_context_is_vmbind (struct msm_context *ctx) +{ +return ctx->userspace_managed_vm; +} +/** * msm_gpu_convert_priority - Map userspace priority to ring # and sched priority *
@@ -689,7 +713,8 @@ int msm_gpu_init(struct drm_device *drm, struct platform_device *pdev, const char *name, struct msm_gpu_config *config);struct drm_gpuvm * -msm_gpu_create_private_vm (struct msm_gpu *gpu,struct task_struct *task); +msm_gpu_create_private_vm (struct msm_gpu *gpu,struct task_struct *task, +bool kernel_managed);void msm_gpu_cleanup (struct msm_gpu *gpu);
include/uapi/drm/msm_drm.h +24 -0
@@ -93,6 +93,30 @@ struct drm_msm_timespec {#define MSM_PARAM_UCHE_TRAP_BASE 0x14/* RO */ /* PRR (Partially Resident Region) is required for sparse residency: */ #define MSM_PARAM_HAS_PRR 0x15/* RO */ +/* MSM_PARAM_EN_VM_BIND is set to 1 to enable VM_BIND ops. +* +* With VM_BIND enabled, userspace is required to allocate iova and use the +* VM_BIND ops for map/unmap ioctls. MSM_INFO_SET_IOVA and MSM_INFO_GET_IOVA +* will be rejected. (The latter does not have a sensible meaning when a BO +* can have multiple and/or partial mappings.) +* +* With VM_BIND enabled, userspace does not include a submit_bo table in the +* SUBMIT ioctl (this will be rejected), the resident set is determined by +* the the VM_BIND ops. +* +* Enabling VM_BIND will fail on devices which do not have per-process pgtables. +* And it is not allowed to disable VM_BIND once it has been enabled. +* +* Enabling VM_BIND should be done (attempted) prior to allocating any BOs or +* submitqueues of type MSM_SUBMITQUEUE_VM_BIND. +* +* Relatedly, when VM_BIND mode is enabled, the kernel will not try to recover +* from GPU faults or failed async VM_BIND ops, in particular because it is +* difficult to communicate to userspace which op failed so that userspace +* could rewind and try again. When the VM is marked unusable, the SUBMIT +* ioctl will throw -EPIPE. +*/ +#define MSM_PARAM_EN_VM_BIND 0x16/* WO, once */ /* For backwards compat. The original support for preemption was based on * a single ring per priority level so # of priority levels equals the #
Signature · 1 line
2.49.0
PATCH v4 23/40 drm/msm: Mark VM as unusable on GPU hangs
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
If userspace has opted-in to VM_BIND, then GPU hangs and VM_BIND errors will mark the VM as unusable.
--- drivers/gpu/drm/msm/msm_gem.h | 17 +++++++++++++++++ drivers/gpu/drm/msm/msm_gem_submit.c | 3 +++ drivers/gpu/drm/msm/msm_gpu.c | 16 ++++++++++++++-- 3 files changed, 34 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/msm_gem.h +17 -0
@@ -76,6 +76,23 @@ struct msm_gem_vm {/** @managed: is this a kernel managed VM? */ bool managed; + +/** +* @unusable: True if the VM has turned unusable because something +* bad happened during an asynchronous request. +* +* We don't try to recover from such failures, because this implies +* informing userspace about the specific operation that failed, and +* hoping the userspace driver can replay things from there. This all +* sounds very complicated for little gain. +* +* Instead, we should just flag the VM as unusable, and fail any +* further request targeting this VM. +* +* As an analogy, this would be mapped to a VK_ERROR_DEVICE_LOST +* situation, where the logical device needs to be re-created. +*/ +bool unusable; };#define to_msm_vm (x) container_of(x, struct msm_gem_vm, base)
drivers/gpu/drm/msm/msm_gem_submit.c +3 -0
@@ -676,6 +676,9 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,if (args->pad)return -EINVAL ; +if (to_msm_vm (ctx->vm)->unusable) +return UERR (EPIPE , dev,"context is unusable" ); +/* for now, we just have 3d pipe.. eventually this would need to * be more clever to dispatch to appropriate gpu module: */
drivers/gpu/drm/msm/msm_gpu.c +14 -2
@@ -386,8 +386,20 @@ static void recover_worker(struct kthread_work *work)/* Increment the fault counts */ submit->queue->faults++; -if (submit->vm) -to_msm_vm (submit->vm)->faults++; +if (submit->vm) { +struct msm_gem_vm *vm =to_msm_vm (submit->vm); + + vm->faults++; + +/* +* If userspace has opted-in to VM_BIND (and therefore userspace +* management of the VM), faults mark the VM as unusuable. This +* matches vulkan expectations (vulkan is the main target for +* VM_BIND) +*/ +if (!vm->managed) + vm->unusable = true; + }get_comm_cmdline (submit, &comm, &cmd);
Signature · 1 line
2.49.0
PATCH v4 24/40 drm/msm: Add _NO_SHARE flag
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Buffers that are not shared between contexts can share a single resv object. This way drm_gpuvm will not track them as external objects, and submit-time validating overhead will be O(1) for all N non-shared BOs, instead of O(n).
--- drivers/gpu/drm/msm/msm_drv.h | 1 + drivers/gpu/drm/msm/msm_gem.c | 23 +++++++++++++++++++++++ drivers/gpu/drm/msm/msm_gem_prime.c | 15 +++++++++++++++ include/uapi/drm/msm_drm.h | 14 ++++++++++++++ 4 files changed, 53 insertions(+)
drivers/gpu/drm/msm/msm_drv.h +1 -0
@@ -246,6 +246,7 @@ int msm_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map);void msm_gem_prime_vunmap (struct drm_gem_object *obj,struct iosys_map *map);struct drm_gem_object *msm_gem_prime_import_sg_table (struct drm_device *dev,struct dma_buf_attachment *attach,struct sg_table *sg); +struct dma_buf *msm_gem_prime_export (struct drm_gem_object *obj,int flags);int msm_gem_prime_pin (struct drm_gem_object *obj);void msm_gem_prime_unpin (struct drm_gem_object *obj);
drivers/gpu/drm/msm/msm_gem.c +23 -0
@@ -532,6 +532,9 @@ static int get_and_pin_iova_range_locked(struct drm_gem_object *obj,msm_gem_assert_locked (obj); +if (to_msm_bo (obj)->flags &MSM_BO_NO_SHARE ) +return -EINVAL ; + vma =get_vma_locked (obj, vm, range_start, range_end);if (IS_ERR (vma))return PTR_ERR (vma);
@@ -1060,6 +1063,16 @@ static void msm_gem_free_object(struct drm_gem_object *obj)put_pages (obj); } +if (obj->resv != &obj->_resv) { +struct drm_gem_object *r_obj = + container_of(obj->resv, struct drm_gem_object, _resv); + +BUG_ON (!(msm_obj->flags &MSM_BO_NO_SHARE )); + +/* Drop reference we hold to shared resv obj: */ +drm_gem_object_put (r_obj); + } +drm_gem_object_release (obj);kfree (msm_obj->metadata);
@@ -1092,6 +1105,15 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,if (name)msm_gem_object_set_name (obj,"%s" , name); +if (flags &MSM_BO_NO_SHARE ) { +struct msm_context *ctx = file->driver_priv; +struct drm_gem_object *r_obj =drm_gpuvm_resv_obj (ctx->vm); + +drm_gem_object_get (r_obj); + + obj->resv = r_obj->resv; + } + ret =drm_gem_handle_create (file, obj, handle);/* drop reference from allocate - handle holds it now */
@@ -1124,6 +1146,7 @@ static const struct drm_gem_object_funcs msm_gem_object_funcs = { .free = msm_gem_free_object, .open = msm_gem_open, .close = msm_gem_close, + .export = msm_gem_prime_export, .pin = msm_gem_prime_pin, .unpin = msm_gem_prime_unpin, .get_sg_table = msm_gem_prime_get_sg_table,
drivers/gpu/drm/msm/msm_gem_prime.c +15 -0
@@ -16,6 +16,9 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj)struct msm_gem_object *msm_obj =to_msm_bo (obj);int npages = obj->size >>PAGE_SHIFT ; +if (msm_obj->flags &MSM_BO_NO_SHARE ) +return ERR_PTR (-EINVAL ); +if (WARN_ON (!msm_obj->pages))/* should have already pinned! */ return ERR_PTR (-ENOMEM );
@@ -45,6 +48,15 @@ struct drm_gem_object *msm_gem_prime_import_sg_table(struct drm_device *dev,return msm_gem_import (dev, attach->dmabuf, sg); } + +struct dma_buf *msm_gem_prime_export (struct drm_gem_object *obj,int flags) +{ +if (to_msm_bo (obj)->flags &MSM_BO_NO_SHARE ) +return ERR_PTR (-EPERM ); + +return drm_gem_prime_export (obj, flags); +} +int msm_gem_prime_pin (struct drm_gem_object *obj) {struct page **pages;
@@ -53,6 +65,9 @@ int msm_gem_prime_pin(struct drm_gem_object *obj)if (obj->import_attach)return 0 ; +if (to_msm_bo (obj)->flags &MSM_BO_NO_SHARE ) +return -EINVAL ; + pages =msm_gem_pin_pages_locked (obj);if (IS_ERR (pages)) ret =PTR_ERR (pages);
include/uapi/drm/msm_drm.h +14 -0
@@ -140,6 +140,19 @@ struct drm_msm_param {#define MSM_BO_SCANOUT 0x00000001/* scanout capable */ #define MSM_BO_GPU_READONLY 0x00000002 +/* Private buffers do not need to be explicitly listed in the SUBMIT +* ioctl, unless referenced by a drm_msm_gem_submit_cmd. Private +* buffers may NOT be imported/exported or used for scanout (or any +* other situation where buffers can be indefinitely pinned, but +* cases other than scanout are all kernel owned BOs which are not +* visible to userspace). +* +* In exchange for those constraints, all private BOs associated with +* a single context (drm_file) share a single dma_resv, and if there +* has been no eviction since the last submit, there are no per-BO +* bookeeping to do, significantly cutting the SUBMIT overhead. +*/ +#define MSM_BO_NO_SHARE 0x00000004#define MSM_BO_CACHE_MASK 0x000f0000/* cache modes */ #define MSM_BO_CACHED 0x00010000
@@ -149,6 +162,7 @@ struct drm_msm_param {#define MSM_BO_FLAGS (MSM_BO_SCANOUT | \ MSM_BO_GPU_READONLY | \ + MSM_BO_NO_SHARE | \ MSM_BO_CACHE_MASK)struct drm_msm_gem_new {
Signature · 1 line
2.49.0
PATCH v4 25/40 drm/msm: Crashdump prep for sparse mappings
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
In this case, userspace could request dumping partial GEM obj mappings. Also drop use of should_dump() helper, which really only makes sense in the old submit->bos[] table world.
--- drivers/gpu/drm/msm/msm_gpu.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
drivers/gpu/drm/msm/msm_gpu.c +10 -7
@@ -219,13 +219,14 @@ static void msm_gpu_devcoredump_free(void *data) }static void msm_gpu_crashstate_get_bo (struct msm_gpu_state *state, -struct drm_gem_object *obj,u64 iova,bool full) +struct drm_gem_object *obj,u64 iova, +bool full,size_t offset,size_t size) {struct msm_gpu_state_bo *state_bo = &state->bos[state->nr_bos];struct msm_gem_object *msm_obj =to_msm_bo (obj);/* Don't record write only objects */ - state_bo->size = obj->size; + state_bo->size = size; state_bo->flags = msm_obj->flags; state_bo->iova = iova;
@@ -236,7 +237,7 @@ static void msm_gpu_crashstate_get_bo(struct msm_gpu_state *state,if (full) {void *ptr; - state_bo->data =kvmalloc (obj->size,GFP_KERNEL ); + state_bo->data =kvmalloc (size,GFP_KERNEL );if (!state_bo->data) goto out;
@@ -249,7 +250,7 @@ static void msm_gpu_crashstate_get_bo(struct msm_gpu_state *state, goto out; } -memcpy (state_bo->data, ptr, obj->size); +memcpy (state_bo->data, ptr + offset, size);msm_gem_put_vaddr (obj); } out:
@@ -279,6 +280,7 @@ static void msm_gpu_crashstate_capture(struct msm_gpu *gpu, state->fault_info = gpu->fault_info;if (submit) { +extern bool rd_full;int i;if (state->fault_info.ttbr0) {
@@ -294,9 +296,10 @@ static void msm_gpu_crashstate_capture(struct msm_gpu *gpu, sizeof(struct msm_gpu_state_bo), GFP_KERNEL);for (i =0 ; state->bos && i < submit->nr_bos; i++) { -msm_gpu_crashstate_get_bo (state, submit->bos[i].obj, - submit->bos[i].iova, -should_dump (submit, i)); +struct drm_gem_object *obj = submit->bos[i].obj; +bool dump = rd_full || (submit->bos[i].flags &MSM_SUBMIT_BO_DUMP ); +msm_gpu_crashstate_get_bo (state, obj, submit->bos[i].iova, + dump,0 , obj->size); } }
Signature · 1 line
2.49.0
PATCH v4 26/40 drm/msm: rd dumping prep for sparse mappings
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Similar to the previous commit, add support for dumping partial mappings.
--- drivers/gpu/drm/msm/msm_gem.h | 10 --------- drivers/gpu/drm/msm/msm_rd.c | 38 ++++++++++++++++------------------- 2 files changed, 17 insertions(+), 31 deletions(-)
drivers/gpu/drm/msm/msm_gem.h +0 -10
@@ -402,14 +402,4 @@ static inline void msm_gem_submit_put(struct msm_gem_submit *submit)void msm_submit_retire (struct msm_gem_submit *submit); -/* helper to determine of a buffer in submit should be dumped, used for both -* devcoredump and debugfs cmdstream dumping: -*/ -static inline bool -should_dump (struct msm_gem_submit *submit,int idx) -{ -extern bool rd_full; -return rd_full || (submit->bos[idx].flags &MSM_SUBMIT_BO_DUMP ); -} -#endif /* __MSM_GEM_H__ */
drivers/gpu/drm/msm/msm_rd.c +17 -21
@@ -308,21 +308,11 @@ void msm_rd_debugfs_cleanup(struct msm_drm_private *priv) priv->hangrd =NULL ; } -static void snapshot_buf (struct msm_rd_state *rd, -struct msm_gem_submit *submit,int idx, -uint64_t iova,uint32_t size,bool full) +static void snapshot_buf (struct msm_rd_state *rd,struct drm_gem_object *obj, +uint64_t iova,bool full,size_t offset,size_t size) { -struct drm_gem_object *obj = submit->bos[idx].obj; -unsigned offset =0 ;const char *buf; -if (iova) { - offset = iova - submit->bos[idx].iova; - }else { - iova = submit->bos[idx].iova; - size = obj->size; - } -/* * Always write the GPUADDR header so can get a complete list of all the * buffers in the cmd
@@ -333,10 +323,6 @@ static void snapshot_buf(struct msm_rd_state *rd,if (!full)return ; -/* But only dump the contents of buffers marked READ */ -if (!(submit->bos[idx].flags &MSM_SUBMIT_BO_READ )) -return ; - buf =msm_gem_get_vaddr_active (obj);if (IS_ERR (buf))return ;
@@ -352,6 +338,7 @@ static void snapshot_buf(struct msm_rd_state *rd,void msm_rd_dump_submit (struct msm_rd_state *rd,struct msm_gem_submit *submit,const char *fmt, ...) { +extern bool rd_full;struct task_struct *task;char msg[256 ];int i, n;
@@ -385,16 +372,25 @@ void msm_rd_dump_submit(struct msm_rd_state *rd, struct msm_gem_submit *submit,rd_write_section (rd,RD_CMD , msg,ALIGN (n,4 )); -for (i =0 ; i < submit->nr_bos; i++) -snapshot_buf (rd, submit, i,0 ,0 ,should_dump (submit, i)); +for (i =0 ; i < submit->nr_bos; i++) { +struct drm_gem_object *obj = submit->bos[i].obj; +bool dump = rd_full || (submit->bos[i].flags &MSM_SUBMIT_BO_DUMP ); + +snapshot_buf (rd, obj, submit->bos[i].iova, dump,0 , obj->size); + }for (i =0 ; i < submit->nr_cmds; i++) {uint32_t szd = submit->cmd[i].size;/* in dwords */ +int idx = submit->cmd[i].idx; +bool dump = rd_full || (submit->bos[idx].flags &MSM_SUBMIT_BO_DUMP );/* snapshot cmdstream bo's (if we haven't already): */ -if (!should_dump (submit, i)) { -snapshot_buf (rd, submit, submit->cmd[i].idx, - submit->cmd[i].iova, szd *4 , true); +if (!dump) { +struct drm_gem_object *obj = submit->bos[idx].obj; +size_t offset = submit->cmd[i].iova - submit->bos[idx].iova; + +snapshot_buf (rd, obj, submit->cmd[i].iova, true, + offset, szd *4 ); } }
Signature · 1 line
2.49.0
PATCH v4 27/40 drm/msm: Crashdec support for sparse
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
In this case, we need to iterate the VMAs looking for ones with MSM_VMA_DUMP flag.
--- drivers/gpu/drm/msm/msm_gpu.c | 96 ++++++++++++++++++++++++++--------- 1 file changed, 72 insertions(+), 24 deletions(-)
drivers/gpu/drm/msm/msm_gpu.c +72 -24
@@ -241,9 +241,7 @@ static void msm_gpu_crashstate_get_bo(struct msm_gpu_state *state,if (!state_bo->data) goto out; -msm_gem_lock (obj); ptr =msm_gem_get_vaddr_active (obj); -msm_gem_unlock (obj);if (IS_ERR (ptr)) {kvfree (state_bo->data); state_bo->data =NULL ;
@@ -251,12 +249,75 @@ static void msm_gpu_crashstate_get_bo(struct msm_gpu_state *state, }memcpy (state_bo->data, ptr + offset, size); -msm_gem_put_vaddr (obj); +msm_gem_put_vaddr_locked (obj); } out: state->nr_bos++; } +static void crashstate_get_bos (struct msm_gpu_state *state,struct msm_gem_submit *submit) +{ +extern bool rd_full; + +if (!submit) +return ; + +if (msm_context_is_vmbind (submit->queue->ctx)) { +struct drm_exec exec; +struct drm_gpuva *vma; +unsigned cnt =0 ; + +drm_exec_init (&exec,DRM_EXEC_IGNORE_DUPLICATES ,0 ); + drm_exec_until_all_locked(&exec) { + cnt =0 ; + +drm_exec_lock_obj (&exec,drm_gpuvm_resv_obj (submit->vm)); +drm_exec_retry_on_contention (&exec); + + drm_gpuvm_for_each_va (vma, submit->vm) { +if (!vma->gem.obj) +continue ; + + cnt++; +drm_exec_lock_obj (&exec, vma->gem.obj); +drm_exec_retry_on_contention (&exec); + } + + } + +drm_gpuvm_for_each_va (vma, submit->vm) + cnt++; + + state->bos =kcalloc (cnt,sizeof (struct msm_gpu_state_bo ),GFP_KERNEL ); + + drm_gpuvm_for_each_va (vma, submit->vm) { +bool dump = rd_full || (vma->flags &MSM_VMA_DUMP ); + +/* Skip MAP_NULL/PRR VMAs: */ +if (!vma->gem.obj) +continue ; + +msm_gpu_crashstate_get_bo (state, vma->gem.obj, vma->va.addr, + dump, vma->gem.offset, vma->va.range); + } + +drm_exec_fini (&exec); + }else { + state->bos =kcalloc (submit->nr_bos, +sizeof (struct msm_gpu_state_bo ),GFP_KERNEL ); + +for (int i =0 ; state->bos && i < submit->nr_bos; i++) { +struct drm_gem_object *obj = submit->bos[i].obj; +bool dump = rd_full || (submit->bos[i].flags &MSM_SUBMIT_BO_DUMP ); + +msm_gem_lock (obj); +msm_gpu_crashstate_get_bo (state, obj, submit->bos[i].iova, + dump,0 , obj->size); +msm_gem_unlock (obj); + } + } +} +static void msm_gpu_crashstate_capture (struct msm_gpu *gpu,struct msm_gem_submit *submit,char *comm,char *cmd) {
@@ -279,30 +340,17 @@ static void msm_gpu_crashstate_capture(struct msm_gpu *gpu, state->cmd =kstrdup (cmd,GFP_KERNEL ); state->fault_info = gpu->fault_info; -if (submit) { -extern bool rd_full; -int i; - -if (state->fault_info.ttbr0) { -struct msm_gpu_fault_info *info = &state->fault_info; -struct msm_mmu *mmu =to_msm_vm (submit->vm)->mmu; +if (submit && state->fault_info.ttbr0) { +struct msm_gpu_fault_info *info = &state->fault_info; +struct msm_mmu *mmu =to_msm_vm (submit->vm)->mmu; -msm_iommu_pagetable_params (mmu, &info->pgtbl_ttbr0, - &info->asid); -msm_iommu_pagetable_walk (mmu, info->iova, info->ptes); - } - - state->bos =kcalloc (submit->nr_bos, -sizeof (struct msm_gpu_state_bo ),GFP_KERNEL ); - -for (i =0 ; state->bos && i < submit->nr_bos; i++) { -struct drm_gem_object *obj = submit->bos[i].obj; -bool dump = rd_full || (submit->bos[i].flags &MSM_SUBMIT_BO_DUMP ); -msm_gpu_crashstate_get_bo (state, obj, submit->bos[i].iova, - dump,0 , obj->size); - } +msm_iommu_pagetable_params (mmu, &info->pgtbl_ttbr0, + &info->asid); +msm_iommu_pagetable_walk (mmu, info->iova, info->ptes); } +crashstate_get_bos (state, submit); +/* Set the active crash state to be dumped on failure */ gpu->crashstate = state;
Signature · 1 line
2.49.0
PATCH v4 28/40 drm/msm: rd dumping support for sparse
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
As with devcoredump, we need to iterate the VMAs to figure out what to dump.
--- drivers/gpu/drm/msm/msm_rd.c | 48 +++++++++++++++++++++++++----------- 1 file changed, 33 insertions(+), 15 deletions(-)
drivers/gpu/drm/msm/msm_rd.c +33 -15
@@ -372,25 +372,43 @@ void msm_rd_dump_submit(struct msm_rd_state *rd, struct msm_gem_submit *submit,rd_write_section (rd,RD_CMD , msg,ALIGN (n,4 )); -for (i =0 ; i < submit->nr_bos; i++) { -struct drm_gem_object *obj = submit->bos[i].obj; -bool dump = rd_full || (submit->bos[i].flags &MSM_SUBMIT_BO_DUMP ); +if (msm_context_is_vmbind (submit->queue->ctx)) { +struct drm_gpuva *vma; -snapshot_buf (rd, obj, submit->bos[i].iova, dump,0 , obj->size); - } +drm_gpuvm_resv_assert_held (submit->vm); -for (i =0 ; i < submit->nr_cmds; i++) { -uint32_t szd = submit->cmd[i].size;/* in dwords */ -int idx = submit->cmd[i].idx; -bool dump = rd_full || (submit->bos[idx].flags &MSM_SUBMIT_BO_DUMP ); + drm_gpuvm_for_each_va (vma, submit->vm) { +bool dump = rd_full || (vma->flags &MSM_VMA_DUMP ); + +/* Skip MAP_NULL/PRR VMAs: */ +if (!vma->gem.obj) +continue ; + +snapshot_buf (rd, vma->gem.obj, vma->va.addr, dump, + vma->gem.offset, vma->va.range); + } + + }else { +for (i =0 ; i < submit->nr_bos; i++) { +struct drm_gem_object *obj = submit->bos[i].obj; +bool dump = rd_full || (submit->bos[i].flags &MSM_SUBMIT_BO_DUMP ); + +snapshot_buf (rd, obj, submit->bos[i].iova, dump,0 , obj->size); + } + +for (i =0 ; i < submit->nr_cmds; i++) { +uint32_t szd = submit->cmd[i].size;/* in dwords */ +int idx = submit->cmd[i].idx; +bool dump = rd_full || (submit->bos[idx].flags &MSM_SUBMIT_BO_DUMP ); -/* snapshot cmdstream bo's (if we haven't already): */ -if (!dump) { -struct drm_gem_object *obj = submit->bos[idx].obj; -size_t offset = submit->cmd[i].iova - submit->bos[idx].iova; +/* snapshot cmdstream bo's (if we haven't already): */ +if (!dump) { +struct drm_gem_object *obj = submit->bos[idx].obj; +size_t offset = submit->cmd[i].iova - submit->bos[idx].iova; -snapshot_buf (rd, obj, submit->cmd[i].iova, true, - offset, szd *4 ); +snapshot_buf (rd, obj, submit->cmd[i].iova, true, + offset, szd *4 ); + } } }
Signature · 1 line
2.49.0
PATCH v4 29/40 drm/msm: Extract out syncobj helpers
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
We'll be re-using these for the VM_BIND ioctl.
Also, rename a few things in the uapi header to reflect that syncobj use is not specific to the submit ioctl.
--- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/msm_gem_submit.c | 192 ++------------------------- drivers/gpu/drm/msm/msm_syncobj.c | 172 ++++++++++++++++++++++++ drivers/gpu/drm/msm/msm_syncobj.h | 37 ++++++ include/uapi/drm/msm_drm.h | 26 ++-- 5 files changed, 235 insertions(+), 193 deletions(-) create mode 100644 drivers/gpu/drm/msm/msm_syncobj.c create mode 100644 drivers/gpu/drm/msm/msm_syncobj.h
drivers/gpu/drm/msm/Makefile +1 -0
@@ -128,6 +128,7 @@ msm-y += \ msm_rd.o \ msm_ringbuffer.o \ msm_submitqueue.o \ + msm_syncobj.o \ msm_gpu_tracepoints.o \ msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o
drivers/gpu/drm/msm/msm_gem_submit.c +12 -180
228 lines not on this page · raw message
drivers/gpu/drm/msm/msm_syncobj.c new file +172 -0
172 lines not on this page · raw message
drivers/gpu/drm/msm/msm_syncobj.h new file +37 -0
@@ -0,0 +1,37 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* Copyright (C) 2020 Google, Inc */ + +#ifndef __MSM_GEM_SYNCOBJ_H__ +#define __MSM_GEM_SYNCOBJ_H__ + +#include "drm/drm_device.h" +#include "drm/drm_syncobj.h" +#include "drm/gpu_scheduler.h" + +struct msm_syncobj_post_dep { +struct drm_syncobj *syncobj; +uint64_t point; +struct dma_fence_chain *chain; +}; + +struct drm_syncobj ** +msm_syncobj_parse_deps (struct drm_device *dev, +struct drm_sched_job *job, +struct drm_file *file, +uint64_t in_syncobjs_addr, +uint32_t nr_in_syncobjs, +size_t syncobj_stride); + +void msm_syncobj_reset (struct drm_syncobj **syncobjs,uint32_t nr_syncobjs); + +struct msm_syncobj_post_dep * +msm_syncobj_parse_post_deps (struct drm_device *dev, +struct drm_file *file, +uint64_t syncobjs_addr, +uint32_t nr_syncobjs, +size_t syncobj_stride); + +void msm_syncobj_process_post_deps (struct msm_syncobj_post_dep *post_deps, +uint32_t count,struct dma_fence *fence); + +#endif /* __MSM_GEM_SYNCOBJ_H__ */
include/uapi/drm/msm_drm.h +13 -13
@@ -220,6 +220,17 @@ struct drm_msm_gem_cpu_fini {* Cmdstream Submission: */ +#define MSM_SYNCOBJ_RESET 0x00000001/* Reset syncobj after wait. */ +#define MSM_SYNCOBJ_FLAGS ( \ + MSM_SYNCOBJ_RESET | \ + 0) + +struct drm_msm_syncobj { +__u32 handle;/* in, syncobj handle. */ +__u32 flags;/* in, from MSM_SUBMIT_SYNCOBJ_FLAGS */ +__u64 point;/* in, timepoint for timeline syncobjs. */ +}; +/* The value written into the cmdstream is logically: * * ((relocbuf->gpuaddr + reloc_offset) << shift) | or
@@ -309,17 +320,6 @@ struct drm_msm_gem_submit_bo {MSM_SUBMIT_FENCE_SN_IN | \ 0) -#define MSM_SUBMIT_SYNCOBJ_RESET 0x00000001/* Reset syncobj after wait. */ -#define MSM_SUBMIT_SYNCOBJ_FLAGS ( \ - MSM_SUBMIT_SYNCOBJ_RESET | \ - 0) - -struct drm_msm_gem_submit_syncobj { -__u32 handle;/* in, syncobj handle. */ -__u32 flags;/* in, from MSM_SUBMIT_SYNCOBJ_FLAGS */ -__u64 point;/* in, timepoint for timeline syncobjs. */ -}; -/* Each cmdstream submit consists of a table of buffers involved, and * one or more cmdstream buffers. This allows for conditional execution * (context-restore), and IB buffers needed for per tile/bin draw cmds.
@@ -333,8 +333,8 @@ struct drm_msm_gem_submit {__u64 cmds;/* in, ptr to array of submit_cmd's */ __s32 fence_fd;/* in/out fence fd (see MSM_SUBMIT_FENCE_FD_IN/OUT) */ __u32 queueid;/* in, submitqueue id */ -__u64 in_syncobjs;/* in, ptr to array of drm_msm_gem_submit_syncobj */ -__u64 out_syncobjs;/* in, ptr to array of drm_msm_gem_submit_syncobj */ +__u64 in_syncobjs;/* in, ptr to array of drm_msm_syncobj */ +__u64 out_syncobjs;/* in, ptr to array of drm_msm_syncobj */ __u32 nr_in_syncobjs;/* in, number of entries in in_syncobj */ __u32 nr_out_syncobjs;/* in, number of entries in out_syncobj. */ __u32 syncobj_stride;/* in, stride of syncobj arrays. */
Signature · 1 line
2.49.0
PATCH v4 30/40 drm/msm: Use DMA_RESV_USAGE_BOOKKEEP/KERNEL
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Any place we wait for a BO to become idle, we should use BOOKKEEP usage, to ensure that it waits for _any_ activity.
--- drivers/gpu/drm/msm/msm_gem.c | 6 +++--- drivers/gpu/drm/msm/msm_gem_shrinker.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +3 -3
@@ -76,8 +76,8 @@ static void msm_gem_close(struct drm_gem_object *obj, struct drm_file *file)* TODO we might need to kick this to a queue to avoid blocking * in CLOSE ioctl */ -dma_resv_wait_timeout (obj->resv,DMA_RESV_USAGE_READ , false, -msecs_to_jiffies (1000 )); +dma_resv_wait_timeout (obj->resv,DMA_RESV_USAGE_BOOKKEEP , false, +MAX_SCHEDULE_TIMEOUT );msm_gem_lock_vm_and_obj (&exec, obj, ctx->vm);put_iova_spaces (obj, ctx->vm, true);
@@ -879,7 +879,7 @@ bool msm_gem_active(struct drm_gem_object *obj)if (to_msm_bo (obj)->pin_count)return true; -return !dma_resv_test_signaled (obj->resv,dma_resv_usage_rw (true)); +return !dma_resv_test_signaled (obj->resv,DMA_RESV_USAGE_BOOKKEEP ); }int msm_gem_cpu_prep (struct drm_gem_object *obj,uint32_t op,ktime_t *timeout)
drivers/gpu/drm/msm/msm_gem_shrinker.c +1 -1
@@ -139,7 +139,7 @@ evict(struct drm_gem_object *obj, struct ww_acquire_ctx *ticket)static bool wait_for_idle (struct drm_gem_object *obj) { -enum dma_resv_usage usage =dma_resv_usage_rw (true); +enum dma_resv_usage usage =DMA_RESV_USAGE_BOOKKEEP ;return dma_resv_wait_timeout (obj->resv, usage, false,10 ) >0 ; }
Signature · 1 line
2.49.0
PATCH v4 31/40 drm/msm: Add VM_BIND submitqueue
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
This submitqueue type isn't tied to a hw ringbuffer, but instead executes on the CPU for performing async VM_BIND ops.
--- drivers/gpu/drm/msm/msm_gem.h | 12 +++++ drivers/gpu/drm/msm/msm_gem_submit.c | 60 +++++++++++++++++++--- drivers/gpu/drm/msm/msm_gem_vma.c | 71 +++++++++++++++++++++++++++ drivers/gpu/drm/msm/msm_gpu.h | 3 ++ drivers/gpu/drm/msm/msm_submitqueue.c | 67 +++++++++++++++++++------ include/uapi/drm/msm_drm.h | 9 +++- 6 files changed, 197 insertions(+), 25 deletions(-)
drivers/gpu/drm/msm/msm_gem.h +12 -0
@@ -53,6 +53,13 @@ struct msm_gem_vm {/** @base: Inherit from drm_gpuvm. */ struct drm_gpuvm base; +/** +* @sched: Scheduler used for asynchronous VM_BIND request. +* +* Unused for kernel managed VMs (where all operations are synchronous). +*/ +struct drm_gpu_scheduler sched; +/** * @mm: Memory management for kernel managed VA allocations *
@@ -71,6 +78,9 @@ struct msm_gem_vm {*/ struct pid *pid; +/** @last_fence: Fence for last pending work scheduled on the VM */ +struct dma_fence *last_fence; +/** @faults: the number of GPU hangs associated with this address space */ int faults;
@@ -100,6 +110,8 @@ struct drm_gpuvm * msm_gem_vm_create(struct drm_device *drm, struct msm_mmu *mmu, const char *name, u64 va_start, u64 va_size, bool managed); +void msm_gem_vm_close (struct drm_gpuvm *gpuvm); +struct msm_fence_context ;#define MSM_VMA_DUMP (DRM_GPUVA_USERBITS << 0)
drivers/gpu/drm/msm/msm_gem_submit.c +52 -8
115 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gem_vma.c +71 -0
97 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gpu.h +3 -0
@@ -570,6 +570,9 @@ struct msm_gpu_submitqueue {struct mutex lock;struct kref ref;struct drm_sched_entity *entity; + +/** @_vm_bind_entity: used for @entity pointer for VM_BIND queues */ +struct drm_sched_entity _vm_bind_entity[0 ]; };struct msm_gpu_state_bo {
drivers/gpu/drm/msm/msm_submitqueue.c +51 -16
108 lines not on this page · raw message
include/uapi/drm/msm_drm.h +8 -1
@@ -385,12 +385,19 @@ struct drm_msm_gem_madvise {/* * Draw queues allow the user to set specific submission parameter. Command * submissions specify a specific submitqueue to use. ID 0 is reserved for -* backwards compatibility as a "default" submitqueue +* backwards compatibility as a "default" submitqueue. +* +* Because VM_BIND async updates happen on the CPU, they must run on a +* virtual queue created with the flag MSM_SUBMITQUEUE_VM_BIND. If we had +* a way to do pgtable updates on the GPU, we could drop this restriction. */ #define MSM_SUBMITQUEUE_ALLOW_PREEMPT 0x00000001 +#define MSM_SUBMITQUEUE_VM_BIND 0x00000002/* virtual queue for VM_BIND ops */ +#define MSM_SUBMITQUEUE_FLAGS ( \ MSM_SUBMITQUEUE_ALLOW_PREEMPT | \ + MSM_SUBMITQUEUE_VM_BIND | \ 0)/*
Signature · 1 line
2.49.0
PATCH v4 32/40 drm/msm: Support IO_PGTABLE_QUIRK_NO_WARN_ON
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
With user managed VMs and multiple queues, it is in theory possible to trigger map/unmap errors. These will (in a later patch) mark the VM as unusable. But we want to tell the io-pgtable helpers not to spam the log. In addition, in the unmap path, we don't want to bail early from the unmap, to ensure we don't leave some dangling pages mapped.
--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/msm_iommu.c | 23 ++++++++++++++++++----- drivers/gpu/drm/msm/msm_mmu.h | 2 +- 3 files changed, 20 insertions(+), 7 deletions(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +1 -1
@@ -2267,7 +2267,7 @@ a6xx_create_private_vm(struct msm_gpu *gpu, bool kernel_managed) {struct msm_mmu *mmu; - mmu =msm_iommu_pagetable_create (to_msm_vm (gpu->vm)->mmu); + mmu =msm_iommu_pagetable_create (to_msm_vm (gpu->vm)->mmu, kernel_managed);if (IS_ERR (mmu))return ERR_CAST (mmu);
drivers/gpu/drm/msm/msm_iommu.c +18 -5
@@ -94,15 +94,24 @@ static int msm_iommu_pagetable_unmap(struct msm_mmu *mmu, u64 iova, {struct msm_iommu_pagetable *pagetable =to_pagetable (mmu);struct io_pgtable_ops *ops = pagetable->pgtbl_ops; +int ret =0 ;while (size) { -size_t unmapped, pgsize, count; +size_t pgsize, count; +ssize_t unmapped; pgsize =calc_pgsize (pagetable, iova, iova, size, &count); unmapped = ops->unmap_pages (ops, iova, pgsize, count,NULL ); -if (!unmapped) -break ; +if (unmapped <=0 ) { + ret = -EINVAL ; +/* +* Continue attempting to unamp the remained of the +* range, so we don't end up with some dangling +* mapped pages +*/ + unmapped =PAGE_SIZE ; + } iova += unmapped; size -= unmapped;
@@ -110,7 +119,7 @@ static int msm_iommu_pagetable_unmap(struct msm_mmu *mmu, u64 iova,iommu_flush_iotlb_all (to_msm_iommu (pagetable->parent)->domain); -return (size ==0 ) ?0 : -EINVAL ; +return ret; }static int msm_iommu_pagetable_map_prr (struct msm_mmu *mmu,u64 iova,size_t len,int prot)
@@ -324,7 +333,7 @@ static const struct iommu_flush_ops tlb_ops = {static int msm_gpu_fault_handler (struct iommu_domain *domain,struct device *dev,unsigned long iova,int flags,void *arg); -struct msm_mmu *msm_iommu_pagetable_create (struct msm_mmu *parent) +struct msm_mmu *msm_iommu_pagetable_create (struct msm_mmu *parent,bool kernel_managed) {struct adreno_smmu_priv *adreno_smmu =dev_get_drvdata (parent->dev);struct msm_iommu *iommu =to_msm_iommu (parent);
@@ -358,6 +367,10 @@ struct msm_mmu *msm_iommu_pagetable_create(struct msm_mmu *parent) ttbr0_cfg.quirks &= ~IO_PGTABLE_QUIRK_ARM_TTBR1 ; ttbr0_cfg.tlb = &tlb_ops; +if (!kernel_managed) { + ttbr0_cfg.quirks |=IO_PGTABLE_QUIRK_NO_WARN_ON ; + } + pagetable->pgtbl_ops =alloc_io_pgtable_ops (ARM_64_LPAE_S1 , &ttbr0_cfg, pagetable);
drivers/gpu/drm/msm/msm_mmu.h +1 -1
@@ -52,7 +52,7 @@ static inline void msm_mmu_set_fault_handler(struct msm_mmu *mmu, void *arg, mmu->handler = handler; } -struct msm_mmu *msm_iommu_pagetable_create (struct msm_mmu *parent); +struct msm_mmu *msm_iommu_pagetable_create (struct msm_mmu *parent,bool kernel_managed);int msm_iommu_pagetable_params (struct msm_mmu *mmu,phys_addr_t *ttbr,int *asid);
Signature · 1 line
2.49.0
PATCH v4 33/40 drm/msm: Support pgtable preallocation
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Introduce a mechanism to count the worst case # of pages required in a VM_BIND op.
Note that previously we would have had to somehow account for allocations in unmap, when splitting a block. This behavior was removed in commit 33729a5fc0ca ("iommu/io-pgtable-arm: Remove split on unmap behavior)"
--- drivers/gpu/drm/msm/msm_gem.h | 1 + drivers/gpu/drm/msm/msm_iommu.c | 191 +++++++++++++++++++++++++++++++- drivers/gpu/drm/msm/msm_mmu.h | 34 ++++++ 3 files changed, 225 insertions(+), 1 deletion(-)
drivers/gpu/drm/msm/msm_gem.h +1 -0
@@ -7,6 +7,7 @@#ifndef __MSM_GEM_H__#define __MSM_GEM_H__ +#include "msm_mmu.h" #include <linux/kref.h> #include <linux/dma-resv.h> #include "drm/drm_exec.h"
drivers/gpu/drm/msm/msm_iommu.c +190 -1
248 lines not on this page · raw message
drivers/gpu/drm/msm/msm_mmu.h +34 -0
@@ -9,8 +9,16 @@#include <linux/iommu.h> +struct msm_mmu_prealloc ; +struct msm_mmu ; +struct msm_gpu ; +struct msm_mmu_funcs {void (*detach)(struct msm_mmu *mmu); +void (*prealloc_count)(struct msm_mmu *mmu,struct msm_mmu_prealloc *p, +uint64_t iova,size_t len); +int (*prealloc_allocate)(struct msm_mmu *mmu,struct msm_mmu_prealloc *p); +void (*prealloc_cleanup)(struct msm_mmu *mmu,struct msm_mmu_prealloc *p);int (*map)(struct msm_mmu *mmu,uint64_t iova,struct sg_table *sgt,size_t off,size_t len,int prot);int (*unmap)(struct msm_mmu *mmu,uint64_t iova,size_t len);
@@ -25,12 +33,38 @@ enum msm_mmu_type { MSM_MMU_IOMMU_PAGETABLE, }; +/** +* struct msm_mmu_prealloc - Tracking for pre-allocated pages for MMU updates. +*/ +struct msm_mmu_prealloc { +/** @count: Number of pages reserved. */ +uint32_t count; +/** @ptr: Index of first unused page in @pages */ +uint32_t ptr; +/** +* @pages: Array of pages preallocated for MMU table updates. +* +* After a VM operation, there might be free pages remaining in this +* array (since the amount allocated is a worst-case). These are +* returned to the pt_cache at mmu->prealloc_cleanup(). +*/ +void **pages; +}; +struct msm_mmu {const struct msm_mmu_funcs *funcs;struct device *dev;int (*handler)(void *arg,unsigned long iova,int flags,void *data);void *arg;enum msm_mmu_type type; + +/** +* @prealloc: pre-allocated pages for pgtable +* +* Set while a VM_BIND job is running, serialized under +* msm_gem_vm::mmu_lock. +*/ +struct msm_mmu_prealloc *prealloc; }; static inline void msm_mmu_init(struct msm_mmu *mmu, struct device *dev,
Signature · 1 line
2.49.0
PATCH v4 34/40 drm/msm: Split out map/unmap ops
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
With async VM_BIND, the actual pgtable updates are deferred. Synchronously, a list of map/unmap ops will be generated, but the actual pgtable changes are deferred. To support that, split out op handlers and change the existing non-VM_BIND paths to use them.
Note in particular, the vma itself may already be destroyed/freed by the time an UNMAP op runs (or even a MAP op if there is a later queued UNMAP). For this reason, the op handlers cannot reference the vma pointer.
--- drivers/gpu/drm/msm/msm_gem_vma.c | 63 +++++++++++++++++++++++++++---- 1 file changed, 56 insertions(+), 7 deletions(-)
drivers/gpu/drm/msm/msm_gem_vma.c +56 -7
@@ -8,6 +8,34 @@#include "msm_gem.h" #include "msm_mmu.h" +#define vm_dbg (fmt, ...) pr_debug("%s:%d: "fmt"\n", __func__, __LINE__, ##__VA_ARGS__) + +/** +* struct msm_vm_map_op - create new pgtable mapping +*/ +struct msm_vm_map_op { +/** @iova: start address for mapping */ +uint64_t iova; +/** @range: size of the region to map */ +uint64_t range; +/** @offset: offset into @sgt to map */ +uint64_t offset; +/** @sgt: pages to map, or NULL for a PRR mapping */ +struct sg_table *sgt; +/** @prot: the mapping protection flags */ +int prot; +}; + +/** +* struct msm_vm_unmap_op - unmap a range of pages from pgtable +*/ +struct msm_vm_unmap_op { +/** @iova: start address for unmap */ +uint64_t iova; +/** @range: size of region to unmap */ +uint64_t range; +}; +static void msm_gem_vm_free (struct drm_gpuvm *gpuvm) {
@@ -21,18 +49,36 @@ msm_gem_vm_free(struct drm_gpuvm *gpuvm)kfree (vm); } +static void +vm_unmap_op (struct msm_gem_vm *vm,const struct msm_vm_unmap_op *op) +{ +vm_dbg ("%p: %016llx %016llx" , vm, op->iova, op->iova + op->range); + + vm->mmu->funcs->unmap (vm->mmu, op->iova, op->range); +} + +static int +vm_map_op (struct msm_gem_vm *vm,const struct msm_vm_map_op *op) +{ +vm_dbg ("%p: %016llx %016llx" , vm, op->iova, op->iova + op->range); + +return vm->mmu->funcs->map (vm->mmu, op->iova, op->sgt, op->offset, + op->range, op->prot); +} +/* Actually unmap memory for the vma */ void msm_gem_vma_unmap (struct drm_gpuva *vma) {struct msm_gem_vma *msm_vma =to_msm_vma (vma); -struct msm_gem_vm *vm =to_msm_vm (vma->vm); -unsigned size = vma->va.range;/* Don't do anything if the memory isn't mapped */ if (!msm_vma->mapped)return ; - vm->mmu->funcs->unmap (vm->mmu, vma->va.addr, size); +vm_unmap_op (to_msm_vm (vma->vm), &(struct msm_vm_unmap_op ){ + .iova = vma->va.addr, + .range = vma->va.range, + }); msm_vma->mapped = false; }
@@ -42,7 +88,6 @@ int msm_gem_vma_map(struct drm_gpuva *vma, int prot, struct sg_table *sgt) { struct msm_gem_vma *msm_vma = to_msm_vma(vma); -struct msm_gem_vm *vm =to_msm_vm (vma->vm);int ret;if (GEM_WARN_ON (!vma->va.addr))
@@ -62,9 +107,13 @@ msm_gem_vma_map(struct drm_gpuva *vma, int prot, struct sg_table *sgt)* Revisit this if we can come up with a scheme to pre-alloc pages * for the pgtable in map/unmap ops. */ - ret = vm->mmu->funcs->map (vm->mmu, vma->va.addr, sgt, - vma->gem.offset, vma->va.range, - prot); + ret =vm_map_op (to_msm_vm (vma->vm), &(struct msm_vm_map_op ){ + .iova = vma->va.addr, + .range = vma->va.range, + .offset = vma->gem.offset, + .sgt = sgt, + .prot = prot, + });if (ret) { msm_vma->mapped = false; }
Signature · 1 line
2.49.0
PATCH v4 35/40 drm/msm: Add VM_BIND ioctl
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Add a VM_BIND ioctl for binding/unbinding buffers into a VM. This is only supported if userspace has opted in to MSM_PARAM_EN_VM_BIND.
--- drivers/gpu/drm/msm/msm_drv.c | 1 + drivers/gpu/drm/msm/msm_drv.h | 4 +- drivers/gpu/drm/msm/msm_gem.c | 40 +- drivers/gpu/drm/msm/msm_gem.h | 4 + drivers/gpu/drm/msm/msm_gem_submit.c | 22 +- drivers/gpu/drm/msm/msm_gem_vma.c | 1073 +++++++++++++++++++++++++- include/uapi/drm/msm_drm.h | 74 +- 7 files changed, 1185 insertions(+), 33 deletions(-)
drivers/gpu/drm/msm/msm_drv.c +1 -0
@@ -791,6 +791,7 @@ static const struct drm_ioctl_desc msm_ioctls[] = {DRM_IOCTL_DEF_DRV (MSM_SUBMITQUEUE_NEW , msm_ioctl_submitqueue_new,DRM_RENDER_ALLOW ),DRM_IOCTL_DEF_DRV (MSM_SUBMITQUEUE_CLOSE , msm_ioctl_submitqueue_close,DRM_RENDER_ALLOW ),DRM_IOCTL_DEF_DRV (MSM_SUBMITQUEUE_QUERY , msm_ioctl_submitqueue_query,DRM_RENDER_ALLOW ), + DRM_IOCTL_DEF_DRV(MSM_VM_BIND, msm_ioctl_vm_bind, DRM_RENDER_ALLOW), };static void msm_show_fdinfo (struct drm_printer *p,struct drm_file *file)
drivers/gpu/drm/msm/msm_drv.h +3 -1
@@ -232,7 +232,9 @@ struct drm_gpuvm *msm_kms_init_vm(struct drm_device *dev);bool msm_use_mmu (struct drm_device *dev);int msm_ioctl_gem_submit (struct drm_device *dev,void *data, -struct drm_file *file); +struct drm_file *file); +int msm_ioctl_vm_bind (struct drm_device *dev,void *data, +struct drm_file *file);#ifdef CONFIG_DEBUG_FS unsigned long msm_gem_shrinker_shrink (struct drm_device *dev,unsigned long nr_to_scan);
drivers/gpu/drm/msm/msm_gem.c +29 -11
@@ -233,8 +233,7 @@ static void put_pages(struct drm_gem_object *obj) } } -static struct page **msm_gem_get_pages_locked (struct drm_gem_object *obj, -unsigned madv) +struct page **msm_gem_get_pages_locked (struct drm_gem_object *obj,unsigned madv) {struct msm_gem_object *msm_obj =to_msm_bo (obj);
@@ -1036,18 +1035,37 @@ static void msm_gem_free_object(struct drm_gem_object *obj)/* * We need to lock any VMs the object is still attached to, but not * the object itself (see explaination in msm_gem_assert_locked()), -* so just open-code this special case: +* so just open-code this special case. +* +* Note that we skip the dance if we aren't attached to any VM. This +* is load bearing. The driver needs to support two usage models: +* +* 1. Legacy kernel managed VM: Userspace expects the VMA's to be +* implicitly torn down when the object is freed, the VMA's do +* not hold a hard reference to the BO. +* +* 2. VM_BIND, userspace managed VM: The VMA holds a reference to the +* BO. This can be dropped when the VM is closed and it's associated +* VMAs are torn down. (See msm_gem_vm_close()). +* +* In the latter case the last reference to a BO can be dropped while +* we already have the VM locked. It would have already been removed +* from the gpuva list, but lockdep doesn't know that. Or understand +* the differences between the two usage models. */ -drm_exec_init (&exec,0 ,0 ); - drm_exec_until_all_locked (&exec) { -struct drm_gpuvm_bo *vm_bo; - drm_gem_for_each_gpuvm_bo (vm_bo, obj) { -drm_exec_lock_obj (&exec,drm_gpuvm_resv_obj (vm_bo->vm)); -drm_exec_retry_on_contention (&exec); +if (!list_empty (&obj->gpuva.list)) { +drm_exec_init (&exec,0 ,0 ); + drm_exec_until_all_locked (&exec) { +struct drm_gpuvm_bo *vm_bo; + drm_gem_for_each_gpuvm_bo (vm_bo, obj) { +drm_exec_lock_obj (&exec, +drm_gpuvm_resv_obj (vm_bo->vm)); +drm_exec_retry_on_contention (&exec); + } } +put_iova_spaces (obj,NULL , true); +drm_exec_fini (&exec);/* drop locks */ } -put_iova_spaces (obj,NULL , true); -drm_exec_fini (&exec);/* drop locks */ if (obj->import_attach) {GEM_WARN_ON (msm_obj->vaddr);
drivers/gpu/drm/msm/msm_gem.h +4 -0
@@ -73,6 +73,9 @@ struct msm_gem_vm {/** @mmu: The mmu object which manages the pgtables */ struct msm_mmu *mmu; +/** @mmu_lock: Protects access to the mmu */ +struct mutex mmu_lock; +/** * @pid: For address spaces associated with a specific process, this * will be non-NULL:
@@ -205,6 +208,7 @@ int msm_gem_get_and_pin_iova(struct drm_gem_object *obj, struct drm_gpuvm *vm, uint64_t *iova);void msm_gem_unpin_iova (struct drm_gem_object *obj,struct drm_gpuvm *vm);void msm_gem_pin_obj_locked (struct drm_gem_object *obj); +struct page **msm_gem_get_pages_locked (struct drm_gem_object *obj,unsigned madv);struct page **msm_gem_pin_pages_locked (struct drm_gem_object *obj);void msm_gem_unpin_pages_locked (struct drm_gem_object *obj); int msm_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
drivers/gpu/drm/msm/msm_gem_submit.c +20 -2
@@ -193,6 +193,7 @@ static int submit_lookup_objects(struct msm_gem_submit *submit,static int submit_lookup_cmds (struct msm_gem_submit *submit,struct drm_msm_gem_submit *args,struct drm_file *file) { +struct msm_context *ctx = file->driver_priv;unsigned i;size_t sz;int ret =0 ;
@@ -224,6 +225,20 @@ static int submit_lookup_cmds(struct msm_gem_submit *submit, goto out; } +if (msm_context_is_vmbind (ctx)) { +if (submit_cmd.nr_relocs) { + ret =SUBMIT_ERROR (EINVAL , submit,"nr_relocs must be zero" ); + goto out; + } + +if (submit_cmd.submit_idx || submit_cmd.submit_offset) { + ret =SUBMIT_ERROR (EINVAL , submit,"submit_idx/offset must be zero" ); + goto out; + } + + submit->cmd[i].iova = submit_cmd.iova; + } + submit->cmd[i].type = submit_cmd.type; submit->cmd[i].size = submit_cmd.size /4 ; submit->cmd[i].offset = submit_cmd.submit_offset /4 ;
@@ -527,6 +542,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,struct msm_syncobj_post_dep *post_deps =NULL ;struct drm_syncobj **syncobjs_to_reset =NULL ;struct sync_file *sync_file =NULL ; +unsigned cmds_to_parse;int out_fence_fd =-1 ;unsigned i;int ret;
@@ -650,7 +666,9 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,if (ret) goto out; -for (i =0 ; i < args->nr_cmds; i++) { + cmds_to_parse =msm_context_is_vmbind (ctx) ?0 : args->nr_cmds; + +for (i =0 ; i < cmds_to_parse; i++) {struct drm_gem_object *obj;uint64_t iova;
@@ -681,7 +699,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, goto out; } - submit->nr_cmds = i; + submit->nr_cmds = args->nr_cmds;idr_preload (GFP_KERNEL );
drivers/gpu/drm/msm/msm_gem_vma.c +1055 -18
1,210 lines not on this page · raw message
include/uapi/drm/msm_drm.h +73 -1
99 lines not on this page · raw message
Signature · 1 line
2.49.0
PATCH v4 36/40 drm/msm: Add VM logging for VM_BIND updates
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
When userspace opts in to VM_BIND, the submit no longer holds references keeping the VMA alive. This makes it difficult to distinguish between UMD/KMD/app bugs. So add a debug option for logging the most recent VM updates and capturing these in GPU devcoredumps.
The submitqueue id is also captured, a value of zero means the operation did not go via a submitqueue (ie. comes from msm_gem_vm_close() tearing down the remaining mappings when the device file is closed.
--- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 11 +++ drivers/gpu/drm/msm/msm_gem.h | 24 +++++ drivers/gpu/drm/msm/msm_gem_vma.c | 124 ++++++++++++++++++++++-- drivers/gpu/drm/msm/msm_gpu.c | 45 ++++++++- drivers/gpu/drm/msm/msm_gpu.h | 4 + 5 files changed, 199 insertions(+), 9 deletions(-)
drivers/gpu/drm/msm/adreno/adreno_gpu.c +11 -0
@@ -837,6 +837,7 @@ void adreno_gpu_state_destroy(struct msm_gpu_state *state)for (i =0 ; state->bos && i < state->nr_bos; i++)kvfree (state->bos[i].data); +kfree (state->vm_logs);kfree (state->bos);kfree (state->comm);kfree (state->cmd);
@@ -977,6 +978,16 @@ void adreno_show(struct msm_gpu *gpu, struct msm_gpu_state *state, info->ptes[0], info->ptes[1], info->ptes[2], info->ptes[3]); } +if (state->vm_logs) { +drm_puts (p,"vm-log:\n" ); +for (i =0 ; i < state->nr_vm_logs; i++) { +struct msm_gem_vm_log_entry *e = &state->vm_logs[i]; +drm_printf (p," - %s:%d: 0x%016llx-0x%016llx\n" , + e->op, e->queue_id, e->iova, + e->iova + e->range); + } + } +drm_printf (p,"rbbm-status: 0x%08x\n" , state->rbbm_status);drm_puts (p,"ringbuffer:\n" );
drivers/gpu/drm/msm/msm_gem.h +24 -0
@@ -24,6 +24,20 @@#define MSM_BO_STOLEN 0x10000000/* try to use stolen/splash memory */ #define MSM_BO_MAP_PRIV 0x20000000/* use IOMMU_PRIV when mapping */ +/** +* struct msm_gem_vm_log_entry - An entry in the VM log +* +* For userspace managed VMs, a log of recent VM updates is tracked and +* captured in GPU devcore dumps, to aid debugging issues caused by (for +* example) incorrectly synchronized VM updates +*/ +struct msm_gem_vm_log_entry { +const char *op; +uint64_t iova; +uint64_t range; +int queue_id; +}; +/** * struct msm_gem_vm - VM object *
@@ -85,6 +99,15 @@ struct msm_gem_vm {/** @last_fence: Fence for last pending work scheduled on the VM */ struct dma_fence *last_fence; +/** @log: A log of recent VM updates */ +struct msm_gem_vm_log_entry *log; + +/** @log_shift: length of @log is (1 << @log_shift) */ +uint32_t log_shift; + +/** @log_idx: index of next @log entry to write */ +uint32_t log_idx; +/** @faults: the number of GPU hangs associated with this address space */ int faults;
@@ -115,6 +138,7 @@ msm_gem_vm_create(struct drm_device *drm, struct msm_mmu *mmu, const char *name, u64 va_start, u64 va_size, bool managed);void msm_gem_vm_close (struct drm_gpuvm *gpuvm); +void msm_gem_vm_unusable (struct drm_gpuvm *gpuvm);struct msm_fence_context ;
drivers/gpu/drm/msm/msm_gem_vma.c +116 -8
210 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gpu.c +44 -1
63 lines not on this page · raw message
drivers/gpu/drm/msm/msm_gpu.h +4 -0
@@ -20,6 +20,7 @@#include "msm_gem.h" struct msm_gem_submit ; +struct msm_gem_vm_log_entry ;struct msm_gpu_perfcntr ;struct msm_gpu_state ;struct msm_context ;
@@ -609,6 +610,9 @@ struct msm_gpu_state {struct msm_gpu_fault_info fault_info; +int nr_vm_logs; +struct msm_gem_vm_log_entry *vm_logs; +int nr_bos;struct msm_gpu_state_bo *bos; };
Signature · 1 line
2.49.0
PATCH v4 37/40 drm/msm: Add VMA unmap reason
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Make the VM log a bit more useful by providing a reason for the unmap (ie. closing VM vs evict/purge, etc)
--- drivers/gpu/drm/msm/msm_gem.c | 18 ++++++++++-------- drivers/gpu/drm/msm/msm_gem.h | 2 +- drivers/gpu/drm/msm/msm_gem_vma.c | 15 ++++++++++++--- 3 files changed, 23 insertions(+), 12 deletions(-)
drivers/gpu/drm/msm/msm_gem.c +10 -8
@@ -47,7 +47,8 @@ static int msm_gem_open(struct drm_gem_object *obj, struct drm_file *file)return 0 ; } -static void put_iova_spaces (struct drm_gem_object *obj,struct drm_gpuvm *vm,bool close); +static void put_iova_spaces (struct drm_gem_object *obj,struct drm_gpuvm *vm, +bool close,const char *reason);static void msm_gem_close (struct drm_gem_object *obj,struct drm_file *file) {
@@ -80,7 +81,7 @@ static void msm_gem_close(struct drm_gem_object *obj, struct drm_file *file) MAX_SCHEDULE_TIMEOUT);msm_gem_lock_vm_and_obj (&exec, obj, ctx->vm); -put_iova_spaces (obj, ctx->vm, true); +put_iova_spaces (obj, ctx->vm, true,"close" );drm_exec_fini (&exec);/* drop locks */ }
@@ -407,7 +408,8 @@ static struct drm_gpuva *lookup_vma(struct drm_gem_object *obj,* mapping. */ static void -put_iova_spaces (struct drm_gem_object *obj,struct drm_gpuvm *vm,bool close) +put_iova_spaces (struct drm_gem_object *obj,struct drm_gpuvm *vm, +bool close,const char *reason) {struct drm_gpuvm_bo *vm_bo, *tmp;
@@ -422,7 +424,7 @@ put_iova_spaces(struct drm_gem_object *obj, struct drm_gpuvm *vm, bool close)drm_gpuvm_bo_get (vm_bo); drm_gpuvm_bo_for_each_va_safe (vma, vmatmp, vm_bo) { -msm_gem_vma_unmap (vma); +msm_gem_vma_unmap (vma, reason);if (close)msm_gem_vma_close (vma); }
@@ -603,7 +605,7 @@ static int clear_iova(struct drm_gem_object *obj,if (!vma)return 0 ; -msm_gem_vma_unmap (vma); +msm_gem_vma_unmap (vma,NULL );msm_gem_vma_close (vma);return 0 ;
@@ -813,7 +815,7 @@ void msm_gem_purge(struct drm_gem_object *obj)GEM_WARN_ON (!is_purgeable (msm_obj));/* Get rid of any iommu mapping(s): */ -put_iova_spaces (obj,NULL , false); +put_iova_spaces (obj,NULL , false,"purge" );msm_gem_vunmap (obj);
@@ -851,7 +853,7 @@ void msm_gem_evict(struct drm_gem_object *obj)GEM_WARN_ON (is_unevictable (msm_obj));/* Get rid of any iommu mapping(s): */ -put_iova_spaces (obj,NULL , false); +put_iova_spaces (obj,NULL , false,"evict" );drm_vma_node_unmap (&obj->vma_node, dev->anon_inode->i_mapping);
@@ -1063,7 +1065,7 @@ static void msm_gem_free_object(struct drm_gem_object *obj)drm_exec_retry_on_contention (&exec); } } -put_iova_spaces (obj,NULL , true); +put_iova_spaces (obj,NULL , true,"free" );drm_exec_fini (&exec);/* drop locks */ }
drivers/gpu/drm/msm/msm_gem.h +1 -1
@@ -168,7 +168,7 @@ struct msm_gem_vma {struct drm_gpuva *msm_gem_vma_new (struct drm_gpuvm *vm,struct drm_gem_object *obj,u64 offset,u64 range_start,u64 range_end); -void msm_gem_vma_unmap (struct drm_gpuva *vma); +void msm_gem_vma_unmap (struct drm_gpuva *vma,const char *reason);int msm_gem_vma_map (struct drm_gpuva *vma,int prot,struct sg_table *sgt);void msm_gem_vma_close (struct drm_gpuva *vma);
drivers/gpu/drm/msm/msm_gem_vma.c +12 -3
@@ -53,6 +53,9 @@ struct msm_vm_unmap_op {/** @range: size of region to unmap */ uint64_t range; +/** @reason: The reason for the unmap */ +const char *reason; +/** * @queue_id: The id of the submitqueue the operation is performed * on, or zero for (in particular) UNMAP ops triggered outside of
@@ -242,7 +245,12 @@ vm_log(struct msm_gem_vm *vm, const char *op, uint64_t iova, uint64_t range, intstatic void vm_unmap_op (struct msm_gem_vm *vm,const struct msm_vm_unmap_op *op) { -vm_log (vm,"unmap" , op->iova, op->range, op->queue_id); +const char *reason = op->reason; + +if (!reason) + reason ="unmap" ; + +vm_log (vm, reason, op->iova, op->range, op->queue_id); vm->mmu->funcs->unmap (vm->mmu, op->iova, op->range); }
@@ -257,7 +265,7 @@ vm_map_op(struct msm_gem_vm *vm, const struct msm_vm_map_op *op) }/* Actually unmap memory for the vma */ -void msm_gem_vma_unmap (struct drm_gpuva *vma) +void msm_gem_vma_unmap (struct drm_gpuva *vma,const char *reason) {struct msm_gem_vm *vm =to_msm_vm (vma->vm);struct msm_gem_vma *msm_vma =to_msm_vma (vma);
@@ -277,6 +285,7 @@ void msm_gem_vma_unmap(struct drm_gpuva *vma)vm_unmap_op (vm, &(struct msm_vm_unmap_op ){ .iova = vma->va.addr, .range = vma->va.range, + .reason = reason, });if (!vm->managed)
@@ -865,7 +874,7 @@ msm_gem_vm_close(struct drm_gpuvm *gpuvm)drm_exec_retry_on_contention (&exec); } -msm_gem_vma_unmap (vma); +msm_gem_vma_unmap (vma,"close" );msm_gem_vma_close (vma);if (obj) {
Signature · 1 line
2.49.0
PATCH v4 38/40 drm/msm: Add mmu prealloc tracepoint
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
So we can monitor how many pages are getting preallocated vs how many get used.
--- drivers/gpu/drm/msm/msm_gpu_trace.h | 14 ++++++++++++++ drivers/gpu/drm/msm/msm_iommu.c | 4 ++++ 2 files changed, 18 insertions(+)
drivers/gpu/drm/msm/msm_gpu_trace.h +14 -0
@@ -205,6 +205,20 @@ TRACE_EVENT(msm_gpu_preemption_irq,TP_printk ("preempted to %u" , __entry->ring_id) ); +TRACE_EVENT (msm_mmu_prealloc_cleanup, + TP_PROTO(u32 count, u32 remaining), +TP_ARGS (count, remaining), +TP_STRUCT__entry ( + __field(u32, count) +__field (u32, remaining) + ), +TP_fast_assign ( + __entry->count = count; + __entry->remaining = remaining; + ), +TP_printk ("count=%u, remaining=%u" , __entry->count, __entry->remaining) +); +#endif #undef TRACE_INCLUDE_PATH
drivers/gpu/drm/msm/msm_iommu.c +4 -0
@@ -8,6 +8,7 @@#include <linux/io-pgtable.h> #include <linux/kmemleak.h> #include "msm_drv.h" +#include "msm_gpu_trace.h" #include "msm_mmu.h" struct msm_iommu {
@@ -346,6 +347,9 @@ msm_iommu_pagetable_prealloc_cleanup(struct msm_mmu *mmu, struct msm_mmu_preallostruct kmem_cache *pt_cache =get_pt_cache (mmu);uint32_t remaining_pt_count = p->count - p->ptr; +if (p->count >0 ) +trace_msm_mmu_prealloc_cleanup (p->count, remaining_pt_count); +kmem_cache_free_bulk (pt_cache, remaining_pt_count, &p->pages[p->ptr]);kvfree (p->pages); }
Signature · 1 line
2.49.0
PATCH v4 39/40 drm/msm: use trylock for debugfs
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
This resolves a potential deadlock vs msm_gem_vm_close(). Otherwise for _NO_SHARE buffers msm_gem_describe() could be trying to acquire the shared vm resv, while already holding priv->obj_lock. But _vm_close() might drop the last reference to a GEM obj while already holding the vm resv, and msm_gem_free_object() needs to grab priv->obj_lock, a locking inversion.
OTOH this is only for debugfs and it isn't critical if we undercount by skipping a locked obj. So just use trylock() and move along if we can't get the lock.
--- drivers/gpu/drm/msm/msm_gem.c | 3 ++- drivers/gpu/drm/msm/msm_gem.h | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/msm/msm_gem.c +2 -1
@@ -922,7 +922,8 @@ void msm_gem_describe(struct drm_gem_object *obj, struct seq_file *m,uint64_t off =drm_vma_node_start (&obj->vma_node);const char *madv; -msm_gem_lock (obj); +if (!msm_gem_trylock (obj)) +return ; stats->all.count++; stats->all.size += obj->size;
drivers/gpu/drm/msm/msm_gem.h +6 -0
@@ -280,6 +280,12 @@ msm_gem_lock(struct drm_gem_object *obj)dma_resv_lock (obj->resv,NULL ); } +static inline bool __must_check +msm_gem_trylock (struct drm_gem_object *obj) +{ +return dma_resv_trylock (obj->resv); +} +static inline int msm_gem_lock_interruptible (struct drm_gem_object *obj) {
Signature · 1 line
2.49.0
PATCH v4 40/40 drm/msm: Bump UAPI version
In reply to Rob ClarkFrom: Rob Clark <[email protected]>
Bump version to signal to userspace that VM_BIND is supported.
--- drivers/gpu/drm/msm/msm_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/msm/msm_drv.c +2 -1
@@ -41,9 +41,10 @@* - 1.10.0 - Add MSM_SUBMIT_BO_NO_IMPLICIT * - 1.11.0 - Add wait boost (MSM_WAIT_FENCE_BOOST, MSM_PREP_BOOST) * - 1.12.0 - Add MSM_INFO_SET_METADATA and MSM_INFO_GET_METADATA +* - 1.13.0 - Add VM_BIND */ #define MSM_VERSION_MAJOR 1 -#define MSM_VERSION_MINOR 12 +#define MSM_VERSION_MINOR 13#define MSM_VERSION_PATCHLEVEL 0bool dumpstate;
Signature · 1 line
2.49.0