Skip to contentSkip to conversation

mach-snapdragon: of_fixup: Drop USB dr_mode override for RB1/2

PATCH Applied Sumit Garg 2 participants 2 messages May 16, 2025 – Jun 23, 2025

Subsystems (2)
lore
Share & tools
lore

Sumit Garg

author
#0 lore raw

PATCH 1/1 mach-snapdragon: of_fixup: Drop USB dr_mode override for RB1/2

From: Sumit Garg <[email protected]>

The default DIP switch configuration on RB1/2 is to enable flashing support via USB type-c port either using QDL or fastboot. It's just cumbersome to get the host mode working in U-Boot via DIP switch toggle when you need the flashing capability using the type-c port.

So instead lets enable fastboot in U-Boot for RB1/2 boards which is more useful in the default board DIP switch configuration. This let's us to drop dr_mode DT fixup.

---
 arch/arm/mach-snapdragon/of_fixup.c | 13 -------------
 1 file changed, 13 deletions(-)
arch/arm/mach-snapdragon/of_fixup.c +0 -13
index b398c6b7b9f..328c7812f30 100644
@@ -99,19 +99,6 @@ static int fixup_qcom_dwc3(struct device_node *root, struct device_node *glue_np
 		return ret;
 	}
 
-	/*
-	 * The RB1/2 boards only have a single USB controller and it's muxed between the type-C port
-	 * and a USB hub. Since we can't do OTG in U-Boot properly we prefer to put it into host mode.
-	 */
-	if (of_device_is_compatible(root, "qcom,qrb4210-rb2", NULL, NULL) ||
-	    of_device_is_compatible(root, "qcom,qrb2210-rb1", NULL, NULL)) {
-		ret = of_write_prop(dwc3, "dr_mode", sizeof("host"), "host");
-		if (ret) {
-			log_err("Failed to set 'dr_mode' property: %d\n", ret);
-			return ret;
-		}
-	}
-
 	return 0;
 }
 
Signature · 1 line
2.48.1
#1 lore raw
Quoted 10 lines · Sumit Garg

The default DIP switch configuration on RB1/2 is to enable flashing support via USB type-c port either using QDL or fastboot. It's just cumbersome to get the host mode working in U-Boot via DIP switch toggle when you need the flashing capability using the type-c port.

So instead lets enable fastboot in U-Boot for RB1/2 boards which is more useful in the default board DIP switch configuration. This let's us to drop dr_mode DT fixup.

[...]

Applied, thanks!

[1/1] mach-snapdragon: of_fixup: Drop USB dr_mode override for RB1/2

      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/fce945be04b7

Best regards,

Signature · 1 line
Casey Connolly <[email protected]>