Skip to contentSkip to conversation

Fix typo in cpu-on-off-test selftest script:

PATCH In review Jihed Chaibi 2 participants 2 messages May 17, 2025 – May 22, 2025 Kselftest

lore
Share & tools
lore

Jihed Chaibi

author
#0 lore raw

PATCH 1/1 Fix typo in cpu-on-off-test selftest script:

Fix typo in hotplaggable_offline_cpus function name:

"hotplaggable" is replaced by "hotpluggable"

Signed-off-by Jihed Chaibi <[email protected]>
---
 tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh +2 -2
index d5dc7e0dc..6232a46ca 100755
@@ -67,7 +67,7 @@ hotpluggable_cpus()
 	done
 }
 
-hotplaggable_offline_cpus()
+hotpluggable_offline_cpus()
 {
 	hotpluggable_cpus 0
 }

@@ -151,7 +151,7 @@ offline_cpu_expect_fail()
 
 online_all_hot_pluggable_cpus()
 {
-	for cpu in `hotplaggable_offline_cpus`; do
+	for cpu in `hotpluggable_offline_cpus`; do
 		online_cpu_expect_success $cpu
 	done
 }
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 6 lines · Jihed Chaibi

Fix typo in hotplaggable_offline_cpus function name:

"hotplaggable" is replaced by "hotpluggable"

Signed-off-by Jihed Chaibi <[email protected]>

---

Change looks good to me. Change log should specify the subsusystem. Check submitting patches document and refer to a few change logs for this file using git log.

Send v2 with a proper change log.

Quoted 17 lines
  tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh +1 -1
index d5dc7e0dc..6232a46ca 100755
@@ -67,7 +67,7 @@ hotpluggable_cpus()
  	done
  }
 
-hotplaggable_offline_cpus()
+hotpluggable_offline_cpus()
  {
  	hotpluggable_cpus 0
  }

tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh offline_cpu_expect_fail() · line 157

Quoted 8 lines
tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh +1 -1
@@ -151,7 +151,7 @@ offline_cpu_expect_fail()
 
  online_all_hot_pluggable_cpus()
  {
-	for cpu in `hotplaggable_offline_cpus`; do
+	for cpu in `hotpluggable_offline_cpus`; do
  		online_cpu_expect_success $cpu
  	done
  }

thanks,
-- Shuah