Skip to contentSkip to conversation

fs/nfsd/nfs4callback.c:1412 nfsd41_cb_referring_call() warn: '&rcl->__list' not removed from list

PATCH kernel test robot 1 participant 1 message May 17, 2025

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw

BCC: [email protected]
CC: [email protected]
TO: Chuck Lever <[email protected]>
CC: Jeff Layton <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux nfsd-testing
head:   d868e4920c3f4feefcbc17c5812bbe1a48af8c6f
commit: 4f3c8d8c9e109655311bbb4c6c46a54a9ef90d99 [3/93] NFSD: Implement CB_SEQUENCE referring call lists

:::::: branch date: 12 hours ago
:::::: commit date: 5 days ago
config: i386-randconfig-141-20250517 (https://download.01.org/0day-ci/archive/20250517/[email protected]/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags

| Reported-by: kernel test robot <[email protected]>
| Reported-by: Dan Carpenter <[email protected]>
| Closes: https://lore.kernel.org/r/[email protected]/

New smatch warnings:
fs/nfsd/nfs4callback.c:1412 nfsd41_cb_referring_call() warn: '&rcl->__list' not removed from list

Old smatch warnings:
include/linux/sunrpc/xdr.h:805 xdr_stream_decode_uint32_array() warn: potential user controlled sizeof overflow 'len * 4' '0-u32max * 4'

vim +1412 fs/nfsd/nfs4callback.c

2bbfed98a4d82a Trond Myklebust 2019-10-23  1350  
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1351  /**
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1352   * nfsd41_cb_referring_call - add a referring call to a callback operation
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1353   * @cb: context of callback to add the rc to
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1354   * @sessionid: referring call's session ID
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1355   * @slotid: referring call's session slot index
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1356   * @seqno: referring call's slot sequence number
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1357   *
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1358   * Caller serializes access to @cb.
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1359   *
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1360   * NB: If memory allocation fails, the referring call is not added.
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1361   */
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1362  void nfsd41_cb_referring_call(struct nfsd4_callback *cb,
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1363  			      struct nfs4_sessionid *sessionid,
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1364  			      u32 slotid, u32 seqno)
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1365  {
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1366  	struct nfsd4_referring_call_list *rcl;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1367  	struct nfsd4_referring_call *rc;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1368  	bool found;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1369  
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1370  	might_sleep();
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1371  
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1372  	found = false;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1373  	list_for_each_entry(rcl, &cb->cb_referring_call_list, __list) {
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1374  		if (!memcmp(rcl->rcl_sessionid.data, sessionid->data,
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1375  			   NFS4_MAX_SESSIONID_LEN)) {
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1376  			found = true;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1377  			break;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1378  		}
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1379  	}
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1380  	if (!found) {
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1381  		rcl = kmalloc(sizeof(*rcl), GFP_KERNEL);
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1382  		if (!rcl)
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1383  			return;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1384  		memcpy(rcl->rcl_sessionid.data, sessionid->data,
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1385  		       NFS4_MAX_SESSIONID_LEN);
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1386  		rcl->__nr_referring_calls = 0;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1387  		INIT_LIST_HEAD(&rcl->rcl_referring_calls);
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1388  		list_add(&rcl->__list, &cb->cb_referring_call_list);
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1389  		cb->cb_nr_referring_call_list++;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1390  	}
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1391  
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1392  	found = false;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1393  	list_for_each_entry(rc, &rcl->rcl_referring_calls, __list) {
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1394  		if (rc->rc_sequenceid == seqno && rc->rc_slotid == slotid) {
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1395  			found = true;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1396  			break;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1397  		}
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1398  	}
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1399  	if (!found) {
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1400  		rc = kmalloc(sizeof(*rc), GFP_KERNEL);
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1401  		if (!rc)
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1402  			goto out;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1403  		rc->rc_sequenceid = seqno;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1404  		rc->rc_slotid = slotid;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1405  		rcl->__nr_referring_calls++;
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1406  		list_add(&rc->__list, &rcl->rcl_referring_calls);
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1407  	}
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1408  
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1409  out:
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1410  	if (!rcl->__nr_referring_calls) {
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1411  		cb->cb_nr_referring_call_list--;
4f3c8d8c9e1096 Chuck Lever     2025-03-01 @1412  		kfree(rcl);
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1413  	}
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1414  }
4f3c8d8c9e1096 Chuck Lever     2025-03-01  1415  
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki