Skip to contentSkip to conversation

mm/damon/core: avoid destroyed target reference from DAMOS quota

PATCH Applied Akinobu Mita 2 participants 2 messages May 17, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/damon/core: avoid destroyed target reference from DAMOS quota

When the number of the monitoring targets in running contexts is reduced, there may be DAMOS quotas referencing the targets that will be destroyed.

Applying the scheme action for such DAMOS scheme will be skipped forever looking for the starting part of the region for the destroyed monitoring target.

To fix this issue, when the monitoring target is destroyed, reset the starting part for all DAMOS quotas that reference the target.

---
 mm/damon/core.c | 8 ++++++++
 1 file changed, 8 insertions(+)
mm/damon/core.c +8 -0
index 587fb9a4fef8..6df13586155b 100644
@@ -1093,9 +1093,17 @@ static int damon_commit_targets(
 			if (err)
 				return err;
 		} else {
+			struct damos *s;
+
 			if (damon_target_has_pid(dst))
 				put_pid(dst_target->pid);
 			damon_destroy_target(dst_target);
+			damon_for_each_scheme(s, dst) {
+				if (s->quota.charge_target_from == dst_target) {
+					s->quota.charge_target_from = NULL;
+					s->quota.charge_addr_from = 0;
+				}
+			}
 		}
 	}
 
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Sat, 17 May 2025 23:18:52 +0900 Akinobu Mita <[email protected]> wrote:

When the number of the monitoring targets in running contexts is reduced, there may be DAMOS quotas referencing the targets that will be destroyed.

Applying the scheme action for such DAMOS scheme will be skipped forever looking for the starting part of the region for the destroyed monitoring target.

Nice catch!

Quoted 4 lines

To fix this issue, when the monitoring target is destroyed, reset the starting part for all DAMOS quotas that reference the target.

I think this deserves below Fixes: tag?

Fixes da87878010e5 ("mm/damon/sysfs: support online inputs update")

For a clarification. The worst scenario consequence of this issue is DAMOS unexpectedly doing less or zero works under certain setups. No horrible problems such as a use after free will happen, though, since quota handling code references quota.charge_target_from, but does not de-reference it.

So I don't think this deserves Cc-ing stable@, but I'll let stable@ maintainers decide, as usual.

Quoted 2 lines

Thanks,
SJ

[...]