Convert Rockchip CDN DP binding to yaml
Subsystems (5)
v4 cover Convert Rockchip CDN DP binding to yaml
From: Chaoyi Chen <[email protected]>
This series convert cdn-dp-rockchip.txt to yaml.
PATCH 1 try to improve coding style on the existing rk3399 cdn-dp node.
PATCH 2 try to convert cdn-dp-rockchip.txt to yaml.
Both of them add new port@1 node that represents the CDN DP output to keep the same style as the other display interfaces.
Changes in v4:
- Link to V3: https://lore.kernel.org/all/[email protected]/
- Add commit about port@1 node
Changes in v3:
- Link to V2: https://lore.kernel.org/all/[email protected]/
- Add more description about phy/extcon
- Fix some coding style
Changes in v2:
- Link to V1: https://lore.kernel.org/all/[email protected]/
- Rename binding file name to match compatible
- Add more description about grf/phy/extcon
- Fix coding style
Chaoyi Chen (2):
arm64: dts: rockchip: Improve coding style for rk3399 cdn_dp
dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
.../display/rockchip/cdn-dp-rockchip.txt | 74 -------- .../rockchip/rockchip,rk3399-cdn-dp.yaml | 165 ++++++++++++++++++ arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 10 +- 3 files changed, 174 insertions(+), 75 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml
--
2.49.0
PATCH v4 1/2 arm64: dts: rockchip: Improve coding style for rk3399 cdn_dp
From: Chaoyi Chen <[email protected]>
Let's make the ports nodes of cdn_dp in the same style as the other display interface, and match the style of ports's yaml.
---
(no changes since v1)
arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-base.dtsi +9 -1
@@ -618,7 +618,11 @@ cdn_dp: dp@fec00000 { status = "disabled"; ports { - dp_in: port { + #address-cells = <1>; + #size-cells = <0>; + + dp_in: port@0 { + reg = <0>; #address-cells = <1>; #size-cells = <0>;
@@ -632,6 +636,10 @@ dp_in_vopl: endpoint@1 { remote-endpoint = <&vopl_out_dp>; }; }; + + dp_out: port@1 { + reg = <1>; + }; }; };
--
2.49.0
PATCH v4 2/2 dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
In reply to Chaoyi ChenFrom: Chaoyi Chen <[email protected]>
Convert cdn-dp-rockchip.txt to yaml.
Add port@1 which represents the CDN DP output to keep the same style as the other display interfaces.
---
Changes in v4:
- Add commit about port@1 node
Changes in v3:
- Add more description about phy/extcon
- Fix some coding style
Changes in v2:
- Rename binding file name to match compatible
- Add more description about grf/phy/extcon
- Fix coding style
.../display/rockchip/cdn-dp-rockchip.txt | 74 -------- .../rockchip/rockchip,rk3399-cdn-dp.yaml | 165 ++++++++++++++++++ 2 files changed, 165 insertions(+), 74 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml
Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt deleted +0 -74
@@ -1,74 +0,0 @@ -Rockchip RK3399 specific extensions to the cdn Display Port -================================ - -Required properties: -- compatible: must be "rockchip,rk3399-cdn-dp" - -- reg: physical base address of the controller and length - -- clocks: from common clock binding: handle to dp clock. - -- clock-names: from common clock binding: - Required elements: "core-clk" "pclk" "spdif" "grf" - -- resets : a list of phandle + reset specifier pairs -- reset-names : string of reset names - Required elements: "apb", "core", "dptx", "spdif" -- power-domains : power-domain property defined with a phandle - to respective power domain. -- assigned-clocks: main clock, should be <&cru SCLK_DP_CORE> -- assigned-clock-rates : the DP core clk frequency, shall be: 100000000 - -- rockchip,grf: this soc should set GRF regs, so need get grf here. - -- ports: contain a port nodes with endpoint definitions as defined in - Documentation/devicetree/bindings/media/video-interfaces.txt. - contained 2 endpoints, connecting to the output of vop. - -- phys: from general PHY binding: the phandle for the PHY device. - -- extcon: extcon specifier for the Power Delivery - -- #sound-dai-cells = it must be 1 if your system is using 2 DAIs: I2S, SPDIF - -------------------------------------------------------------------------------- - -Example: - cdn_dp: dp@fec00000 { - compatible = "rockchip,rk3399-cdn-dp"; - reg = <0x0 0xfec00000 0x0 0x100000>; - interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&cru SCLK_DP_CORE>, <&cru PCLK_DP_CTRL>, - <&cru SCLK_SPDIF_REC_DPTX>, <&cru PCLK_VIO_GRF>; - clock-names = "core-clk", "pclk", "spdif", "grf"; - assigned-clocks = <&cru SCLK_DP_CORE>; - assigned-clock-rates = <100000000>; - power-domains = <&power RK3399_PD_HDCP>; - phys = <&tcphy0_dp>, <&tcphy1_dp>; - resets = <&cru SRST_DPTX_SPDIF_REC>; - reset-names = "spdif"; - extcon = <&fusb0>, <&fusb1>; - rockchip,grf = <&grf>; - #address-cells = <1>; - #size-cells = <0>; - #sound-dai-cells = <1>; - - ports { - #address-cells = <1>; - #size-cells = <0>; - - dp_in: port { - #address-cells = <1>; - #size-cells = <0>; - dp_in_vopb: endpoint@0 { - reg = <0>; - remote-endpoint = <&vopb_out_dp>; - }; - - dp_in_vopl: endpoint@1 { - reg = <1>; - remote-endpoint = <&vopl_out_dp>; - }; - }; - }; - };
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +165 -0
165 lines not on this page · raw message
--
2.49.0
Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
Quoted 25 lines · Chaoyi Chen
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +25
-0+maintainers: + - Andy Yan <[email protected]> + - Heiko Stuebner <[email protected]> + - Sandy Huang <[email protected]> + +allOf: + - $ref: /schemas/sound/dai-common.yaml# + +properties: + compatible: + items: + - const: rockchip,rk3399-cdn-dp + + reg: + maxItems: 1 + + clocks: + items: + - description: DP core work clock + - description: APB clock + - description: SPDIF interface clock + - description: GRF clock + + clock-names: + items:
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 43
Quoted 10 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +10
-0+ - const: core-clk + - const: pclk + - const: spdif + - const: grf + + extcon: + $ref: /schemas/types.yaml#/definitions/phandle-array + items: + maxItems: 1 + maxItems: 2
Instead of this, list the items. Old binding said only "specifier", so this is technically a change, which should be explained in commit msg.
Quoted 4 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +4
-0+ description: + List of phandle to the extcon device providing the cable state for the DP PHY. + + interrupts:
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 57
Quoted 10 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +10
-0+ maxItems: 1 + + phys: + items: + maxItems: 1 + maxItems: 2 + description: | + List of phandle to the PHY device for DP output. + RK3399 have two DP-TPYEC PHY, specifying one PHY which want to use, + or specify two PHYs here to let the driver determine which PHY to use.
You do not allow one phy, so your description is not accurate. OTOH, original binding did not allow two phandles, so that's another change in the binding. You need to document all changes done to the binding in the commit msg.
Quoted 43 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +43
-0+ + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: Input of the CDN DP + properties: + endpoint@0: + description: Connection to the VOPB + endpoint@1: + description: Connection to the VOPL + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: Output of the CDN DP + + required: + - port@0 + - port@1 + + power-domains: + maxItems: 1 + + resets: + maxItems: 4 + + reset-names: + items: + - const: spdif + - const: dptx + - const: apb + - const: core + + rockchip,grf: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to GRF register to control HPD. + + "#sound-dai-cells": + const: 1 + +required:
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 110
Quoted 10 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +10
-0+ - compatible + - reg + - clocks + - clock-names + - interrupts + - phys + - ports + - resets + - reset-names + - rockchip,grf
sound-dai-cells was a required property.
Best regards,
Krzysztof
Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
Hi Krzysztof,
Quoted 30 lines · Krzysztof Kozlowski
Quoted 29 lines · Chaoyi Chen
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +29
-0+maintainers: + - Andy Yan <[email protected]> + - Heiko Stuebner <[email protected]> + - Sandy Huang <[email protected]> + +allOf: + - $ref: /schemas/sound/dai-common.yaml# + +properties: + compatible: + items: + - const: rockchip,rk3399-cdn-dp + + reg: + maxItems: 1 + + clocks: + items: + - description: DP core work clock + - description: APB clock + - description: SPDIF interface clock + - description: GRF clock + + clock-names: + items: + - const: core-clk + - const: pclk + - const: spdif + - const: grf
Quoted 8 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 43
Quoted 6 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +6
-0+ + extcon: + $ref: /schemas/types.yaml#/definitions/phandle-array + items: + maxItems: 1 + maxItems: 2Instead of this, list the items. Old binding said only "specifier", so this is technically a change, which should be explained in commit msg.
Will fix in v5.
Quoted 12 lines
Quoted 12 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +11
-0+ description: + List of phandle to the extcon device providing the cable state for the DP PHY. + + interrupts: + maxItems: 1 + + phys: + items: + maxItems: 1 + maxItems: 2 + description: |
Quoted 8 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 57
Quoted 3 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +3
-0+ List of phandle to the PHY device for DP output. + RK3399 have two DP-TPYEC PHY, specifying one PHY which want to use, + or specify two PHYs here to let the driver determine which PHY to use.You do not allow one phy, so your description is not accurate. OTOH, original binding did not allow two phandles, so that's another change in the binding. You need to document all changes done to the binding in the commit msg.
Oh, the original binding example use two phandles. I think only one PHY can also pass the dtb check here, or maybe I'm missing something else?
Quoted 48 lines
Quoted 48 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +47
-0+ + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: Input of the CDN DP + properties: + endpoint@0: + description: Connection to the VOPB + endpoint@1: + description: Connection to the VOPL + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: Output of the CDN DP + + required: + - port@0 + - port@1 + + power-domains: + maxItems: 1 + + resets: + maxItems: 4 + + reset-names: + items: + - const: spdif + - const: dptx + - const: apb + - const: core + + rockchip,grf: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to GRF register to control HPD. + + "#sound-dai-cells": + const: 1 + +required: + - compatible + - reg + - clocks + - clock-names
Quoted 9 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 110
Quoted 6 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +6
-0+ - interrupts + - phys + - ports + - resets + - reset-names + - rockchip,grfsound-dai-cells was a required property.
Okay, will add in v5.
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
Quoted 66 lines · Chaoyi Chen
Hi Krzysztof,
Quoted 30 lines · Krzysztof Kozlowski
Quoted 29 lines · Chaoyi Chen
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +29
-0+maintainers: + - Andy Yan <[email protected]> + - Heiko Stuebner <[email protected]> + - Sandy Huang <[email protected]> + +allOf: + - $ref: /schemas/sound/dai-common.yaml# + +properties: + compatible: + items: + - const: rockchip,rk3399-cdn-dp + + reg: + maxItems: 1 + + clocks: + items: + - description: DP core work clock + - description: APB clock + - description: SPDIF interface clock + - description: GRF clock + + clock-names: + items: + - const: core-clk + - const: pclk + - const: spdif + - const: grfQuoted 8 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 43
Quoted 6 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +6
-0+ + extcon: + $ref: /schemas/types.yaml#/definitions/phandle-array + items: + maxItems: 1 + maxItems: 2Instead of this, list the items. Old binding said only "specifier", so this is technically a change, which should be explained in commit msg.
Will fix in v5.
Quoted 12 lines
Quoted 12 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +11
-0+ description: + List of phandle to the extcon device providing the cable state for the DP PHY. + + interrupts: + maxItems: 1 + + phys: + items: + maxItems: 1 + maxItems: 2 + description: |Quoted 8 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 57
Quoted 3 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +3
-0+ List of phandle to the PHY device for DP output. + RK3399 have two DP-TPYEC PHY, specifying one PHY which want to use, + or specify two PHYs here to let the driver determine which PHY to use.You do not allow one phy, so your description is not accurate. OTOH, original binding did not allow two phandles, so that's another change in the binding. You need to document all changes done to the binding in the commit msg.
Quoted 1 line
Oh, the original binding example use two phandles. I think only one PHY can
Example is not the binding, just an example.
Quoted 1 line
also pass the dtb check here, or maybe I'm missing something else?
You think or you tested it? What is the minItems value? 2, so even if this works it's rather a bug in dtschema.
Also, inner maxItems:1 is not really correct. Why can't this work with different phy providers?
Best regards,
Krzysztof
Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
Hi Krzysztof,
Quoted 63 lines · Krzysztof Kozlowski
Quoted 62 lines · Chaoyi Chen
Hi Krzysztof,
Quoted 30 lines · Krzysztof Kozlowski
Quoted 29 lines · Chaoyi Chen
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +29
-0+maintainers: + - Andy Yan <[email protected]> + - Heiko Stuebner <[email protected]> + - Sandy Huang <[email protected]> + +allOf: + - $ref: /schemas/sound/dai-common.yaml# + +properties: + compatible: + items: + - const: rockchip,rk3399-cdn-dp + + reg: + maxItems: 1 + + clocks: + items: + - description: DP core work clock + - description: APB clock + - description: SPDIF interface clock + - description: GRF clock + + clock-names: + items: + - const: core-clk + - const: pclk + - const: spdif + - const: grfQuoted 8 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 43
Quoted 6 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +6
-0+ + extcon: + $ref: /schemas/types.yaml#/definitions/phandle-array + items: + maxItems: 1 + maxItems: 2Instead of this, list the items. Old binding said only "specifier", so this is technically a change, which should be explained in commit msg.
Will fix in v5.
Quoted 18 lines
Quoted 4 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +4
-0+ description: + List of phandle to the extcon device providing the cable state for the DP PHY. + + interrupts:Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml line 57
Quoted 10 lines
Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml new file +10
-0+ maxItems: 1 + + phys: + items: + maxItems: 1 + maxItems: 2 + description: | + List of phandle to the PHY device for DP output. + RK3399 have two DP-TPYEC PHY, specifying one PHY which want to use, + or specify two PHYs here to let the driver determine which PHY to use.You do not allow one phy, so your description is not accurate. OTOH, original binding did not allow two phandles, so that's another change in the binding. You need to document all changes done to the binding in the commit msg.
Quoted 6 lines
Quoted 1 line
Oh, the original binding example use two phandles. I think only one PHY can
Example is not the binding, just an example.
Quoted 1 line
also pass the dtb check here, or maybe I'm missing something else?
You think or you tested it? What is the minItems value? 2, so even if this works it's rather a bug in dtschema.
Yes I tested it. Both of "phys = <&tcphy0_dp>", "phys = <&tcphy0_dp>, <&tcphy1_dp>" pass the dtb check.
Quoted 3 lines
Also, inner maxItems:1 is not really correct. Why can't this work with different phy providers?
I'll see what other bindings do. Thanks for the clarification!
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip