loop: don't require ->write_iter for writable files in loop_configure
PATCH 1/1 loop: don't require ->write_iter for writable files in loop_configure
Block devices can be opened read-write even if they can't be written to for historic reasons. Remove the check requiring file->f_op->write_iter when the block devices was opened in loop_configure. The call to loop_check_backing_file just below ensures the ->write_iter is present for backing files opened for writing, which is the only check that is actually needed.
--- drivers/block/loop.c | 3 --- 1 file changed, 3 deletions(-)
drivers/block/loop.c +0 -3
@@ -979,9 +979,6 @@ static int loop_configure(struct loop_device *lo, blk_mode_t mode,if (!file)return -EBADF ; -if ((mode &BLK_OPEN_WRITE ) && !file->f_op->write_iter) -return -EINVAL ; - error =loop_check_backing_file (file);if (error)return error;
Signature · 1 line
2.47.2
Quoted 8 lines · Christoph Hellwig
Block devices can be opened read-write even if they can't be written to for historic reasons. Remove the check requiring
file->f_op->write_iterwhen the block devices was opened inloop_configure. The call toloop_check_backing_filejust below ensures the ->write_iter is present for backing files opened for writing, which is the only check that is actually needed.[...]
Applied, thanks!
[1/1] loop: don't require ->write_iter for writable files in loop_configure
commit: 355341e4359b2d5edf0ed5e117f7e9e7a0a5dac0
Best regards,
Signature · 1 line
Jens Axboe