PCI: Unnecessary linesplit in __pci_setup_bridge()
PATCH 1/1 PCI: Unnecessary linesplit in __pci_setup_bridge()
No need to split the line in __pci_setup_bridge() as it is way shorter than the limit.
--- drivers/pci/setup-bus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/pci/setup-bus.c +1 -2
@@ -772,8 +772,7 @@ static void __pci_setup_bridge(struct pci_bus *bus, unsigned long type) {struct pci_dev *bridge = bus->self; -pci_info (bridge,"PCI bridge to %pR\n" , - &bus->busn_res); +pci_info (bridge,"PCI bridge to %pR\n" , &bus->busn_res);if (type &IORESOURCE_IO )pci_setup_bridge_io (bridge);
base-commit: 7d06015d936c861160803e020f68f413b5c3cd9d
Signature · 1 line
2.39.5
Hello,
[...]
drivers/pci/setup-bus.c static void __pci_setup_bridge(struct pci_bus *bus, unsigned long type) · line 775
Quoted 3 lines
drivers/pci/setup-bus.c +1
-2-pci_info (bridge,"PCI bridge to %pR\n" , - &bus->busn_res); +pci_info (bridge,"PCI bridge to %pR\n" , &bus->busn_res);
I don't know if there still exists such a thing as "trivial patches maintainer" any more, so I will pull this.
I gather, it must have bothered you a bit. That said, Ilpo... your expertise and time could have been spent differently. :)
Thank you!
Krzysztof
Quoted 10 lines · Krzysztof Wilczyński
[...]
drivers/pci/setup-bus.c static void __pci_setup_bridge(struct pci_bus *bus, unsigned long type) · line 775
Quoted 3 lines
drivers/pci/setup-bus.c +1
-2-pci_info (bridge,"PCI bridge to %pR\n" , - &bus->busn_res); +pci_info (bridge,"PCI bridge to %pR\n" , &bus->busn_res);I don't know if there still exists such a thing as "trivial patches maintainer" any more, so I will pull this.
I gather, it must have bothered you a bit. That said, Ilpo... your expertise and time could have been spent differently. :)
It doesn't take long to do patches like this and I don't search for things like this intentionally nor focus on them. It's just that I do encounter these simple ones too while I'm spending my expertise differently :-). You can check my track record on discovering e.g. real concurrency issues recently so I hope you can give a bit slack on a few trivial patches here and there ;-).
Signature · 1 line
i.
Hello,
[...]
Quoted 3 lines
You can check my track record on discovering e.g. real concurrency issues recently so I hope you can give a bit slack on a few trivial patches here and there ;-).
We love your work! The unparalleled attention to details, especially. :)
On the topic of trivial patches... There has been a debate within the community at large about trivial patches, per:
https://lore.kernel.org/all/[email protected]/t/
Lot of opinions there... Ultimately, most of the time things are up to the maintainers, as per usual.
Thank you again for all your work! Much appreciated!
Krzysztof
Krzysztof Wilczyński
AppliedHello,
Quoted 4 lines
No need to split the line in
__pci_setup_bridge()as it is way shorter than the limit.
Applied to misc, thank you!
[1/1] PCI: Unnecessary linesplit in __pci_setup_bridge()
https://git.kernel.org/pci/pci/c/e57eb4f08f5a Krzysztof