Skip to contentSkip to conversation

staging: octeon: remove typedef declaration

PATCH In review Sunghun Son 2 participants 2 messages May 20, 2025 – May 21, 2025 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: octeon: remove typedef declaration

Remove typedef declaration from several structs.
Also replace related function signatures to reflect these changes. Issue found by checkpatch.pl

---
This is my first time contributing to the kernel.
I now understand how to enable modules through menuconfig.
The reason why 'my previous build' is not working is because I didn't enable the module in menuconfig. Please let me know if there are any issues.
Thank you.

 drivers/staging/octeon/ethernet.c     |  6 ++--
 drivers/staging/octeon/octeon-stubs.h | 49 +++++++++++++--------------
 2 files changed, 27 insertions(+), 28 deletions(-)
drivers/staging/octeon/ethernet.c +3 -3
index eadb74fc14c8..2f58a6c0e2e7 100644
@@ -201,8 +201,8 @@ EXPORT_SYMBOL(cvm_oct_free_work);
  */
 static struct net_device_stats *cvm_oct_common_get_stats(struct net_device *dev)
 {
-	cvmx_pip_port_status_t rx_status;
-	cvmx_pko_port_status_t tx_status;
+	struct cvmx_pip_port_status rx_status;
+	struct cvmx_pko_port_status_t tx_status;
 	struct octeon_ethernet *priv = netdev_priv(dev);
 
 	if (priv->port < CVMX_PIP_NUM_INPUT_PORTS) {
@@ -798,7 +798,7 @@ static int cvm_oct_probe(struct platform_device *pdev)
 
 	num_interfaces = cvmx_helper_get_number_of_interfaces();
 	for (interface = 0; interface < num_interfaces; interface++) {
-		cvmx_helper_interface_mode_t imode =
+		enum cvmx_helper_interface_mode imode =
 		    cvmx_helper_interface_get_mode(interface);
 		int num_ports = cvmx_helper_ports_on_interface(interface);
 		int port;
drivers/staging/octeon/octeon-stubs.h +24 -25

136 lines not on this page · raw message

Signature · 1 line
2.39.5
#1 lore raw
Quoted 11 lines · Sunghun Son

Remove typedef declaration from several structs.
Also replace related function signatures to reflect these changes. Issue found by checkpatch.pl

---
This is my first time contributing to the kernel.
I now understand how to enable modules through menuconfig.
The reason why 'my previous build' is not working is because I didn't enable the module in menuconfig. Please let me know if there are any issues.
Thank you.

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot