gpio: davinci: select GPIOLIB_IRQCHIP
PATCH 1/1 gpio: davinci: select GPIOLIB_IRQCHIP
From: Bartosz Golaszewski <[email protected]>
This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
---
Another one signalled by the build bot. Peng: if you could go through the other patches you sent and verify their dependencies are satisfied, that would be awesome.
drivers/gpio/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpio/Kconfig +1 -0
@@ -253,6 +253,7 @@ config GPIO_DAVINCI tristate "TI Davinci/Keystone GPIO support" default y if ARCH_DAVINCI depends on ((ARM || ARM64) && (ARCH_DAVINCI || ARCH_KEYSTONE || ARCH_K3)) || COMPILE_TEST + select GPIOLIB_IRQCHIP help Say yes here to enable GPIO support for TI Davinci/Keystone SoCs.
Signature · 1 line
2.48.1
Quoted 19 lines
Subject: [PATCH] gpio: davinci: select
GPIOLIB_IRQCHIPFrom: Bartosz Golaszewski <[email protected]>
This driver uses
gpiochip_irq_reqres()andgpiochip_irq_relres()which are only built with GPIOLIB_IRQCHIP=y. Add the missingKconfigselect.Fixes 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")Reported-by kernel test robot <[email protected]>Closes:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
lore.kernel.org%2Foe-kbuild-all%2F202505210606.PudPm5pC- lkp%40intel.com%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7Ca0 c5af787d854064539608dd983883ab%7C686ea1d3bc2b4c6fa92cd99c 5c301635%7C0%7C0%7C638834090666472921%7CUnknown%7CTW FpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAi OiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C& sdata=DMwJeyC%2Bu4xmb1Ijuf6erLE3EVgprzEW%2FR4Gjo55zOs%3D &reserved=0
Quoted 1 line
Signed-off-by Bartosz Golaszewski <[email protected]>
Quoted 4 lines
---
Another one signalled by the build bot. Peng: if you could go through the other patches you sent and verify their dependencies are satisfied, that would be awesome.
I tried all configs under arch/arm/configs/, no error with this patch applied. I will give a check on other archs.
Thanks,
Peng
Quoted 20 lines
drivers/gpio/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpio/Kconfig index renamed from drivers/gpio/Kconfig +0
-0
bbc71cdde9ed6..5bc31b56b5157100644drivers/gpio/Kconfig +0
-0@@ -253,6 +253,7 @@ config GPIO_DAVINCI tristate "TI Davinci/Keystone GPIO support" default y if ARCH_DAVINCI depends on ((ARM || ARM64) && (ARCH_DAVINCI ||
ARCH_KEYSTONE||ARCH_K3)) ||COMPILE_TESTdrivers/gpio/Kconfig +1
-0+ select GPIOLIB_IRQCHIP help Say yes here to enable GPIO support for TI Davinci/KeystoneSoCs.
--
2.48.1
Hi Bartosz,
Quoted 5 lines
Subject: RE: [PATCH] gpio: davinci: select
GPIOLIB_IRQCHIPQuoted 2 lines
Subject: [PATCH] gpio: davinci: select
GPIOLIB_IRQCHIP
Quoted 8 lines
Quoted 4 lines
---
Another one signalled by the build bot. Peng: if you could go through the other patches you sent and verify their dependencies are satisfied, that would be awesome.I tried all configs under
arch/arm/configs/, no error with this patch applied.
I will give a check on other archs.
For other Kconfig entries, would you help add a patch to select GPIOLIB_IRQCHIP for them all to avoid potential issue?
GPIO_TIMBERDALE: no configs select this entryGPIO_BCM_KONA: multi_v7_defconfig has GPIOLIB_IRQCHIP in .configGPIO_LPC18XX: lpc18xx_defconfig has GPIOLIB_IRQCHIP in .configGPIO_XGENE: arm64 defconfig has GPIOLIB_IRQCHIP in .configGPIO_GRGPIO: no configs select this entry
Thanks,
Peng
Quoted 25 lines
Thanks,
Pengdrivers/gpio/Kconfig config GPIO_DAVINCI · line 255
Quoted 12 lines
drivers/gpio/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpio/Kconfig index renamed from drivers/gpio/Kconfig +0
-0
bbc71cdde9ed6..5bc31b56b5157100644drivers/gpio/Kconfig +0
-0@@ -253,6 +253,7 @@ config GPIO_DAVINCI tristate "TI Davinci/Keystone GPIO support" default y if ARCH_DAVINCI depends on ((ARM || ARM64) && (ARCH_DAVINCI ||
ARCH_KEYSTONE||drivers/gpio/Kconfig config GPIO_DAVINCI
Quoted 4 lines
ARCH_K3)) ||COMPILE_TESTdrivers/gpio/Kconfig +1
-0+ select GPIOLIB_IRQCHIP help Say yes here to enable GPIO support for TI Davinci/KeystoneSoCs.
Quoted 3 lines
--
2.48.1
Quoted 17 lines · Peng Fan
Hi Bartosz,
Quoted 5 lines
Subject: RE: [PATCH] gpio: davinci: select
GPIOLIB_IRQCHIPQuoted 2 lines
Subject: [PATCH] gpio: davinci: select
GPIOLIB_IRQCHIPQuoted 8 lines
Quoted 4 lines
---
Another one signalled by the build bot. Peng: if you could go through the other patches you sent and verify their dependencies are satisfied, that would be awesome.I tried all configs under
arch/arm/configs/, no error with this patch applied.
I will give a check on other archs.
Quoted 9 lines
For other
Kconfigentries, would you help add a patch to selectGPIOLIB_IRQCHIPfor them all to avoid potential issue?
GPIO_TIMBERDALE: no configs select this entryGPIO_BCM_KONA:multi_v7_defconfighasGPIOLIB_IRQCHIPin .configGPIO_LPC18XX:lpc18xx_defconfighasGPIOLIB_IRQCHIPin .configGPIO_XGENE: arm64 defconfig hasGPIOLIB_IRQCHIPin .configGPIO_GRGPIO: no configs select this entry
I think all of them need to select GPIOLIB_IRQCHIP. Defconfig is not enough as a randconfig can still break in this case.
Bart
Quoted 26 lines
Subject: Re: [PATCH] gpio: davinci: select
GPIOLIB_IRQCHIPQuoted 17 lines · Peng Fan
Hi Bartosz,
Quoted 5 lines
Subject: RE: [PATCH] gpio: davinci: select
GPIOLIB_IRQCHIPQuoted 2 lines
Subject: [PATCH] gpio: davinci: select
GPIOLIB_IRQCHIPQuoted 8 lines
Quoted 4 lines
---
Another one signalled by the build bot. Peng: if you could go through the other patches you sent and verify their dependencies are satisfied, that would be awesome.I tried all configs under
arch/arm/configs/, no error with this patch applied.
I will give a check on other archs.Quoted 5 lines
For other
Kconfigentries, would you help add a patch to selectGPIOLIB_IRQCHIPfor them all to avoid potential issue?
GPIO_TIMBERDALE: no configs select this entryGPIO_BCM_KONA:multi_v7_defconfighasGPIOLIB_IRQCHIP
Quoted 8 lines
in .config
Quoted 4 lines
GPIO_LPC18XX:lpc18xx_defconfighasGPIOLIB_IRQCHIPin .configGPIO_XGENE: arm64 defconfig hasGPIOLIB_IRQCHIPin .configGPIO_GRGPIO: no configs select this entryI think all of them need to select
GPIOLIB_IRQCHIP. Defconfig is not enough as a randconfig can still break in this case.
ok. I will prepare a patchset soon for this.
Thanks,
Peng
Quoted 2 lines
Bart