Skip to contentSkip to conversation

arm64: dts: amlogic: Update USB hub power and reset properties

PATCH Superseded Anand Moon 1 participant 2 messages May 21, 2025

Subsystems (2)
Device tree bindings Arm/Amlogic Meson SoC support

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH v2 1/1 arm64: dts: amlogic: Update USB hub power and reset properties

Add missing reset-gpios property to the USB 2.0 hub node to ensure proper reset handling. Also update the vdd-supply for both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator for consistent power management. Remove usb2_phy1 phy-supply since now it's managed by the hub reset control.

Fixes ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Signed-off-by Anand Moon <[email protected]>

---
v2: remove usb2_phy1 phy-supply since now it's managed by the hub reset control.

---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +3 -7
index 3bca8023638d..d46b6aaef8fa 100644
@@ -42,7 +42,8 @@ hub_2_0: hub@1 {
 			compatible = "usb5e3,610";
 			reg = <1>;
 			peer-hub = <&hub_3_0>;
-			vdd-supply = <&usb_pwr_en>;
+			reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+			vdd-supply = <&hub_5v>;
 		};
 
 		/* 3.0 hub on port 4 */

@@ -51,7 +52,7 @@ hub_3_0: hub@2 {
 			reg = <2>;
 			peer-hub = <&hub_2_0>;
 			reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
-			vdd-supply = <&vcc_5v>;
+			vdd-supply = <&hub_5v>;
 		};
 	};
 

@@ -311,8 +312,3 @@ &toacodec {
 &usb {
 	vbus-supply = <&usb_pwr_en>;
 };
-
-&usb2_phy1 {
-	/* Enable the hub which is connected to this port */
-	phy-supply = <&hub_5v>;
-};

base-commit: 4a95bc121ccdaee04c4d72f84dbfa6b880a514b6

Signature · 1 line
2.49.0
author
#1 lore raw

Hi Neil,

Quoted 40 lines · Anand Moon

Add missing reset-gpios property to the USB 2.0 hub node to ensure proper reset handling. Also update the vdd-supply for both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator for consistent power management. Remove usb2_phy1 phy-supply since now it's managed by the hub reset control.

Fixes ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Signed-off-by Anand Moon <[email protected]>

---
v2: remove usb2_phy1 phy-supply since now it's managed by the hub reset control.

---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +3 -2
index 3bca8023638d..d46b6aaef8fa 100644
@@ -42,7 +42,8 @@ hub_2_0: hub@1 {
                        compatible = "usb5e3,610";
                        reg = <1>;
                        peer-hub = <&hub_3_0>;
-                       vdd-supply = <&usb_pwr_en>;
+                       reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+                       vdd-supply = <&hub_5v>;
                };
 
                /* 3.0 hub on port 4 */

@@ -51,7 +52,7 @@ hub_3_0: hub@2 {
                        reg = <2>;
                        peer-hub = <&hub_2_0>;
                        reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
-                       vdd-supply = <&vcc_5v>;
+                       vdd-supply = <&hub_5v>;
                };
        };

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi &toacodec { · line 318

Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +0 -5
@@ -311,8 +312,3 @@ &toacodec {
 &usb {
        vbus-supply = <&usb_pwr_en>;
 };
-
-&usb2_phy1 {
-       /* Enable the hub which is connected to this port */
-       phy-supply = <&hub_5v>;
-};

This is breaking the bring-up of dwc2 in u-boot
so could you consider V1 of the patch?

Thanks
-Anand

Quoted 5 lines

base-commit: 4a95bc121ccdaee04c4d72f84dbfa6b880a514b6 --
2.49.0