platform/x86: Add Lenovo WMI Gaming Series Drivers
Subsystems (5)
Derek J. Clark
maintainerv11 cover platform/x86: Add Lenovo WMI Gaming Series Drivers
Adds support for the Lenovo "Gaming Series" of laptop hardware that use WMI interfaces that control various power settings. There are multiple WMI interfaces that work in concert to provide getting and setting values as well as validation of input. Currently only the "Gamezone", "Other Mode", and "LENOVO_CAPABILITY_DATA_01" interfaces are implemented, but I attempted to structure the driver so that adding the "Custom Mode", "Lighting", and other data block interfaces would be trivial in later patches.
This driver attempts to standardize the exposed sysfs by mirroring the asus-armoury driver currently under review. As such, a lot of inspiration has been drawn from that driver.
https://lore.kernel.org/platform-driver-x86/[email protected]/#t
The drivers have been tested by me on the Lenovo Legion Go and Legion Go S.
---
v11:
- Fix formmating issues.
v10:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v9:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v8:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v7:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v6:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v5:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v4:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v3:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v2:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v1:
https://lore.kernel.org/platform-driver-x86/[email protected]/
Derek J. Clark (6):
platform/x86: Add lenovo-wmi-* driver Documentation platform/x86: Add lenovo-wmi-helpers platform/x86: Add Lenovo WMI Events Driver platform/x86: Add Lenovo Capability Data 01 WMI Driver platform/x86: Add Lenovo Gamezone WMI Driver platform/x86: Add Lenovo Other Mode WMI Driver
.../wmi/devices/lenovo-wmi-gamezone.rst | 203 ++++++ .../wmi/devices/lenovo-wmi-other.rst | 108 +++ MAINTAINERS | 12 + drivers/platform/x86/Kconfig | 41 ++ drivers/platform/x86/Makefile | 5 + drivers/platform/x86/lenovo-wmi-capdata01.c | 302 ++++++++ drivers/platform/x86/lenovo-wmi-capdata01.h | 25 + drivers/platform/x86/lenovo-wmi-events.c | 196 ++++++ drivers/platform/x86/lenovo-wmi-events.h | 20 + drivers/platform/x86/lenovo-wmi-gamezone.c | 407 +++++++++++ drivers/platform/x86/lenovo-wmi-gamezone.h | 20 + drivers/platform/x86/lenovo-wmi-helpers.c | 74 ++ drivers/platform/x86/lenovo-wmi-helpers.h | 20 + drivers/platform/x86/lenovo-wmi-other.c | 665 ++++++++++++++++++ drivers/platform/x86/lenovo-wmi-other.h | 16 + 15 files changed, 2114 insertions(+) create mode 100644 Documentation/wmi/devices/lenovo-wmi-gamezone.rst create mode 100644 Documentation/wmi/devices/lenovo-wmi-other.rst create mode 100644 drivers/platform/x86/lenovo-wmi-capdata01.c create mode 100644 drivers/platform/x86/lenovo-wmi-capdata01.h create mode 100644 drivers/platform/x86/lenovo-wmi-events.c create mode 100644 drivers/platform/x86/lenovo-wmi-events.h create mode 100644 drivers/platform/x86/lenovo-wmi-gamezone.c create mode 100644 drivers/platform/x86/lenovo-wmi-gamezone.h create mode 100644 drivers/platform/x86/lenovo-wmi-helpers.c create mode 100644 drivers/platform/x86/lenovo-wmi-helpers.h create mode 100644 drivers/platform/x86/lenovo-wmi-other.c create mode 100644 drivers/platform/x86/lenovo-wmi-other.h
Signature · 1 line
2.49.0
Derek J. Clark
maintainerPATCH v11 1/6 platform/x86: Add lenovo-wmi-* driver Documentation
Adds documentation for new lenovo-wmi drivers.
---
v11: No change
v10: No change
v9: No change
v8: No change
v7: No change
v6:
- Fix typos and requested rewordings from v5 review.
- Rename lenovo-wmi-other-method.rst to lenovo-wmi-other.rst, fixes warining and aligns documentation with driver name.
v5:
- Fix extra spaces in lenovo-wmi-gamezone.rst.
- Fix monospace for GUID's.
v4:
- Fixed MOF formatting issues.
- Fixed spelling mistakes.
- Updated description of balanced-performance profile for Gamezone.
- Updated description of thermal mode event GUID for Gamezone.
v3:
- Split documentation into multiple files, one for each parent driver for the Gamezone and Other Mode WMI interfaces.
- Add MOF data for all parent and child interfaces.
- Remove lenovo-wmi-camera.c driver from v2 documentation. v2:
- Update description of Custom Profile to include the need to manually set it.
- Remove all references to Legion hardware.
- Add section for lenovo-wmi-camera.c driver as it follows the same naming convention.
--- .../wmi/devices/lenovo-wmi-gamezone.rst | 203 ++++++++++++++++++ .../wmi/devices/lenovo-wmi-other.rst | 108 ++++++++++ MAINTAINERS | 7 + 3 files changed, 318 insertions(+) create mode 100644 Documentation/wmi/devices/lenovo-wmi-gamezone.rst create mode 100644 Documentation/wmi/devices/lenovo-wmi-other.rst
Documentation/wmi/devices/lenovo-wmi-gamezone.rst new file +203 -0
@@ -0,0 +1,203 @@ +.. SPDX-License-Identifier: GPL-2.0-or-later + +========================================================== +Lenovo WMI Interface Gamezone Driver (lenovo-wmi-gamezone) +========================================================== + +Introduction +============ +The Lenovo WMI gamezone interface is broken up into multiple GUIDs, +The primary "Gamezone" GUID provides advanced features such as fan +profiles and overclocking. It is paired with multiple event GUIDs +and data block GUIDs that provide context for the various methods. + +Gamezone Data +------------- + +WMI GUID ``887B54E3-DDDC-4B2C-8B88-68A26A8835D0`` + +The Gamezone Data WMI interface provides platform-profile and fan curve +settings for devices that fall under the "Gaming Series" of Lenovo devices. +It uses a notifier chain to inform other Lenovo WMI interface drivers of the +current platform profile when it changes. + +The following platform profiles are supported: + - low-power + - balanced + - balanced-performance + - performance + - custom + +Balanced-Performance +~~~~~~~~~~~~~~~~~~~~ +Some newer Lenovo "Gaming Series" laptops have an "Extreme Mode" profile +enabled in their BIOS. For these devices, the performance platform profile +corresponds to the BIOS Extreme Mode, while the balanced-performance +platform profile corresponds to the BIOS Performance mode. For legacy +devices, the performance platform profile will correspond with the BIOS +Performance mode. + +For some newer devices the "Extreme Mode" profile is incomplete in the BIOS +and setting it will cause undefined behavior. A BIOS bug quirk table is +provided to ensure these devices cannot set "Extreme Mode" from the driver. + +Custom Profile +~~~~~~~~~~~~~~ +The custom profile represents a hardware mode on Lenovo devices that enables +user modifications to Package Power Tracking (PPT) and fan curve settings. +When an attribute exposed by the Other Mode WMI interface is to be modified, +the Gamezone driver must first be switched to the "custom" profile manually, +or the setting will have no effect. If another profile is set from the list +of supported profiles, the BIOS will override any user PPT settings when +switching to that profile. + +Gamezone Thermal Mode Event +--------------------------- + +WMI GUID ``D320289E-8FEA-41E0-86F9-911D83151B5F`` + +The Gamezone Thermal Mode Event interface notifies the system when the platform +profile has changed, either through the hardware event (Fn+Q for laptops or +Legion + Y for Go Series), or through the Gamezone WMI interface. This event is +implemented in the Lenovo WMI Events driver (lenovo-wmi-events). + + +WMI interface description +========================= + +The WMI interface description can be decoded from the embedded binary MOF (bmof) +data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility: + +:: + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("LENOVO_GAMEZONE_DATA class"), guid("{887B54E3-DDDC-4B2C-8B88-68A26A8835D0}")] + class LENOVO_GAMEZONE_DATA { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiMethodId(4), Implemented, Description("Is SupportGpu OverClock")] void IsSupportGpuOC([out, Description("Is SupportGpu OverClock")] uint32 Data); + [WmiMethodId(11), Implemented, Description("Get AslCode Version")] void GetVersion ([out, Description("AslCode version")] UINT32 Data); + [WmiMethodId(12), Implemented, Description("Fan cooling capability")] void IsSupportFanCooling([out, Description("Fan cooling capability")] UINT32 Data); + [WmiMethodId(13), Implemented, Description("Set Fan cooling on/off")] void SetFanCooling ([in, Description("Set Fan cooling on/off")] UINT32 Data); + [WmiMethodId(14), Implemented, Description("cpu oc capability")] void IsSupportCpuOC ([out, Description("cpu oc capability")] UINT32 Data); + [WmiMethodId(15), Implemented, Description("bios has overclock capability")] void IsBIOSSupportOC ([out, Description("bios has overclock capability")] UINT32 Data); + [WmiMethodId(16), Implemented, Description("enable or disable overclock in bios")] void SetBIOSOC ([in, Description("enable or disable overclock in bios")] UINT32 Data); + [WmiMethodId(18), Implemented, Description("Get CPU temperature")] void GetCPUTemp ([out, Description("Get CPU temperature")] UINT32 Data); + [WmiMethodId(19), Implemented, Description("Get GPU temperature")] void GetGPUTemp ([out, Description("Get GPU temperature")] UINT32 Data); + [WmiMethodId(20), Implemented, Description("Get Fan cooling on/off status")] void GetFanCoolingStatus ([out, Description("Get Fan cooling on/off status")] UINT32 Data); + [WmiMethodId(21), Implemented, Description("EC support disable windows key capability")] void IsSupportDisableWinKey ([out, Description("EC support disable windows key capability")] UINT32 Data); + [WmiMethodId(22), Implemented, Description("Set windows key disable/enable")] void SetWinKeyStatus ([in, Description("Set windows key disable/enable")] UINT32 Data); + [WmiMethodId(23), Implemented, Description("Get windows key disable/enable status")] void GetWinKeyStatus ([out, Description("Get windows key disable/enable status")] UINT32 Data); + [WmiMethodId(24), Implemented, Description("EC support disable touchpad capability")] void IsSupportDisableTP ([out, Description("EC support disable touchpad capability")] UINT32 Data); + [WmiMethodId(25), Implemented, Description("Set touchpad disable/enable")] void SetTPStatus ([in, Description("Set touchpad disable/enable")] UINT32 Data); + [WmiMethodId(26), Implemented, Description("Get touchpad disable/enable status")] void GetTPStatus ([out, Description("Get touchpad disable/enable status")] UINT32 Data); + [WmiMethodId(30), Implemented, Description("Get Keyboard feature list")] void GetKeyboardfeaturelist ([out, Description("Get Keyboard feature list")] UINT32 Data); + [WmiMethodId(31), Implemented, Description("Get Memory OC Information")] void GetMemoryOCInfo ([out, Description("Get Memory OC Information")] UINT32 Data); + [WmiMethodId(32), Implemented, Description("Water Cooling feature capability")] void IsSupportWaterCooling ([out, Description("Water Cooling feature capability")] UINT32 Data); + [WmiMethodId(33), Implemented, Description("Set Water Cooling status")] void SetWaterCoolingStatus ([in, Description("Set Water Cooling status")] UINT32 Data); + [WmiMethodId(34), Implemented, Description("Get Water Cooling status")] void GetWaterCoolingStatus ([out, Description("Get Water Cooling status")] UINT32 Data); + [WmiMethodId(35), Implemented, Description("Lighting feature capability")] void IsSupportLightingFeature ([out, Description("Lighting feature capability")] UINT32 Data); + [WmiMethodId(36), Implemented, Description("Set keyboard light off or on to max")] void SetKeyboardLight ([in, Description("keyboard light off or on switch")] UINT32 Data); + [WmiMethodId(37), Implemented, Description("Get keyboard light on/off status")] void GetKeyboardLight ([out, Description("Get keyboard light on/off status")] UINT32 Data); + [WmiMethodId(38), Implemented, Description("Get Macrokey scan code")] void GetMacrokeyScancode ([in, Description("Macrokey index")] UINT32 idx, [out, Description("Scan code")] UINT32 scancode); + [WmiMethodId(39), Implemented, Description("Get Macrokey count")] void GetMacrokeyCount ([out, Description("Macrokey count")] UINT32 Data); + [WmiMethodId(40), Implemented, Description("Support G-Sync feature")] void IsSupportGSync ([out, Description("Support G-Sync feature")] UINT32 Data); + [WmiMethodId(41), Implemented, Description("Get G-Sync Status")] void GetGSyncStatus ([out, Description("Get G-Sync Status")] UINT32 Data); + [WmiMethodId(42), Implemented, Description("Set G-Sync Status")] void SetGSyncStatus ([in, Description("Set G-Sync Status")] UINT32 Data); + [WmiMethodId(43), Implemented, Description("Support Smart Fan feature")] void IsSupportSmartFan ([out, Description("Support Smart Fan feature")] UINT32 Data); + [WmiMethodId(44), Implemented, Description("Set Smart Fan Mode")] void SetSmartFanMode ([in, Description("Set Smart Fan Mode")] UINT32 Data); + [WmiMethodId(45), Implemented, Description("Get Smart Fan Mode")] void GetSmartFanMode ([out, Description("Get Smart Fan Mode")] UINT32 Data); + [WmiMethodId(46), Implemented, Description("Get Smart Fan Setting Mode")] void GetSmartFanSetting ([out, Description("Get Smart Setting Mode")] UINT32 Data); + [WmiMethodId(47), Implemented, Description("Get Power Charge Mode")] void GetPowerChargeMode ([out, Description("Get Power Charge Mode")] UINT32 Data); + [WmiMethodId(48), Implemented, Description("Get Gaming Product Info")] void GetProductInfo ([out, Description("Get Gaming Product Info")] UINT32 Data); + [WmiMethodId(49), Implemented, Description("Over Drive feature capability")] void IsSupportOD ([out, Description("Over Drive feature capability")] UINT32 Data); + [WmiMethodId(50), Implemented, Description("Get Over Drive status")] void GetODStatus ([out, Description("Get Over Drive status")] UINT32 Data); + [WmiMethodId(51), Implemented, Description("Set Over Drive status")] void SetODStatus ([in, Description("Set Over Drive status")] UINT32 Data); + [WmiMethodId(52), Implemented, Description("Set Light Control Owner")] void SetLightControlOwner ([in, Description("Set Light Control Owner")] UINT32 Data); + [WmiMethodId(53), Implemented, Description("Set DDS Control Owner")] void SetDDSControlOwner ([in, Description("Set DDS Control Owner")] UINT32 Data); + [WmiMethodId(54), Implemented, Description("Get the flag of restore OC value")] void IsRestoreOCValue ([in, Description("Clean this flag")] UINT32 idx, [out, Description("Restore oc value flag")] UINT32 Data); + [WmiMethodId(55), Implemented, Description("Get Real Thremal Mode")] void GetThermalMode ([out, Description("Real Thremal Mode")] UINT32 Data); + [WmiMethodId(56), Implemented, Description("Get the OC switch status in BIOS")] void GetBIOSOCMode ([out, Description("OC Mode")] UINT32 Data); + [WmiMethodId(59), Implemented, Description("Get hardware info support version")] void GetHardwareInfoSupportVersion ([out, Description("version")] UINT32 Data); + [WmiMethodId(60), Implemented, Description("Get Cpu core 0 max frequency")] void GetCpuFrequency ([out, Description("frequency")] UINT32 Data); + [WmiMethodId(62), Implemented, Description("Check the Adapter type fit for OC")] void IsACFitForOC ([out, Description("AC check result")] UINT32 Data); + [WmiMethodId(63), Implemented, Description("Is support IGPU mode")] void IsSupportIGPUMode ([out, Description("IGPU modes")] UINT32 Data); + [WmiMethodId(64), Implemented, Description("Get IGPU Mode Status")] void GetIGPUModeStatus([out, Description("IGPU Mode Status")] UINT32 Data); + [WmiMethodId(65), Implemented, Description("Set IGPU Mode")] void SetIGPUModeStatus([in, Description("IGPU Mode")] UINT32 mode, [out, Description("return code")] UINT32 Data); + [WmiMethodId(66), Implemented, Description("Notify DGPU Status")] void NotifyDGPUStatus([in, Description("DGPU status")] UINT32 status, [out, Description("return code")] UINT32 Data); + [WmiMethodId(67), Implemented, Description("Is changed Y log")] void IsChangedYLog([out, Description("Is changed Y Log")] UINT32 Data); + [WmiMethodId(68), Implemented, Description("Get DGPU Hardwawre ID")] void GetDGPUHWId([out, Description("Get DGPU Hardware ID")] string Data); + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Definition of CPU OC parameter list"), guid("{B7F3CA0A-ACDC-42D2-9217-77C6C628FBD2}")] + class LENOVO_GAMEZONE_CPU_OC_DATA { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("OC tune id.")] uint32 Tuneid; + [WmiDataId(2), read, Description("Default value.")] uint32 DefaultValue; + [WmiDataId(3), read, Description("OC Value.")] uint32 OCValue; + [WmiDataId(4), read, Description("Min Value.")] uint32 MinValue; + [WmiDataId(5), read, Description("Max Value.")] uint32 MaxValue; + [WmiDataId(6), read, Description("Scale Value.")] uint32 ScaleValue; + [WmiDataId(7), read, Description("OC Order id.")] uint32 OCOrderid; + [WmiDataId(8), read, Description("NON-OC Order id.")] uint32 NOCOrderid; + [WmiDataId(9), read, Description("Delay time in ms.")] uint32 Interval; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Definition of GPU OC parameter list"), guid("{887B54E2-DDDC-4B2C-8B88-68A26A8835D0}")] + class LENOVO_GAMEZONE_GPU_OC_DATA { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("P-State ID.")] uint32 PStateID; + [WmiDataId(2), read, Description("CLOCK ID.")] uint32 ClockID; + [WmiDataId(3), read, Description("Default value.")] uint32 defaultvalue; + [WmiDataId(4), read, Description("OC Offset freqency.")] uint32 OCOffsetFreq; + [WmiDataId(5), read, Description("OC Min offset value.")] uint32 OCMinOffset; + [WmiDataId(6), read, Description("OC Max offset value.")] uint32 OCMaxOffset; + [WmiDataId(7), read, Description("OC Offset Scale.")] uint32 OCOffsetScale; + [WmiDataId(8), read, Description("OC Order id.")] uint32 OCOrderid; + [WmiDataId(9), read, Description("NON-OC Order id.")] uint32 NOCOrderid; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Fancooling finish event"), guid("{BC72A435-E8C1-4275-B3E2-D8B8074ABA59}")] + class LENOVO_GAMEZONE_FAN_COOLING_EVENT: WMIEvent { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("Fancooling clean finish event")] uint32 EventId; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Smart Fan mode change event"), guid("{D320289E-8FEA-41E0-86F9-611D83151B5F}")] + class LENOVO_GAMEZONE_SMART_FAN_MODE_EVENT: WMIEvent { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("Smart Fan Mode change event")] uint32 mode; + [WmiDataId(2), read, Description("version of FN+Q")] uint32 version; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Smart Fan setting mode change event"), guid("{D320289E-8FEA-41E1-86F9-611D83151B5F}")] + class LENOVO_GAMEZONE_SMART_FAN_SETTING_EVENT: WMIEvent { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("Smart Fan Setting mode change event")] uint32 mode; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("POWER CHARGE MODE Change EVENT"), guid("{D320289E-8FEA-41E0-86F9-711D83151B5F}")] + class LENOVO_GAMEZONE_POWER_CHARGE_MODE_EVENT: WMIEvent { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("POWER CHARGE MODE Change EVENT")] uint32 mode; + }; + + [WMI, Dynamic, Provider("WmiProv"), Locale("MS\\0x409"), Description("Thermal Mode Real Mode change event"), guid("{D320289E-8FEA-41E0-86F9-911D83151B5F}")] + class LENOVO_GAMEZONE_THERMAL_MODE_EVENT: WMIEvent { + [key, read] string InstanceName; + [read] boolean Active; + + [WmiDataId(1), read, Description("Thermal Mode Real Mode")] uint32 mode; + };
Documentation/wmi/devices/lenovo-wmi-other.rst new file +108 -0
108 lines not on this page · raw message
MAINTAINERS +7 -0
@@ -13158,6 +13158,13 @@ S: Maintained W: http://legousb.sourceforge.net/ F: drivers/usb/misc/legousbtower.c +LENOVO WMI DRIVERS +M: Derek J. Clark <[email protected]> +L: [email protected] +S: Maintained +F: Documentation/wmi/devices/lenovo-wmi-gamezone.rst +F: Documentation/wmi/devices/lenovo-wmi-other.rst + LENOVO WMI HOTKEY UTILITIES DRIVER M: Jackie Dong <[email protected]> L: [email protected]
Signature · 1 line
2.49.0
Derek J. Clark
maintainerPATCH v11 2/6 platform/x86: Add lenovo-wmi-helpers
In reply to Derek J. ClarkAdds lenovo-wmi-helpers, which provides a common wrapper function for wmidev_evaluate_method that does data validation and error handling.
---
v11:
- Formatting
v10: No change
v9: Fix missing newline before return in lwmi_dev_evaluate_int
v8: No change
v7:
- Fix typos
v6:
- Fix typos and rewordings from v5 review.
v5:
- Fixes from v4 review.
- Combine all previous methods into a single function that takes a buffer for the wmi method arguments.
v4:
- Changed namespace to LENOVO_WMI_HELPERS from LENOVO_WMI.
- Changed filenames to lenovo-wmi-helpers from lenovo-wmi.
- Removed structs and functions implemented by other drivers.
--- MAINTAINERS | 1 + drivers/platform/x86/Kconfig | 4 ++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/lenovo-wmi-helpers.c | 74 +++++++++++++++++++++++ drivers/platform/x86/lenovo-wmi-helpers.h | 20 ++++++ 5 files changed, 100 insertions(+) create mode 100644 drivers/platform/x86/lenovo-wmi-helpers.c create mode 100644 drivers/platform/x86/lenovo-wmi-helpers.h
MAINTAINERS +1 -0
@@ -13164,6 +13164,7 @@ L: [email protected] S: Maintained F: Documentation/wmi/devices/lenovo-wmi-gamezone.rst F: Documentation/wmi/devices/lenovo-wmi-other.rst +F: drivers/platform/x86/lenovo-wmi-helpers.* LENOVO WMI HOTKEY UTILITIES DRIVER M: Jackie Dong <[email protected]>
drivers/platform/x86/Kconfig +4 -0
@@ -459,6 +459,10 @@ config IBM_RTL state = 0 (BIOS SMIs on) state = 1 (BIOS SMIs off) +config LENOVO_WMI_HELPERS + tristate + depends on ACPI_WMI + config IDEAPAD_LAPTOP tristate "Lenovo IdeaPad Laptop Extras" depends on ACPI
drivers/platform/x86/Makefile +1 -0
@@ -69,6 +69,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o obj-$(CONFIG_YOGABOOK) += lenovo-yogabook.o obj-$(CONFIG_YT2_1380) += lenovo-yoga-tab2-pro-1380-fastcharger.o obj-$(CONFIG_LENOVO_WMI_CAMERA) += lenovo-wmi-camera.o +obj-$(CONFIG_LENOVO_WMI_HELPERS) += lenovo-wmi-helpers.o # Intel obj-y += intel/
drivers/platform/x86/lenovo-wmi-helpers.c new file +74 -0
74 lines not on this page · raw message
drivers/platform/x86/lenovo-wmi-helpers.h new file +20 -0
@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/* Copyright (C) 2025 Derek J. Clark <[email protected]> */ + +#ifndef _LENOVO_WMI_HELPERS_H_ +#define _LENOVO_WMI_HELPERS_H_ + +#include <linux/types.h> + +struct wmi_device ; + +struct wmi_method_args_32 { +u32 arg0; +u32 arg1; +}; + +int lwmi_dev_evaluate_int (struct wmi_device *wdev,u8 instance,u32 method_id, +unsigned char *buf,size_t size,u32 *retval); + +#endif /* !_LENOVO_WMI_HELPERS_H_ */
Signature · 1 line
2.49.0
Derek J. Clark
maintainerPATCH v11 3/6 platform/x86: Add Lenovo WMI Events Driver
In reply to Derek J. ClarkAdds lenovo-wmi-events driver. The events driver is designed as a general entrypoint for all Lenovo WMI Events. It acts as a notification chain head that will process event data and pass it on to registered drivers so they can react to the events.
Currently only the Gamezone interface Thermal Mode Event GUID is implemented in this driver. It is documented in the Gamezone documentation.
---
v11:
- Formatting
v10: No change
v9: No change
v8: No change
v7:
- Fix typos
v6:
- Fix typos and rewordings to ensure consistancy in function description text.
v5:
- Fixes from v4 review.
v4:
- Remove the Thermal Mode Event GUID from Gamezone and add this driver.
--- MAINTAINERS | 1 + drivers/platform/x86/Kconfig | 4 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/lenovo-wmi-events.c | 196 +++++++++++++++++++++++ drivers/platform/x86/lenovo-wmi-events.h | 20 +++ 5 files changed, 222 insertions(+) create mode 100644 drivers/platform/x86/lenovo-wmi-events.c create mode 100644 drivers/platform/x86/lenovo-wmi-events.h
MAINTAINERS +1 -0
@@ -13164,6 +13164,7 @@ L: [email protected] S: Maintained F: Documentation/wmi/devices/lenovo-wmi-gamezone.rst F: Documentation/wmi/devices/lenovo-wmi-other.rst +F: drivers/platform/x86/lenovo-wmi-events.* F: drivers/platform/x86/lenovo-wmi-helpers.* LENOVO WMI HOTKEY UTILITIES DRIVER
drivers/platform/x86/Kconfig +4 -0
@@ -459,6 +459,10 @@ config IBM_RTL state = 0 (BIOS SMIs on) state = 1 (BIOS SMIs off) +config LENOVO_WMI_EVENTS + tristate + depends on ACPI_WMI + config LENOVO_WMI_HELPERS tristate depends on ACPI_WMI
drivers/platform/x86/Makefile +1 -0
@@ -69,6 +69,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o obj-$(CONFIG_YOGABOOK) += lenovo-yogabook.o obj-$(CONFIG_YT2_1380) += lenovo-yoga-tab2-pro-1380-fastcharger.o obj-$(CONFIG_LENOVO_WMI_CAMERA) += lenovo-wmi-camera.o +obj-$(CONFIG_LENOVO_WMI_EVENTS) += lenovo-wmi-events.o obj-$(CONFIG_LENOVO_WMI_HELPERS) += lenovo-wmi-helpers.o # Intel
drivers/platform/x86/lenovo-wmi-events.c new file +196 -0
196 lines not on this page · raw message
drivers/platform/x86/lenovo-wmi-events.h new file +20 -0
@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/* Copyright (C) 2025 Derek J. Clark <[email protected]> */ + +#ifndef _LENOVO_WMI_EVENTS_H_ +#define _LENOVO_WMI_EVENTS_H_ + +struct device ; +struct notifier_block ; + +enum lwmi_events_type { +LWMI_EVENT_THERMAL_MODE =1 , +}; + +int lwmi_events_register_notifier (struct notifier_block *nb); +int lwmi_events_unregister_notifier (struct notifier_block *nb); +int devm_lwmi_events_register_notifier (struct device *dev, +struct notifier_block *nb); + +#endif /* !_LENOVO_WMI_EVENTS_H_ */
Signature · 1 line
2.49.0
Derek J. Clark
maintainerPATCH v11 4/6 platform/x86: Add Lenovo Capability Data 01 WMI Driver
In reply to Derek J. ClarkAdds lenovo-wmi-capdata01 driver which provides the LENOVO_CAPABILITY_DATA_01 WMI data block that comes on "Other Mode" enabled hardware. Provides an interface for querying if a given attribute is supported by the hardware, as well as its default_value, max_value, min_value, and step increment.
---
v11:
- Formatting cd
v10: No change
v9:
- Check result of devm_mutex_init.
v8:
- Use devm_mutex_init() instead of mutex_init().
- Check return of devm_add_action_or_reset during probe.
- Don't check if cd01 list exists in bind as the driver will bail if there is a malloc/populating issue prior to bind.
- Fix typos.
v7:
- Do memcpy instead of returning pointer in lwmi_cd01_get_data.
- Put list mutex inside lwmi_cd01_priv struct.
- Unregister from acpi events on dev remove.
- Fix typos.
v6:
- Recache capabiltiy data on ACPI AC events to ensure accutare max_value.
- Fix typos and rewordings from v5 review.
v5:
- Return to cache at device initialization. On component bind, pass a pointer to lenovo-wmi-other.
- Fixes from v4 review.
v4:
- Make driver data a private struct, remove references from Other Mode driver.
- Don't cache data at device initialization. Instead, on component bind, cache the data on a member variable of the Other Mode driver data passed as a void pointer.
- Add header file for capdata01 structs.
- Add new struct to pass capdata01 array data and array length to Other Mode.
v3:
- Add as component to lenovo-wmi-other driver.
v2:
- Use devm_kmalloc to ensure driver can be instanced, remove global reference.
- Ensure reverse Christmas tree for all variable declarations.
- Remove extra whitespace.
- Use guard(mutex) in all mutex instances, global mutex.
- Use pr_fmt instead of adding the driver name to each pr_err.
- Remove noisy pr_info usage.
- Rename capdata_wmi to lenovo_wmi_cd01_priv and cd01_wmi to priv.
- Use list to get the lenovo_wmi_cd01_priv instance in lenovo_wmi_capdata01_get as none of the data provided by the macros that will use it can pass a member of the struct for use in container_of.
--- MAINTAINERS | 1 + drivers/platform/x86/Kconfig | 4 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/lenovo-wmi-capdata01.c | 302 ++++++++++++++++++++ drivers/platform/x86/lenovo-wmi-capdata01.h | 25 ++ 5 files changed, 333 insertions(+) create mode 100644 drivers/platform/x86/lenovo-wmi-capdata01.c create mode 100644 drivers/platform/x86/lenovo-wmi-capdata01.h
MAINTAINERS +1 -0
@@ -13164,6 +13164,7 @@ L: [email protected] S: Maintained F: Documentation/wmi/devices/lenovo-wmi-gamezone.rst F: Documentation/wmi/devices/lenovo-wmi-other.rst +F: drivers/platform/x86/lenovo-wmi-capdata01.* F: drivers/platform/x86/lenovo-wmi-events.* F: drivers/platform/x86/lenovo-wmi-helpers.*
drivers/platform/x86/Kconfig +4 -0
@@ -467,6 +467,10 @@ config LENOVO_WMI_HELPERS tristate depends on ACPI_WMI +config LENOVO_WMI_DATA01 + tristate + depends on ACPI_WMI + config IDEAPAD_LAPTOP tristate "Lenovo IdeaPad Laptop Extras" depends on ACPI
drivers/platform/x86/Makefile +1 -0
@@ -69,6 +69,7 @@ obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o obj-$(CONFIG_YOGABOOK) += lenovo-yogabook.o obj-$(CONFIG_YT2_1380) += lenovo-yoga-tab2-pro-1380-fastcharger.o obj-$(CONFIG_LENOVO_WMI_CAMERA) += lenovo-wmi-camera.o +obj-$(CONFIG_LENOVO_WMI_DATA01) += lenovo-wmi-capdata01.o obj-$(CONFIG_LENOVO_WMI_EVENTS) += lenovo-wmi-events.o obj-$(CONFIG_LENOVO_WMI_HELPERS) += lenovo-wmi-helpers.o
drivers/platform/x86/lenovo-wmi-capdata01.c new file +302 -0
302 lines not on this page · raw message
drivers/platform/x86/lenovo-wmi-capdata01.h new file +25 -0
@@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/* Copyright (C) 2025 Derek J. Clark <[email protected]> */ + +#ifndef _LENOVO_WMI_CAPDATA01_H_ +#define _LENOVO_WMI_CAPDATA01_H_ + +#include <linux/types.h> + +struct device ; +struct cd01_list ; + +struct capdata01 { +u32 id; +u32 supported; +u32 default_value; +u32 step; +u32 min_value; +u32 max_value; +}; + +int lwmi_cd01_get_data (struct cd01_list *list,u32 attribute_id,struct capdata01 *output); +int lwmi_cd01_match (struct device *dev,void *data); + +#endif /* !_LENOVO_WMI_CAPDATA01_H_ */
Signature · 1 line
2.49.0
Derek J. Clark
maintainerPATCH v11 5/6 platform/x86: Add Lenovo Gamezone WMI Driver
In reply to Derek J. ClarkAdds lenovo-wmi-gamezone driver which provides the Lenovo Gamezone WMI interface that comes on Lenovo "Gaming Series" hardware. Provides ACPI platform profiles over WMI.
---
v11:
- Formatting.
v10: No change
v9:
- Pass NULL instead of 0 in lwmi_dev_evaluate_int where no args buffer was used.
v8:
- Remove RW from lock comment.
v7:
- Move spinlock into lwmi_gz_priv.
- Add scoped_guard at missing location.
- Move adding lwmi_gz_mode_call up in the series. While its only used by lenovo-wmi-other, it doesn't depend on it.
- Return instead of assigning ret at end of probe.
- Fix typos.
v6:
- Recache capabiltiy data on ACPI AC events to ensure accutare max_value.
- Fix typos and rewordings from v5 review.
v5:
- Return to cache at device initialization. On component bind, pass a pointer to lenovo-wmi-other.
- Fixes from v4 review.
v4:
- Make driver data a private struct, remove references from Other Mode driver.
- Don't cache data at device initialization. Instead, on component bind, cache the data on a member variable of the Other Mode driver data passed as a void pointer.
- Add header file for capdata01 structs.
- Add new struct to pass capdata01 array data and array length to Other Mode.
v3:
- Add as component to lenovo-wmi-other driver.
v2:
- Use devm_kmalloc to ensure driver can be instanced, remove global reference.
- Ensure reverse Christmas tree for all variable declarations.
- Remove extra whitespace.
- Use guard(mutex) in all mutex instances, global mutex.
- Use pr_fmt instead of adding the driver name to each pr_err.
- Remove noisy pr_info usage.
- Rename capdata_wmi to lenovo_wmi_cd01_priv and cd01_wmi to priv.
- Use list to get the lenovo_wmi_cd01_priv instance in lenovo_wmi_capdata01_get as none of the data provided by the macros that will use it can pass a member of the struct for use in container_of.
--- MAINTAINERS | 1 + drivers/platform/x86/Kconfig | 14 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/lenovo-wmi-gamezone.c | 401 +++++++++++++++++++++ drivers/platform/x86/lenovo-wmi-gamezone.h | 20 + 5 files changed, 437 insertions(+) create mode 100644 drivers/platform/x86/lenovo-wmi-gamezone.c create mode 100644 drivers/platform/x86/lenovo-wmi-gamezone.h
MAINTAINERS +1 -0
@@ -13166,6 +13166,7 @@ F: Documentation/wmi/devices/lenovo-wmi-gamezone.rst F: Documentation/wmi/devices/lenovo-wmi-other.rst F: drivers/platform/x86/lenovo-wmi-capdata01.* F: drivers/platform/x86/lenovo-wmi-events.* +F: drivers/platform/x86/lenovo-wmi-gamezone.* F: drivers/platform/x86/lenovo-wmi-helpers.* LENOVO WMI HOTKEY UTILITIES DRIVER
drivers/platform/x86/Kconfig +14 -0
@@ -467,6 +467,20 @@ config LENOVO_WMI_HELPERS tristate depends on ACPI_WMI +config LENOVO_WMI_GAMEZONE + tristate "Lenovo GameZone WMI Driver" + depends on ACPI_WMI + depends on DMI + select ACPI_PLATFORM_PROFILE + select LENOVO_WMI_EVENTS + select LENOVO_WMI_HELPERS + help + Say Y here if you have a WMI aware Lenovo Legion device and would like to use the + platform-profile firmware interface to manage power usage. + + To compile this driver as a module, choose M here: the module will + be called lenovo-wmi-gamezone. + config LENOVO_WMI_DATA01 tristate depends on ACPI_WMI
drivers/platform/x86/Makefile +1 -0
@@ -71,6 +71,7 @@ obj-$(CONFIG_YT2_1380) += lenovo-yoga-tab2-pro-1380-fastcharger.o obj-$(CONFIG_LENOVO_WMI_CAMERA) += lenovo-wmi-camera.o obj-$(CONFIG_LENOVO_WMI_DATA01) += lenovo-wmi-capdata01.o obj-$(CONFIG_LENOVO_WMI_EVENTS) += lenovo-wmi-events.o +obj-$(CONFIG_LENOVO_WMI_GAMEZONE) += lenovo-wmi-gamezone.o obj-$(CONFIG_LENOVO_WMI_HELPERS) += lenovo-wmi-helpers.o # Intel
drivers/platform/x86/lenovo-wmi-gamezone.c new file +401 -0
401 lines not on this page · raw message
drivers/platform/x86/lenovo-wmi-gamezone.h new file +20 -0
@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/* Copyright (C) 2025 Derek J. Clark <[email protected]> */ + +#ifndef _LENOVO_WMI_GAMEZONE_H_ +#define _LENOVO_WMI_GAMEZONE_H_ + +enum gamezone_events_type { +LWMI_GZ_GET_THERMAL_MODE =1 , +}; + +enum thermal_mode { +LWMI_GZ_THERMAL_MODE_QUIET =0x01 , +LWMI_GZ_THERMAL_MODE_BALANCED =0x02 , +LWMI_GZ_THERMAL_MODE_PERFORMANCE =0x03 , +LWMI_GZ_THERMAL_MODE_EXTREME =0xE0 ,/* Ver 6+ */ +LWMI_GZ_THERMAL_MODE_CUSTOM =0xFF , +}; + +#endif /* !_LENOVO_WMI_GAMEZONE_H_ */
Signature · 1 line
2.49.0
Derek J. Clark
maintainerPATCH v11 6/6 platform/x86: Add Lenovo Other Mode WMI Driver
In reply to Derek J. ClarkAdds lenovo-wmi-other driver which provides the Lenovo "Other Mode" WMI interface that comes on some Lenovo "Gaming Series" hardware. Provides a firmware-attributes class which enables the use of tunable knobs for SPL, SPPT, and FPPT.
---
v11:
- Formatting
v10:
- include kdev_t to fix build error.
v9:
- Make tunable_attr_01 declarations static & adjust formatting.
v8:
- Remove dead code.
- use struct cd01_list pointer instead of void pointer in lwmi_cd01_priv.
v7:
- Use stach allocated capdata01 stuct instead of getting a pointer from lenovo-wmi-capdata01.
- Fix typos.
v6:
- Pass locally stored pointer to cd01_list back to lenovo-wmi-capdata01 instead of itterating over the list locally. Due to ACPI event handing the list is now mutexed.
- Fix typos and rewordings from v5 review.
v5:
- Switch from locally storing capability data list to storing a pointer from the capability data interface.
- Add portion of Gamezone driver that relies on the exported functions of this driver.
- Properly initialize IDA and use it for naming the firmware-attributes path.
- Rename most defines to clearly indicate they are from this driver.
- Misc fixes from v4 review.
v4:
- Treat Other Mode as a notifier chain head, use the notifier chain to get the current mode from Gamezone.
- Add header file for Other Mode specific structs and finctions.
- Use component master bind to cache the capdata01 array locally.
- Drop all reference to external driver private data structs.
- Various fixes from review.
v3:
- Add notifier block and store result for getting the Gamezone interface profile changes.
- Add driver as master component of capdata01 driver.
- Use FIELD_PREP where appropriate.
- Move macros and associated functions out of lemovo-wmi.h that are only used by this driver.
v2:
- Use devm_kmalloc to ensure driver can be instanced, remove global reference.
- Ensure reverse Christmas tree for all variable declarations.
- Remove extra whitespace.
- Use guard(mutex) in all mutex instances, global mutex.
- Use pr_fmt instead of adding the driver name to each pr_err.
- Remove noisy pr_info usage.
- Rename other_method_wmi to lenovo_wmi_om_priv and om_wmi to priv.
- Use list to get the lenovo_wmi_om_priv instance in some macro called functions as the data provided by the macros that use it doesn't pass a member of the struct for use in container_of.
- Do not rely on GameZone interface to grab the current fan mode.
--- MAINTAINERS | 1 + drivers/platform/x86/Kconfig | 15 + drivers/platform/x86/Makefile | 1 + drivers/platform/x86/lenovo-wmi-gamezone.c | 8 +- drivers/platform/x86/lenovo-wmi-other.c | 665 +++++++++++++++++++++ drivers/platform/x86/lenovo-wmi-other.h | 16 + 6 files changed, 705 insertions(+), 1 deletion(-) create mode 100644 drivers/platform/x86/lenovo-wmi-other.c create mode 100644 drivers/platform/x86/lenovo-wmi-other.h
MAINTAINERS +1 -0
@@ -13168,6 +13168,7 @@ F: drivers/platform/x86/lenovo-wmi-capdata01.* F: drivers/platform/x86/lenovo-wmi-events.* F: drivers/platform/x86/lenovo-wmi-gamezone.* F: drivers/platform/x86/lenovo-wmi-helpers.* +F: drivers/platform/x86/lenovo-wmi-other.* LENOVO WMI HOTKEY UTILITIES DRIVER M: Jackie Dong <[email protected]>
drivers/platform/x86/Kconfig +15 -0
@@ -485,6 +485,21 @@ config LENOVO_WMI_DATA01 tristate depends on ACPI_WMI +config LENOVO_WMI_TUNING + tristate "Lenovo Other Mode WMI Driver" + depends on ACPI_WMI + select FW_ATTR_CLASS + select LENOVO_WMI_DATA01 + select LENOVO_WMI_EVENTS + select LENOVO_WMI_HELPERS + help + Say Y here if you have a WMI aware Lenovo Legion device and would like to use the + firmware_attributes API to control various tunable settings typically exposed by + Lenovo software in Windows. + + To compile this driver as a module, choose M here: the module will + be called lenovo-wmi-other. + config IDEAPAD_LAPTOP tristate "Lenovo IdeaPad Laptop Extras" depends on ACPI
drivers/platform/x86/Makefile +1 -0
@@ -73,6 +73,7 @@ obj-$(CONFIG_LENOVO_WMI_DATA01) += lenovo-wmi-capdata01.o obj-$(CONFIG_LENOVO_WMI_EVENTS) += lenovo-wmi-events.o obj-$(CONFIG_LENOVO_WMI_GAMEZONE) += lenovo-wmi-gamezone.o obj-$(CONFIG_LENOVO_WMI_HELPERS) += lenovo-wmi-helpers.o +obj-$(CONFIG_LENOVO_WMI_TUNING) += lenovo-wmi-other.o # Intel obj-y += intel/
drivers/platform/x86/lenovo-wmi-gamezone.c +7 -1
@@ -373,7 +373,12 @@ static int lwmi_gz_probe(struct wmi_device *wdev, const void *context)return ret; priv->event_nb.notifier_call = lwmi_gz_event_call; -return devm_lwmi_events_register_notifier (&wdev->dev, &priv->event_nb); + ret =devm_lwmi_events_register_notifier (&wdev->dev, &priv->event_nb); +if (ret) +return ret; + + priv->mode_nb.notifier_call = lwmi_gz_mode_call; +return devm_lwmi_om_register_notifier (&wdev->dev, &priv->mode_nb); }static const struct wmi_device_id lwmi_gz_id_table[] = {
@@ -395,6 +400,7 @@ module_wmi_driver(lwmi_gz_driver);MODULE_IMPORT_NS ("LENOVO_WMI_EVENTS" );MODULE_IMPORT_NS ("LENOVO_WMI_HELPERS" ); +MODULE_IMPORT_NS ("LENOVO_WMI_OTHER" );MODULE_DEVICE_TABLE (wmi, lwmi_gz_id_table);MODULE_AUTHOR ("Derek J. Clark <[email protected]>" );MODULE_DESCRIPTION ("Lenovo GameZone WMI Driver" );
drivers/platform/x86/lenovo-wmi-other.c new file +665 -0
665 lines not on this page · raw message
drivers/platform/x86/lenovo-wmi-other.h new file +16 -0
@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/* Copyright (C) 2025 Derek J. Clark <[email protected]> */ + +#ifndef _LENOVO_WMI_OTHER_H_ +#define _LENOVO_WMI_OTHER_H_ + +struct device ; +struct notifier_block ; + +int lwmi_om_register_notifier (struct notifier_block *nb); +int lwmi_om_unregister_notifier (struct notifier_block *nb); +int devm_lwmi_om_register_notifier (struct device *dev, +struct notifier_block *nb); + +#endif /* !_LENOVO_WMI_OTHER_H_ */
Signature · 1 line
2.49.0
Ilpo Järvinen
maintainerQuoted 17 lines · Derek J. Clark
Adds support for the Lenovo "Gaming Series" of laptop hardware that use WMI interfaces that control various power settings. There are multiple WMI interfaces that work in concert to provide getting and setting values as well as validation of input. Currently only the "Gamezone", "Other Mode", and "
LENOVO_CAPABILITY_DATA_01" interfaces are implemented, but I attempted to structure the driver so that adding the "Custom Mode", "Lighting", and other data block interfaces would be trivial in later patches.This driver attempts to standardize the exposed sysfs by mirroring the asus-armoury driver currently under review. As such, a lot of inspiration has been drawn from that driver.
https://lore.kernel.org/platform-driver-x86/[email protected]/#tThe drivers have been tested by me on the Lenovo Legion Go and Legion Go S.
Quoted 6 lines
Suggested-by Mario Limonciello <[email protected]>Reviewed-by Armin Wolf <[email protected]>Signed-off-by Derek J. Clark <[email protected]>---
v11:
- Fix formmating issues.
Thanks for the update, I've applied this now into the review-ilpo-next branch. BUT, this is very late in the cycle now and if there's a build issue (or LKP doesn't build test it in reasonable time), I'll have to drop this series and postpone it into the next cycle as I don't want to delay the main PR to Linus too long.
But lets hope for the best, I think some depends on issues were fixed earlier (IIRC), so hopefully it works good enough now. :-)
--
i.
Quoted 59 lines
v10:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v9:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v8:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v7:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v6:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v5:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v4:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v3:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v2:
https://lore.kernel.org/platform-driver-x86/[email protected]/
v1:
https://lore.kernel.org/platform-driver-x86/[email protected]/Derek J. Clark (6):
platform/x86: Add lenovo-wmi-* driver Documentation platform/x86: Add lenovo-wmi-helpers platform/x86: Add Lenovo WMI Events Driver platform/x86: Add Lenovo Capability Data 01 WMI Driver platform/x86: Add Lenovo Gamezone WMI Driver platform/x86: Add Lenovo Other Mode WMI Driver.../wmi/devices/lenovo-wmi-gamezone.rst | 203 ++++++ .../wmi/devices/lenovo-wmi-other.rst | 108 +++ MAINTAINERS | 12 + drivers/platform/x86/Kconfig | 41 ++ drivers/platform/x86/Makefile | 5 + drivers/platform/x86/lenovo-wmi-capdata01.c | 302 ++++++++ drivers/platform/x86/lenovo-wmi-capdata01.h | 25 + drivers/platform/x86/lenovo-wmi-events.c | 196 ++++++ drivers/platform/x86/lenovo-wmi-events.h | 20 + drivers/platform/x86/lenovo-wmi-gamezone.c | 407 +++++++++++ drivers/platform/x86/lenovo-wmi-gamezone.h | 20 + drivers/platform/x86/lenovo-wmi-helpers.c | 74 ++ drivers/platform/x86/lenovo-wmi-helpers.h | 20 + drivers/platform/x86/lenovo-wmi-other.c | 665 ++++++++++++++++++ drivers/platform/x86/lenovo-wmi-other.h | 16 + 15 files changed, 2114 insertions(+) create mode 100644 Documentation/wmi/devices/lenovo-wmi-gamezone.rst create mode 100644 Documentation/wmi/devices/lenovo-wmi-other.rst create mode 100644 drivers/platform/x86/lenovo-wmi-capdata01.c create mode 100644 drivers/platform/x86/lenovo-wmi-capdata01.h create mode 100644 drivers/platform/x86/lenovo-wmi-events.c create mode 100644 drivers/platform/x86/lenovo-wmi-events.h create mode 100644 drivers/platform/x86/lenovo-wmi-gamezone.c create mode 100644 drivers/platform/x86/lenovo-wmi-gamezone.h create mode 100644 drivers/platform/x86/lenovo-wmi-helpers.c create mode 100644 drivers/platform/x86/lenovo-wmi-helpers.h create mode 100644 drivers/platform/x86/lenovo-wmi-other.c create mode 100644 drivers/platform/x86/lenovo-wmi-other.h
Ilpo Järvinen
maintainerQuoted 26 lines · Ilpo Järvinen
Quoted 17 lines · Derek J. Clark
Adds support for the Lenovo "Gaming Series" of laptop hardware that use WMI interfaces that control various power settings. There are multiple WMI interfaces that work in concert to provide getting and setting values as well as validation of input. Currently only the "Gamezone", "Other Mode", and "
LENOVO_CAPABILITY_DATA_01" interfaces are implemented, but I attempted to structure the driver so that adding the "Custom Mode", "Lighting", and other data block interfaces would be trivial in later patches.This driver attempts to standardize the exposed sysfs by mirroring the asus-armoury driver currently under review. As such, a lot of inspiration has been drawn from that driver.
https://lore.kernel.org/platform-driver-x86/[email protected]/#tThe drivers have been tested by me on the Lenovo Legion Go and Legion Go S.
Quoted 6 lines
Suggested-by Mario Limonciello <[email protected]>Reviewed-by Armin Wolf <[email protected]>Signed-off-by Derek J. Clark <[email protected]>---
v11:
- Fix formmating issues.
Quoted 8 lines
Thanks for the update, I've applied this now into the review-ilpo-next branch. BUT, this is very late in the cycle now and if there's a build issue (or LKP doesn't build test it in reasonable time), I'll have to drop this series and postpone it into the next cycle as I don't want to delay the main PR to Linus too long.
But lets hope for the best, I think some depends on issues were fixed earlier (IIRC), so hopefully it works good enough now. :-)
Hmpf, these give me a few new warnings related to this series:
make W=1 drivers/platform/x86/
make C=2 drivers/platform/x86/
...I really don't know why sparse complains about the lock context imbalance though, those functions use guard().
There's also a copy-paste error:
* lwmi_gz_profile_get_get() - Get the current platform profile.
..._get_get -> ..._set
Get -> Set
Signature · 1 line
i.
Derek J. Clark
maintainerQuoted 37 lines · Ilpo Järvinen
Quoted 26 lines · Ilpo Järvinen
Quoted 17 lines · Derek J. Clark
Adds support for the Lenovo "Gaming Series" of laptop hardware that use WMI interfaces that control various power settings. There are multiple WMI interfaces that work in concert to provide getting and setting values as well as validation of input. Currently only the "Gamezone", "Other Mode", and "
LENOVO_CAPABILITY_DATA_01" interfaces are implemented, but I attempted to structure the driver so that adding the "Custom Mode", "Lighting", and other data block interfaces would be trivial in later patches.This driver attempts to standardize the exposed sysfs by mirroring the asus-armoury driver currently under review. As such, a lot of inspiration has been drawn from that driver.
https://lore.kernel.org/platform-driver-x86/[email protected]/#tThe drivers have been tested by me on the Lenovo Legion Go and Legion Go S.
Quoted 6 lines
Suggested-by Mario Limonciello <[email protected]>Reviewed-by Armin Wolf <[email protected]>Signed-off-by Derek J. Clark <[email protected]>---
v11:
- Fix formmating issues.Quoted 8 lines
Thanks for the update, I've applied this now into the review-ilpo-next branch. BUT, this is very late in the cycle now and if there's a build issue (or LKP doesn't build test it in reasonable time), I'll have to drop this series and postpone it into the next cycle as I don't want to delay the main PR to Linus too long.
But lets hope for the best, I think some depends on issues were fixed earlier (IIRC), so hopefully it works good enough now. :-)
Quoted 7 lines
Hmpf, these give me a few new warnings related to this series:
make W=1
drivers/platform/x86/
make C=2drivers/platform/x86/...I really don't know why sparse complains about the lock context imbalance though, those functions use
guard().
Hmm, I'll take a look at it.
Is there a comprehensive list of all tests that need to be run? I'd like to improve my process to avoid these in the future.
Quoted 6 lines
There's also a copy-paste error:
*
lwmi_gz_profile_get_get()- Get the current platform profile...._get_get -> ..._set
Get -> Set
Do you want me to submit v12 whenever it's ready, or wait for the merge window to open? Trying to avoid too much noise on your end.
Thanks,
- Derek
Ilpo Järvinen
maintainerQuoted 40 lines · Derek J. Clark
Quoted 39 lines · Ilpo Järvinen
Quoted 26 lines · Ilpo Järvinen
Quoted 17 lines · Derek J. Clark
Adds support for the Lenovo "Gaming Series" of laptop hardware that use WMI interfaces that control various power settings. There are multiple WMI interfaces that work in concert to provide getting and setting values as well as validation of input. Currently only the "Gamezone", "Other Mode", and "
LENOVO_CAPABILITY_DATA_01" interfaces are implemented, but I attempted to structure the driver so that adding the "Custom Mode", "Lighting", and other data block interfaces would be trivial in later patches.This driver attempts to standardize the exposed sysfs by mirroring the asus-armoury driver currently under review. As such, a lot of inspiration has been drawn from that driver.
https://lore.kernel.org/platform-driver-x86/[email protected]/#tThe drivers have been tested by me on the Lenovo Legion Go and Legion Go S.
Quoted 6 lines
Suggested-by Mario Limonciello <[email protected]>Reviewed-by Armin Wolf <[email protected]>Signed-off-by Derek J. Clark <[email protected]>---
v11:
- Fix formmating issues.Quoted 8 lines
Thanks for the update, I've applied this now into the review-ilpo-next branch. BUT, this is very late in the cycle now and if there's a build issue (or LKP doesn't build test it in reasonable time), I'll have to drop this series and postpone it into the next cycle as I don't want to delay the main PR to Linus too long.
But lets hope for the best, I think some depends on issues were fixed earlier (IIRC), so hopefully it works good enough now. :-)
Hmpf, these give me a few new warnings related to this series:
Quoted 7 lines
Quoted 5 lines
make W=1
drivers/platform/x86/
make C=2drivers/platform/x86/...I really don't know why sparse complains about the lock context imbalance though, those functions use
guard().Hmm, I'll take a look at it.
Thanks.
Quoted 2 lines
Is there a comprehensive list of all tests that need to be run? I'd like to improve my process to avoid these in the future.
There's some list in Documentation/process/submit-checklist.rst but use reason with some of the items whether they're relevant, I think very few patches would meet _all_ of those in the most literal interpretation :-).
Quoted 10 lines
Quoted 6 lines
There's also a copy-paste error:
*
lwmi_gz_profile_get_get()- Get the current platform profile...._get_get -> ..._set
Get -> SetDo you want me to submit v12 whenever it's ready, or wait for the merge window to open? Trying to avoid too much noise on your end.
Just send v12 when it's ready. For pdx86, there's no need to avoid sending during merge window (just don't assume anything gets applied during merge window :-)).
Signature · 1 line
i.
Derek John Clark
maintainerQuoted 35 lines · Ilpo Järvinen
Quoted 32 lines · Ilpo Järvinen
Quoted 17 lines · Derek J. Clark
Adds support for the Lenovo "Gaming Series" of laptop hardware that use WMI interfaces that control various power settings. There are multiple WMI interfaces that work in concert to provide getting and setting values as well as validation of input. Currently only the "Gamezone", "Other Mode", and "
LENOVO_CAPABILITY_DATA_01" interfaces are implemented, but I attempted to structure the driver so that adding the "Custom Mode", "Lighting", and other data block interfaces would be trivial in later patches.This driver attempts to standardize the exposed sysfs by mirroring the asus-armoury driver currently under review. As such, a lot of inspiration has been drawn from that driver.
https://lore.kernel.org/platform-driver-x86/[email protected]/#tThe drivers have been tested by me on the Lenovo Legion Go and Legion Go S.
Quoted 6 lines
Suggested-by Mario Limonciello <[email protected]>Reviewed-by Armin Wolf <[email protected]>Signed-off-by Derek J. Clark <[email protected]>---
v11:
- Fix formmating issues.Thanks for the update, I've applied this now into the review-ilpo-next branch. BUT, this is very late in the cycle now and if there's a build issue (or LKP doesn't build test it in reasonable time), I'll have to drop this series and postpone it into the next cycle as I don't want to delay the main PR to Linus too long.
Quoted 7 lines
Quoted 2 lines
But lets hope for the best, I think some depends on issues were fixed earlier (IIRC), so hopefully it works good enough now. :-)
Hmpf, these give me a few new warnings related to this series:
make W=1
drivers/platform/x86/
make C=2drivers/platform/x86/
When I use scoped_guard the warnings go away. It seems to be a limitation of sparse in that its not correctly identifying the guard will be unlocked on the return perhaps? In any case, if you're okay with a scoped guard here (matches both other invocations) I'll send it up.
I also took care of the warnings for W=1.
Quoted 14 lines
...I really don't know why sparse complains about the lock context imbalance though, those functions use
guard().There's also a copy-paste error:
*
lwmi_gz_profile_get_get()- Get the current platform profile...._get_get -> ..._set
Get -> Set--
i.
Ilpo Järvinen
maintainer+ Cc sparse people.
Quoted 40 lines · Derek John Clark
Quoted 38 lines · Ilpo Järvinen
Quoted 34 lines · Ilpo Järvinen
Quoted 17 lines · Derek J. Clark
Adds support for the Lenovo "Gaming Series" of laptop hardware that use WMI interfaces that control various power settings. There are multiple WMI interfaces that work in concert to provide getting and setting values as well as validation of input. Currently only the "Gamezone", "Other Mode", and "
LENOVO_CAPABILITY_DATA_01" interfaces are implemented, but I attempted to structure the driver so that adding the "Custom Mode", "Lighting", and other data block interfaces would be trivial in later patches.This driver attempts to standardize the exposed sysfs by mirroring the asus-armoury driver currently under review. As such, a lot of inspiration has been drawn from that driver.
https://lore.kernel.org/platform-driver-x86/[email protected]/#tThe drivers have been tested by me on the Lenovo Legion Go and Legion Go S.
Quoted 6 lines
Suggested-by Mario Limonciello <[email protected]>Reviewed-by Armin Wolf <[email protected]>Signed-off-by Derek J. Clark <[email protected]>---
v11:
- Fix formmating issues.Thanks for the update, I've applied this now into the review-ilpo-next branch. BUT, this is very late in the cycle now and if there's a build issue (or LKP doesn't build test it in reasonable time), I'll have to drop this series and postpone it into the next cycle as I don't want to delay the main PR to Linus too long.
But lets hope for the best, I think some depends on issues were fixed earlier (IIRC), so hopefully it works good enough now. :-)
Quoted 6 lines
Quoted 4 lines
Hmpf, these give me a few new warnings related to this series:
make W=1
drivers/platform/x86/
make C=2drivers/platform/x86/When I use
scoped_guardthe warnings go away.
Okay, not that it helps much because the implementation of guard() and scoped_guard() is dramatically different.
Quoted 3 lines
It seems to be a
limitation of sparse in that its not correctly identifying the guard will be unlocked on the return perhaps?
It's odd because we'd have those warnings all over the place if it would be general thing for sparse to not understand how guard() works. Maybe sparse people have some idea what's so special here?
To give context to sparse people, this patch triggers two false positives in sparse:
https://lore.kernel.org/platform-driver-x86/[email protected]/
$ make C=2 drivers/platform/x86/lenovo-wmi-gamezone.o CHECK scripts/mod/empty.c CALL scripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CHECK drivers/platform/x86/lenovo-wmi-gamezone.c drivers/platform/x86/lenovo-wmi-gamezone.c:155:12: warning: context imbalance in 'lwmi_gz_profile_get' - different lock contexts for basic block drivers/platform/x86/lenovo-wmi-gamezone.c:206:12: warning: context imbalance in 'lwmi_gz_profile_set' - different lock contexts for basic block
(That code link is just for convinience, it's not a perma one, I'll be overwriting that branch eventually once the merge window is over, if not sooner.)
Quoted 3 lines
In any case, if you're okay
with a scoped guard here (matches both other invocations) I'll send it up.
I'd prefer to keep using guard() for now as this looks clearly a false positive from sparse, not a problem in your code.
Quoted 1 line
I also took care of the warnings for W=1.
Thanks.
Quoted 2 lines
Quoted 2 lines
...I really don't know why sparse complains about the lock context imbalance though, those functions use
guard().
Signature · 1 line
i.