Skip to contentSkip to conversation

ASoC: wm_adsp: Make cirrus_dir const

PATCH In review Richard Fitzgerald 2 participants 2 messages May 22, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: wm_adsp: Make cirrus_dir const

The cirrus_dir pointer should be const data but was missing the second const needed to achieve this.

I haven't marked this as a 'Fixes' because it isn't causing any bugs, it's only a code improvement.

---
 sound/soc/codecs/wm_adsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/wm_adsp.c +1 -1
index 91c8697c29c3..c52b4dc7a509 100644
@@ -785,7 +785,7 @@ static int wm_adsp_request_firmware_file(struct wm_adsp *dsp,
 	return ret;
 }
 
-static const char *cirrus_dir = "cirrus/";
+static const char * const cirrus_dir = "cirrus/";
 static int wm_adsp_request_firmware_files(struct wm_adsp *dsp,
 					  const struct firmware **wmfw_firmware,
 					  char **wmfw_filename,
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 8 lines · Richard Fitzgerald

The cirrus_dir pointer should be const data but was missing the second const needed to achieve this.

I haven't marked this as a 'Fixes' because it isn't causing any bugs, it's only a code improvement.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: wm_adsp: Make cirrus_dir const

      commit: fd4b6c0fdf71d71f2bbc2f9aceb6f0814b4d93e2

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark