firmware: cs_dsp: Fix OOB memory read access in KUnit test
Subsystems (3)
Jaroslav Kysela
maintainerPATCH 1/1 firmware: cs_dsp: Fix OOB memory read access in KUnit test
KASAN reported out of bounds access - cs_dsp_mock_bin_add_name_or_info(), because the source string length was rounded up to the allocation size.
--- drivers/firmware/cirrus/test/cs_dsp_mock_bin.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/firmware/cirrus/test/cs_dsp_mock_bin.c +2 -1
@@ -96,10 +96,11 @@ static void cs_dsp_mock_bin_add_name_or_info(struct cs_dsp_mock_bin_builder *buiif (info_len %4 ) {/* Create a padded string with length a multiple of 4 */ +size_t copy_len = info_len; info_len =round_up (info_len,4 ); tmp =kunit_kzalloc (builder->test_priv->test, info_len,GFP_KERNEL );KUNIT_ASSERT_NOT_ERR_OR_NULL (builder->test_priv->test, tmp); -memcpy (tmp, info, info_len); +memcpy (tmp, info, copy_len); info = tmp; }
Signature · 1 line
2.49.0
Quoted 9 lines · Jaroslav Kysela
KASAN reported out of bounds access -
cs_dsp_mock_bin_add_name_or_info(), because the source string length was rounded up to the allocation size.Cc Simon Trimmer <[email protected]>Cc Charles Keepax <[email protected]>Cc Richard Fitzgerald <[email protected]>Signed-off-by Jaroslav Kysela <[email protected]>
Quoted 4 lines · Jaroslav Kysela
KASAN reported out of bounds access -
cs_dsp_mock_bin_add_name_or_info(), because the source string length was rounded up to the allocation size.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] firmware: cs_dsp: Fix OOB memory read access in KUnit test
commit: fe6446215bfad11cf3b446f38b28dc7708973c25
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark